Re: [PATCH 370 bis] Implement lt_dlopening of only preloaded modules.

2008-08-16 Thread Ralf Wildenhues
Hi Gary, late second round of review: * Gary V. Vaughan wrote on Wed, May 07, 2008 at 10:32:13PM CEST: * libltdl/m4/ltdl.m4 (LTDL_INIT): Check for a libltdl that provides lt_dladvise_preopen when deciding if installed libltdl is 'new enough'. * libltdl/libltdl/lt__private.h (lt__advise): Add

Re: [PATCH 370 bis] Implement lt_dlopening of only preloaded modules.

2008-08-16 Thread Gary V. Vaughan
On 16 Aug 2008, at 17:25, Ralf Wildenhues wrote: Hi Gary, Hallo Ralf, late ;o) second round of review: + archive_name = MALLOC (char, LT_STRLEN (name) + 3); This should probably be LT_STRLEN (name) + LT_STRLEN (.a) + 1 except that... - if (tryall_dlopen

Re: [PATCH 370 bis] Implement lt_dlopening of only preloaded modules.

2008-06-18 Thread Gary V. Vaughan
Ping? I'll push in a day or two unless someone asks me not to... On 7 May 2008, at 21:32, Gary V. Vaughan wrote: * libltdl/m4/ltdl.m4 (LTDL_INIT): Check for a libltdl that provides lt_dladvise_preopen when deciding if installed libltdl is 'new enough'. * libltdl/libltdl/lt__private.h

Re: [PATCH 370 bis] Implement lt_dlopening of only preloaded modules.

2008-06-18 Thread Bob Friesenhahn
On Wed, 18 Jun 2008, Gary V. Vaughan wrote: Ping? I'll push in a day or two unless someone asks me not to... I am not seeing a problem with this patch. Bob On 7 May 2008, at 21:32, Gary V. Vaughan wrote: * libltdl/m4/ltdl.m4 (LTDL_INIT): Check for a libltdl that provides

Re: [PATCH 370 bis] Implement lt_dlopening of only preloaded modules.

2008-05-08 Thread Gary V. Vaughan
Hi Olly, On 7 May 2008, at 17:25, Olly Betts wrote: On 2008-05-07, Gary V. Vaughan [EMAIL PROTECTED] wrote: + - New lt_dloadvise_preload() call to set a hint that only preloadeded I think lt_dloadvise_preload should be lt_dladvise_preload. D'oh! Thanks. Fixed. Cheers, Gary --

[PATCH 370 bis] Implement lt_dlopening of only preloaded modules.

2008-05-07 Thread Gary V. Vaughan
* libltdl/m4/ltdl.m4 (LTDL_INIT): Check for a libltdl that provides lt_dladvise_preopen when deciding if installed libltdl is 'new enough'. * libltdl/libltdl/lt__private.h (lt__advise): Add a new is_preload flag. * libltdl/ltdl.c (lt_dladvise_preload): New api call to set it. (try_dlopen): If it

Re: [PATCH 370 bis] Implement lt_dlopening of only preloaded modules.

2008-05-07 Thread Olly Betts
On 2008-05-07, Gary V. Vaughan [EMAIL PROTECTED] wrote: + - New lt_dloadvise_preload() call to set a hint that only preloadeded I think lt_dloadvise_preload should be lt_dladvise_preload. Cheers, Olly