Re: [PATCH 6/6] use printf as $ECHO

Hello Sven, thanks for the quick feedback! * Sven Mascheck wrote on Tue, Nov 11, 2008 at 01:00:26AM CET: > On Mon, Nov 10, 2008 at 08:34:31PM +0100, Ralf Wildenhues wrote: > > > func_fallback_echo() > > { > > eval 'cat <<_LTEOF > > $* > > _LTEOF' > > } > > > You probably remembered "http://w

Re: [PATCH 6/6] use printf as $ECHO

On Mon, Nov 10, 2008 at 08:34:31PM +0100, Ralf Wildenhues wrote: > * Paolo Bonzini wrote on Mon, Nov 10, 2008 at 12:07:12PM CET: > > [...] we could use a shell function like > > > >func_fallback_echo() > >{ > > cat <<_LTEOF > >$1 (or $*) > >_LTEOF > >} > > IIRC then it w

Re: [PATCH 6/6] use printf as $ECHO

[ ] Hello Sven, below is a question regarding your shell pages. * Paolo Bonzini wrote on Mon, Nov 10, 2008 at 12:07:12PM CET: > > > Esp., I'm quite sure that we need the cat here-document fallback; > > [...] I am quite con

Re: [PATCH 6/6] use printf as $ECHO

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paolo Bonzini on 11/10/2008 4:07 AM: Just for safety, shouldn't the test use '%s\n' rather than bare %s (in other words, make our test match our usage pattern)? >>> _AS_ECHO_PREPARE does the same... >> Here's a chance to f

Re: [PATCH 6/6] use printf as $ECHO

+if test "X`printf %s $ECHO`" = "X$ECHO"; then + ECHO='printf %s\n' >>> Just for safety, shouldn't the test use '%s\n' rather than bare %s (in >>> other >>> words, make our test match our usage pattern)? >> _AS_ECHO_PREPARE does the same... > > Here's a chance to fix both at once. :-

Re: [PATCH 6/6] use printf as $ECHO

Hello, I haven't fully reviewed this patch yet; there are more issues with it. However: * Paolo Bonzini wrote on Sat, Nov 08, 2008 at 11:13:32AM CET: > > >> M4SH_VERBATIM([[ > > > > Hmm. This is a nicer name for m4_echo, for how it is being used; maybe it > > is > > time to migrated it into

Re: [PATCH 6/6] use printf as $ECHO

>> M4SH_VERBATIM([[ > > Hmm. This is a nicer name for m4_echo, for how it is being used; maybe it is > time to migrated it into the Autoconf manual (perhaps under the name > AS_VERBATIM)? Maybe, yes. >> : ${CP="cp -f"} >> -: ${ECHO="echo"} >> +: ${ECHO=$as_echo} > > This is delving a bit

Re: [PATCH 6/6] use printf as $ECHO

Paolo Bonzini gnu.org> writes: > This patch bumps the requirement for *building* Libtool to > Autoconf 2.62, which provides a handy $as_echo which does > exactly the same as we need for Libtool. However, Libtool > itself uses its own echo replacement, so it is not tied to > Autoconf 2.62. Shoul

[PATCH 6/6] use printf as $ECHO

This is the bulk of the patch series, and it removes $ECHO in favor of `some printf' that works. This printf can be: 1) a shell builtin for the current shell; 2) a printf binary; 3) a shell builtin for another shell. There is a lot of simplification -- and more can be done because this patch remo