This is a revised version, incorporating the additional changes
suggested by Eric and Noah. I re-ran the testsuite on cygwin, mingw,
and linux and the results were identical to those posted here:
http://lists.gnu.org/archive/html/libtool-patches/2007-06/msg00019.html
Looks good to me.
Hopefully the attached addresses all of the concerns mentions by Noah,
Erick, and Peter with regards to my recent cwrapper-emits-shwrapper patch.
Tested on cygwin, mingw, and linux with no regressions from
http://lists.gnu.org/archive/html/libtool-patches/2007-04/msg00088.html
although, as
I don't see any problems. If you will commit these changes, I will
test them right away in my own builds.
Bob
On Fri, 8 Jun 2007, Charles Wilson wrote:
Hopefully the attached addresses all of the concerns mentions by Noah, Erick,
and Peter with regards to my recent cwrapper-emits-shwrapper
Bob Friesenhahn wrote:
I don't see any problems. If you will commit these changes, I will test
them right away in my own builds.
I'd like to hear from those who raised the original issues in each case,
first -- e.g. Noah/Peter for the WRAPPER_SCRIPT_BELONGS_IN_OBJDIR
changes, Erick for the
Charles Wilson libtool at cwilson.fastmail.fm writes:
Hopefully the attached addresses all of the concerns mentions by Noah,
Erick, and Peter with regards to my recent cwrapper-emits-shwrapper patch.
s/Erick/Eric/, but that's okay (I've seen worse butchering of my name, as short
as it is,
Eric Blake wrote:
s/Erick/Eric/, but that's okay (I've seen worse butchering of my name, as short
as it is, and I'm sure I've done worse to those with longer names :)
Sorry...
(func_emit_libtool_cwrapperexe_source) [LTWRAPPER_DEBUGPRINTF]:
declare as a function, not a macro,
On Fri, Jun 08, 2007 at 01:11:17PM -0400, Charles Wilson wrote:
if ((stat (path, st) = 0) (
-/* MinGW native WIN32 do not support
S_IXOTH or S_IXGRP */
-#if defined (S_IXOTH)
-((st.st_mode S_IXOTH) == S_IXOTH) ||
-#endif
Noah Misch wrote:
You can write this more simply:
if (stat (path, st) = 0 st.st_mode (S_IXUSR | S_IXGRP | S_IXOTH))
D'oh! You're right.
(Or even `access (path, X_OK) == 0', if MSYS has that.)
Err, well, sorta. What you're really asking is if the C runtime
library(ies) exposed by
