Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-20 Thread Cesar Strauss
On 10/20/2010 02:53 PM, Peter Rosin wrote: Den 2010-10-20 17:55 skrev Charles Wilson: On 10/20/2010 2:31 AM, Peter Rosin wrote: Den 2010-10-05 13:33 skrev Peter Rosin: I have implemented exactly that and just posted this to the MinGW patch tracker: http://sourceforge.net/tracker/index.php?func

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-20 Thread Peter Rosin
Den 2010-10-20 18:53 skrev Peter Rosin: > Den 2010-10-20 17:55 skrev Charles Wilson: >> if we (MSYS) want to preserve existing popup-showing behavior at all -- >> which I think we do. MAYBE the following (pseudo-bat-code, where >> MSYS_NOPOP is set based on --no-popups arg to .bat file): >> >>

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-20 Thread Peter Rosin
Den 2010-10-20 17:55 skrev Charles Wilson: > On 10/20/2010 2:31 AM, Peter Rosin wrote: >> Den 2010-10-05 13:33 skrev Peter Rosin: >>> I have implemented exactly that and just posted this to the MinGW patch >>> tracker: >>> http://sourceforge.net/tracker/index.php?func=detail&aid=3081421&group_id=24

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-20 Thread Charles Wilson
On 10/20/2010 2:31 AM, Peter Rosin wrote: > Den 2010-10-05 13:33 skrev Peter Rosin: >> I have implemented exactly that and just posted this to the MinGW patch >> tracker: >> http://sourceforge.net/tracker/index.php?func=detail&aid=3081421&group_id=2435&atid=302435 > > The silence is deafening. >

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-20 Thread Peter Rosin
Hi Gary, Den 2010-10-20 08:55 skrev Gary V. Vaughan: > On 20 Oct 2010, at 13:31, Peter Rosin wrote: >> Den 2010-10-05 13:33 skrev Peter Rosin: >>> Den 2010-09-30 09:44 skrev Peter Rosin: Maybe the shopt isn't needed after all. If the SetErrorMode call checks if the SEM_FAILCRITICALERROR

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-20 Thread Gary V. Vaughan
Hi Peter, On 20 Oct 2010, at 13:31, Peter Rosin wrote: > Den 2010-10-05 13:33 skrev Peter Rosin: >> Den 2010-09-30 09:44 skrev Peter Rosin: >>> Maybe the shopt isn't needed after all. If the SetErrorMode call checks >>> if the SEM_FAILCRITICALERRORS is already set, that could be used to >>> deter

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-19 Thread Peter Rosin
Den 2010-10-05 13:33 skrev Peter Rosin: > Den 2010-09-30 09:44 skrev Peter Rosin: >> Maybe the shopt isn't needed after all. If the SetErrorMode call checks >> if the SEM_FAILCRITICALERRORS is already set, that could be used to >> determine if the CREATE_DEFAULT_ERROR_MODE flag should be added in

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-05 Thread Peter Rosin
Den 2010-09-30 09:44 skrev Peter Rosin: > Maybe the shopt isn't needed after all. If the SetErrorMode call checks > if the SEM_FAILCRITICALERRORS is already set, that could be used to > determine if the CREATE_DEFAULT_ERROR_MODE flag should be added in > spawn_guts. Then you could start an MSYS p

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-01 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Wed, Sep 29, 2010 at 11:21:11PM CEST: > Den 2010-09-29 21:01 skrev Ralf Wildenhues: > > * Peter Rosin wrote on Wed, Sep 29, 2010 at 10:06:00AM CEST: > >> Ok to push this one? > > > > I don't mind it, but I'll note that the patch will cause testsuite > > failures w

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-30 Thread Peter Rosin
Den 2010-09-29 23:21 skrev Peter Rosin: > I'll think some more about the general issue. What I really would > like is a bash shopt to set the error mode from the shell when > running testsuites. Then we could really forget this issue. Either > that or some way to make MSYS not force the "default

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-29 Thread Peter Rosin
Hi Ralf, Den 2010-09-29 21:01 skrev Ralf Wildenhues: > * Peter Rosin wrote on Wed, Sep 29, 2010 at 10:06:00AM CEST: >> Ok to push this one? > > I don't mind it, but I'll note that the patch will cause testsuite > failures when no wrapper is actually used. This can happen > > - with --disable-sh

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-29 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Wed, Sep 29, 2010 at 10:06:00AM CEST: > Ok to push this one? I don't mind it, but I'll note that the patch will cause testsuite failures when no wrapper is actually used. This can happen - with --disable-shared passed toplevel, or on static-only systems, - on sy

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-29 Thread Peter Rosin
Den 2010-09-29 17:00 skrev Charles Wilson: > On 9/29/2010 10:15 AM, Peter Rosin wrote: >> Den 2010-09-29 15:47 skrev Charles Wilson: >>> Will this patch cause any issues if people try to use libtool + MSYS on >>> a Win9x system? >> >> I don't foresee any problems, because SetErrorMode is really old

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-29 Thread Charles Wilson
On 9/29/2010 10:15 AM, Peter Rosin wrote: > Den 2010-09-29 15:47 skrev Charles Wilson: >> Will this patch cause any issues if people try to use libtool + MSYS on >> a Win9x system? > > I don't foresee any problems, because SetErrorMode is really old. You > were worrying about the entry point not

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-29 Thread Peter Rosin
Den 2010-09-29 15:47 skrev Charles Wilson: > On 9/29/2010 4:06 AM, Peter Rosin wrote: >> Cygwin is always running with this error mode (I think), MSYS is not. > > Cygwin no longer supports Win9x, MSYS does. > > Will this patch cause any issues if people try to use libtool + MSYS on > a Win9x syst

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-29 Thread Charles Wilson
On 9/29/2010 4:06 AM, Peter Rosin wrote: > Cygwin is always running with this error mode (I think), MSYS is not. Cygwin no longer supports Win9x, MSYS does. Will this patch cause any issues if people try to use libtool + MSYS on a Win9x system? -- Chuck

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-29 Thread Peter Rosin
Den 2010-09-28 22:09 skrev Ralf Wildenhues: > Hello Peter, > > * Peter Rosin wrote on Tue, Sep 28, 2010 at 08:08:13PM CEST: >> Ok to push? > > Avoiding assert doesn't seem like a scalable solution: lots of packages > use assert for testing. assert is ANSI C. We use assert in slist.at. > Is ther

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-28 Thread Ralf Wildenhues
Hello Peter, * Peter Rosin wrote on Tue, Sep 28, 2010 at 08:08:13PM CEST: > Ok to push? Avoiding assert doesn't seem like a scalable solution: lots of packages use assert for testing. assert is ANSI C. We use assert in slist.at. Is there a way to avoid popups? Hmm, or, if there is no way, then