Compiler warning in libltdl/m4/libtool.m4 test program

2010-06-15 Thread Philip Allison
The test program for whether a program can dlopen itself generates a compiler warning, which turns into a failure when building with -Wall -Werror in CFLAGS. The error is in the libltdl/m4/libtool.m4 file, and is due to the fnord function containing an unused variable. Please find attached a

Re: [libtool 2.2.11a] testsuite: 48 69 92 failed [cygwin]

2010-06-15 Thread Charles Wilson
On 6/15/2010 1:04 AM, Charles Wilson wrote: On 6/14/2010 11:26 PM, Ralf Wildenhues wrote: Can you try whether this fixes the issue? It does, but I only tried to run test 048. I'll report back tomorrow after the whole test suite finishes. Then I'll try incrementally to address your points

Re: overridable pic_flag

2010-06-15 Thread Paolo Bonzini
On 06/15/2010 07:45 PM, Ralf Wildenhues wrote: Ping! I would at least like a comment upon this, why it would be too dangerous, and all that. http://thread.gmane.org/gmane.comp.sysutils.automake.general/11229/focus=9626 (No, this patch is unrelated to the -flto patches I just pinged.) I'm all

Re: overridable pic_flag

2010-06-15 Thread Ralf Wildenhues
Ping! I would at least like a comment upon this, why it would be too dangerous, and all that. http://thread.gmane.org/gmane.comp.sysutils.automake.general/11229/focus=9626 (No, this patch is unrelated to the -flto patches I just pinged.) Thank you, Ralf * Ralf Wildenhues wrote on Sat, Jan 09,

Re: Print Libtool project URL in program --help output.

2010-06-15 Thread Ralf Wildenhues
* Bob Friesenhahn wrote on Sun, Jun 13, 2010 at 06:16:15PM CEST: On Sun, 13 Jun 2010, Ralf Wildenhues wrote: Tested with git Autoconf and 2.62. OK? This change looks fine to me. Thanks for the review. I had applied this, but it turns out it wasn't complete after all. The bootstrap script

Re: Compiler warning in libltdl/m4/libtool.m4 test program

2010-06-15 Thread Ralf Wildenhues
Hello Philip, thanks for the report and patch. * Philip Allison wrote on Tue, Jun 15, 2010 at 01:15:14PM CEST: The test program for whether a program can dlopen itself generates a compiler warning, which turns into a failure when building with -Wall -Werror in CFLAGS. Please note that in

Optimize func_ltwrapper_scriptname to assume a cwrapper.

2010-06-15 Thread Ralf Wildenhues
The function func_ltwrapper_executable_p is used right before func_ltwrapper_scriptname a couple of times in ltmain; the latter again calls the former. This costs an extra grep. The only time we don't call func_ltwrapper_executable_p first is on a just-created wrapper executable. So this should

Re: MSVC: Find potential libs regardless of case.

2010-06-15 Thread Peter Rosin
Hi Ralf, Den 2010-06-14 23:01 skrev Ralf Wildenhues: Hi Peter, * Peter Rosin wrote on Mon, Jun 14, 2010 at 01:26:04PM CEST: Here's the next patch on the MSVC branch. I decided to merge in a couple of things further ahead, no point in reviewing stuff when an improvement is around the corner,

Re: Print Libtool project URL in program --help output.

2010-06-15 Thread Bob Friesenhahn
On Tue, 15 Jun 2010, Ralf Wildenhues wrote: * Bob Friesenhahn wrote on Sun, Jun 13, 2010 at 06:16:15PM CEST: On Sun, 13 Jun 2010, Ralf Wildenhues wrote: Tested with git Autoconf and 2.62. OK? This change looks fine to me. Thanks for the review. I had applied this, but it turns out it

Re: Optimize func_ltwrapper_scriptname to assume a cwrapper.

2010-06-15 Thread Charles Wilson
On 6/15/2010 3:28 PM, Ralf Wildenhues wrote: So this should be safe. And the documentation is there already before the function, too. Any reasons against committing this? No reasons. Looks good to me (but I haven't actually /tested/ it). -- Chuck