Re: [RFT PATCH v3 2/9] handle sysroot flags

2010-08-01 Thread Ralf Wildenhues
Hi Paolo, patch 1/9 is OK right away. Thanks! * Paolo Bonzini wrote on Thu, Jul 29, 2010 at 01:23:15AM CEST: * libltdl/config/ltmain.m4sh (func_mode_link): Recognize --sysroot option. This patch 2/9 is OK but please commit together with the rest. Thanks, Ralf

[RFT PATCH v4 4/8] handle sysrooted paths when reading dependencies to la files

2010-08-01 Thread Paolo Bonzini
* libltdl/config/ltmain.m4sh (func_mode_execute, func_mode_install, func_mode_link): Whenever a .la file occurs in another .la file, expand the sysroot path in it. Signed-off-by: Paolo Bonzini bonz...@gnu.org --- libltdl/config/ltmain.m4sh | 18 ++ 1 files changed, 14

[RFT PATCH v4 8/8] initial version of the NEWS entry

2010-08-01 Thread Paolo Bonzini
* NEWS: Document sysroot support. --- NEWS | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 95fa97d..68ebcee 100644 --- a/NEWS +++ b/NEWS @@ -4,6 +4,16 @@ New in 2.2.12 2010-08-??: git version 2.2.11a, Libtool team: * New features: + -

[RFT PATCH v4 2/8] add --with-sysroot

2010-08-01 Thread Paolo Bonzini
* libltdl/m4/libtool.m4 (_LT_HOST_NONCANONICAL, _LT_WITH_SYSROOT): New. (LT_SETUP): Require _LT_WITH_SYSROOT. Signed-off-by: Paolo Bonzini bonz...@gnu.org --- libltdl/m4/libtool.m4 | 50 + 1 files changed, 50 insertions(+), 0 deletions(-) diff

[RFT PATCH v4 7/8] add sysroot test

2010-08-01 Thread Paolo Bonzini
* Makefile.am (TESTSUITE_AT): Add tests/sysroot.at. * tests/sysroot.at: New. Signed-off-by: Paolo Bonzini bonz...@gnu.org Signed-off-by: Charles Wilson libt...@cwilson.fastmail.fm --- Makefile.am |3 +- tests/sysroot.at | 201 ++ 2

[RFT PATCH v4 0/8] Sysroot series

2010-08-01 Thread Paolo Bonzini
This should, and I say should :) pass all tests. old: All 122 tests passed new: 37: Link order test FAILED (link-order.at:87) 38: Link order of deplibs FAILED (link-order2.at:123) 111: Run tests with low max_cmd_lenFAILED

[RFT PATCH v4 5/8] process postdeps to include sysrooted paths

2010-08-01 Thread Paolo Bonzini
* libltdl/m4/libtool.m4 (_LT_FUNC_STRIPNAME_CNF): New (from Charles Wilson). (_LT_SYS_HIDDEN_LIBDEPS): Require it. Use func_stripname_cnf to convert sysroot (-L= and -R=) usage in postdeps. Adjust the code because -L, -R and -l flags will now always be separated from the rest of the argument.

Re: using ld for linking non-C code

2010-08-01 Thread Charles Wilson
On 8/1/2010 6:46 AM, Ralf Wildenhues wrote: * Charles Wilson wrote on Mon, Jul 26, 2010 at 01:57:57PM CEST: As an aside, WHY is it that libtool tries to figure out what the language driver does, and use ld directly, rather than just trust the language driver and use it to link instead? It

Re: [RFT PATCH v3 3/9] add --with-sysroot

2010-08-01 Thread Ralf Wildenhues
Next one: 3/9. This is a bit of a preliminary review, because I haven't read all patches and all of the discussion yet. * Paolo Bonzini wrote on Thu, Jul 29, 2010 at 01:23:16AM CEST: * libltdl/m4/libtool.m4 (_LT_HOST_NONCANONICAL, _LT_WITH_SYSROOT): New. (LT_SETUP): Require _LT_WITH_SYSROOT.

Re: using ld for linking non-C code

2010-08-01 Thread Ralf Wildenhues
* Charles Wilson wrote on Sun, Aug 01, 2010 at 02:10:36PM CEST: On 8/1/2010 6:46 AM, Ralf Wildenhues wrote: Because that allows it to set run paths to the compiler libs? (I don't know either.) Hmm. If so, what use case does that capability have? You want to install an application compiled

using ld for linking non-C code (was: [REBASED PATCH 0/9] Paolo's sysroot patches, rebased plus some fixes)

2010-08-01 Thread Ralf Wildenhues
* Charles Wilson wrote on Mon, Jul 26, 2010 at 01:57:57PM CEST: As an aside, WHY is it that libtool tries to figure out what the language driver does, and use ld directly, rather than just trust the language driver and use it to link instead? It seems that the current libtool behavior

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-01 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Sun, Aug 01, 2010 at 04:47:26PM CEST: This should, and I say should :) pass all tests. Thanks for the repost. Did anything change beside the discussion attached to the last patch series post? This passes for me on GNU/Linux with a non sysrooted GCC. How come there is

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-01 Thread Charles Wilson
On 8/1/2010 10:47 AM, Paolo Bonzini wrote: 112: override pic_flag at configure time FAILED (pic_flag.at:48) 112 has been discussed before and should be skipped on non-ELF. Since I wasn't around, why is this regressing? Is it intermittent? Maybe a double-check of the testsuite.dir would

Re: [PATCH] fixup for teach libtool -L= and -R=

2010-08-01 Thread Charles Wilson
On 8/1/2010 10:42 AM, Paolo Bonzini wrote: This fixes 37 and 38 (and likely a bunch of other failures). Yep. The 37/38 failure is really a logic bug, the other two are cut-and-paste problems. It seems like I didn't review the patch even. (I did; what I didn't do was testing it beyond

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-01 Thread Ralf Wildenhues
* Charles Wilson wrote on Sun, Aug 01, 2010 at 08:03:11PM CEST: On 8/1/2010 10:47 AM, Paolo Bonzini wrote: 112: override pic_flag at configure time FAILED (pic_flag.at:48) 112 has been discussed before and should be skipped on non-ELF. Since I wasn't around, why is this regressing?

Re: [RFT PATCH v4 6/8] emit sysrooted paths when installing .la files

2010-08-01 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Sun, Aug 01, 2010 at 04:47:32PM CEST: * libltdl/config/ltmain.m4sh (func_replace_sysroot): New. (func_mode_link): Prepend paths in $libdir with the sysroot. Further, replace the sysroot with = (using func_replace_sysroot) whenever such a path is written in a .la file.

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-01 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Sun, Aug 01, 2010 at 04:47:26PM CEST: handle sysroot flags add --with-sysroot teach libtool -L= and -R= handle sysrooted paths when reading dependencies to la files process postdeps to include sysrooted paths emit sysrooted paths when installing .la files

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-01 Thread Paolo Bonzini
On 08/01/2010 08:43 PM, Ralf Wildenhues wrote: * Paolo Bonzini wrote on Sun, Aug 01, 2010 at 04:47:26PM CEST: handle sysroot flags add --with-sysroot teach libtool -L= and -R= handle sysrooted paths when reading dependencies to la files process postdeps to include sysrooted paths

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-01 Thread Charles Wilson
On 8/1/2010 2:43 PM, Ralf Wildenhues wrote: I can't really give a good review of the rest without a sysrooted compiler, and I don't have time to build one any more this weekend, so I'd appreciate if you could post output of make check-local TESTSUITEFLAGS='-v -d -x -k sysroot' for both w32

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-01 Thread Charles Wilson
On 8/1/2010 10:47 AM, Paolo Bonzini wrote: This should, and I say should :) pass all tests. Paolo Bonzini (8): handle sysroot flags add --with-sysroot teach libtool -L= and -R= handle sysrooted paths when reading dependencies to la files process postdeps to include sysrooted

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-01 Thread Charles Wilson
On 8/1/2010 4:04 PM, Charles Wilson wrote: On 8/1/2010 2:43 PM, Ralf Wildenhues wrote: I can't really give a good review of the rest without a sysrooted compiler, and I don't have time to build one any more this weekend, so I'd appreciate if you could post output of make check-local