Re: less mixing of object and function pointers

2006-08-29 Thread Ralf Wildenhues
Hello Peter, Eric, * Peter O'Gorman wrote on Wed, Aug 30, 2006 at 12:17:20AM CEST: > >From: Ralf Wildenhues > >> > >>OK to apply? Tested on GNU/Linux, where libltdl now passes > >> make CFLAGS='-W -Wall -Werror' > I think it is okay also, however, doesn't it require a documentation > update t

Re: TESTSUITE_FLAGS -> TESTSUITEFLAGS

2006-08-29 Thread Ralf Wildenhues
Hello Eric, * Eric Blake wrote on Tue, Aug 29, 2006 at 10:12:47PM CEST: > Ralf Wildenhues gmx.de> writes: > > > > OK to apply? > > * Makefile.am (check-local, installcheck-local): Use > > `TESTSUITEFLAGS' rather than `TESTSUITE_FLAGS', like Autoconf. > > * HACKING, README, README.al

Re: less mixing of object and function pointers

2006-08-29 Thread Peter O'Gorman
On Aug 30, 2006, at 5:08 AM, Eric Blake wrote: Hi Ralf, From: Ralf Wildenhues This rather mechanical patch fixes one half of the issue of mixing pointers to data and pointers to functions, by changing the set of callback functions to using two pointers to void and one pointer to a function ty

Re: TESTSUITE_FLAGS -> TESTSUITEFLAGS

2006-08-29 Thread Eric Blake
Ralf Wildenhues gmx.de> writes: > > Autoconf uses TESTSUITEFLAGS and also documents this in its example > setup, and I get confused when switching back and forth. OK to apply? > > Cheers, > Ralf > > * Makefile.am (check-local, installcheck-local): Use > `TESTSUITEFLAGS' rather tha

Re: less mixing of object and function pointers

2006-08-29 Thread Eric Blake
Hi Ralf, From: Ralf Wildenhues > This rather mechanical patch fixes one half of the issue of mixing > pointers to data and pointers to functions, by changing the set of > callback functions to using two pointers to void and one pointer to > a function type (since we only need one function signatur

TESTSUITE_FLAGS -> TESTSUITEFLAGS

2006-08-29 Thread Ralf Wildenhues
Autoconf uses TESTSUITEFLAGS and also documents this in its example setup, and I get confused when switching back and forth. OK to apply? Cheers, Ralf * Makefile.am (check-local, installcheck-local): Use `TESTSUITEFLAGS' rather than `TESTSUITE_FLAGS', like Autoconf. * HAC