[PATCH 365] Only complain that files are up-to-date with --force.

2008-04-22 Thread Gary V. Vaughan
As a side effect, this also means that when `aclocal' copies the libtool macros into `aclocal.m4' libtoolize complains only about the macro files that are missing or not up-to-date. * libtoolize.m4sh (func_echo_once): New function that prints the contents of a named variable only on the first

[PATCH 366] Libtoolize now advises AC_CONFIG_MACRO_DIR use where appropriate.

2008-04-22 Thread Gary V. Vaughan
* libtoolize.at (func_check_macros): Always advise use of AC_CONFIG_MACRO_DIR when not able to copy libtool macros into the project tree. * tests/libtoolize.at: Update expected test output. * NEWS: Updated. --- Okay to apply? ChangeLog |7 +++ NEWS|2 ++

Re: [PATCH 363] Allow better compile time type checking for lt_dladvise

2008-04-22 Thread Gary V. Vaughan
Hallo Ralf, On 21 Apr 2008, at 01:23, Ralf Wildenhues wrote: * Gary V. Vaughan wrote on Mon, Apr 21, 2008 at 02:39:37AM CEST: * libltdl/lt__private.h (lt__handle, lt__advise): Typedefs removed in favour of... * libltdl/ltdl.h (lt_dlhandle), libltdl/libltdl/lt_dlloader.h (lt_dladvise):

Re: Feature request: setting env vars for binary wrappers

2008-04-22 Thread Paolo Bonzini
Behdad Esfahbod wrote: On Fri, 2008-04-18 at 22:27 +0300, Roumen Petrov wrote: I perfectly know that user cannot go in build-dir and just to run secure shell daemon/client. And if you are happy with that, good for you. In GNOME though, we want our users to be able to run uninstalled

Re: libtool performance status

2008-04-22 Thread Bob Friesenhahn
On Tue, 22 Apr 2008, Ralf Wildenhues wrote: To put some sort of proof to my claims, here's what I get building GM unoptimized (CFLAGS=-g) on GNU/Linux with Libtool 2.2.2. and current master (all timings best of three): [ stuff removed ] Looks like a small but definite improvement to me.

Re: libtool performance status

2008-04-22 Thread Ralf Wildenhues
* Bob Friesenhahn wrote on Tue, Apr 22, 2008 at 05:18:34PM CEST: On Tue, 22 Apr 2008, Ralf Wildenhues wrote: Can you please check whether libtool --tag=CXX --config is identical for each of the builds you timed? It is really not as easy as you presume for me to relibtoolize

Re: Feature request: setting env vars for binary wrappers

2008-04-22 Thread Ralf Wildenhues
Hi Paolo, * Paolo Bonzini wrote on Tue, Apr 22, 2008 at 04:32:23PM CEST: In GNU Smalltalk, ./gst is used if you don't need to load any plugin, while tests/gst is used if you need plugins; tests/gst is created by config.status. Most of the time launching ./gst is enough; and since its

Re: [PATCH 366] Libtoolize now advises AC_CONFIG_MACRO_DIR use where appropriate.

2008-04-22 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Tue, Apr 22, 2008 at 08:51:39AM CEST: * libtoolize.at (func_check_macros): Always advise use of AC_CONFIG_MACRO_DIR when not able to copy libtool macros into the project tree. * tests/libtoolize.at: Update expected test output. * NEWS: Updated. ---

Re: Feature request: setting env vars for binary wrappers

2008-04-22 Thread Behdad Esfahbod
On Tue, 2008-04-22 at 16:32 +0200, Paolo Bonzini wrote: Behdad Esfahbod wrote: On Fri, 2008-04-18 at 22:27 +0300, Roumen Petrov wrote: I perfectly know that user cannot go in build-dir and just to run secure shell daemon/client. And if you are happy with that, good for you. In GNOME

Re: Feature request: setting env vars for binary wrappers

2008-04-22 Thread Paolo Bonzini
In GNU Smalltalk, ./gst is used if you don't need to load any plugin, while tests/gst is used if you need plugins; tests/gst is created by config.status. Most of the time launching ./gst is enough; and since its startup time is much faster than tests/gst, I didn't feel the need to use

Re: [PATCH 366] Libtoolize now advises AC_CONFIG_MACRO_DIR use where appropriate.

2008-04-22 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Tue, Apr 22, 2008 at 07:49:25PM CEST: * Gary V. Vaughan wrote on Tue, Apr 22, 2008 at 08:51:39AM CEST: * libtoolize.at (func_check_macros): Always advise use of AC_CONFIG_MACRO_DIR when not able to copy libtool macros into the project tree. *

Re: AC_LIBLTDL_CONVENIENCE

2008-04-22 Thread Ralf Wildenhues
Hello Andreas, * Andreas Schwab wrote on Tue, Apr 22, 2008 at 10:11:11AM CEST: --- libltdl/m4/ltdl.m4 1 Apr 2008 18:23:20 - 1.46 +++ libltdl/m4/ltdl.m4 16 Apr 2008 08:04:41 - @@ -79,7 +79,7 @@ _$0() # AC_LIBLTDL_CONVENIENCE accepted a directory argument in older

Re: libtool 2.2.2, ccache and -all-static

2008-04-22 Thread Ralf Wildenhues
Hi Richard, * Richard Purdie wrote on Tue, Apr 22, 2008 at 12:29:50PM CEST: I've noticed another problem with two packages in poky, prelink and libvorbis. Both packages have areas where LDFLAGS=-all-static is used. The problem comes about since Poky sets CC to ccache gcc, then libtool

Re: [PATCH 365] Only complain that files are up-to-date with --force.

2008-04-22 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Tue, Apr 22, 2008 at 08:49:54AM CEST: Okay to Apply? I'd say yes. I have some nits below; I haven't had the time to check all the logic changes in detail, but I suppose user feedback will weed out remaining issues. ;-) Thank you very much for tackling

Re: [PATCH 366] Libtoolize now advises AC_CONFIG_MACRO_DIR use where appropriate.

2008-04-22 Thread Gary V. Vaughan
Hallo Ralf, On 22 Apr 2008, at 15:27, Ralf Wildenhues wrote: * Ralf Wildenhues wrote on Tue, Apr 22, 2008 at 07:49:25PM CEST: * Gary V. Vaughan wrote on Tue, Apr 22, 2008 at 08:51:39AM CEST: * libtoolize.at (func_check_macros): Always advise use of AC_CONFIG_MACRO_DIR when not able to copy

Re: [PATCH 365] Only complain that files are up-to-date with --force.

2008-04-22 Thread Gary V. Vaughan
On 22 Apr 2008, at 16:16, Ralf Wildenhues wrote: Hi Gary, Hallo Ralf, Thanks again for the fast review :-) * Gary V. Vaughan wrote on Tue, Apr 22, 2008 at 08:49:54AM CEST: Okay to Apply? I'd say yes. + my_msg=`eval echo \\\$$1` Can this line be simplified to eval my_msg=\$$1 ?

Re: libtool 2.2.2, ccache and -all-static

2008-04-22 Thread Gary V. Vaughan
Hallo Ralf, On 22 Apr 2008, at 15:43, Ralf Wildenhues wrote: * Richard Purdie wrote on Tue, Apr 22, 2008 at 12:29:50PM CEST: I've noticed another problem with two packages in poky, prelink and libvorbis. Both packages have areas where LDFLAGS=-all-static is used. The problem comes about

Re: libtool 2.2.2, ccache and -all-static

2008-04-22 Thread Richard Purdie
Hi Ralf, On Tue, 2008-04-22 at 21:43 +0200, Ralf Wildenhues wrote: Thanks for the bug report, and especially for providing an example to reproduce it! libtool: link: ccache -static gcc -O20 -ffast-math -D_REENTRANT -fsigned-char -DUSE_MEMORY_H -o decoder_example decoder_example.o

Re: [PATCH 365] Only complain that files are up-to-date with --force.

2008-04-22 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Wed, Apr 23, 2008 at 12:18:39AM CEST: On 22 Apr 2008, at 16:16, Ralf Wildenhues wrote: +eval $1= Those double quotes are pretty superfluous, as they won't survive the eval. Not that they are a problem at all. :-) I quite like the fact that the say to

Re: libtool 2.2.2, ccache and -all-static

2008-04-22 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Wed, Apr 23, 2008 at 12:54:57AM CEST: 27. static.at:357: testing ... ../../tests/static.at:373: $CC $CPPFLAGS $CFLAGS -c a.c stdout: ../../tests/static.at:375: $LIBTOOL --mode=link --tag=CC ./ccache $CC $CFLAGS $LDFLAGS -all-static a.$OBJEXT -o a --- /dev/null