Re: Windows Line Endings
Peter Rosin wrote: [SNIP] That part of mdemo now works, thanks! But that said, I'm about to push this revert of one of the line ending fixes that was masked by this orthogonal problem. Cheers, Peter From b78fd9740ef6a2ed67a1ef14e76483af784fb5f0 Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Sun, 7 Oct 2012 00:57:26 +0200 Subject: [PATCH] tests: refix line ending problems on MinGW. In commit 22f5750, one of the hunks actually introduced line ending problems. Revert that hunk. * tests/mdemo.at: Use AT_DATA for expected output when the output from compiled programs is fed through $EGREP. Signed-off-by: Peter Rosin p...@lysator.liu.se --- tests/mdemo.at |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tests/mdemo.at b/tests/mdemo.at index 70c5532..48b7f63 100644 --- a/tests/mdemo.at +++ b/tests/mdemo.at @@ -824,7 +824,8 @@ int main (int argc, char **argv) } ]]) -LT_AT_HOST_DATA([expout], +# Not using LT_AT_HOST_DATA below, since $EGREP normalizes line endings. +AT_DATA([expout], [[Welcome to GNU libtool mdemo2! module name: foo1 module reference count: 1 -- 1.7.9 And now test fail in cross environment : linux for mingw host Roumen
Re: [PATCH] tests: skip with-pic test when no real pic flag is used.
Peter Rosin wrote: On 2012-09-19 23:02, Roumen Petrov wrote: Peter Rosin wrote: SNIP] So, what do you mean? On woe libtool define -DDLL_EXPORT as pic flag . So the value is pic_flag= -DDLL_EXPORT -DPIC On some other platform PIC default. I don't have asses to those platforms and I could guess that the value is pic_flag=-DPIC, i.e. only wit defines. Ah, now the objection makes sense. Thanks for spelling it out! If I understand patched code properly, skip the test if pic_flag contain only defines. This mean that other platform will be skipped too. Correct. What about to skip test only if DLL_EXPORT is in pic_flag ? Since the patch has already been pushed and it is only a test that may be skipped on some other platforms, I'm going to wait for a bit until someone can confirm if this change has in fact caused skips where the test used to pass. So, not rushing this one... I can not understand why you expect someone to confirm. a) how many users use platform with PIC default ? b) how many users build with libtool instead that vendor (proprietary) build system ? c) how many users test libtool ? d) how many users report skipped tests if no one of the tests fail ? Anyway, the change is simple if needed: So push it. -real_pic=false +no_dlls=: case $pic_flag in -[* [^ -]* | * -[^D]*]) real_pic=: ;; +* -DDLL_EXPORT *) no_dlls=false ;; esac -AT_CHECK([$real_pic || exit 77]) +AT_CHECK([$no_dlls || exit 77]) Cheers, Peter Roumen
126. mdemo.at:684: testing ltdl dryrun ...
Hi, This test case fail tic(tick) and pass on tac(tack) ;) on linux , libtool bootstrap with autoconf 2.69 and automake 1.12.2. It seems to me a timestamp issue . LT_AT_MAKE([install]) run config.status to refresh config.h as stamp-h1 is newer . Result is appended to config.log and later compare before vs after trigger failure in the test. May be this is autoconf issue What about attached patch 0001-tests-mdemo.at-in-ltdl-dryrun-build-config.h-first-t.patch ? Roumen From 2061bfc7e996a7af1a2f92dbcd36101d87c1 Mon Sep 17 00:00:00 2001 From: Roumen Petrov lo...@example.net Date: Sun, 7 Oct 2012 14:04:22 +0300 Subject: [PATCH] tests/mdemo.at : in ltdl dryrun build config.h first to avoid timestamp issues --- tests/mdemo.at |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/mdemo.at b/tests/mdemo.at index 70c5532..622e45c 100644 --- a/tests/mdemo.at +++ b/tests/mdemo.at @@ -686,7 +686,7 @@ AT_SETUP([ltdl dryrun]) _LT_SETUP LT_AT_CHECK_CONFIG([--with-included-ltdl]) -LT_AT_MAKE([all-local libltdl/libltdlc.la]) +LT_AT_MAKE([config.h all-local libltdl/libltdlc.la]) # create `before' and `after' in a directory deep within objdir, # so that their creation and removal does not modify even a timestamp -- 1.7.4.4
