Re: bootstrap breakage starting with fec7d87
On 2013-11-19 10:08, Ozkan Sezer wrote: Starting with fec7d87 (funclib.sh: simplify version comparison functions) I am getting the following error from bootstrap: bootstrap: error: 'makeinfo' version == 4.13 is too old bootstrap:'makeinfo' version = 4.8 is required 9fd7b88 is fine. This is with Fedora 16, with grep-2.9-3.fc16.x86_64, sed-4.2.1-9.fc16.x86_64, and bash-4.2.37-1.fc16.x86_64 Will this be fixed anytime soon? Yes, please. I came up with this patch, but I don't know how portable it is, so I would like someone knowledgeable to comment on it before pushing it... Cheers, Peter From a7462c5563e124e06f4f61ce2a9cea26cf8be390 Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Tue, 19 Nov 2013 11:54:27 +0100 Subject: [PATCH] bootstrap: fix version sort Reported by Ozkan Sezer who suffered from makeinfo 4.13 being detected as lesser than the required makeinfo 4.8. * bootstrap (func_sort_ver): Sort numerically on the non-primary keys as well. --- bootstrap |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/bootstrap b/bootstrap index 1b16d95..852efd5 100755 --- a/bootstrap +++ b/bootstrap @@ -1323,7 +1323,7 @@ func_sort_ver () $debug_cmd printf '%s\n%s\n' $1 $2 | -sort -t. -k1n -k1 -k2n -k2 -k3n -k3 -k4n -k4 -k5n -k5 -k6n -k6 -k7n -k7 -k8n -k8 -k9n -k9 +sort -t. -k 1,1n -k 2,2n -k 3,3n -k 4,4n -k 5,5n -k 6,6n -k 7,7n -k 8,8n -k 9,9n } # func_lt_ver PREV CURR -- 1.7.9
Re: bootstrap breakage starting with fec7d87
Hi Ozkan, Petor, On Nov 19, 2013, at 11:57 PM, Peter Rosin p...@lysator.liu.se wrote: On 2013-11-19 10:08, Ozkan Sezer wrote: Starting with fec7d87 (funclib.sh: simplify version comparison functions) I am getting the following error from bootstrap: bootstrap: error: 'makeinfo' version == 4.13 is too old bootstrap:'makeinfo' version = 4.8 is required 9fd7b88 is fine. This is with Fedora 16, with grep-2.9-3.fc16.x86_64, sed-4.2.1-9.fc16.x86_64, and bash-4.2.37-1.fc16.x86_64 Will this be fixed anytime soon? Yes, please. Ouch, sorry about that. I came up with this patch, but I don't know how portable it is, so I would like someone knowledgeable to comment on it before pushing it... I don't have access to any Windows environments, but your patch works correctly for me on various flavours of Mac OS, GNU/Linux, Solaris, HPUX, and AIX -- I no longer have access to Tru64 Unix, SCO Unix or IRIX. Thanks for the quick fix. Assuming it works on cygwin, mingw and other windows variants we support, please go ahead and push. Cheers, -- Gary V. Vaughan (gary AT gnu DOT org) signature.asc Description: Message signed with OpenPGP using GPGMail
Re: bootstrap breakage starting with fec7d87
On Nov 20, 2013, at 12:32 PM, Gary V. Vaughan g...@gnu.org wrote: Hi Ozkan, Petor, ^H^H^H^H^H^H^HPeter, *blush* signature.asc Description: Message signed with OpenPGP using GPGMail
