Re: [RFC] w32 and Libtool.

2010-11-02 Thread Peter Rosin
Den 2010-11-01 17:31 skrev Ralf Wildenhues: Hi Peter, * Peter Rosin wrote on Mon, Nov 01, 2010 at 10:12:01AM CET: For PDF and DVI, the text looks like this: With contemporary GNU tools, auto-import often saves the day, but see the GNU ld documentation and its ‘--enable-auto-import

* doc/libtool.texi (Platform quirks): Fix typo.

2010-11-01 Thread Peter Rosin
Hi! I pushed this as obvious. Cheers, Peter 2010-11-01 Peter Rosin p...@lysator.liu.se * doc/libtool.texi (Platform quirks): Fix typo. diff --git a/doc/libtool.texi b/doc/libtool.texi index fa8d0d1..152d491 100644 --- a/doc/libtool.texi +++ b/doc/libtool.texi @@ -5970,7 +5970,7

Re: [RFC] w32 and Libtool.

2010-11-01 Thread Peter Rosin
Den 2010-10-31 20:51 skrev Peter Rosin: Hi Ralf, Den 2010-10-31 10:13 skrev Ralf Wildenhues: This should have a cross reference to just that documentation. ...if I write: With contemporary GNU tools, auto-import often saves the day, but see the GNU ld documentation and its @code{--enable

Re: [RFC] w32 and Libtool.

2010-10-31 Thread Peter Rosin
Hi Ralf, Den 2010-10-31 10:13 skrev Ralf Wildenhues: This should have a cross reference to just that documentation. ...if I write: With contemporary GNU tools, auto-import often saves the day, but see the GNU ld documentation and its @code{--enable-auto-import} option for some corner cases

Re: [RFC] w32 and Libtool.

2010-10-29 Thread Peter Rosin
Den 2010-10-14 12:31 skrev Peter Rosin: Den 2010-10-13 20:50 skrev Ralf Wildenhues: Hi Peter, * Peter Rosin wrote on Wed, Oct 13, 2010 at 08:19:27PM CEST: Can you spot any errors? See below. I've only checked for things obvious to me; I hope somebody else verifies the w32 semantics

Re: [patch] allow --with-pic to accept package names

2010-10-22 Thread Peter Rosin
Hi Ollie, Den 2010-10-22 00:29 skrev Ollie Wild: This is motivated by GCC. We compile Fortran shared libraries which must execute on systems with no libgfortrans.so. The usual approach, passing --with-pic to configure is undesirable because it reduces the performance of other static

Re: [patch] allow --with-pic to accept package names

2010-10-22 Thread Peter Rosin
Den 2010-10-22 08:21 skrev Peter Rosin: + for pkg in $withval; do No quotes *allowed*. for pkg in $withval; do If you have quotes here, isn't the changed IFS meaningless? This is the issue that made me send the mail, the others are not really important. Oh, forgot to mention

Re: [patch] allow --with-pic to accept package names

2010-10-22 Thread Peter Rosin
Hi Ollie, Den 2010-10-22 18:32 skrev Ollie Wild: On Thu, Oct 21, 2010 at 5:29 PM, Ollie Wild a...@google.com wrote: 2010-10-21 Ollie Wild a...@google.com Modify --with-pic to support per-package configurations. * libltdl/m4/libtool.m4: Modify --with-pic to accept a list of

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-20 Thread Peter Rosin
Den 2010-10-05 13:33 skrev Peter Rosin: Den 2010-09-30 09:44 skrev Peter Rosin: Maybe the shopt isn't needed after all. If the SetErrorMode call checks if the SEM_FAILCRITICALERRORS is already set, that could be used to determine if the CREATE_DEFAULT_ERROR_MODE flag should be added

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-20 Thread Peter Rosin
Hi Gary, Den 2010-10-20 08:55 skrev Gary V. Vaughan: On 20 Oct 2010, at 13:31, Peter Rosin wrote: Den 2010-10-05 13:33 skrev Peter Rosin: Den 2010-09-30 09:44 skrev Peter Rosin: Maybe the shopt isn't needed after all. If the SetErrorMode call checks if the SEM_FAILCRITICALERRORS is already

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-20 Thread Peter Rosin
Den 2010-10-20 17:55 skrev Charles Wilson: On 10/20/2010 2:31 AM, Peter Rosin wrote: Den 2010-10-05 13:33 skrev Peter Rosin: I have implemented exactly that and just posted this to the MinGW patch tracker: http://sourceforge.net/tracker/index.php?func=detailaid=3081421group_id=2435atid=302435

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-20 Thread Peter Rosin
Den 2010-10-20 18:53 skrev Peter Rosin: Den 2010-10-20 17:55 skrev Charles Wilson: if we (MSYS) want to preserve existing popup-showing behavior at all -- which I think we do. MAYBE the following (pseudo-bat-code, where MSYS_NOPOP is set based on --no-popups arg to .bat file): if x

[PATCH] tests: fix $EXEEXT typo.

2010-10-14 Thread Peter Rosin
Hi! I have pushed the below as obvious. Cheers, Peter From 89986f448ced00ac213ec1e54fef7a146804caea Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Thu, 14 Oct 2010 14:19:21 +0200 Subject: [PATCH] tests: fix $EXEEXT typo. * tests/depdemo-relink.test (func_restore_files

Re: bindir.at takes forever.

2010-10-14 Thread Peter Rosin
Den 2010-10-14 21:48 skrev Ralf Wildenhues: [ moving from libtool@ to -patches ] Hi Dave, * Dave Korn wrote on Sun, Oct 03, 2010 at 01:15:46PM CEST: On 28/09/2010 21:36, Ralf Wildenhues wrote: * Peter Rosin wrote on Tue, Sep 28, 2010 at 02:28:48PM CEST: I have been looking at the loops

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-05 Thread Peter Rosin
Den 2010-09-30 09:44 skrev Peter Rosin: Maybe the shopt isn't needed after all. If the SetErrorMode call checks if the SEM_FAILCRITICALERRORS is already set, that could be used to determine if the CREATE_DEFAULT_ERROR_MODE flag should be added in spawn_guts. Then you could start an MSYS

Re: cwrapper generates long strings.

2010-10-04 Thread Peter Rosin
Den 2010-10-04 07:00 skrev Ralf Wildenhues: * Peter Rosin wrote on Sun, Oct 03, 2010 at 08:28:47PM CEST: Den 2010-10-03 09:01 skrev Ralf Wildenhues: +for i in 25 50 75 100 125 150 175 200 225 250 +do + PATH=$PATH$PATH_SEPARATOR/somewhere-that-eksists-not Does $LIBTOOL or the autotest

Re: [PATCH] msvc: handle symbols from different files independently.

2010-10-04 Thread Peter Rosin
Den 2010-10-04 13:25 skrev Peter Rosin: +AT_CHECK([eval cat dumpbin-output | $global_symbol_pipe], [], [stdout]) Oops, forgot one nit, I'm going with +AT_CHECK([ dumpbin-output eval $global_symbol_pipe], [], [stdout]) instead. Cheers, Peter

Re: [PATCH] msvc: handle symbols from different files independently.

2010-10-04 Thread Peter Rosin
Den 2010-10-02 08:40 skrev Ralf Wildenhues: Hi Peter, * Peter Rosin wrote on Fri, Oct 01, 2010 at 01:38:42PM CEST: Anyway, is this test case good enough? Should I find a better way to skip on non-dumpbin runs? How? Skip if $NM != $DUMPBIN? But then you'd need to ensure DUMPBIN is set

Re: [PATCH] msvc: handle symbols from different files independently.

2010-10-04 Thread Peter Rosin
Den 2010-10-04 20:07 skrev Ralf Wildenhues: Go! Pushed, thanks for reviewing! Cheers, Peter

Re: cwrapper generates long strings.

2010-10-03 Thread Peter Rosin
Den 2010-10-03 09:01 skrev Ralf Wildenhues: I used 250 at the limit in the test as the 79 characters from the string splitter in ltmain might be doubled due to C string escapes and then I added some extra margin for quotes and the , f); trailer. Still below 255 which might be an arbitrary

Re: cwrapper generates long strings.

2010-10-02 Thread Peter Rosin
Den 2010-10-02 08:32 skrev Ralf Wildenhues: Hi Peter, * Peter Rosin wrote on Fri, Oct 01, 2010 at 11:22:54PM CEST: Subject: [PATCH] cwrapper: split long lines when dumping the wrapper script. * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src): If the wrapper script contains long

Re: cwrapper generates long strings.

2010-10-02 Thread Peter Rosin
Den 2010-10-02 13:53 skrev Ralf Wildenhues: * Peter Rosin wrote on Sat, Oct 02, 2010 at 01:42:02PM CEST: Den 2010-10-02 08:32 skrev Ralf Wildenhues: +$SED -n -e ' +s/^\(.\{79\}\)\(..*\)/\1\n\2/ \n is portable only in the regex part, but not in the replacement part. For that you need

Re: [PATCH] msvc: handle symbols from different files independently.

2010-10-01 Thread Peter Rosin
Den 2010-09-30 23:29 skrev Ralf Wildenhues: * Peter Rosin wrote on Thu, Sep 30, 2010 at 10:53:13PM CEST: Den 2010-09-30 21:25 skrev Ralf Wildenhues: * Peter Rosin wrote on Thu, Sep 30, 2010 at 09:06:16PM CEST: Ok to push when I have tested with various MSVC versions? I guess, but you should

Re: cwrapper generates long strings.

2010-10-01 Thread Peter Rosin
Hi Chuck, Den 2010-10-01 16:03 skrev Charles Wilson: On 10/1/2010 7:28 AM, Peter Rosin wrote: I.e. I have this on line 865 in lt-main.c: fputs (relink_command=\(cd /c/cygwin/home/peda/libtool/git/msvc/tests/testsuite.dir/112; PATH=\\\/LOADS:/OF:/ENTRIES\\\; export PATH; PATH=\\\/LOADS

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-30 Thread Peter Rosin
Den 2010-09-29 23:21 skrev Peter Rosin: I'll think some more about the general issue. What I really would like is a bash shopt to set the error mode from the shell when running testsuites. Then we could really forget this issue. Either that or some way to make MSYS not force the default

[PATCH] msvc: handle symbols from different files independently.

2010-09-30 Thread Peter Rosin
MSVC versions? Cheers, Peter From cd30a11c9702b6102fcdb62b67af4c226f87f300 Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Thu, 30 Sep 2010 15:06:31 +0200 Subject: [PATCH] msvc: handle symbols from different files independently. * libltdl/m4/libtool.m4 (_LT_CMD_GLOBAL_SYMBOLS

Re: [PATCH] msvc: handle symbols from different files independently.

2010-09-30 Thread Peter Rosin
Hi Ralf, Den 2010-09-30 21:25 skrev Ralf Wildenhues: * Peter Rosin wrote on Thu, Sep 30, 2010 at 09:06:16PM CEST: Ok to push when I have tested with various MSVC versions? I guess, but you should really add testsuite exposure. I don't know any controlled way to create a pair of object files

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-29 Thread Peter Rosin
Den 2010-09-28 22:09 skrev Ralf Wildenhues: Hello Peter, * Peter Rosin wrote on Tue, Sep 28, 2010 at 08:08:13PM CEST: Ok to push? Avoiding assert doesn't seem like a scalable solution: lots of packages use assert for testing. assert is ANSI C. We use assert in slist.at. Is there a way

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-29 Thread Peter Rosin
Den 2010-09-29 15:47 skrev Charles Wilson: On 9/29/2010 4:06 AM, Peter Rosin wrote: Cygwin is always running with this error mode (I think), MSYS is not. Cygwin no longer supports Win9x, MSYS does. Will this patch cause any issues if people try to use libtool + MSYS on a Win9x system? I

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-29 Thread Peter Rosin
Den 2010-09-29 17:00 skrev Charles Wilson: On 9/29/2010 10:15 AM, Peter Rosin wrote: Den 2010-09-29 15:47 skrev Charles Wilson: Will this patch cause any issues if people try to use libtool + MSYS on a Win9x system? I don't foresee any problems, because SetErrorMode is really old. You were

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-29 Thread Peter Rosin
Hi Ralf, Den 2010-09-29 21:01 skrev Ralf Wildenhues: * Peter Rosin wrote on Wed, Sep 29, 2010 at 10:06:00AM CEST: Ok to push this one? I don't mind it, but I'll note that the patch will cause testsuite failures when no wrapper is actually used. This can happen - with --disable-shared

[PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-28 Thread Peter Rosin
Hi! Ok to push? Cheers, Peter From f17e568aea90ea2def14d0d0825da927b4a2421d Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Tue, 28 Sep 2010 20:02:22 +0200 Subject: [PATCH] tests: don't use assert/abort on MSVC as they are interactive. * tests/lalib-syntax.at (main.c

Re: [PATCH] tests: import variables for MSVC.

2010-09-27 Thread Peter Rosin
Den 2010-09-25 07:28 skrev Charles Wilson: On 9/24/2010 2:46 PM, Peter Rosin wrote: Now I'm also confused. That's not good. /me double checks (see below) WHAT? It doesn't work as I stated!?! *ponders that for a bit* *scratches head* Ahh, you said libtool does this by default IIRC

Re: [PATCH] tests: import variables for MSVC.

2010-09-27 Thread Peter Rosin
Den 2010-09-27 10:45 skrev Peter Rosin: Den 2010-09-25 07:28 skrev Charles Wilson: With regards to Ralf's question re: _MSC_VER. Well, technically you'd probably be more correct to do: #if (defined(_WIN32) || defined(_WIN32_WCE)) !defined(__GNUC__) ... rather than _MSC_VER; that formula

Re: [PATCH] Skip need_lib_prefix.at on systems without lib prefix on libraries.

2010-09-27 Thread Peter Rosin
Den 2010-09-24 19:37 skrev Ralf Wildenhues: Hi Peter, * Peter Rosin wrote on Fri, Sep 24, 2010 at 11:30:07AM CEST: Den 2010-09-24 06:20 skrev Ralf Wildenhues: The part about this patch which I'm unsure about is this: Does the testsuite otherwise cover well enough the fact that users may

[PATCH] tests: check if sys_lib_search_path_spec works on MSVC.

2010-09-27 Thread Peter Rosin
Hi! Ok to push? Passes with MSVC, MinGW/gcc and Cygwin/gcc. If I trivially break the compile step, it skips as designed. Cheers, Peter From 7a3874ef05fcdb58c23b563c80c2dc63a64c0e2f Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Mon, 27 Sep 2010 16:33:14 +0200 Subject

Re: [PATCH] tests: check if sys_lib_search_path_spec works on MSVC.

2010-09-27 Thread Peter Rosin
Den 2010-09-27 16:37 skrev Peter Rosin: --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,10 @@ 2010-09-27 Peter Rosin p...@lysator.liu.se + tests: check if sys_lib_search_path_spec works on MSVC. + * tests/sys-lib.at: New test, catching regressions in + v2.2.10-207-g09142ea

Re: [PATCH] tests: check if sys_lib_search_path_spec works on MSVC.

2010-09-27 Thread Peter Rosin
Hi Ralf, Den 2010-09-27 19:55 skrev Ralf Wildenhues: * Peter Rosin wrote on Mon, Sep 27, 2010 at 04:37:17PM CEST: Ok to push? Passes with MSVC, MinGW/gcc and Cygwin/gcc. If I trivially break the compile step, it skips as designed. Interesting. If it were late in the release cycle, I'd

Re: [PATCH] tests: check if sys_lib_search_path_spec works on MSVC.

2010-09-27 Thread Peter Rosin
Den 2010-09-27 20:19 skrev Peter Rosin: From c5bce8258136b2766d349a6451b933efae7b885b Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Mon, 27 Sep 2010 20:09:53 +0200 Subject: [PATCH] tests: check if sys_lib_search_path_spec works on MSVC. * tests/sys-lib.at: New test

Re: [PATCH] msvc: don't try to export import descriptors.

2010-09-24 Thread Peter Rosin
Den 2010-09-24 07:15 skrev Ralf Wildenhues: Hi Peter, * Peter Rosin wrote on Fri, Sep 24, 2010 at 12:39:13AM CEST: With the patch posted with subject: [PATCH] tests: import variables for MSVC. I found that libtool tries to put some bad symbols in the generated symbol lookup table leading

Re: [PATCH] Skip need_lib_prefix.at on systems without lib prefix on libraries.

2010-09-24 Thread Peter Rosin
Hi Ralf, Den 2010-09-24 06:20 skrev Ralf Wildenhues: Hello Peter, * Peter Rosin wrote on Fri, Sep 17, 2010 at 08:44:43AM CEST: need_lib_prefix.at currently fails with MSVC. I think the test is there to ensure that weird systems continue to work even if the testsuite is running on a normal

Re: [PATCH] tests: import variables for MSVC.

2010-09-24 Thread Peter Rosin
Hi Ralf, Den 2010-09-24 07:21 skrev Ralf Wildenhues: * Peter Rosin wrote on Fri, Sep 24, 2010 at 12:25:14AM CEST: Subject: [PATCH] tests: import variables for MSVC. * tests/depdemo/sysdep.h (EXTERN): New define, saying how to declare variables that might need to be imported. * tests/depdemo

Re: [PATCH] tests: import variables for MSVC.

2010-09-24 Thread Peter Rosin
Den 2010-09-24 19:30 skrev Charles Wilson: On 9/23/2010 6:25 PM, Peter Rosin wrote: I don't know how to set up the defines so that EXTERN becomes 1. extern when you use a static library 2. extern when you build a static library 3. extern declspec(dllimport) when you use a shared library 4

[PATCH] tests: import variables for MSVC.

2010-09-23 Thread Peter Rosin
# else # define EXTERN extern declspec(dllimport) # endif #endif #ifndef EXTERN # define EXTERN extern #endif Cheers, Peter From 044c0e8de4c98da753e7b17d87f03c8eebe2bcbe Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Thu, 23 Sep 2010 22:55:04 +0200 Subject: [PATCH] tests

[PATCH] msvc: don't try to export import descriptors.

2010-09-23 Thread Peter Rosin
00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Thu, 23 Sep 2010 23:02:42 +0200 Subject: [PATCH] msvc: don't try to export import descriptors. * libltdl/m4/libtool.m4 (_LT_LINKER_SHLIBS) [cygwin, mingw] [pw32, cegcc] cl*, exclude_expsyms: Don't export symbols in import libraries related

[PATCH] tests: reloadable objects do not work on MSVC, SKIP test.

2010-09-22 Thread Peter Rosin
!) Cheers, Peter From bff43a89559b2be74250d990e18b1b64ec073b3a Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Wed, 22 Sep 2010 09:58:47 +0200 Subject: [PATCH] tests: reloadable objects do not work on MSVC, SKIP test. * libltdl/m4/libtool.m4 (_LT_LINKER_SHLIBS) [cygwin, mingw, pw32

Re: [PATCH] tests: reloadable objects do not work on MSVC, SKIP test.

2010-09-22 Thread Peter Rosin
Den 2010-09-22 10:11 skrev Gary V. Vaughan: Hi Peter, On 22 Sep 2010, at 15:02, Peter Rosin wrote: This is fixing a testsuite issue for MSVC, and I don't need it to go in before the release. So, no rush. The patch was previously discussed here: http://lists.gnu.org/archive/html/libtool

Re: [PATCH] tests: reloadable objects do not work on MSVC, SKIP test.

2010-09-22 Thread Peter Rosin
Den 2010-09-22 10:24 skrev Gary V. Vaughan: Hi Peter, On 22 Sep 2010, at 15:15, Peter Rosin wrote: Den 2010-09-22 10:11 skrev Gary V. Vaughan: Hi Peter, On 22 Sep 2010, at 15:02, Peter Rosin wrote: This is fixing a testsuite issue for MSVC, and I don't need it to go in before the release

Re: [PATCH] tests: reloadable objects do not work on MSVC, SKIP test.

2010-09-22 Thread Peter Rosin
Den 2010-09-22 10:24 skrev Gary V. Vaughan: On 22 Sep 2010, at 15:15, Peter Rosin wrote: Den 2010-09-22 10:11 skrev Gary V. Vaughan: Sure, go ahead. And please add a `no test failures with msvc/msys' entry to NEWS while you're there. I assume you mean that both patches are OK to push

[PATCH] msvc: eliminate spaces in the library search path.

2010-09-21 Thread Peter Rosin
library such as -luser32 if -lz isn't found. So, ok to push even if it's late and without testsuite coverage? Cheers, Peter From 6292de4810a69f5debc89d714df0db580e684eef Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Tue, 21 Sep 2010 09:30:07 +0200 Subject: [PATCH] msvc

Re: [PATCH] msvc: eliminate spaces in the library search path.

2010-09-21 Thread Peter Rosin
Den 2010-09-21 09:37 skrev Peter Rosin: I know it's late for the release, but I'd like to squeeze this one in too, if at all possible. After all, it doesn't affect anything but MSVC. With the patch, I get sys_lib_search_path_spec=/c/PROGRA~1/MID05A~1/VC/ATLMFC/LIB /c/PROGRA~1/MID05A~1/VC

Re: [PATCH] msvc: eliminate spaces in the library search path.

2010-09-21 Thread Peter Rosin
Den 2010-09-21 19:33 skrev Ralf Wildenhues: Hi Peter, * Peter Rosin wrote on Tue, Sep 21, 2010 at 09:37:16AM CEST: I know it's late for the release, but I'd like to squeeze this one in too, if at all possible. After all, it doesn't affect anything but MSVC. I have questions: What does

Re: [PATCH] msvc: eliminate spaces in the library search path.

2010-09-21 Thread Peter Rosin
Den 2010-09-21 20:08 skrev Charles Wilson: On 9/21/2010 1:33 PM, Ralf Wildenhues wrote: * Peter Rosin wrote on Tue, Sep 21, 2010 at 09:37:16AM CEST: + do +IFS=$lt_save_ifs +# Let DOS variable expansion print the short 8.3 style file name. +lt_path=`cd $lt_path

Re: [PATCH] msvc: eliminate spaces in the library search path.

2010-09-21 Thread Peter Rosin
Den 2010-09-21 20:08 skrev Charles Wilson: On 9/21/2010 1:33 PM, Ralf Wildenhues wrote: Hi Peter, * Peter Rosin wrote on Tue, Sep 21, 2010 at 09:37:16AM CEST: I know it's late for the release, but I'd like to squeeze this one in too, if at all possible. After all, it doesn't affect anything

[PATCH 1/2] tests: __declspec (dll{ex, im}port) in tests/exceptions.at

2010-09-20 Thread Peter Rosin
Hi! I have tested this patch on MinGW/gcc and Cygwin/gcc and they are both ok with the __declspec() notation. On MSVC, the test goes from skip to fail, as it needs 2/2. Cheers, Peter From 52972128c5952da628e033e4509208711906c3a2 Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se

Re: [PATCH 1/2] tests: __declspec (dll{ex, im}port) in tests/exceptions.at

2010-09-20 Thread Peter Rosin
Hi Bob, Den 2010-09-20 17:57 skrev Bob Friesenhahn: On Mon, 20 Sep 2010, Peter Rosin wrote: I have tested this patch on MinGW/gcc and Cygwin/gcc and they are both ok with the __declspec() notation. On MSVC, the test goes from skip to fail, as it needs 2/2. This patch looks good to apply

[PATCH] tests: Import items from liba1 for MSVC.

2010-09-19 Thread Peter Rosin
Hi! tests/lt_dlexit.at turned out to be trival to fix for MSVC. Ok to push? No rush for the release though, it's only the testsuite... Cheers, Peter From f05840852938b904ac81502f7162e19525206f59 Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Sun, 19 Sep 2010 14:14:21

Re: [PATCH] tests: Import items from liba1 for MSVC.

2010-09-19 Thread Peter Rosin
Hi Ralf, Den 2010-09-19 16:16 skrev Ralf Wildenhues: * Peter Rosin wrote on Sun, Sep 19, 2010 at 04:05:06PM CEST: tests/lt_dlexit.at turned out to be trival to fix for MSVC. Ok to push? No rush for the release though, it's only the testsuite... Okay if the test still passes with GCC

Re: [PATCH] Skip need_lib_prefix.at on systems without lib prefix on libraries.

2010-09-18 Thread Peter Rosin
Den 2010-09-18 00:04 skrev Roumen Petrov: Hi Peter, Peter Rosin wrote: Hi! need_lib_prefix.at currently fails with MSVC. Hmm probably test fail as shared library is build without -no-undefined flag. Did libtool MSC allow creation of shared libraries without -no-undefined

Re: [PATCH 2/2] Move portable shell tests from the old to the new testsuite.

2010-09-18 Thread Peter Rosin
Den 2010-09-17 19:28 skrev Charles Wilson: On 9/17/2010 1:23 PM, Ralf Wildenhues wrote: And since IIRC Gary wanted to do the release this weekend, I wonder whether this isn't more safely pushed to after the relase. WDYT? FWIW, I agree that this patch should be postponed until after the

Re: [PATCH] Fix sh.test failure introduced in 72064249

2010-09-17 Thread Peter Rosin
Den 2010-09-17 04:53 skrev Charles Wilson: * libltdl/config/ltmain.m4sh (func_mode_link): Avoid poor syntax. --- Without this, sh.test fails. Committed as obvious (no, really, this time). Oops, sorry. Thanks for taking care of the mess! Cheers, Peter

[PATCH] Skip need_lib_prefix.at on systems without lib prefix on libraries.

2010-09-17 Thread Peter Rosin
, Peter From d23b133decabf20349e7b2a13aec5b1ce070b03c Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Thu, 16 Sep 2010 23:17:28 +0200 Subject: [PATCH] Skip need_lib_prefix.at on systems without lib prefix on libraries. * tests/need_lib_prefix.at [MSVC, OS/2]: Skip this test

[0/2] sh.test adjustments

2010-09-17 Thread Peter Rosin
Hi! Since I tripped up and made sh.test fail, to repent I'd thought I'd move the test to the new testsuite. But then I noticed a bug, so it turned into a two patch series... Ok to push? Cheers, Peter

[PATCH 1/2] * tests/sh.test: Detect missing 'test' in 'if $foo = ...'.

2010-09-17 Thread Peter Rosin
From 75358282c6674d399e76c42eb456ed20b73c358a Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Fri, 17 Sep 2010 12:15:00 +0200 Subject: [PATCH 1/2] * tests/sh.test: Detect missing 'test' in 'if $foo = ...'. Signed-off-by: Peter Rosin p...@lysator.liu.se --- ChangeLog

[PATCH 2/2] Move portable shell tests from the old to the new testsuite.

2010-09-17 Thread Peter Rosin
From c6195aeb806270200950a86cda955ca674e680f1 Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Fri, 17 Sep 2010 12:28:51 +0200 Subject: [PATCH 2/2] Move portable shell tests from the old to the new testsuite. * tests/sh.test: Move this... * tests/sh.at: ...to here, and adjust

[PATCH] Copy over DLL_EXPORT handling from C to C++ for non-GCC on w32.

2010-09-17 Thread Peter Rosin
Hi! I noticed that -DDLL_EXPORT didn't appear when I compiled C++ code with MSVC. I'd like this one to go in before the release. Ok to push? Cheers, Peter From 0114c5a834fb1ce8e8324ff6d7c0bb782139c3c7 Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Fri, 17 Sep 2010 16:15

Re: [PATCH 1/2] * tests/sh.test: Detect missing 'test' in 'if $foo = ...'.

2010-09-17 Thread Peter Rosin
Den 2010-09-17 19:06 skrev Ralf Wildenhues: * Peter Rosin wrote on Fri, Sep 17, 2010 at 12:37:07PM CEST: Subject: [PATCH 1/2] * tests/sh.test: Detect missing 'test' in 'if $foo = ...'. OK, but I find the log entry not really explaining the change. How about this instead? tests

Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length.

2010-09-16 Thread Peter Rosin
Den 2010-09-16 19:25 skrev Ralf Wildenhues: Hi Peter, * Peter Rosin wrote on Mon, Sep 13, 2010 at 10:03:10AM CEST: Ok to push this time? Okay. I think it ought to be possible to clean up the logic a bit further, to make it easier to follow when you read the whole paragraph of code

Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length.

2010-09-13 Thread Peter Rosin
. Ok to push this time? Cheers, Peter From a5e4bb2eb0a47ea72ccc31a43e149a1cb6a557b8 Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Mon, 13 Sep 2010 09:48:57 +0200 Subject: [PATCH] Prefer $NM @file when the toolchain isn't native to $build. * libltdl/config/ltmain.m4sh

Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length.

2010-09-13 Thread Peter Rosin
Den 2010-09-13 10:03 skrev Peter Rosin: I have tested stresstest.at on MSYS/gcc, MinGW/MSVC, Cygwin/gcc and Cygwin/MSVC. Passes all over. In the logs I see this on MSYS and for Cygwin/gcc: libtool: link: dumpbin -symbols various/relative/paths ... and libtool: link: dumpbin -symbols

Testsuite issues (was: [PATCH 6/7] Convert file name to toolchain format when invoking $NM.)

2010-09-13 Thread Peter Rosin
Den 2010-09-10 07:38 skrev Ralf Wildenhues: Hi Peter, * Peter Rosin wrote on Fri, Sep 10, 2010 at 12:35:59AM CEST: Den 2010-09-09 22:05 skrev Charles Wilson: On 9/9/2010 3:56 PM, Ralf Wildenhues wrote: Secondly, I can help with unsupervised git bisect if you need. In http://lists.gnu.org

Re: approving w32 patches

2010-09-13 Thread Peter Rosin
Hi! Den 2010-09-11 23:30 skrev Ralf Wildenhues: * Peter O'Gorman wrote on Sat, Sep 11, 2010 at 07:37:41PM CEST: On 09/11/2010 10:09 AM, Charles Wilson wrote: However...I don't have the authority to push *anything* without approval, so I *can't* simply say pushed as obvious. It is ok for

Re: [PATCH] * HACKING (Maintenance Notes): Adjust to moved files.

2010-09-12 Thread Peter Rosin
Den 2010-09-11 23:18 skrev Ralf Wildenhues: * Peter Rosin wrote on Sat, Sep 11, 2010 at 09:02:54PM CEST: I noticed that HACKING referred to files that have been moved. Should I also add libltdl/config/compile? Yes, plase. But that one does not appear to be handled by make

[PATCH] * .gitignore: Ignore *.obj files for MSVC (and w32 in general).

2010-09-12 Thread Peter Rosin
Hi! I have pushed this as obvious. Cheers, Peter From 52e86c62786b95f91f32e7020f7eaf3c1be9a59b Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Sun, 12 Sep 2010 18:43:11 +0200 Subject: [PATCH] * .gitignore: Ignore *.obj files for MSVC (and w32 in general). --- .gitignore

Re: [PATCH] Correct typo: $sharedlib_from_linklib_cmd missing '_cmd'

2010-09-11 Thread Peter Rosin
Den 2010-09-11 07:02 skrev Charles Wilson: OK to push as obvious? To me, pushing as obvious is the same as pushing without asking (and when I do, I make damn sure I don't push anything bad). This makes me curious, what does it mean to you? Cheers, Peter

Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length.

2010-09-11 Thread Peter Rosin
783a1f89bd69a76cf836c49a04a3a5e854725785 Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Sat, 11 Sep 2010 13:57:10 +0200 Subject: [PATCH 7/7] Prefer $NM @file when the toolchain isn't native to $build. * libltdl/config/ltmain.m4sh (func_mode_link): Avoid calculating the command

[PATCH] * HACKING (Maintenance Notes): Adjust to moved files.

2010-09-11 Thread Peter Rosin
with the latest MSVC fixes for 'compile'? Cheers, Peter From 67dcc26620b7eb296cf58e7dfd9aedcb811b3870 Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Sat, 11 Sep 2010 20:57:43 +0200 Subject: [PATCH] * HACKING (Maintenance Notes): Adjust to moved files. Signed-off-by: Peter

Re: [PATCH 6/7] Convert file name to toolchain format when invoking $NM.

2010-09-10 Thread Peter Rosin
Den 2010-09-05 23:29 skrev Ralf Wildenhues: * Peter Rosin wrote on Sun, Sep 05, 2010 at 10:02:11PM CEST: Subject: [PATCH 6/7] Convert file name to toolchain format when invoking $NM. * libltdl/config/ltmain.m4sh (func_generate_dlsyms) (func_win32_libid, func_cygming_gnu_implib_p

Re: [PATCH 6/7] Convert file name to toolchain format when invoking $NM.

2010-09-10 Thread Peter Rosin
Den 2010-09-10 15:54 skrev Charles Wilson: On 9/10/2010 9:11 AM, Peter Rosin wrote: func_cygming_gnu_implib_p - 6. Dead code. Needs the sharedlib_from_linklib - sharedlib_from_linklib_cmd typo fix. So, a previous testsuite deficiency that should not hold back

Re: [PATCH 6/7] Convert file name to toolchain format when invoking $NM.

2010-09-10 Thread Peter Rosin
Den 2010-09-10 16:09 skrev Charles Wilson: On 9/10/2010 10:07 AM, Peter Rosin wrote: It's dead, you need the below patch to animate it. There is no sane way you can influence the sharedlib_from_linklib variable. Well, that's just a bug with a known but uncommitted patch. So he's stopped

Re: [PATCH 6/7] Convert file name to toolchain format when invoking $NM.

2010-09-10 Thread Peter Rosin
Den 2010-09-10 19:19 skrev Ralf Wildenhues: * Peter Rosin wrote on Fri, Sep 10, 2010 at 03:11:39PM CEST: 1. Not covered, you'd need to link a program with -dlopen self, but also with a non-libtool object (.o) and/or an non-libtooled old archive (.a). Neither appears to happen in the testsuite

Re: [PATCH 6/7] Convert file name to toolchain format when invoking $NM.

2010-09-09 Thread Peter Rosin
Den 2010-09-09 00:19 skrev Charles Wilson: On 9/8/2010 6:14 PM, Charles Wilson wrote: On 9/8/2010 5:52 PM, Peter Rosin wrote: sharedlib_from_linklib_cmd, which is not used anywhere according # no lafile. user explicitly requested -dlpreopen import

Re: [PATCH 6/7] Convert file name to toolchain format when invoking $NM.

2010-09-09 Thread Peter Rosin
Den 2010-09-09 18:02 skrev Charles Wilson: After all, the point of that patch was to correct the FAILURE of that particular test! So, somewhere between 2009-01 and e83da49a, some OTHER change to libtool fixed (?) the mdemo test on mingw/msys. Sigh. Doesn't look like it.

Re: [PATCH] Fix dependency tracking for MSYS/MinGW.

2010-09-09 Thread Peter Rosin
Den 2010-09-09 19:00 skrev Ralf Wildenhues: * Peter Rosin wrote on Thu, Sep 09, 2010 at 10:59:30AM CEST: + func_stripname 'func_convert_file_' '' $to_tool_file_cmd func_stripname is fast with modern shells, but may fork with others. Let's not introduce a number of forks here, just because

Re: [PATCH 6/7] Convert file name to toolchain format when invoking $NM.

2010-09-09 Thread Peter Rosin
Den 2010-09-09 22:05 skrev Charles Wilson: On 9/9/2010 3:56 PM, Ralf Wildenhues wrote: I understand that you're doing a difficult bug hunt here, and 6/7 is the only unapplied patch of this series (right?). I've looked at 6/7 again, and conclude that it has a low chance of regressing. I

Re: [PATCH] Adjust naming of MSVC import libraries.

2010-09-08 Thread Peter Rosin
Den 2010-09-08 00:23 skrev Peter Rosin: Den 2010-09-07 22:24 skrev Ralf Wildenhues: * Ralf Wildenhues wrote on Tue, Sep 07, 2010 at 10:20:06PM CEST: * Peter Rosin wrote on Tue, Sep 07, 2010 at 11:25:00AM CEST: Subject: [PATCH] Adjust naming of MSVC import libraries. * libltdl/m4/libtool.m4

Re: [PATCH] Adjust naming of MSVC import libraries.

2010-09-08 Thread Peter Rosin
Den 2010-09-08 07:16 skrev Ralf Wildenhues: * Peter Rosin wrote on Wed, Sep 08, 2010 at 12:23:17AM CEST: Den 2010-09-07 22:24 skrev Ralf Wildenhues: * Ralf Wildenhues wrote on Tue, Sep 07, 2010 at 10:20:06PM CEST: * Peter Rosin wrote on Tue, Sep 07, 2010 at 11:25:00AM CEST: Rationale: you

Re: [PATCH] Adjust naming of MSVC import libraries.

2010-09-08 Thread Peter Rosin
Den 2010-09-08 21:13 skrev Ralf Wildenhues: * Peter Rosin wrote on Wed, Sep 08, 2010 at 01:42:20PM CEST: How about the below? Sure, thanks! Pushed. Thank you! Cheers, Peter

Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length.

2010-09-08 Thread Peter Rosin
Den 2010-09-08 23:10 skrev Charles Wilson: On 9/8/2010 4:54 PM, Peter Rosin wrote: Hmmm, but @file makes it harder than necessary to debug on MSYS, since the automatic command line conversion make the n...@file branch work there. And the @file branch is probably bad for performance on MSYS too

Re: [PATCH 6/7] Convert file name to toolchain format when invoking $NM.

2010-09-08 Thread Peter Rosin
Den 2010-09-05 23:29 skrev Ralf Wildenhues: * Peter Rosin wrote on Sun, Sep 05, 2010 at 10:02:11PM CEST: Subject: [PATCH 6/7] Convert file name to toolchain format when invoking $NM. * libltdl/config/ltmain.m4sh (func_generate_dlsyms) (func_win32_libid, func_cygming_gnu_implib_p

[PATCH] Fixup texi typo in previous.

2010-09-07 Thread Peter Rosin
Hi! I noticed a silly bug in the texi-hunk of the previous commit. Pushing the below as obvious. Cheers, Peter From 4faba0449e5abe8d136bbcd30544888b4b9dcdd3 Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Tue, 7 Sep 2010 11:07:10 +0200 Subject: [PATCH] Fixup texi typo

Re: [PATCH] Adjust naming of MSVC import libraries.

2010-09-07 Thread Peter Rosin
Den 2010-09-04 16:21 skrev Charles Wilson: On 9/4/2010 4:52 AM, Peter Rosin wrote: And the testsuite runs have finished and results are the same. I still want to push this. I have no objections anymore, but I can't approve it. Here's a rebased and adjusted version now that 5/7 from

Re: [PATCH] Adjust naming of MSVC import libraries.

2010-09-07 Thread Peter Rosin
Hi Gary, Den 2010-09-07 11:47 skrev Gary V. Vaughan: On 7 Sep 2010, at 16:25, Peter Rosin wrote: (or are you all on the 72 hour clock since the first post? I'm setting a new 72 hour clock now in case you're not) No need for that I think. As long as the testsuite is still passing

Re: [PATCH 1/7] Add file name conversion from $build to toolchain.

2010-09-06 Thread Peter Rosin
Hi Chuck, Ralf, Den 2010-09-05 22:49 skrev Charles Wilson: [meta-request: in the future, could you not use whatever option it is that causes the entire patch message to be stored at attachment to the actual message...this is a little awkward to reply-to:] On 9/5/2010 3:58 PM, Peter Rosin

Re: [PATCH 1/7] Add file name conversion from $build to toolchain.

2010-09-06 Thread Peter Rosin
Den 2010-09-06 08:42 skrev Peter Rosin: I have a patch ready with some updates to both the fake and the lying case (and the nits requested by Ralf), will see if I can find a way to post without destroying tabs and without causing you all trouble... Also, no comments for 2/7 and 3/7, does

Re: [PATCH 4/7] Use func_to_tool_file instead of fix_srcfile_path.

2010-09-06 Thread Peter Rosin
Den 2010-09-05 23:23 skrev Ralf Wildenhues: 2/7 and 3/7 are ok, thanks. Aha, look what I found! * Peter Rosin wrote on Sun, Sep 05, 2010 at 10:01:04PM CEST: Subject: [PATCH 4/7] Use func_to_tool_file instead of fix_srcfile_path. * libltdl/config/ltmain.m4sh (func_mode_compile): Replace

Re: [PATCH 5/7] Convert POSIX file names to toolchain format for MSVC

2010-09-06 Thread Peter Rosin
Den 2010-09-05 23:27 skrev Ralf Wildenhues: * Peter Rosin wrote on Sun, Sep 05, 2010 at 10:01:42PM CEST: From 449723f9bdcad6946e098d7acf0f215f3a4c18a2 Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Sun, 5 Sep 2010 17:53:35 +0200 Subject: [PATCH 5/7] Convert POSIX file

Re: git log - changelog

2010-09-06 Thread Peter Rosin
Den 2010-09-06 11:27 skrev Gary V. Vaughan: On 6 Sep 2010, at 12:47, Ralf Wildenhues wrote: * Gary V. Vaughan wrote on Mon, Sep 06, 2010 at 05:20:30AM CEST: On 6 Sep 2010, at 03:44, Ralf Wildenhues wrote: Except that the autotools project logs contain lots of S-O-B entries which explicitly do

Re: [PATCH 5/7] Convert POSIX file names to toolchain format for MSVC

2010-09-06 Thread Peter Rosin
Hi Ralf, Den 2010-09-06 20:01 skrev Ralf Wildenhues: * Peter Rosin wrote on Mon, Sep 06, 2010 at 11:14:19AM CEST: Easily? Is this something like this what you had in mind? (untested) Yes, something like that is what I had in mind, nice! I haven't tested it yet either, though. I think I

Re: [PATCH 5/7] Convert POSIX file names to toolchain format for MSVC

2010-09-06 Thread Peter Rosin
Den 2010-09-06 20:42 skrev Ralf Wildenhues: * Peter Rosin wrote on Mon, Sep 06, 2010 at 08:38:31PM CEST: Den 2010-09-06 20:01 skrev Ralf Wildenhues: * Peter Rosin wrote on Mon, Sep 06, 2010 at 11:14:19AM CEST: Easily? Is this something like this what you had in mind? (untested) Yes

<    1   2   3   4   5   >