Re: [PATCH 6/6] use printf as $ECHO

2008-11-10 Thread Ralf Wildenhues
[ http://thread.gmane.org/gmane.comp.gnu.libtool.patches/8788/focus=8811 ] Hello Sven, below is a question regarding your shell pages. * Paolo Bonzini wrote on Mon, Nov 10, 2008 at 12:07:12PM CET: Esp., I'm quite sure that we need the cat here-document fallback; [...] I am quite concerned

Re: [PATCH 6/6] use print or printf or cat as $ECHO (really)

2008-11-10 Thread Ralf Wildenhues
Hi Paolo, * Paolo Bonzini wrote on Mon, Nov 10, 2008 at 02:16:03PM CET: Regarding the other patches, I retested them successfully using Autoconf 2.59 for the tests/*demo* directories. Thanks. When pushing I got this error error: unable to create temporary sha1 filename ./objects/95:

Re: executable wrapper on mingw mangles arguments

2008-11-10 Thread Ralf Wildenhues
[ Cc:ing the list ] * Bruno Haible wrote on Tue, Nov 11, 2008 at 12:21:10AM CET: If you prefer a tarball for testing, then I can also just push the combined patch and you can use the nightly build from the Libtool web page. Yes please. It's safer and less troublesome if I can use a

Simplify cwrapper handling a bit

2008-11-10 Thread Ralf Wildenhues
OK to apply? FWIW, IFS splitting of $list in for item in $list; do ... done is done once, at the beginning of the list. Thanks, Ralf 2008-11-11 Ralf Wildenhues [EMAIL PROTECTED] Simplify cwrapper handling a bit. * libltdl/config/ltmain.m4sh (func_emit_wrapper_part1

Re: [PATCH 6/6] use printf as $ECHO

2008-11-10 Thread Ralf Wildenhues
Hello Sven, thanks for the quick feedback! * Sven Mascheck wrote on Tue, Nov 11, 2008 at 01:00:26AM CET: On Mon, Nov 10, 2008 at 08:34:31PM +0100, Ralf Wildenhues wrote: func_fallback_echo() { eval 'cat _LTEOF $* _LTEOF' } You probably remembered http://www.in-ulm.de

Re: [PATCH 6/6] use print or printf or cat as $ECHO (really)

2008-11-11 Thread Ralf Wildenhues
Hi Paolo, * Paolo Bonzini wrote on Mon, Nov 10, 2008 at 09:58:32PM CET: Regarding the 6/6 patch, you have posted several variants, also there are pending issues. For me it'd be easiest to review the final one when things have been hashed out; I think I've voiced all concerns that I

Re: Simplify cwrapper handling a bit

2008-11-11 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Tue, Nov 11, 2008 at 07:14:54AM CET: Ralf Wildenhues wrote: OK to apply? Not this bit: Thanks for the reminder, and the speedy review. I left out that hunk, fixed a couple more coding style issues, and committed this. Cheers, Ralf Simplify

Re: libtool(20080421), mingw-cross, check-local fail for DESTDIR tests

2008-11-11 Thread Ralf Wildenhues
Hello Charles, Roumen, * Charles Wilson wrote on Sat, Nov 08, 2008 at 05:12:18PM CET: Roumen Petrov wrote: With attached patch now I get for libtool 2.2.4: DESTDIR tests 38: Simple DESTDIR install ok 39: DESTDIR with in-package deplibs ok

Do not use `test ... -a ...'.

2008-11-11 Thread Ralf Wildenhues
Spotted, and pushed this trivial patch. (Yes, on HP-UX all shells know this, but being consistent is easy here.) Cheers, Ralf Do not use `test ... -a ...'. * libltdl/m4/libtool.m4 (_LT_LINKER_SHLIBS) [hpux10, hpux11]: Replace test -a with test test. diff --git

Re: testsuite.at for version 2.x Was: ... mingw-cross, check-local fail for DESTDIR tests

2008-11-11 Thread Ralf Wildenhues
Hello Roumen, all, apologies for the huge delay. * Roumen Petrov wrote on Sat, May 10, 2008 at 12:25:48PM CEST: The libtool version before 2.x (as example 1.5x) in mingw-cross compilation environment create executables as follow: - foo : wrapper shell script - foo.exe : libtool wrapper

Use -no-undefined in install tests.

2008-11-11 Thread Ralf Wildenhues
Another trivial testsuite failure with w32 (cross compiled; the failure is exposed with the pending *EXEC_CHECK patch applied). Pushed. Cheers, Ralf Use -no-undefined in install tests. * tests/install.at (Install tests): Use `-no-undefined'. diff --git a/tests/install.at

Re: libtool(20080421), mingw-cross, check-local fail for DESTDIR tests

2008-11-12 Thread Ralf Wildenhues
Hi Roumen, * Roumen Petrov wrote on Wed, Nov 12, 2008 at 08:41:09PM CET: Ralf Wildenhues wrote: --- a/tests/destdir.at +++ b/tests/destdir.at @@ -56,7 +56,7 @@ $LIBTOOL --mode=compile $CC $CPPFLAGS $CFLAGS -c a.c [SNIP] AT_CHECK([$LIBTOOL --mode=finish $libdir], [ignore], [ignore

Re: testsuite.at for version 2.x Was: ... mingw-cross, check-local fail for DESTDIR tests

2008-11-12 Thread Ralf Wildenhues
Let's drop bug-libtool. * Roumen Petrov wrote on Wed, Nov 12, 2008 at 10:01:56PM CET: Please find attached file convenience.at-log Thanks. [SRCDIR]/tests/convenience.at:61: $LIBTOOL --mode=link $CC $CFLAGS $LDFLAGS -o main main$i.lo liba$conv.la stderr: stdout: libtool: link:

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static

2008-11-13 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Thu, Nov 13, 2008 at 06:09:20AM CET: Ralf Wildenhues wrote: Well, --verbose is documented to be a reversal of --silent, and documented to be the default. The fact that opt_verbose is never set is a limitation. If fixed, that should better happen

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static

2008-11-13 Thread Ralf Wildenhues
* [EMAIL PROTECTED] wrote on Fri, Nov 14, 2008 at 12:28:36AM CET: The point is, we perhaps STARTED with the .la file, but the whole point of the dlpreopen $pass is to replace each .la file in $dlprefiles with the name of the object from which the symbols should be extracted, to build the

Re: executable wrapper on mingw mangles arguments

2008-11-16 Thread Ralf Wildenhues
Hi Bruno, * Bruno Haible wrote on Fri, Nov 14, 2008 at 12:47:44PM CET: Find attached the resulting logs (stdout+stderr, and tests/testsuite.dir/36/testsuite.log). The test passes. But it also passes when I comment out the line newargv = prepare_spawn (newargv); in ltmain.sh and do a make

Re: [PATCH] Fix --verbose option and add new --no-silent option

2008-11-16 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Sat, Nov 15, 2008 at 10:40:26AM CET: * libltdl/config/ltmain.m4sh (usage): Document new --no-silent/--no-quiet options. Spacing changes. (func_enable_tag): Handle --no-silent/--no-quiet options. Modified --verbose to actually activate opt_verbose. New

Fix $ECHO abuse exposed by recent patch.

2008-11-16 Thread Ralf Wildenhues
The $ECHO changes (now using printf on GNU/Linux) exposed a buglet, fixed as below. Cheers, Ralf Fix $ECHO abuse exposed by recent patch. * libltdl/m4/libtool.m4 (_LT_SYS_DYNAMIC_LINKER): Require _LT_CHECK_SHELL_FEATURES, for $lt_NL2SP. Always quote argument to $ECHO. diff

Re: Revenge of the $ECHO. Kill most uses of Xsed.

2008-11-16 Thread Ralf Wildenhues
Hi Eric, * Eric Blake wrote on Mon, Nov 17, 2008 at 12:49:25AM CET: According to Ralf Wildenhues on 11/16/2008 3:48 PM: -my_directory_path=`$ECHO X$my_directory_path | $Xsed -e $dirname` +my_directory_path=`$ECHO $my_directory_path | $SED -e $dirname` done

Re: Revenge of the $ECHO. Kill most uses of Xsed.

2008-11-18 Thread Ralf Wildenhues
* Eric Blake wrote on Wed, Nov 19, 2008 at 06:12:27AM CET: - RM=$ECHO $RM + RM=echo $RM Are all of these safe, considering mingw might have \ in an absolute pathname to these tools? No, and I'm glad you ask about this. The point here is that there

Re: testsuite.at for version 2.x Was: ... mingw-cross, check-local fail for DESTDIR tests

2008-11-18 Thread Ralf Wildenhues
Hi Roumen, let's drop bug-libtool from the Cc:. * Roumen Petrov wrote on Tue, Nov 18, 2008 at 11:12:56PM CET: [SNIP] Test 25 Link order of deplibs skipped (link-order2.at:129) - in my todo for investigation. Still skipped. The executable exit code is 1 instead 2. No idea what is

Re: 2.2.6: libltdlcS.c:22: error: 'lt_ptr' undeclared here (not in a function)

2008-11-19 Thread Ralf Wildenhues
[ moving from bug-libtool ] * Ralf Wildenhues wrote on Mon, Nov 17, 2008 at 10:42:09PM CET: * Akim Demaille wrote on Mon, Nov 17, 2008 at 09:38:56PM CET: Actually, grepping inside my original 2.2.6 tarball does find quite a few lt_ptr (and not only in the changelog). It appears mainly

Re: [PATCH] Fix --verbose option and add new --no-silent option

2008-11-21 Thread Ralf Wildenhues
Hi Charles, apologies: I actually wrote this reply a few days ago, and then forgot to send it. :-( Sorry. * Charles Wilson wrote on Mon, Nov 17, 2008 at 02:31:56AM CET: +Thus, to restore the default state, the following two options +must be given (in order): [EMAIL PROTECTED] [EMAIL

Re: [PATCH 6/6] use print or printf or cat as $ECHO (really)

2008-11-22 Thread Ralf Wildenhues
Hello again, * Paolo Bonzini wrote on Mon, Nov 10, 2008 at 02:16:03PM CET: * libltdl/m4/libtool.m4 (LT_INIT): Add _LT_SHELL_INIT to work around Autoconf 2.64 bug. (_LT_OUTPUT_LIBTOOL_COMMANDS_INIT): Add func_fallback_echo. Eliminate lt_ECHO requoting. (_LT_SHELL_INIT): Use a public M4sh

Re: [PATCH 6/6] use print or printf or cat as $ECHO (really)

2008-11-23 Thread Ralf Wildenhues
* Eric Blake wrote on Sat, Nov 22, 2008 at 03:37:03PM CET: According to Eric Blake on 11/22/2008 7:31 AM: Maybe a better suggested test would be one that checks for either print or printf (that way, a Solaris machine will let ksh pass the suggested test). Since the overall test is

Re: [OMPI devel] RFC: Add SunStudio/Libtool helper script for post-configure

2008-11-23 Thread Ralf Wildenhues
[ Libtool list readers: this thread is http://www.open-mpi.org/community/lists/devel/2008/11/4937.php ] I'm applying this patch to Libtool master, to fix $wl for the Sun Ceres Fortran compiler. Cheers, Ralf Fix matching of Sun Fortran compiler on Linux. * libltdl/m4/libtool.m4

Re: Revenge of the $ECHO. Kill most uses of Xsed.

2008-11-23 Thread Ralf Wildenhues
I've fixed the issues with the first version of the $Xsed killer patch now, with the incremental diff as shown below, and pushed the combined result. Cheers, Ralf diff --git a/libltdl/config/general.m4sh b/libltdl/config/general.m4sh index ce80241..9fe5873 100644 ---

No need to prepend $progname with './'.

2008-11-23 Thread Ralf Wildenhues
The new $ECHO allows for this simplification, pushed. Cheers, Ralf No need to prepend $progname with './'. * libltdl/config/general.m4sh (func_dirname_and_basename): $ECHO copes with leading hyphens now, so do not mangle $progname any more. diff --git

Replace uses of $SED $basename.

2008-11-23 Thread Ralf Wildenhues
Further simplification: no more $SED $basename outside of func_*basename. Pushed. Cheers, Ralf Replace uses of $SED $basename. * libltdl/config/ltmain.m4sh (func_mode_link): Replace instances of `$ECHO ... | $SED' with calls to func_basename. * libtoolize.m4sh

Avoid newlines in some AT_CHECK commands.

2008-11-23 Thread Ralf Wildenhues
It bothered me while testing these test groups that TESTSUITEFLAGS='-v -x' doesn't show the trace output for these commands. Fixed with this trivial patch by avoiding newlines inside, pushed. Cheers, Ralf Avoid newlines in some AT_CHECK commands. * tests/standalone.at (linking

Re: [PATCH 6/6] use print or printf or cat as $ECHO (really)

2008-11-23 Thread Ralf Wildenhues
* Eric Blake wrote on Sun, Nov 23, 2008 at 03:26:41PM CET: According to Ralf Wildenhues on 11/23/2008 1:10 AM: Are we certain enough no bash or zsh version has problems with a long format string? I'm not certain they are bug-free on all possible formats (for example, printf %10s\\n

No trailing period in Autotest test group names.

2008-11-23 Thread Ralf Wildenhues
Software Foundation, Inc. # Written by Alexandre Oliva Ralf Wildenhues, 2005 # # This file is part of GNU Libtool. @@ -23,7 +23,7 @@ -AT_SETUP([Link order test.]) +AT_SETUP([Link order test]) AT_KEYWORDS([libtool]) eval `$LIBTOOL --config | $EGREP '^(hardcode_direct

Re: testsuite.at for version 2.x Was: ... mingw-cross, check-local fail for DESTDIR tests

2008-11-23 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Wed, Nov 19, 2008 at 07:42:02AM CET: Test 29 static linking flags for programs skipped (static.at:177) - problem is with libtool --mode install since real executable is in .libs subdirectory. No idea how to fix. It is not --mode install problem. Still

use $EXEEXT consistently in new testsuite

2008-11-23 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Sun, Nov 23, 2008 at 10:41:46PM CET: To fix the loose end wrt. the exec checks, there was some exit status normalization needed here. I think this patch should be sufficient, once the $EXEEXT patch is in (comes next). Here it is. I went over tests

Relax link-order2 test for systems with partial wrong order.

2008-11-23 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Wed, Nov 19, 2008 at 07:42:02AM CET: * Roumen Petrov wrote on Tue, Nov 18, 2008 at 11:12:56PM CET: [SNIP] Test 25 Link order of deplibs skipped (link-order2.at:129) - in my todo for investigation. Still skipped. The executable exit code is 1 instead 2

Fix expout and experr line ending issues.

2008-11-23 Thread Ralf Wildenhues
* Roumen Petrov wrote on Tue, Nov 18, 2008 at 11:12:56PM CET: Test 48 enforced lib prefix FAILED (need_lib_prefix.at:184) - again --mode install problem (see test 29). It is not --mode install problem. It is related to end of line. Fixed like this. Cheers, Ralf Fix expout and

Re: Revenge of the $ECHO. Kill most uses of Xsed.

2008-11-24 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Sun, Nov 16, 2008 at 11:48:01PM CET: There is at least one more place with problematic usage of $ECHO, in func_infer_tag (several instances in two lines). Not yet sure how to fix that in a concise way. Like this. I also added some initial testsuite exposure

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static

2008-11-24 Thread Ralf Wildenhues
Hello Brian, * Brian Dessent wrote on Thu, Nov 13, 2008 at 11:16:24PM CET: Ralf Wildenhues wrote: I'm actually not sure whether _GLOBAL__F[ID]_.* can appear on w32. Do you know? They should happen with C++ code using constructors and destructors IIRC. Yes they do occur, although

Re: $ECHO change uncovered underquoting

2008-11-26 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Wed, Nov 26, 2008 at 08:54:29AM CET: 1) Add more escaping to the input lines. E.g., _LT_TAGVAR(archive_cmds, $1)='$CC -o $lib $libobjs $compiler_flags `$ECHO $deplibs | $SED '\''s/ -lc$//'\''` -link -dll~linknames=' would become

Re: use $EXEEXT consistently in new testsuite

2008-11-27 Thread Ralf Wildenhues
Hi Roumen, * Roumen Petrov wrote on Wed, Nov 26, 2008 at 12:46:00AM CET: I will check this failure: 28: Runpath in libtool library filesFAILED (runpath-in-lalib.at:59) Please post tests/testsuite.log, so we can see the verbose failure output. You can also run make

Re: [SCM] GNU Libtool branch, master, updated. v2.2.6-56-g9c9cde2

2008-11-28 Thread Ralf Wildenhues
[ moving from libtool-commit ] Hi Paolo, * Paolo Bonzini wrote on Fri, Nov 28, 2008 at 04:10:33PM CET: Do not use $ECHO within eval-ed `...`, as %s\\n becomes %s\n. * HACKING: Document func_echo_all. * libltdl/m4/libtool.m4: Use it within backticks that appear in

Re: Typo in the documentation?

2008-11-28 Thread Ralf Wildenhues
Hello Paolo, Akim, * Paolo Bonzini wrote on Fri, Nov 28, 2008 at 04:41:23PM CET: Akim Demaille wrote: Do you really mean --recheck? In that case there is no reason for config.status to recreate libtool, unless I missing something. Don't you mean ./config.status libtool? Seeing that

GCC_NO_EXECUTABLES and Libtool

2008-12-13 Thread Ralf Wildenhues
)]) | + ]) | + _LT_TAGVAR(archive_cmds_need_lc, $1)=$lt_cv_[]_LT_TAGVAR(archive_cmds_need_lc, $1) |;; | esac |fi Thanks, Ralf 2008-12-13 Ralf Wildenhues ralf.wildenh...@gmx.de Add cache variables to link tests. * libltdl/m4/libtool.m4 (_LT_SYS_DYNAMIC_LINKER

[patch #6691] FreeMiNT support to libtool 1.5.26 (tested)

2008-12-14 Thread Ralf Wildenhues
Follow-up Comment #1, patch #6691 (project libtool): Thanks for the patch. We'd much prefer it if you redid the patch against the current git tree (or 2.2.6 if you like), ran the testsuite (make -k check; see README for details and verbose output), and posted verbose output for all failed test

Re: GCC_NO_EXECUTABLES and Libtool

2008-12-18 Thread Ralf Wildenhues
Hello Paolo, Peter, * Peter O'Gorman wrote on Tue, Dec 16, 2008 at 07:15:06AM CET: On 13-Dec-08, at 7:45 AM, Ralf Wildenhues wrote: Add cache variables to link tests. * libltdl/m4/libtool.m4 (_LT_SYS_DYNAMIC_LINKER) (_LT_LINKER_SHLIBS): Add cache variables to tests

Re: Avoid accidental disastrous space cleanups

2008-12-19 Thread Ralf Wildenhues
Hello Eric, Akim, * Eric Blake wrote on Fri, Dec 19, 2008 at 02:26:57PM CET: According to Akim Demaille on 12/19/2008 5:08 AM: I have been bitten by this :( So has autoconf, which is why all m4sugar scripts currently start with the shorter: IFS= $as_nl Which makes me wonder -

Re: [PATCH] GNU/kOpenSolaris port

2008-12-29 Thread Ralf Wildenhues
Hello Robert, thank you for the patch and the testing. * Robert Millan wrote on Mon, Dec 22, 2008 at 03:40:34AM CET: I ported libtool to GNU/kOpenSolaris [1]. Because the checks are always the same for all Glibc-based systems, and having to wait for libtool to propagate to every package

Re: Fix distcc/ccache interferences with the test suite

2009-01-05 Thread Ralf Wildenhues
Hi Akim, * Akim Demaille wrote on Mon, Jan 05, 2009 at 03:22:24PM CET: Hi all, Are those the only distcc/ccache-induced failures? Thanks, Ralf From 02a3220b061f232d30baf1d1d3bc497d7e9417b8 Mon Sep 17 00:00:00 2001 From: Akim Demaille demai...@gostai.com Date: Mon, 5 Jan 2009 15:10:55 +0100

Re: Rebase of the pr-msvc-support branch?

2009-01-08 Thread Ralf Wildenhues
* Eric Blake wrote on Fri, Jan 09, 2009 at 03:58:36AM CET: According to Peter Rosin on 1/8/2009 12:43 PM: Should I kill the branch on savannah, rebase my local tree and finally push a brand new pr-msvc-support branch? Now that you've told us the branch will be rebased, it makes sense to

Re: Provide a means to activate dynamically the debug traces

2009-01-09 Thread Ralf Wildenhues
Hi Akim, * Akim Demaille wrote on Fri, Jan 09, 2009 at 04:37:32PM CET: when I dlopen a module.la which has a dependency.la library, I expected ltdl to automatically find dependency.la which is not installed. Yet it does not seem to use the module.la's deplibs to dlopen them, it delegates

Re: Rebase of the pr-msvc-support branch?

2009-01-09 Thread Ralf Wildenhues
* Bob Friesenhahn wrote on Fri, Jan 09, 2009 at 06:37:18PM CET: It will solve a lot of problems if autotools can be used to build real Windows programs. Yes, but we need to address the efficiency issue. For example, http://www.open-mpi.org/community/lists/devel/2008/11/4959.php dropped the

Re: Provide a means to activate dynamically the debug traces

2009-01-10 Thread Ralf Wildenhues
* Akim Demaille wrote on Fri, Jan 09, 2009 at 08:56:20PM CET: Le 9 janv. 09 à 19:40, Ralf Wildenhues a écrit : You can instead use libtool --mode=execute -dlopen module.la $program $args Are you saying that the behavior is expected? Why? Why not actually using the *.la in ltdl

Re: Rebase of the pr-msvc-support branch?

2009-01-11 Thread Ralf Wildenhues
Hello Markus, * Duft Markus wrote on Mon, Jan 12, 2009 at 08:29:48AM CET: Maybe on windows, we should recommend using interix? You can't be serious, on a GNU mailing list, suggesting that we recommend a proprietary system over a free one.

Re: Unify line endings in localization test

2009-01-19 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Sat, Jan 17, 2009 at 12:42:34AM CET: In the localization test, the output of the compiler is compared with the grepped output of the compiler when run through libtool. MSVC outputs its messages with \r\n, but the grep in the above strips that down to just \n

happy late new year

2009-01-19 Thread Ralf Wildenhues
Pushed to master, sorry for the long delay. The long line in ltmain.m4sh is actually necessary in order for libtool --version to work correctly. Will address in a followup patch. Cheers, Ralf Bump copyright years. * ChangeLog.2008: New, rotated from ... * ChangeLog: ...

[PATCH] func_version copes with multi-line copyright headers.

2009-01-19 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Mon, Jan 19, 2009 at 09:40:20PM CET: The long line in ltmain.m4sh is actually necessary in order for libtool --version to work correctly. Will address in a followup patch. OK to push? Thanks, Ralf func_version copes with multi-line copyright headers

Re: use $EXEEXT consistently in new testsuite

2009-01-19 Thread Ralf Wildenhues
Software Foundation, Inc. +# Copyright (C) 2005, 2007, 2008, 2009 Free Software Foundation, Inc. # Written by Ralf Wildenhues, 2005 # # This file is part of GNU Libtool. @@ -263,7 +263,7 @@ EOF # libgcj.spec or unable to find it. Skip this test for them. if test $i -eq 1

Another LT_AT_EXEC_CHECK fixup.

2009-01-19 Thread Ralf Wildenhues
Hello, I've had this really small patch to fix a couple of omissions. Seems obvious, pushed. Cheers, Ralf Another LT_AT_EXEC_CHECK fixup. * tests/shlibpath.at (shlibpath_overrides_runpath): Use LT_AT_EXEC_CHECK instead of AT_CHECK. diff --git a/tests/shlibpath.at

Re: set_program_name behavior

2009-01-19 Thread Ralf Wildenhues
Hello Bruno, * Bruno Haible wrote on Wed, Jan 14, 2009 at 10:51:46PM CET: The removal of */.libs/lt- prefixes is done so that make check produces reliable results, and because the precise location of the executable used under the hood by libtool is a detail that the user should not know

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 3

2009-01-19 Thread Ralf Wildenhues
. +# Copyright (C) 2008, 2009 Free Software Foundation, Inc. # Written by Ralf Wildenhues, 2008 # # This file is part of GNU Libtool. @@ -190,7 +190,7 @@ do if test -z $arg1; then arg1=$arg2; continue fi - AT_CHECK([$LIBTOOL --mode=execute ./foo abc $arg1 $arg2 xyz], [], [stdout

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 2

2009-01-19 Thread Ralf Wildenhues
Hello Charles, I haven't looked at your patches in detail yet, but a couple of things caught my eye: * Charles Wilson wrote on Sat, Jan 03, 2009 at 02:39:15AM CET: diff --git a/libltdl/config/general.m4sh b/libltdl/config/general.m4sh index 4bc304c..c4de91a 100644 ---

Re: Unify line endings in localization test

2009-01-19 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Mon, Jan 19, 2009 at 09:52:50PM CET: Den 2009-01-19 21:35 skrev Ralf Wildenhues: I think we shouldn't be constantly rebasing pr-msvc-support. I think instead when we can't decide soonish whether to merge it into master or to redo it (because it would need

Re: plugins on the command line are renamed

2009-01-19 Thread Ralf Wildenhues
Hello Paul, let's drop the libtool list. * Paul Biggar wrote on Tue, Jan 20, 2009 at 03:11:25AM CET: On Mon, Jan 19, 2009 at 10:15 PM, Ralf Wildenhues wrote: Please try the patch below. I had trouble applying this with git apply. Is it against git trunk? git master, yes. It was updated

Re: [PATCH] Minor cygwin cleanup

2009-01-20 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Tue, Jan 20, 2009 at 11:31:43PM CET: libltdl/config/ltmain.m4sh (func_generate_dlsyms): Correct case pattern for cygwin. --- Ok to push? Yes, thanks! Cheers, Ralf

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-21 Thread Ralf Wildenhues
* Charles Wilson wrote on Wed, Jan 21, 2009 at 08:47:42PM CET: Ralf Wildenhues wrote: I am very sorry that reviewing takes so long. Mostly this is due to time constraints on my side. On the plus side, your reviews are usually insightful, and lead to ideas for better code, like

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-21 Thread Ralf Wildenhues
* Charles Wilson wrote on Wed, Jan 21, 2009 at 10:10:08PM CET: Ralf Wildenhues wrote: Part (1) is easy to review: it is obvious that regressions are very unlikely to be system-dependent. One does get the impression that it might just be more efficient to let libtool save the cwrapper text

Re: Run tests with low max_cmd_len on MSYS/MSVC

2009-01-21 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Wed, Jan 21, 2009 at 02:26:36AM CET: This patch together with [1] and [2] will make Run tests with low max_cmd_len on MSYS/MSVC behave the same as the individual tests. The patch fixes a couple more of the /abs/path issues already fixed in [1] and [2].

Re: [PATCH] GNU/kOpenSolaris port

2009-01-21 Thread Ralf Wildenhues
* Robert Millan wrote on Tue, Jan 20, 2009 at 11:09:06AM CET: Btw, do you expect a new release soon? Hopefully in the not too distant future; we cannot promise any time frame, though. There are a few issues to address yet. Cheers, Ralf

Re: Unify line endings in localization test

2009-01-21 Thread Ralf Wildenhues
* Peter Rosin wrote on Tue, Jan 20, 2009 at 12:34:57AM CET: Den 2009-01-19 21:35 skrev Ralf Wildenhues: This looks a bit hackish. We already have a handful of places which we fixed up in order to avoid line ending issues. This one looks hackish enough to deserve being wrapped in a macro

Re: spaces

2009-01-21 Thread Ralf Wildenhues
* Charles Wilson wrote on Tue, Jan 20, 2009 at 07:29:52PM CET: Bob Friesenhahn wrote: For many years I have had my editor configured to always use spaces. This ensures WYSIWYG for everyone involved. Agree 100%. I try to manually match whatever sp/tab convention is in place -- using vi if

Re: Run tests with low max_cmd_len on MSYS/MSVC

2009-01-21 Thread Ralf Wildenhues
* Charles Wilson wrote on Wed, Jan 21, 2009 at 11:11:22PM CET: Ralf Wildenhues wrote: We may need to think about speeding up func_to_host_path, e.g., by not forking for arguments that don't need conversion, or by converting several paths with a constant amount of forks. But that can

testsuite performance (was: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.)

2009-01-22 Thread Ralf Wildenhues
* Charles Wilson wrote on Wed, Jan 21, 2009 at 08:47:42PM CET: [...] EVERY separate patchset requires an independent full testsuite run. Until recently, that was 5 hours of sitting in front of my computer waiting for popups, while that computer was completely useless for anything else (100%

Re: Unify line endings in localization test

2009-01-22 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Thu, Jan 22, 2009 at 10:57:20AM CET: Something like the attached? Yes, with nits below addressed. Ok, so push to master or pr-msvc-support? This change is ok for both. However, let's move away from manual addition of the same change to more than one public

Re: Run tests with low max_cmd_len on MSYS/MSVC

2009-01-22 Thread Ralf Wildenhues
* Bob Friesenhahn wrote on Thu, Jan 22, 2009 at 02:04:07AM CET: On Wed, 21 Jan 2009, Ralf Wildenhues wrote: We may need to think about speeding up func_to_host_path, e.g., by not forking for arguments that don't need conversion, or by converting several paths with a constant amount of forks

Re: Unify line endings in localization test

2009-01-22 Thread Ralf Wildenhues
* Peter Rosin wrote on Fri, Jan 23, 2009 at 12:01:00AM CET: Den 2009-01-22 21:54 skrev Ralf Wildenhues: 1) create, in your own repository, a new branch pr-tests-newline-fixes containing this one patch, then merge this patch into both pr-msvc-support and into master, then push the last two

Re: [PATCH] Add tests for cwrapper with -std=c89 and -std=c99

2009-01-22 Thread Ralf Wildenhues
* Charles Wilson wrote on Fri, Jan 23, 2009 at 12:36:57AM CET: * tests/cwrapper.at: New file. * Makefile.am: Add tests/cwrapper.at. --- Ok to push? Yes, with really minor nits: --- /dev/null +++ b/tests/cwrapper.at @@ -0,0 +1,81 @@ +AT_SETUP([wrapper for uninstalled dynamically linked

Re: LT_AT_NOINST_EXEC_CHECK expands badly

2009-01-24 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Sat, Jan 24, 2009 at 12:13:50AM CET: [ m4_ifval([$2], [test $lt_status != $2 ])]dnl I'm taking a wild guess here, but shouldn't that be $3 instead? Yes, it should. 2009-01-24 Peter Rosin p...@lysator.liu.se Expand exit status test in

Re: Unify line endings in localization test

2009-01-24 Thread Ralf Wildenhues
* Peter Rosin wrote on Fri, Jan 23, 2009 at 04:39:02PM CET: I'm preparing a merge with master now instead. Just got to run the testsuite on a couple of $hosts/compilers (sigh) before I push... One funny thing (funny strange, not haha) is that the ChangeLog entries from master appeared in

Re: [PATCH] [cygwin|mingw] cwrapper cleanups.

2009-01-24 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Wed, Jan 21, 2009 at 10:14:22PM CET: libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src) [file scope]: re-organized includes and portability macros. Avoid oldnames on MINGW32 and MSVC for setmode/stat/chmod/getcwd/putenv. Declare _putenv on MINGW32

Re: Small patch for the QNX platform

2009-01-24 Thread Ralf Wildenhues
Hello Mike, * Mike Gorchak wrote on Fri, Jan 23, 2009 at 12:37:34PM CET: This patch adds qnx as platform which supports library version information. RW As far as I can see, this patch changes the versioning scheme used on RW QNX. This means, that potentially all libraries created with

versioning test (was: Small patch for the QNX platform)

2009-01-24 Thread Ralf Wildenhues
Here is a testsuite addition to get some exposure to versioning. OK to push (and add Mike to THANKS)? It'd be good if somebody proof-read it so there are no silly typos or thinkos. Thanks, Ralf 2009-01-24 Ralf Wildenhues ralf.wildenh...@gmx.de Add versioning tests. * tests

Re: Unify line endings in localization test

2009-01-24 Thread Ralf Wildenhues
* Eric Blake wrote on Sat, Jan 24, 2009 at 02:00:15PM CET: According to Ralf Wildenhues on 1/24/2009 2:37 AM: One funny thing (funny strange, not haha) is that the ChangeLog entries from master appeared in reverse order in the pr-msvc-support ChangeLog after the merge, and I had to fix

Re: Preloading in ltdl doesn't heed libname_spec.

2009-01-24 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Sat, Jan 24, 2009 at 11:55:50AM CET: When you open libfoo.la, the preloader assumes that the preloaded library is named libfoo.$libext. I.e. it doesn't care about the libname_spec variable. This patch fixes that and makes lt_dladvise.at pass on MSYS/MSVC (and

git merging (was: [SCM] GNU Libtool branch, pr-msvc-support, updated.) v2.2.6-93-g7b44e17

2009-01-24 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Sat, Jan 24, 2009 at 10:39:35AM CET: * Peter Rosin wrote on Fri, Jan 23, 2009 at 02:18:30PM CET: The branch, pr-msvc-support has been updated Merge branch 'pr-changelog-libtool-ar' into pr-msvc-support Merge branch 'pr-changelog-embed-manifest-exeext

Re: plugins on the command line are renamed

2009-01-24 Thread Ralf Wildenhues
Hello Paul, * Paul Biggar wrote on Tue, Jan 20, 2009 at 09:06:17PM CET: On Tue, Jan 20, 2009 at 6:48 AM, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: ./bootstrap should suffice; please post its output if there are problems. The problem was at my end. I had a shell script called make

Re: libtool --mode=execute gdb

2009-01-24 Thread Ralf Wildenhues
* Bruno Haible wrote on Tue, Jan 20, 2009 at 11:36:18PM CET: Thanks for this practical shorthand re-introduction! Well, I was at least a bit hasty. the requirement for a mode seems to have been present for at least 10 years. I could use libtool gdb in version 1.5.x; only since version

Re: [PATCH] Fix typo in libtool install mode usage text

2009-01-26 Thread Ralf Wildenhues
): Likewise. Signed-off-by: Mike Frysinger vap...@gentoo.org Signed-off-by: Ralf Wildenhues ralf.wildenh...@gmx.de diff --git a/ChangeLog b/ChangeLog index 424d296..92fc4c5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2009-01-25 Mike Frysinger vap...@gentoo.org + + Fix

Re: [PATCH] Fix typo in libtool install mode usage text

2009-01-26 Thread Ralf Wildenhues
* Mike Frysinger wrote on Mon, Jan 26, 2009 at 09:23:42PM CET: On Monday 26 January 2009 14:27:43 Ralf Wildenhues wrote: I did consider renaming the option to match the documentation instead, and am not sure which was better; typically, the user never needs to use this option. Have you

Re: AWK is required by MS dumpbin symbol pipe.

2009-01-26 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Mon, Jan 26, 2009 at 02:16:52PM CET: This patch make sure AWK is set, even for minimal configure script that doesn't bring it in from elsewhere. OK for master. Thanks, Ralf 2009-01-26 Peter Rosin p...@lysator.liu.se AWK is required, make sure it

Re: Unify line endings in localization test

2009-01-26 Thread Ralf Wildenhues
* Peter Rosin wrote on Sat, Jan 24, 2009 at 08:47:03PM CET: Den 2009-01-24 14:03, skrev Ralf Wildenhues: * Eric Blake wrote on Sat, Jan 24, 2009 at 02:00:15PM CET: According to Ralf Wildenhues on 1/24/2009 2:37 AM: Ah yes, that sounds like it was the problem here. Surely that makes criss

Re: versioning test

2009-01-26 Thread Ralf Wildenhues
Hi Bob, * Bob Friesenhahn wrote on Sat, Jan 24, 2009 at 05:18:32PM CET: On Sat, 24 Jan 2009, Ralf Wildenhues wrote: Here is a testsuite addition to get some exposure to versioning. OK to push (and add Mike to THANKS)? It'd be good if somebody proof-read it so there are no silly typos

Re: versioning test

2009-01-26 Thread Ralf Wildenhues
Hello Mike, please keep the mailing list in Cc:, thanks. * Mike Gorchak wrote on Mon, Jan 26, 2009 at 11:11:30AM CET: RW Here is a testsuite addition to get some exposure to versioning. RW OK to push (and add Mike to THANKS)? It'd be good if somebody RW proof-read it so there are no silly

Re: Make modified libtool script executable in cwrapper.at test

2009-01-29 Thread Ralf Wildenhues
* Peter Rosin wrote on Thu, Jan 29, 2009 at 09:02:57AM CET: 2009-01-29 Peter Rosin p...@lysator.liu.se Make modified libtool script in cwrapper test executable * tests/cwrapper.at: Make modified libtool script executable. Report by Roumen Petrov. This is obvious, thanks.

Re: Fix distcc/ccache interferences with the test suite

2009-01-29 Thread Ralf Wildenhues
Hi Akim, * Akim Demaille wrote on Tue, Jan 06, 2009 at 09:24:32AM CET: Le 6 janv. 09 à 07:48, Ralf Wildenhues a écrit : Are those the only distcc/ccache-induced failures? Yes, I had no other failures. Thanks, and sorry for the delay. In the meantime, the localization code has seen some

Re: Pings

2009-01-29 Thread Ralf Wildenhues
Hi Akim, * Akim Demaille wrote on Wed, Jan 28, 2009 at 04:43:56PM CET: Some of my patches are waiting for approvals or comments. I do understand that it requires time to process them, I just want to make sure they aren't forgotten :) Thanks for the reminder. I think I had them all on my

Re: [PATCH] func_version copes with multi-line copyright headers.

2009-01-29 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Mon, Jan 19, 2009 at 09:47:54PM CET: The long line in ltmain.m4sh is actually necessary in order for libtool --version to work correctly. Will address in a followup patch. OK to push? I've pushed this now. Cheers, Ralf func_version copes with multi

test mode short-hands (was: libtool --mode=execute gdb)

2009-01-29 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Sat, Jan 24, 2009 at 03:52:49PM CET: Please note that there is an alternative short-hand, in that you can use (among others) the following equivalently: libtool --mode=execute PROG [ARGS]... libtoolexecute PROG [ARGS]... libtoolexe PROG

Re: Pings

2009-01-29 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Fri, Jan 30, 2009 at 05:34:08AM CET: See earlier reply in this thread for why we don't need to worry about any other magic MSVC macros. So, I think the only remaining cleanup-warnings patch for the cwrapper is this: diff --git

Re: plugins on the command line are renamed

2009-01-31 Thread Ralf Wildenhues
Hello Paul, * Paul Biggar wrote on Sat, Jan 24, 2009 at 03:48:54PM CET: On Sat, Jan 24, 2009 at 2:39 PM, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: What is the output of autoconf --version autom4te --version on this system? If you are using 2.59, can you try a newer one

Re: plugins on the command line are renamed

2009-01-31 Thread Ralf Wildenhues
* Paul Biggar wrote on Sat, Jan 31, 2009 at 01:02:15PM CET: On Sat, Jan 31, 2009 at 10:28 AM, Ralf Wildenhues wrote: Chucks. I can't reproduce this problem. Can you post the output of autom4te --verbose --language=m4sh -B libltdl/config libtoolize.m4sh \ libtoolize.in echo

<    7   8   9   10   11   12   13   14   15   16   >