Re: [PATCH] libtool: fix ABI detection for freebsd-amd64.

2016-11-02 Thread Tijl Coosemans 
On Wed, 2 Nov 2016 16:54:35 +0500 Mihail Konev  wrote:
> Fixes _LT_ENABLE_LOCK.
> Untested.
> 
> BugLink: https://github.com/libffi/libffi/pull/79
> ---
>  m4/libtool.m4 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/m4/libtool.m4 b/m4/libtool.m4
> index ee292aff5bca..d97f20f1ba0b 100644
> --- a/m4/libtool.m4
> +++ b/m4/libtool.m4
> @@ -1369,7 +1369,7 @@ mips64*-*linux*)
>rm -rf conftest*
>;;
>  
> -x86_64-*kfreebsd*-gnu|x86_64-*linux*|powerpc*-*linux*| \
> +amd64-*-freebsd*|x86_64-*kfreebsd*-gnu|x86_64-*linux*|powerpc*-*linux*| \
>  s390*-*linux*|s390*-*tpf*|sparc*-*linux*)
># Find out what ABI is being produced by ac_compile, and set linker
># options accordingly.  Note that the listed cases only cover the

The code under this case is a no-op for FreeBSD so this patch doesn't make
any sense.  I looked at the history of this patch and the original does
make sense (for libffi) but is no longer needed.  Instead of removing it it
was changed into the above by someone who obviously didn't know what they
were doing:
https://svnweb.freebsd.org/ports/head/lang/python26/files/patch-Modules-_ctypes-libffi-configure?r1=158131=221521=158131

So please just ignore this and feel free to close the libffi bug you
linked to above.

[PATCH] libtool: fix ABI detection for freebsd-amd64.

2016-11-02 Thread Mihail Konev 
Fixes _LT_ENABLE_LOCK.
Untested.

BugLink: https://github.com/libffi/libffi/pull/79
---
 m4/libtool.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index ee292aff5bca..d97f20f1ba0b 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -1369,7 +1369,7 @@ mips64*-*linux*)
   rm -rf conftest*
   ;;
 
-x86_64-*kfreebsd*-gnu|x86_64-*linux*|powerpc*-*linux*| \
+amd64-*-freebsd*|x86_64-*kfreebsd*-gnu|x86_64-*linux*|powerpc*-*linux*| \
 s390*-*linux*|s390*-*tpf*|sparc*-*linux*)
   # Find out what ABI is being produced by ac_compile, and set linker
   # options accordingly.  Note that the listed cases only cover the
-- 
2.9.2