Re: [PATCH] Add missing sysroot resolution
Hi Paolo At OE we needed such a feature for long time. I am working on deploying 2.4 these days. There might be more we need to get it going so far its looking good. Thanks -Khem On 10/9/10, Paolo Bonzini wrote: >> Paolo, I'm sorry if I made you though this patch was fixing my problem >> (in fact after a quick test, it does not). I just wanted to point it >> out, because Openembedded like buildroot, are projects which try to >> crosscompile source packages. I though it might be a good start to >> investigate the problem. > > It is anyway, and it's a real bug, so thanks for pointing me to it and > to Openembedded! > > Paolo > -- Sent from my mobile device -Khem
Re: [PATCH] Add missing sysroot resolution
> Paolo, I'm sorry if I made you though this patch was fixing my problem > (in fact after a quick test, it does not). I just wanted to point it > out, because Openembedded like buildroot, are projects which try to > crosscompile source packages. I though it might be a good start to > investigate the problem. It is anyway, and it's a real bug, so thanks for pointing me to it and to Openembedded! Paolo
Re: [PATCH] Add missing sysroot resolution
Le samedi 09 octobre 2010 à 10:55 +0200, Paolo Bonzini a écrit : > On 10/09/2010 10:51 AM, Ralf Wildenhues wrote: > > * Paolo Bonzini wrote on Sat, Oct 09, 2010 at 10:43:12AM CEST: > >> I'm applying this patch since it's pretty obvious. > > > > Thank you. > > > > Is this fixing (part) of the reported bug? > > Lionel pointed us to the patch, so I assumed it fixed all of it. I > still haven't built his stuff. It looks really interesting, as does > OpenEmbedded, and it's really cool that the sysroot feature is already > getting this much exposure. I was worried that it would remain confined > in the "unused feature" limbo and would bitrot. > > It's also nice because it shows that these people _are_ > autoreconfing/relibtoolizing as part of their build systems. It gives > me much more confidence on the backwards-compatibility of libtool 2.4! > > > Do you know how to expose it, so we can cover it in the testsuite? > > Not yet, I'll look into it next week. I need to build Lionel's recipe > and then distill a testcase. > > > For future sysroot patches, feel free to also (or first) commit them to > > the sysroot branch and merge them to master. > > Ok, I was undecided about the status of the sysroot branch. > Hi, Paolo, I'm sorry if I made you though this patch was fixing my problem (in fact after a quick test, it does not). I just wanted to point it out, because Openembedded like buildroot, are projects which try to crosscompile source packages. I though it might be a good start to investigate the problem. And yes, I personally prefer to autoreconf/libtoolize packages rather than patching a generated libtool script :) Regards, -- Lionel Landwerlin
Re: [PATCH] Add missing sysroot resolution
* Paolo Bonzini wrote on Sat, Oct 09, 2010 at 10:55:44AM CEST: > On 10/09/2010 10:51 AM, Ralf Wildenhues wrote: > >* Paolo Bonzini wrote on Sat, Oct 09, 2010 at 10:43:12AM CEST: > >>I'm applying this patch since it's pretty obvious. > >Is this fixing (part) of the reported bug? > > Lionel pointed us to the patch, so I assumed it fixed all of it. I > still haven't built his stuff. It looks really interesting, as does > OpenEmbedded, and it's really cool that the sysroot feature is > already getting this much exposure. I was worried that it would > remain confined in the "unused feature" limbo and would bitrot. > > It's also nice because it shows that these people _are_ > autoreconfing/relibtoolizing as part of their build systems. It > gives me much more confidence on the backwards-compatibility of > libtool 2.4! Indeed! Good you say this (all of the above), because I forgot to mention any of it. > >Do you know how to expose it, so we can cover it in the testsuite? > > Not yet, I'll look into it next week. I need to build Lionel's > recipe and then distill a testcase. Cool. Thanks. > >For future sysroot patches, feel free to also (or first) commit them to > >the sysroot branch and merge them to master. > > Ok, I was undecided about the status of the sysroot branch. Oh, I don't care much either way, but as long as we're still fixing things with, might as well document the fixes on the branch. For some kind of future code-archeology niceness or so. ;-) Cheers, Ralf
Re: [PATCH] Add missing sysroot resolution
On 10/09/2010 10:51 AM, Ralf Wildenhues wrote: * Paolo Bonzini wrote on Sat, Oct 09, 2010 at 10:43:12AM CEST: I'm applying this patch since it's pretty obvious. Thank you. Is this fixing (part) of the reported bug? Lionel pointed us to the patch, so I assumed it fixed all of it. I still haven't built his stuff. It looks really interesting, as does OpenEmbedded, and it's really cool that the sysroot feature is already getting this much exposure. I was worried that it would remain confined in the "unused feature" limbo and would bitrot. It's also nice because it shows that these people _are_ autoreconfing/relibtoolizing as part of their build systems. It gives me much more confidence on the backwards-compatibility of libtool 2.4! Do you know how to expose it, so we can cover it in the testsuite? Not yet, I'll look into it next week. I need to build Lionel's recipe and then distill a testcase. For future sysroot patches, feel free to also (or first) commit them to the sysroot branch and merge them to master. Ok, I was undecided about the status of the sysroot branch. Paolo
Re: [PATCH] Add missing sysroot resolution
Hi Paolo, * Paolo Bonzini wrote on Sat, Oct 09, 2010 at 10:43:12AM CEST: > I'm applying this patch since it's pretty obvious. Thank you. Is this fixing (part) of the reported bug? Do you know how to expose it, so we can cover it in the testsuite? For future sysroot patches, feel free to also (or first) commit them to the sysroot branch and merge them to master. Thanks, Ralf > * libltdl/config/ltmain.m4sh (func_mode_link): Resolve sysroot > when fetching the install directory of dependent libraries. > Reported by Lionel Landwerlin , > patch by Khem Raj . > * THANKS: Reorder entries, add Khem and Lionel.
[PATCH] Add missing sysroot resolution
I'm applying this patch since it's pretty obvious.
* libltdl/config/ltmain.m4sh (func_mode_link): Resolve sysroot
when fetching the install directory of dependent libraries.
Reported by Lionel Landwerlin ,
patch by Khem Raj .
* THANKS: Reorder entries, add Khem and Lionel.
Cc: Lionel Landwerlin
Cc: Khem Raj
---
THANKS |6 --
libltdl/config/ltmain.m4sh |3 ++-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/THANKS b/THANKS
index ff3ab7d..5aa0c3c 100644
--- a/THANKS
+++ b/THANKS
@@ -42,6 +42,7 @@
Christian Cornelssen cc...@cs.tu-berlin.de 2002-11-05
Jan Kratochvil project-libt...@jankratochvil.net 2003-01-28
Raja R. Harinath harin...@acm.org 2003-02-25
+ Paolo Bonzinibonz...@gnu.org
2003-03-01
Richard Nicholas Somer Dawe r...@phekda.freeserve.co.uk 2003-03-12
Peter O'Gorman pe...@pogma.com 2003-03-14
Ralph Schleicher r...@nunatak.allgaeu.org
2003-03-13
@@ -55,7 +56,6 @@
Benjamin Reedran...@befunk.com
2004-02-08
Ralf Wildenhues ralf.wildenh...@gmx.de2004-02-12
Nick Hudson sk...@netbsd.org 2004-03-29
- Paolo Bonzinibonz...@gnu.org
2003-03-01
Noah Jeffrey Misch n...@cs.caltech.edu 2004-07-05
Thorsten Glaser t...@66h.42h.de 2004-10-11
Peter Rosin p...@lysator.liu.se 2005-04-12
@@ -118,11 +118,13 @@
John Wolfe j...@sco.com
Josh Hursey jjhur...@open-mpi.org
Joseph Beckenbach IIIj...@best.com
- Lennart Poettering lenn...@poettering.net
Karl Berry k...@freefriends.org
Kenneth Albanowski kja...@kjahds.com
Kevin Ryde use...@zip.com.au
+ Khem Raj raj.k...@gmail.com
Kurt D. Zeilenga k...@openldap.org
+ Lennart Poettering lenn...@poettering.net
+ Lionel Landwerlin llandwer...@gmail.com
Maciej Helminiak di...@wp.pl
Maciej W. Rozyckima...@linux-mips.org
Mahesh Narayanamurthimahesh.m...@gmail.com
diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index 1078e75..af46cb8 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -8478,7 +8478,8 @@ EOF
*.la)
func_basename "$deplib"
name="$func_basename_result"
- eval libdir=`${SED} -n -e 's/^libdir=\(.*\)$/\1/p' $deplib`
+ func_resolve_sysroot "$deplib"
+ eval libdir=`${SED} -n -e 's/^libdir=\(.*\)$/\1/p'
$func_resolve_sysroot_result`
test -z "$libdir" && \
func_fatal_error "\`$deplib' is not a valid libtool archive"
func_append newdependency_libs " ${lt_sysroot:+=}$libdir/$name"
--
1.7.2.3
