approving w32 patches (was: [PATCH] Correct typo: $sharedlib_from_linklib_cmd missing '_cmd')

2010-09-11 Thread Ralf Wildenhues
Hello, * Peter O'Gorman wrote on Sat, Sep 11, 2010 at 07:37:41PM CEST: > On 09/11/2010 10:09 AM, Charles Wilson wrote: > >However...I don't have the authority to push *anything* without > >approval, so I *can't* simply say "pushed as obvious". > > It is ok for anyone with commit access to commit

Re: [PATCH] Correct typo: $sharedlib_from_linklib_cmd missing '_cmd'

2010-09-11 Thread Peter O'Gorman
On 09/11/2010 10:09 AM, Charles Wilson wrote: On 9/11/2010 2:47 AM, Peter Rosin wrote: Den 2010-09-11 07:02 skrev Charles Wilson: OK to push as obvious? To me, pushing as obvious is the same as pushing without asking (and when I do, I make damn sure I don't push anything bad). This makes me c

Re: [PATCH] Correct typo: $sharedlib_from_linklib_cmd missing '_cmd'

2010-09-11 Thread Charles Wilson
On 9/11/2010 4:16 AM, Ralf Wildenhues wrote: > OK to push. Pushed. -- Chuck

Re: [PATCH] Correct typo: $sharedlib_from_linklib_cmd missing '_cmd'

2010-09-11 Thread Charles Wilson
On 9/11/2010 2:47 AM, Peter Rosin wrote: > Den 2010-09-11 07:02 skrev Charles Wilson: >> OK to push as obvious? > > To me, pushing as obvious is the same as pushing without > asking (and when I do, I make damn sure I don't push anything > bad). This makes me curious, what does it mean to you? It

Re: [PATCH] Correct typo: $sharedlib_from_linklib_cmd missing '_cmd'

2010-09-11 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Sat, Sep 11, 2010 at 07:02:29AM CEST: > * libltdl/config/ltmain.m4sh (func_generate_dlsyms): Fix obvious > typo, $sharedlib_from_linklib_cmd missing '_cmd'. > --- > Typo in e83da49a1faf9df1c7e351df9e9b175388d76619: there is no variable > named 'sharedlib_from_

Re: [PATCH] Correct typo: $sharedlib_from_linklib_cmd missing '_cmd'

2010-09-10 Thread Peter Rosin
Den 2010-09-11 07:02 skrev Charles Wilson: > OK to push as obvious? To me, pushing as obvious is the same as pushing without asking (and when I do, I make damn sure I don't push anything bad). This makes me curious, what does it mean to you? Cheers, Peter

[PATCH] Correct typo: $sharedlib_from_linklib_cmd missing '_cmd'

2010-09-10 Thread Charles Wilson
* libltdl/config/ltmain.m4sh (func_generate_dlsyms): Fix obvious typo, $sharedlib_from_linklib_cmd missing '_cmd'. --- Typo in e83da49a1faf9df1c7e351df9e9b175388d76619: there is no variable named 'sharedlib_from_linklib' -- the variable should be 'sharedlib_from_linklib_cmd'. OK to push as obvious