Re: [PATCH] Ensure cwrapper compiles without warnings under -std=c99.

Gary V. Vaughan wrote: On 6 May 2008, at 22:47, Charles Wilson wrote: Unresolved: (1) whether func_emit_wrapper_part1 should even TAKE an argument (2) whether the cwrapper src, when printing a const char*, should use puts() in preference to printf(%s,...) Please go ahead and choose however

Re: [PATCH] Ensure cwrapper compiles without warnings under -std=c99.

Hi Chuck, On 6 May 2008, at 22:47, Charles Wilson wrote: Please refer to arguments in all caps: ARG (as is done elsewhere). See above (.libs). # func_emit_wrapper [ARG=no] Somewhat confusingly, we took our inspiration from the text rendering of a gnu info document, so the line above would

Re: [PATCH] Ensure cwrapper compiles without warnings under -std=c99.

Hi Chuck, On 6 May 2008, at 22:47, Charles Wilson wrote: Unresolved: (1) whether func_emit_wrapper_part1 should even TAKE an argument (2) whether the cwrapper src, when printing a const char*, should use puts() in preference to printf(%s,...) The quality of your patches has always been

[PATCH] Ensure cwrapper compiles without warnings under -std=c99.

2008-05-05 Charles Wilson ... Ensure cwrapper compiles without warnings under -std=c99. * libltdl/config/ltmain.m4sh (func_emit_wrapper_part1): new function. (func_emit_wrapper_part2): new function. (func_emit_wrapper): delegate to new functions.

Re: [PATCH] Ensure cwrapper compiles without warnings under -std=c99.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Charles Wilson on 5/5/2008 6:23 PM: | 2008-05-05 Charles Wilson ... | | Ensure cwrapper compiles without warnings under -std=c99. | Looks ok, except for these nits: | | -# func_emit_wrapper arg | +# func_emit_wrapper_part1 arg

Re: [PATCH] Ensure cwrapper compiles without warnings under -std=c99.

Hi Charles, In addition to Eric's review, here's some extremely picky nits: * Charles Wilson wrote on Tue, May 06, 2008 at 02:23:05AM CEST: 2008-05-05 Charles Wilson ... Ensure cwrapper compiles without warnings under -std=c99. * libltdl/config/ltmain.m4sh

Re: [PATCH] Ensure cwrapper compiles without warnings under -std=c99.

Eric Blake wrote: According to Charles Wilson on 5/5/2008 6:23 PM: | -# func_emit_wrapper arg | +# func_emit_wrapper_part1 arg Since you provide a default, I'd show that arg is optional, as in: # func_emit_wrapper_part1 [arg=no] Ack. Is func_emit_wrapper_part1_arg1 even used? Why not just

Re: [PATCH] Ensure cwrapper compiles without warnings under -std=c99.

Ralf Wildenhues wrote: In addition to Eric's review, here's some extremely picky nits: -# func_emit_wrapper arg +# func_emit_wrapper_part1 arg Isn't that .libs/_libs aka $objdir here? This is not new here, but further below. Capitalization, period at end of the sentence. #

[PATCH] Ensure cwrapper compiles without warnings under -std=c99.

2008-05-05 Charles Wilson ... Ensure cwrapper compiles without warnings under -std=c99. * libltdl/config/ltmain.m4sh (func_emit_wrapper_part1): new function. (func_emit_wrapper_part2): new function. (func_emit_wrapper): delegate to new functions.