Gary V. Vaughan gary at gnu.org writes:
Does this work with C and C++ compilers?
Yes.
I took that as a yes vote and pushed the patch. :)
Well, almost. The MALLOC macro already includes a cast, as part of allocating
an array of n elements of the type. And lt_dlhandle-deplibs is an
Hallo Ralf,
On 21 Apr 2008, at 01:23, Ralf Wildenhues wrote:
* Gary V. Vaughan wrote on Mon, Apr 21, 2008 at 02:39:37AM CEST:
* libltdl/lt__private.h (lt__handle, lt__advise): Typedefs
removed in favour of...
* libltdl/ltdl.h (lt_dlhandle),
libltdl/libltdl/lt_dlloader.h (lt_dladvise):
On Mon, 21 Apr 2008, Ralf Wildenhues wrote:
Does this work with C and C++ compilers? Does it change the ABI or API?
If yes, no, then I like it. Otherwise, as nice as it is, it would be a
bit inappropriate for a minor release number, no?
I use this approach in GraphicsMagick C code without
* libltdl/lt__private.h (lt__handle, lt__advise): Typedefs
removed in favour of...
* libltdl/ltdl.h (lt_dlhandle),
libltdl/libltdl/lt_dlloader.h (lt_dladvise): ...changing from
void* to forward declarations.
* libltdl/loaders/dlopen.c, libltdl/loaders/loadlibrary.c,
libltdl/lt_dlloader.c,
On Sun, 20 Apr 2008, Gary V. Vaughan wrote:
* libltdl/lt__private.h (lt__handle, lt__advise): Typedefs
removed in favour of...
* libltdl/ltdl.h (lt_dlhandle),
libltdl/libltdl/lt_dlloader.h (lt_dladvise): ...changing from
void* to forward declarations.
* libltdl/loaders/dlopen.c,
Howdy Bob!
On 20 Apr 2008, at 21:13, Bob Friesenhahn wrote:
On Sun, 20 Apr 2008, Gary V. Vaughan wrote:
* libltdl/lt__private.h (lt__handle, lt__advise): Typedefs
removed in favour of...
* libltdl/ltdl.h (lt_dlhandle),
libltdl/libltdl/lt_dlloader.h (lt_dladvise): ...changing from
void* to
On Sun, 20 Apr 2008, Gary V. Vaughan wrote:
I like this very much. Besides helping user code, it should diminish the
number of compiler warnings when compiling libltdl and may even avoid some
optimization-related bugs.
Is that a review with an implicit please apply? Or are you just
* Gary V. Vaughan wrote on Mon, Apr 21, 2008 at 02:39:37AM CEST:
* libltdl/lt__private.h (lt__handle, lt__advise): Typedefs
removed in favour of...
* libltdl/ltdl.h (lt_dlhandle),
libltdl/libltdl/lt_dlloader.h (lt_dladvise): ...changing from
void* to forward declarations.
*
