Re: [patch libgfortran] path to libquadmath

2011-01-09 Thread Ralf Wildenhues
* John David Anglin wrote on Fri, Dec 10, 2010 at 05:58:26PM CET:
 The attached change to ltmain.sh fixes the above problem on on 32-bit
 hppa*-*hpux*.  Tested on hppa2.0w-hp-hpux11.11 and hppa64-hp-hpux11.11.
 
 Would you please apply if ok to libtool, gcc and sourceware?

Sorry for the long delay.  I'm applying this to Libtool.
I don't have a good test case yet, unfortunately, but I do think that it
is the right change to make within the current set of semantics Libtool
provides.

We need some facilities in the Libtool testsuite to generate binary
incompatible libraries more or less portably.

As to GCC, that's for another mail ...

Cheers,
Ralf

 2010-12-10  John David Anglin  dave.ang...@nrc-cnrc.gc.ca
 
   * ltmain.sh (relink): Use absolute path when hardcoding with -L.
 

2011-01-09  John David Anglin  dave.ang...@nrc-cnrc.gc.ca  (tiny change)

Fix relink mode to use absolute path if hardcode_minus_L.
* libltdl/config/ltmain.m4sh (func_mode_link): Use absolute path
when hardcoding with -L.

diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index d9e1cd2..7baa6aa 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -6050,7 +6050,7 @@ func_mode_link ()
 test $hardcode_direct_absolute = no; then
add=$dir/$linklib
  elif test $hardcode_minus_L = yes; then
-   add_dir=-L$dir
+   add_dir=-L$absdir
# Try looking first in the location we're being installed to.
if test -n $inst_prefix_dir; then
  case $libdir in



Re: [patch libgfortran] path to libquadmath

2010-12-10 Thread John David Anglin
On Sun, 28 Nov 2010, Ralf Wildenhues wrote:

 * John David Anglin wrote on Sun, Nov 28, 2010 at 09:42:43PM CET:
  The current relative path to libquadmath can be incorrectly interpreted
  on systems that hard code library paths.  In particular, on 32-bit
  hppa*-*hpux*, the '..' part of the path is relative to the final executable.
  As a result, all libgfortran tests fail due to a dynamic loader error.
  
  The patch changes the path to an absolute path.
  
  Tested on hppa2.0w-hp-hpux11.11 and i686-apple-darwin9 with no observed
  regressions.
  
  OK for trunk?
 
 That doesn't seem to make sense to me.  The fix should be in ltmain.sh
 or in libtool.m4.  Please post the output of how libquadmath is linked
 on your system (the 'libtool --mode=link' command plus all of its
 output).

The attached change to ltmain.sh fixes the above problem on on 32-bit
hppa*-*hpux*.  Tested on hppa2.0w-hp-hpux11.11 and hppa64-hp-hpux11.11.

Would you please apply if ok to libtool, gcc and sourceware?

Thanks,
Dave
-- 
J. David Anglin  dave.ang...@nrc-cnrc.gc.ca
National Research Council of Canada  (613) 990-0752 (FAX: 952-6602)

2010-12-10  John David Anglin  dave.ang...@nrc-cnrc.gc.ca

* ltmain.sh (relink): Use absolute path when hardcoding with -L.

Index: ltmain.sh
===
--- ltmain.sh   (revision 167668)
+++ ltmain.sh   (working copy)
@@ -5928,7 +5928,7 @@
 test $hardcode_direct_absolute = no; then
add=$dir/$linklib
  elif test $hardcode_minus_L = yes; then
-   add_dir=-L$dir
+   add_dir=-L$absdir
# Try looking first in the location we're being installed to.
if test -n $inst_prefix_dir; then
  case $libdir in