Re: FYI: libtool-1.5.18 -- installed files owned by non-root user

2005-07-10 Thread Albert Chin 
On Fri, Jul 08, 2005 at 06:27:51PM +0100, Gary V. Vaughan wrote:
 Hallo Ralf,
 
 Sorry for the late review:
 
 On 8 Jul 2005, at 16:57, Ralf Wildenhues wrote:
 2005-07-08  Peter Breitenlohner  [EMAIL PROTECTED]
 
 * Makefile.am (install-data-local): Have root own of installed
 files (but do not fail, for user installs).
 
 Index: Makefile.am
 ===
 RCS file: /cvsroot/libtool/libtool/Makefile.am,v
 retrieving revision 1.153
 diff -u -r1.153 Makefile.am
 --- Makefile.am2 May 2005 09:20:24 -1.153
 +++ Makefile.am8 Jul 2005 15:54:01 -
 @@ -254,6 +254,8 @@
  done; \
  ( cd $(srcdir)/m4  $(AMTAR) chf - $$aclocalfiles; ) \
| ( umask 0  cd $(DESTDIR)$(aclocaldir)  $(AMTAR) xf -; )
 +chown -R root $(DESTDIR)$(ltdldatadir)  \
 +chgrp -R root $(DESTDIR)$(ltdldatadir) || :
 
 What about:
 
 -chown -R root $(DESTDIR)$(ltdldatadir) 2/dev/null
 -chgrp -R root $(DESTDIR)$(ltdldatadir) 2/dev/null

I like this too.

-- 
albert chin ([EMAIL PROTECTED])

FYI: libtool-1.5.18 -- installed files owned by non-root user

2005-07-08 Thread Ralf Wildenhues 
* Peter Breitenlohner wrote on Wed, Jul 06, 2005 at 09:34:24AM CEST:
 
 What about simply
   chown -R root $(DESTDIR)$(ltdldatadir)  \
   chgrp -R root $(DESTDIR)$(ltdldatadir) || :
 where failure of chown/chgrp is ignored? Who cares about some noise when
 `make install' is done by non-root or on non-posix systems, in particular
 when the cause of such noise can easily be deduced.

FYI: I have applied this to all three branches.

Thanks,
Ralf

HEAD/branch-2-0:

2005-07-08  Peter Breitenlohner  [EMAIL PROTECTED]

* Makefile.am (install-data-local): Have root own of installed
files (but do not fail, for user installs).

Index: Makefile.am
===
RCS file: /cvsroot/libtool/libtool/Makefile.am,v
retrieving revision 1.153
diff -u -r1.153 Makefile.am
--- Makefile.am 2 May 2005 09:20:24 -   1.153
+++ Makefile.am 8 Jul 2005 15:54:01 -
@@ -254,6 +254,8 @@
done; \
( cd $(srcdir)/m4  $(AMTAR) chf - $$aclocalfiles; ) \
  | ( umask 0  cd $(DESTDIR)$(aclocaldir)  $(AMTAR) xf -; )
+   chown -R root $(DESTDIR)$(ltdldatadir)  \
+   chgrp -R root $(DESTDIR)$(ltdldatadir) || :
 
 install-data-hook:
chmod +x $(DESTDIR)$(pkgdatadir)/config/config.guess




branch-1-5:

2005-07-08  Peter Breitenlohner  [EMAIL PROTECTED]

* libltdl/Makefile.am (local-install-files): Have root own of
installed files (but do not fail, for user installs).

Index: libltdl/Makefile.am
===
RCS file: /cvsroot/libtool/libtool/libltdl/Makefile.am,v
retrieving revision 1.42.2.6
diff -u -r1.42.2.6 Makefile.am
--- libltdl/Makefile.am 2 May 2005 12:52:07 -   1.42.2.6
+++ libltdl/Makefile.am 8 Jul 2005 15:53:30 -
@@ -47,3 +47,5 @@
$(mkinstalldirs) $(DESTDIR)$(ltdldatadir)
( cd $(srcdir)  $(AMTAR) chf - $(ltdldatafiles); ) \
  | ( umask 0  cd $(DESTDIR)$(ltdldatadir)  $(AMTAR) xf -; )
+   chown -R root $(DESTDIR)$(ltdldatadir)  \
+   chgrp -R root $(DESTDIR)$(ltdldatadir) || :

Re: FYI: libtool-1.5.18 -- installed files owned by non-root user

2005-07-08 Thread Gary V. Vaughan 

Hallo Ralf,

Sorry for the late review:

On 8 Jul 2005, at 16:57, Ralf Wildenhues wrote:

2005-07-08  Peter Breitenlohner  [EMAIL PROTECTED]

* Makefile.am (install-data-local): Have root own of installed
files (but do not fail, for user installs).

Index: Makefile.am
===
RCS file: /cvsroot/libtool/libtool/Makefile.am,v
retrieving revision 1.153
diff -u -r1.153 Makefile.am
--- Makefile.am2 May 2005 09:20:24 -1.153
+++ Makefile.am8 Jul 2005 15:54:01 -
@@ -254,6 +254,8 @@
 done; \
 ( cd $(srcdir)/m4  $(AMTAR) chf - $$aclocalfiles; ) \
   | ( umask 0  cd $(DESTDIR)$(aclocaldir)  $(AMTAR) xf -; )
+chown -R root $(DESTDIR)$(ltdldatadir)  \
+chgrp -R root $(DESTDIR)$(ltdldatadir) || :


What about:

-chown -R root $(DESTDIR)$(ltdldatadir) 2/dev/null
-chgrp -R root $(DESTDIR)$(ltdldatadir) 2/dev/null

Cheers,
Gary.
--  
Gary V. Vaughan  ())_.  gary@ 
{lilith.warpmail.net,gnu.org},[EMAIL PROTECTED]

Research Scientist   ( '/   http://www.tkd.kicks-ass.net
GNU Hacker   / )=   http://www.gnu.org/software/{libtool,m4}
Technical Author   `(_~)_   http://sources.redhat.com/autobook





PGP.sig
Description: This is a digitally signed message part