Re: Patch for bug#16452: opt_duplicate_compiler_generated_deps is harmful on Solaris

2014-01-17 Thread Richard PALO

Le 17/01/14 15:02, Rainer Orth a écrit :

As reported in

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16452

the default for opt_duplicate_compiler_generated_deps can cause
exception handling/unwinding failures on 64-bit Solaris 10+/x86 when the
underlying gcc bug

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59788

is fixed.  The libtool bug report already contains the fix for the
version of libtool bundled in the gcc repo.  I'd like to include the
patch from the gcc bug report in the upcoming next gcc release, 4.9.0.
gcc policy requires that such patches have to be accepted for upstream
libtool first, so here's the patch to git libtool:




It has been tested on i386-pc-solaris2.10 with gcc 4.8 without testsuite
regressions.

Rainer



This is quite interesting as it appears to explain some issues I've been 
encountering.. and will test to see how it works.


If I'm not mistaken, ltmain.sh and ltmain.in (formerly ltmain.m4sh) 
should be kept synchronised in the source tree...





Patch for bug#16452: opt_duplicate_compiler_generated_deps is harmful on Solaris

2014-01-17 Thread Rainer Orth
As reported in

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16452

the default for opt_duplicate_compiler_generated_deps can cause
exception handling/unwinding failures on 64-bit Solaris 10+/x86 when the
underlying gcc bug

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59788

is fixed.  The libtool bug report already contains the fix for the
version of libtool bundled in the gcc repo.  I'd like to include the
patch from the gcc bug report in the upcoming next gcc release, 4.9.0.
gcc policy requires that such patches have to be accepted for upstream
libtool first, so here's the patch to git libtool:

diff --git a/build-aux/ltmain.in b/build-aux/ltmain.in
index f452e54..85b4e0c 100644
--- a/build-aux/ltmain.in
+++ b/build-aux/ltmain.in
@@ -497,7 +497,7 @@ libtool_validate_options ()
 test : = "$debug_cmd" || func_append preserve_args " --debug"
 
 case $host in
-  *cygwin* | *mingw* | *pw32* | *cegcc*)
+  *cygwin* | *mingw* | *pw32* | *cegcc* | *solaris2* )
 # don't eliminate duplications in $postdeps and $predeps
 opt_duplicate_compiler_generated_deps=:
 ;;

It has been tested on i386-pc-solaris2.10 with gcc 4.8 without testsuite
regressions.

Rainer

-- 
-
Rainer Orth, Center for Biotechnology, Bielefeld University