-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Eric Blake on 10/11/2007 2:49 PM: >> Before the patch, m4_append and m4_append_uniq disagreed as to whether >> separator should be quoted. I went with the latter, apparently libtool >> wants the former. > > On further examination, I've decided the problem in libtool.m4: > > Furthermore, this line in libtool.m4 ONLY appears on libtool HEAD, which has > not been released yet, so I hope very few others are being bitten by this bug.
One more argument in favor of keeping the new m4sugar semantics and merely patching libtool to work around the older broken m4_append - prior to now, m4_append was undocumented (yet another case of libtool using undocumented autoconf internals, without any feedback to the autoconf lists on the desirability of documenting them). I'll work up a patch to document a series of m4sugar macros that seem useful and stable in their interface. > > +** The m4sugar macro m4_append has been fixed to properly quote its > + separator argument. Prior to this fix, m4_append_uniq would > + mistakenly duplicate entries if the separator was active. Obviously, I would also have to touch up this wording in NEWS, to make it clear that 2.62 is the first time m4_append is documented, and that the bug would only trip people up if they used the undocumented interface. And looking into this a bit more, it looks like ltsugar.m4 has some useful ideas for porting back into m4sugar, such as making m4_append_uniq take an additional two optional arguments (action-if-appended, action-if-already-present), or adding m4_unquote (strip one layer of quoting; different than the existing m4_noquote which expands all macros regardless of quoting). - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHDtlC84KuGfSFAYARAhkxAJ9ieLQOV/pz9/C+w9LCGE3zevHtOgCcDBDf n+Zo1Y0e+ss6/QziXTUzulM= =Azg2 -----END PGP SIGNATURE-----
