[PATCH] Use getopt.m4sh to generate libtoolize option parser.

2010-06-10 Thread Gary V. Vaughan
Okay to push? * libtoolize.m4sh: Replace hand written shell code with a call to M4SH_GETOPTS. Move some premature initialization from the preamble to the main part of the script. Exit with an error on spurious additional non-option arguments. (envopts): Integrate LIBTOOLIZE_OPTIONS pre-parsing

Re: [PATCH] Use getopt.m4sh to generate libtoolize option parser.

2010-06-10 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Thu, Jun 10, 2010 at 05:18:08PM CEST: Okay to push? Some of the $ECHO use ($ECHO $opt) now became plain echo, that might be a problem with backslashes or leading single hyphens. Otherwise, it looks to me like with --ltdl=foo --ltdl=bar the old version

Re: make dist failure

2010-06-10 Thread Ralf Wildenhues
* Peter Rosin wrote on Thu, Jun 10, 2010 at 12:10:34AM CEST: Den 2010-06-09 20:30 skrev Ralf Wildenhues: Sorry for not being clear. I really meant running this in the toplevel build directory: make install installcheck TESTSUITEFLAGS='-v -d -x 75' But since you could reproduce, that's

Re: Multiple test failures with --disable-shared

2010-06-10 Thread Peter O'Gorman
On 06/10/2010 03:07 PM, Peter O'Gorman wrote: On 06/10/2010 11:10 AM, Peter O'Gorman wrote: Hi, I got an off-list report from a user about test failures in 2.2.6b, that turned out to be either because he'd configured with --disable-shared or libtool had incorrectly guessed that his system did

Re: Multiple test failures with --disable-shared

2010-06-10 Thread Gary V. Vaughan
Hi Peter, On 11 Jun 2010, at 10:04, Peter O'Gorman wrote: This patch fixes the above problem with libtool dropping the c.lo object. Test passes with and without --disable-shared. Ok? * libltdl/config/ltmain.m4sh: When not building a shared library, use the non-pic objects to create a

Re: Multiple test failures with --disable-shared

2010-06-10 Thread Ralf Wildenhues
Hi Peter, * Peter O'Gorman wrote on Fri, Jun 11, 2010 at 05:04:55AM CEST: + Create reloadable object files with non-pic objects too. + * libltdl/config/ltmain.m4sh: When not building a shared + library, use the non-pic objects to create a reloadable + object, because pic

Re: Multiple test failures with --disable-shared

2010-06-10 Thread Peter O'Gorman
On 06/10/2010 11:05 PM, Ralf Wildenhues wrote: Hi Peter, * Peter O'Gorman wrote on Fri, Jun 11, 2010 at 05:04:55AM CEST: + Create reloadable object files with non-pic objects too. + * libltdl/config/ltmain.m4sh: When not building a shared + library, use the non-pic objects to

Re: [PATCH] Use getopt.m4sh to generate libtoolize option parser.

2010-06-10 Thread Gary V. Vaughan
Hallo Ralf, Thanks for the review. On 10 Jun 2010, at 23:54, Ralf Wildenhues wrote: * Gary V. Vaughan wrote on Thu, Jun 10, 2010 at 05:18:08PM CEST: Okay to push? Some of the $ECHO use ($ECHO $opt) now became plain echo, that might be a problem with backslashes or leading single hyphens.