Re: w32 pending?

2010-09-23 Thread Vincent Torri
Hey, Now that libtool is released, i reply the questions below This is the Warning: linker path does not have real file for library -lole32. problem, right? libole32.a and friends are all part of the Win32 API, and are installed by a proper mingw64 native non-multilib toolchain in

[PATCH v2 01/11] maint: rearrange Makefile.am in preparation for a follow-up patch.

2010-09-23 Thread Gary V. Vaughan
In case of doubt it might be easier to not try to change the actual dependency graph at all, but merely the rules, which should be enough to fix the problem you are targeting. Rather than try to build debians freebsd-buildutils on my mac, I decided to take the route of leaving the dependency

[PATCH v2 03/11] build: compare `revision' rather than `correctver' in Makefile.am.

2010-09-23 Thread Gary V. Vaughan
Split out of the original 3/4 patch. Not tested separately, but 3/4 passed make distcheck originally, and so does this series as a whole. Okay to push? * Makefile.am (rebuild): Set the shell variable `revision' rather than `correctver' for clarity of purpose. (bootstrap_edit,

[PATCH v2 04/11] build: avoid unnecessary directory changes in Makefile rules.

2010-09-23 Thread Gary V. Vaughan
The vast majority of this patch gets thrown away further in the series. It's only really here to show separately how each of the affected rules can be run perfectly well from the build tree... IIRC I only wrote them this way originally as a short hand for retyping all those long paths... but they

[PATCH v2 06/11] build: name temporary files in `Makefile.am' consistently.

2010-09-23 Thread Gary V. Vaughan
This is another silly patch that ends up being mostly edited away by the next couple of patches in the series... but I think it's useful to split it out so that you can see what I'm thinking at each stage. It was also a good exercise because after splitting, I realised that the original 3/4

[PATCH v2 11/11] maint: simplify and improve safety of bootstrap process.

2010-09-23 Thread Gary V. Vaughan
This is the original 4/4 patch, unchanged from last time. It still passes `make distcheck' from a clean checkout and build on my mac. Assuming strongly that this patch depends upon the semantics of 3/4 applied, I will review this patch after 3/4 is fixed I haven't actually tried it

[PATCH v2 05/11] build: factor Makefile.am `m4sh' invocations to LT_M4SH.

2010-09-23 Thread Gary V. Vaughan
Another patch factored from the original 3/4. This is the first readability improvement to the rules that got lengthier in the last patch... now that the groundwork is done. I did run a build and minimal testing (as I described earlier in this series) from a clean tree without problems at this

[PATCH v2 08/11] build: don't hardcode repeated long paths in Makefile rules.

2010-09-23 Thread Gary V. Vaughan
The few remaining cases where I would have liked to use $, instead of writing it out long-hand relative to the build tree more than once, I've stored it in a shell variable and referenced that. There are another couple of instances that don't show in this patch where there was only a single $

[PATCH v2 09/11] build: eliminate `ltmain.in' intermediate file.

2010-09-23 Thread Gary V. Vaughan
Factored out of the origin 3/4 patch. Okay to push? * Makefile.am (libltdl/config/ltmain.sh): Pipe the output of `$(LT_M4SH)' directly into `$(bootstrap_edit)' to avoid use of superfluous intermediate file. Signed-off-by: Gary V. Vaughan g...@gnu.org --- ChangeLog |5 + Makefile.am |

Re: [PATCH v2 02/11] maint: don't leak developer GREP, SED etc into distribution file.

2010-09-23 Thread Gary V. Vaughan
typu ahead... On 23 Sep 2010, at 22:21, Gary V. Vaughan wrote: I'm torn between running our own minimal substitution to fill the values in from libtool.m4, or having the make rule for libtool just edit them out. Thoughts? Of course, I mean the rule for ltmain.sh could edit them out as it

Re: [PATCH v2 02/11] maint: don't leak developer GREP, SED etc into distribution file.

2010-09-23 Thread Ralf Wildenhues
Hello Gary, * Gary V. Vaughan wrote on Thu, Sep 23, 2010 at 05:21:19PM CEST: I've pared this down to the absolute minimum necessary to fix the bug it is targetting. I did run this through `make distcheck' (and it passed), but most of the others following only got a cursory `git clean -x -d

Re: [PATCH v2 07/11] build: make better use of automatic variables in `Makefile.am'.

2010-09-23 Thread Ralf Wildenhues
Hi Gary, this isn't a review, I'm just adding a couple of hints that come to mind at first glance. * Gary V. Vaughan wrote on Thu, Sep 23, 2010 at 05:21:24PM CEST: Rules are getting shorter and more readable again now. I'm assuming there are no portability problems with $@ and $^ in regular

[PATCH] tests: import variables for MSVC.

2010-09-23 Thread Peter Rosin
Hi! This is a repost of an old patch. Ralf said a long time ago that I should drop the fixes for the old testsuite, but since I'm short of problems in the new testsuite and the old one isn't going away, I'm revisiting this. This was first posted here as part of a much bigger patch:

Re: [PATCH] tests: import variables for MSVC.

2010-09-23 Thread Vincent Torri
On Fri, 24 Sep 2010, Peter Rosin wrote: Hi! I don't know how to set up the defines so that EXTERN becomes 1. extern when you use a static library 2. extern when you build a static library 3. extern declspec(dllimport) when you use a shared library 4. extern declspec(dllexport) when you build

[PATCH] msvc: don't try to export import descriptors.

2010-09-23 Thread Peter Rosin
Hi! With the patch posted with subject: [PATCH] tests: import variables for MSVC. I found that libtool tries to put some bad symbols in the generated symbol lookup table leading to errors such as this: libtool: link: (cd .libs /home/peda/automake/lib/compile cl -MD -Zi -EHsc -c helldl.exeS.c)

Re: [PATCH] Skip need_lib_prefix.at on systems without lib prefix on libraries.

2010-09-23 Thread Ralf Wildenhues
Hello Peter, * Peter Rosin wrote on Fri, Sep 17, 2010 at 08:44:43AM CEST: need_lib_prefix.at currently fails with MSVC. I think the test is there to ensure that weird systems continue to work even if the testsuite is running on a normal system. weird in this case are systems with

Re: [PATCH] msvc: don't try to export import descriptors.

2010-09-23 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Fri, Sep 24, 2010 at 12:39:13AM CEST: With the patch posted with subject: [PATCH] tests: import variables for MSVC. I found that libtool tries to put some bad symbols in the generated symbol lookup table leading to errors such as this: Ok to push? Yes, with

Re: [PATCH] tests: import variables for MSVC.

2010-09-23 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Fri, Sep 24, 2010 at 12:25:14AM CEST: Subject: [PATCH] tests: import variables for MSVC. * tests/depdemo/sysdep.h (EXTERN): New define, saying how to declare variables that might need to be imported. * tests/depdemo/l1/l1.h, tests/depdemo/l2/l2.h,