Re: [PATCH] Further update/simplify OpenBSD support

2022-08-22 Thread Alex Ameen 
I wound up with a handful of regressions running on Darwin with BSD 
utils. I'm sending the diff here and attaching the full logs. The 
"expected failure" messages are something I'm investigating - I'm going 
to assume until I know for sure the "expected failure" vs "pass" is 
noteworthy.



3c3

< make[1]: Entering directory '/private/tmp/libtool-base'

---


make[1]: Entering directory '/private/tmp/libtool'


5c5

< make[2]: Entering directory '/private/tmp/libtool-base'

---


make[2]: Entering directory '/private/tmp/libtool'


7,10c7,10

< make[3]: Entering directory '/private/tmp/libtool-base'

< ## --- ##

< ## GNU Libtool 2.4.7.3-61320-dirty test suite. ##

< ## --- ##

---


make[3]: Entering directory '/private/tmp/libtool'



## -- ##



## GNU Libtool 2.4.7.4-b9a3-dirty test suite. ##



## -- ##


29,30c29,30

<  13: upgrading verbatim style aclocal.m4 ok

<  14: verbatim aclocal.m4 w/o AC_CONFIG_MACRO_DIRS    ok

---


  13: upgrading verbatim style aclocal.m4 expected failure 
(libtoolize.at:698)



  14: verbatim aclocal.m4 w/o AC_CONFIG_MACRO_DIRS    expected failure 
(libtoolize.at:789)


45c45

<  26: test LT_SUPPORTED_TAG interface ok

---


  26: test LT_SUPPORTED_TAG interface skipped (libtool.at:219)


49,61c49,61

<  27: link against a preloaded static library ok

<  28: build and dynamically load a module ok

<  29: preload static and dynamic module   ok

<  30: deplibs_check_method    ok

<  31: disable fast install    ok

<  32: force PIC objects   ok

<  33: force non-PIC objects   ok

<  34: hardcoding library path ok

<  35: binary relinking at install time    ok

<  36: uninstalled libraries have priority ok

<  37: linking with long file names    ok

<  38: override pic_flag at configure time ok

<  39: test --with-pic skipped (with-pic.at:40)

---


  27: link against a preloaded static library expected failure 
(demo.at:388)



  28: build and dynamically load a module expected failure 
(demo.at:405)



  29: preload static and dynamic module   expected failure 
(demo.at:422)



  30: deplibs_check_method    expected failure 
(demo.at:468)



  31: disable fast install    expected failure 
(demo.at:483)



  32: force PIC objects   expected failure 
(demo.at:501)



  33: force non-PIC objects   expected failure 
(demo.at:539)



  34: hardcoding library path expected failure 
(demo.at:612)



  35: binary relinking at install time    expected failure 
(demo.at:724)



  36: uninstalled libraries have priority expected failure 
(demo.at:795)



  37: linking with long file names    expected failure 
(demo.at:982)



  38: override pic_flag at configure time expected failure 
(pic_flag.at:52)



  39: test --with-pic expected failure 
(with-pic.at:31)


65,68c65,68

<  40: build and link against a static library ok

<  41: build and link against a dynamic library    ok

<  42: build both static and dynamic   ok

<  43: allow_undefined_flag    ok

---


  40: build and link against a static library expected failure 
(cdemo.at:140)



  41: build and link against a dynamic library    expected failure 
(cdemo.at:155)



  42: build both static and dynamic   expected failure 
(cdemo.at:170)



  43: allow_undefined_flag    expected failure 
(cdemo.at:185)


77,81c77,81

<  49: static library interdependencies    ok

<  50: shared library interdependencies    ok

<  51: shared and static interdependencies ok

<  52: disable fast install    ok

<  53: binary relinking at install time    ok

---


  49: static library interdependencies    expected failure 
(depdemo.at:290)



  50: shared library interdependencies    expected failure 
(depdemo.at:307)



  51: shared and static interdependencies expected failure 
(depdemo.at:324)



  52: disable fast install    expected failure 
(depdemo.at:341)



  53: binary relinking at install time    expected failure 
(depdemo.at:360)


136,137c136,137

<  99: AM_PROG_LIBTOOL ok

< 100: AC_WITH_LTDL    ok

---


  99: AM_PROG_LIBTOOL  

Re: [PATCH] Further update/simplify OpenBSD support

2022-08-21 Thread Alex Ameen 

Yeah I didn't get time to work on it until today.

I've applied the patch and ran the test suite through my usual VMs; I'm 
setting up a fresh VM now with OpenBSD's utilities for a "more useful" 
test run but everything looks good so far.


On 8/20/22 14:51, Brad Smith wrote:

On 8/15/2022 10:47 AM, Alex Ameen wrote:
Thanks for your submission. I'll run it through the test suite this 
week and keep you posted.


Any update on this?

Re: [PATCH] Further update/simplify OpenBSD support

2022-08-20 Thread Brad Smith 

On 8/15/2022 10:47 AM, Alex Ameen wrote:
Thanks for your submission. I'll run it through the test suite this 
week and keep you posted.


Any update on this?

Re: [PATCH] Further update/simplify OpenBSD support

2022-08-15 Thread Alex Ameen 
Thanks for your submission. I'll run it through the test suite this week
and keep you posted.

On Sat, Aug 13, 2022, 5:06 PM Brad Smith  wrote:

> Further update/simplify OpenBSD support
>
> * m4/libtool.m4: Remove long obsolete support for a.out and support
> for archs not supporting shared libaries
> ---
>  m4/libtool.m4 | 61 ---
>  1 file changed, 19 insertions(+), 42 deletions(-)
>
> diff --git a/m4/libtool.m4 b/m4/libtool.m4
> index 79a2451e..fa424ec6 100644
> --- a/m4/libtool.m4
> +++ b/m4/libtool.m4
> @@ -1557,7 +1557,7 @@ old_postuninstall_cmds=
>
>  if test -n "$RANLIB"; then
>case $host_os in
> -  bitrig* | openbsd*)
> +  bitrig*)
>  old_postinstall_cmds="$old_postinstall_cmds~\$RANLIB -t \$tool_oldlib"
>  ;;
>*)
> @@ -2948,11 +2948,7 @@ openbsd* | bitrig*)
>version_type=sunos
>sys_lib_dlsearch_path_spec=/usr/lib
>need_lib_prefix=no
> -  if test -z "`echo __ELF__ | $CC -E - | $GREP __ELF__`"; then
> -need_version=no
> -  else
> -need_version=yes
> -  fi
> +  need_version=no
>library_names_spec='$libname$release$shared_ext$versuffix
> $libname$shared_ext$versuffix'
>finish_cmds='PATH="\$PATH:/sbin" ldconfig -m $libdir'
>shlibpath_var=LD_LIBRARY_PATH
> @@ -3585,11 +3581,7 @@ newos6*)
>;;
>
>  openbsd* | bitrig*)
> -  if test -z "`echo __ELF__ | $CC -E - | $GREP __ELF__`"; then
> -lt_cv_deplibs_check_method='match_pattern
> /lib[[^/]]+(\.so\.[[0-9]]+\.[[0-9]]+|\.so|_pic\.a)$'
> -  else
> -lt_cv_deplibs_check_method='match_pattern
> /lib[[^/]]+(\.so\.[[0-9]]+\.[[0-9]]+|_pic\.a)$'
> -  fi
> +  lt_cv_deplibs_check_method='match_pattern
> /lib[[^/]]+(\.so\.[[0-9]]+\.[[0-9]]+|\.so|_pic\.a)$'
>;;
>
>  osf3* | osf4* | osf5*)
> @@ -5838,22 +5830,13 @@ _LT_EOF
>;;
>
>  openbsd* | bitrig*)
> -  if test -f /usr/libexec/ld.so; then
> -   _LT_TAGVAR(hardcode_direct, $1)=yes
> -   _LT_TAGVAR(hardcode_shlibpath_var, $1)=no
> -   _LT_TAGVAR(hardcode_direct_absolute, $1)=yes
> -   if test -z "`echo __ELF__ | $CC -E - | $GREP __ELF__`"; then
> - _LT_TAGVAR(archive_cmds, $1)='$CC -shared $pic_flag -o $lib
> $libobjs $deplibs $compiler_flags'
> - _LT_TAGVAR(archive_expsym_cmds, $1)='$CC -shared $pic_flag -o
> $lib $libobjs $deplibs $compiler_flags
> $wl-retain-symbols-file,$export_symbols'
> - _LT_TAGVAR(hardcode_libdir_flag_spec, $1)='$wl-rpath,$libdir'
> - _LT_TAGVAR(export_dynamic_flag_spec, $1)='$wl-E'
> -   else
> - _LT_TAGVAR(archive_cmds, $1)='$CC -shared $pic_flag -o $lib
> $libobjs $deplibs $compiler_flags'
> - _LT_TAGVAR(hardcode_libdir_flag_spec, $1)='$wl-rpath,$libdir'
> -   fi
> -  else
> -   _LT_TAGVAR(ld_shlibs, $1)=no
> -  fi
> +  _LT_TAGVAR(hardcode_direct, $1)=yes
> +  _LT_TAGVAR(hardcode_shlibpath_var, $1)=no
> +  _LT_TAGVAR(hardcode_direct_absolute, $1)=yes
> +  _LT_TAGVAR(archive_cmds, $1)='$CC -shared $pic_flag -o $lib
> $libobjs $deplibs $compiler_flags'
> +  _LT_TAGVAR(archive_expsym_cmds, $1)='$CC -shared $pic_flag -o $lib
> $libobjs $deplibs $compiler_flags $wl-retain-symbols-file,$export_symbols'
> +  _LT_TAGVAR(hardcode_libdir_flag_spec, $1)='$wl-rpath,$libdir'
> +  _LT_TAGVAR(export_dynamic_flag_spec, $1)='$wl--export-dynamic'
>;;
>
>  os2*)
> @@ -7132,21 +7115,15 @@ if test yes != "$_lt_caught_CXX_error"; then
> ;;
>
>openbsd* | bitrig*)
> -   if test -f /usr/libexec/ld.so; then
> - _LT_TAGVAR(hardcode_direct, $1)=yes
> - _LT_TAGVAR(hardcode_shlibpath_var, $1)=no
> - _LT_TAGVAR(hardcode_direct_absolute, $1)=yes
> - _LT_TAGVAR(archive_cmds, $1)='$CC -shared $pic_flag
> $predep_objects $libobjs $deplibs $postdep_objects $compiler_flags -o $lib'
> - _LT_TAGVAR(hardcode_libdir_flag_spec, $1)='$wl-rpath,$libdir'
> - if test -z "`echo __ELF__ | $CC -E - | grep __ELF__`"; then
> -   _LT_TAGVAR(archive_expsym_cmds, $1)='$CC -shared $pic_flag
> $predep_objects $libobjs $deplibs $postdep_objects $compiler_flags
> $wl-retain-symbols-file,$export_symbols -o $lib'
> -   _LT_TAGVAR(export_dynamic_flag_spec, $1)='$wl-E'
> -   _LT_TAGVAR(whole_archive_flag_spec,
> $1)=$wlarc'--whole-archive$convenience '$wlarc'--no-whole-archive'
> - fi
> - output_verbose_link_cmd=func_echo_all
> -   else
> - _LT_TAGVAR(ld_shlibs, $1)=no
> -   fi
> +   _LT_TAGVAR(hardcode_direct, $1)=yes
> +   _LT_TAGVAR(hardcode_shlibpath_var, $1)=no
> +   _LT_TAGVAR(hardcode_direct_absolute, $1)=yes
> +   _LT_TAGVAR(archive_cmds, $1)='$CC -shared $pic_flag
> $predep_objects $libobjs $deplibs $postdep_objects $compiler_flags -o $lib'
> +   _LT_TAGVAR(hardcode_libdir_flag_spec, $1)='$wl-rpath,$libdir'
> +   _LT_TAGVAR(archive_expsym_cmds, $1)='$CC -shared $pic_flag
> $predep_objects $libobjs $deplibs $postdep_objects $compiler_flags
>

[PATCH] Further update/simplify OpenBSD support

2022-08-13 Thread Brad Smith 
Further update/simplify OpenBSD support

* m4/libtool.m4: Remove long obsolete support for a.out and support
for archs not supporting shared libaries
---
 m4/libtool.m4 | 61 ---
 1 file changed, 19 insertions(+), 42 deletions(-)

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 79a2451e..fa424ec6 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -1557,7 +1557,7 @@ old_postuninstall_cmds=
 
 if test -n "$RANLIB"; then
   case $host_os in
-  bitrig* | openbsd*)
+  bitrig*)
 old_postinstall_cmds="$old_postinstall_cmds~\$RANLIB -t \$tool_oldlib"
 ;;
   *)
@@ -2948,11 +2948,7 @@ openbsd* | bitrig*)
   version_type=sunos
   sys_lib_dlsearch_path_spec=/usr/lib
   need_lib_prefix=no
-  if test -z "`echo __ELF__ | $CC -E - | $GREP __ELF__`"; then
-need_version=no
-  else
-need_version=yes
-  fi
+  need_version=no
   library_names_spec='$libname$release$shared_ext$versuffix 
$libname$shared_ext$versuffix'
   finish_cmds='PATH="\$PATH:/sbin" ldconfig -m $libdir'
   shlibpath_var=LD_LIBRARY_PATH
@@ -3585,11 +3581,7 @@ newos6*)
   ;;
 
 openbsd* | bitrig*)
-  if test -z "`echo __ELF__ | $CC -E - | $GREP __ELF__`"; then
-lt_cv_deplibs_check_method='match_pattern 
/lib[[^/]]+(\.so\.[[0-9]]+\.[[0-9]]+|\.so|_pic\.a)$'
-  else
-lt_cv_deplibs_check_method='match_pattern 
/lib[[^/]]+(\.so\.[[0-9]]+\.[[0-9]]+|_pic\.a)$'
-  fi
+  lt_cv_deplibs_check_method='match_pattern 
/lib[[^/]]+(\.so\.[[0-9]]+\.[[0-9]]+|\.so|_pic\.a)$'
   ;;
 
 osf3* | osf4* | osf5*)
@@ -5838,22 +5830,13 @@ _LT_EOF
   ;;
 
 openbsd* | bitrig*)
-  if test -f /usr/libexec/ld.so; then
-   _LT_TAGVAR(hardcode_direct, $1)=yes
-   _LT_TAGVAR(hardcode_shlibpath_var, $1)=no
-   _LT_TAGVAR(hardcode_direct_absolute, $1)=yes
-   if test -z "`echo __ELF__ | $CC -E - | $GREP __ELF__`"; then
- _LT_TAGVAR(archive_cmds, $1)='$CC -shared $pic_flag -o $lib $libobjs 
$deplibs $compiler_flags'
- _LT_TAGVAR(archive_expsym_cmds, $1)='$CC -shared $pic_flag -o $lib 
$libobjs $deplibs $compiler_flags $wl-retain-symbols-file,$export_symbols'
- _LT_TAGVAR(hardcode_libdir_flag_spec, $1)='$wl-rpath,$libdir'
- _LT_TAGVAR(export_dynamic_flag_spec, $1)='$wl-E'
-   else
- _LT_TAGVAR(archive_cmds, $1)='$CC -shared $pic_flag -o $lib $libobjs 
$deplibs $compiler_flags'
- _LT_TAGVAR(hardcode_libdir_flag_spec, $1)='$wl-rpath,$libdir'
-   fi
-  else
-   _LT_TAGVAR(ld_shlibs, $1)=no
-  fi
+  _LT_TAGVAR(hardcode_direct, $1)=yes
+  _LT_TAGVAR(hardcode_shlibpath_var, $1)=no
+  _LT_TAGVAR(hardcode_direct_absolute, $1)=yes
+  _LT_TAGVAR(archive_cmds, $1)='$CC -shared $pic_flag -o $lib $libobjs 
$deplibs $compiler_flags'
+  _LT_TAGVAR(archive_expsym_cmds, $1)='$CC -shared $pic_flag -o $lib 
$libobjs $deplibs $compiler_flags $wl-retain-symbols-file,$export_symbols'
+  _LT_TAGVAR(hardcode_libdir_flag_spec, $1)='$wl-rpath,$libdir'
+  _LT_TAGVAR(export_dynamic_flag_spec, $1)='$wl--export-dynamic'
   ;;
 
 os2*)
@@ -7132,21 +7115,15 @@ if test yes != "$_lt_caught_CXX_error"; then
;;
 
   openbsd* | bitrig*)
-   if test -f /usr/libexec/ld.so; then
- _LT_TAGVAR(hardcode_direct, $1)=yes
- _LT_TAGVAR(hardcode_shlibpath_var, $1)=no
- _LT_TAGVAR(hardcode_direct_absolute, $1)=yes
- _LT_TAGVAR(archive_cmds, $1)='$CC -shared $pic_flag $predep_objects 
$libobjs $deplibs $postdep_objects $compiler_flags -o $lib'
- _LT_TAGVAR(hardcode_libdir_flag_spec, $1)='$wl-rpath,$libdir'
- if test -z "`echo __ELF__ | $CC -E - | grep __ELF__`"; then
-   _LT_TAGVAR(archive_expsym_cmds, $1)='$CC -shared $pic_flag 
$predep_objects $libobjs $deplibs $postdep_objects $compiler_flags 
$wl-retain-symbols-file,$export_symbols -o $lib'
-   _LT_TAGVAR(export_dynamic_flag_spec, $1)='$wl-E'
-   _LT_TAGVAR(whole_archive_flag_spec, 
$1)=$wlarc'--whole-archive$convenience '$wlarc'--no-whole-archive'
- fi
- output_verbose_link_cmd=func_echo_all
-   else
- _LT_TAGVAR(ld_shlibs, $1)=no
-   fi
+   _LT_TAGVAR(hardcode_direct, $1)=yes
+   _LT_TAGVAR(hardcode_shlibpath_var, $1)=no
+   _LT_TAGVAR(hardcode_direct_absolute, $1)=yes
+   _LT_TAGVAR(archive_cmds, $1)='$CC -shared $pic_flag $predep_objects 
$libobjs $deplibs $postdep_objects $compiler_flags -o $lib'
+   _LT_TAGVAR(hardcode_libdir_flag_spec, $1)='$wl-rpath,$libdir'
+   _LT_TAGVAR(archive_expsym_cmds, $1)='$CC -shared $pic_flag 
$predep_objects $libobjs $deplibs $postdep_objects $compiler_flags 
$wl-retain-symbols-file,$export_symbols -o $lib'
+   _LT_TAGVAR(export_dynamic_flag_spec, $1)='$wl--export-dynamic'
+   _LT_TAGVAR(whole_archive_flag_spec, 
$1)=$wlarc'--whole-archive$convenience '$wlarc'--no-whole-archive'
+   output_verbose_link_cmd=func_echo_all
;;
 
   osf3* | osf4* | osf5*)
-- 
2.37.1