Re: [PATCH 06/12] libtool.m4: Handle "/" as a sysroot correctly
On Mon, 2024-01-15 at 17:00 -0500, Mike Frysinger wrote: > On 25 Oct 2021 15:33, Richard Purdie wrote: > > Update libtool.m4 to resolve a problem with lt_sysroot not being properly > > updated if the option '--with[-libtool]-sysroot' is not provided when > > running the 'configure' script for a package so that "/" as a sysroot > > is handled correctly by libtool. > > this is a long sentence, and there's no concrete examples, so i'm having a > bit of trouble extrapolating the bug. can you tweak this a bit to make it > more clear ? I've resent with part of that patch and a clearer explanation of what the issue is. I need to look into what the other bit of the patch is doing, it looks a bit like two different changes became intertwined. Cheers, Richard
Re: [PATCH 06/12] libtool.m4: Handle "/" as a sysroot correctly
On 25 Oct 2021 15:33, Richard Purdie wrote: > Update libtool.m4 to resolve a problem with lt_sysroot not being properly > updated if the option '--with[-libtool]-sysroot' is not provided when > running the 'configure' script for a package so that "/" as a sysroot > is handled correctly by libtool. this is a long sentence, and there's no concrete examples, so i'm having a bit of trouble extrapolating the bug. can you tweak this a bit to make it more clear ? -mike signature.asc Description: PGP signature
[PATCH 06/12] libtool.m4: Handle "/" as a sysroot correctly
Update libtool.m4 to resolve a problem with lt_sysroot not being properly updated if the option '--with[-libtool]-sysroot' is not provided when running the 'configure' script for a package so that "/" as a sysroot is handled correctly by libtool. Signed-off-by: Richard Purdie --- m4/libtool.m4 | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/m4/libtool.m4 b/m4/libtool.m4 index de2f1ebf..180dd9d1 100644 --- a/m4/libtool.m4 +++ b/m4/libtool.m4 @@ -1256,16 +1256,20 @@ dnl lt_sysroot will always be passed unquoted. We quote it here dnl in case the user passed a directory name. lt_sysroot= case $with_libtool_sysroot in #( - yes) + no) if test yes = "$GCC"; then lt_sysroot=`$CC --print-sysroot 2>/dev/null` + # Treat "/" the same a an unset sysroot. + if test "$lt_sysroot" = /; then + lt_sysroot= + fi fi ;; #( + yes|''|/) + ;; #( /*) lt_sysroot=`echo "$with_libtool_sysroot" | sed -e "$sed_quote_subst"` ;; #( - no|'') - ;; #( *) AC_MSG_RESULT([$with_libtool_sysroot]) AC_MSG_ERROR([The sysroot must be an absolute path.]) -- 2.25.1
