Re: [PATCH 1/4] Fix func_echo_all inside configure.

2016-03-11 Thread Michael Haubenwallner 

On 03/10/2016 05:44 PM, Eric Blake wrote:
> On 03/10/2016 02:01 AM, Michael Haubenwallner wrote:
>> * m4/libtool.m4 (func_echo_all): Properly get $* through m4.
>> ---
>>  m4/libtool.m4 | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>  func_echo_all ()
>>  {
>> -$ECHO "$*"
>> +$ECHO "@S|@*"
> 
> That works.  You might also want to try $[]*, for less typing, and
> comparable to what we have a few lines earlier:

While I don't really care, and failed to identify the preferred syntax
across libtool.m4 - wouldn't [$]* be even more obvious to read, as in
"quote the dollar-sign"?

/haubi/
>From 3099497610ea29f67dacf33ec0d11e3a1a87602e Mon Sep 17 00:00:00 2001
From: Michael Haubenwallner 
Date: Thu, 21 May 2015 18:59:42 +0200
Subject: [PATCH 1/4] Fix func_echo_all inside configure.

* m4/libtool.m4 (func_echo_all): Properly get $* through m4.
---
 m4/libtool.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index ee292af..7c7c82e 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -1218,7 +1218,7 @@ fi
 # Invoke $ECHO with all args, space-separated.
 func_echo_all ()
 {
-$ECHO "$*"
+$ECHO "[$]*"
 }
 
 case $ECHO in
-- 
2.4.6

Re: [PATCH 1/4] Fix func_echo_all inside configure.

2016-03-10 Thread Eric Blake 
On 03/10/2016 02:01 AM, Michael Haubenwallner wrote:
> * m4/libtool.m4 (func_echo_all): Properly get $* through m4.
> ---
>  m4/libtool.m4 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/m4/libtool.m4 b/m4/libtool.m4
> index ee292af..7b8b591 100644
> --- a/m4/libtool.m4
> +++ b/m4/libtool.m4
> @@ -1218,7 +1218,7 @@ fi
>  # Invoke $ECHO with all args, space-separated.
>  func_echo_all ()
>  {
> -$ECHO "$*"
> +$ECHO "@S|@*"

That works.  You might also want to try $[]*, for less typing, and
comparable to what we have a few lines earlier:

eval 'cat <<_LTECHO_EOF
$[]1
_LTECHO_EOF'
  }
  ECHO='func_fallback_echo'
fi

# func_echo_all arg...
# Invoke $ECHO with all args, space-separated.
func_echo_all ()
{
$ECHO "$*"


-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature

[PATCH 1/4] Fix func_echo_all inside configure.

2016-03-10 Thread Michael Haubenwallner 
* m4/libtool.m4 (func_echo_all): Properly get $* through m4.
---
 m4/libtool.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index ee292af..7b8b591 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -1218,7 +1218,7 @@ fi
 # Invoke $ECHO with all args, space-separated.
 func_echo_all ()
 {
-$ECHO "$*"
+$ECHO "@S|@*"
 }
 
 case $ECHO in
-- 
2.4.6