Re: [PATCH, take 4][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-20 Thread Roumen Petrov
Hi Charles, Charles Wilson wrote: Roumen Petrov wrote: [SNIP] If you can come up with a mechanism to use absolute paths in dlname, which does not break any of the known installation modes, works whether the installation tree(s) are pre-created or NOT, and whether the final installation tree

Re: [PATCH, take 4][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-18 Thread Roumen Petrov
Dave Korn wrote: Roumen Petrov wrote: The calculation or relative path to dll is based on function XXX_abspath that may produce wrong results. No it doesn't. Like any function, it produces the correct results when given valid inputs, but if you give it bad input, you get GIGO. :) :)

Re: [PATCH, take 4][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-18 Thread Dave Korn
Roumen Petrov wrote: Dave Korn wrote: *Your suggestion to use realpath instead of abspath requires magic or time-travel before it is even possible, which is why I will waste no time on it.* Reading all above seems to my you mix mail threads and/or lists. Nonsense, I'm not engaged in

Re: [PATCH, take 4][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-18 Thread Charles Wilson
Roumen Petrov wrote: I'm concerned that we can't implement a working portable(cross-platform) relative path calculation. In the general case, Roumen, you are correct: there IS no portable mechanism to compute relative paths when non-portable constructs such as symbolic links are/may-be

Re: [PATCH, take 4][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-17 Thread Roumen Petrov
Charles Wilson wrote: Roumen Petrov wrote: Dave Korn wrote: Roumen Petrov wrote: [SNIP] Why? abspath != realpath. That's the point. If you're arguing that all GNU installation tools should use realpath to canonicalize all paths before use, well...maybe that discussion should be held, in

Re: [PATCH, take 4][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-17 Thread Dave Korn
Roumen Petrov wrote: The calculation or relative path to dll is based on function XXX_abspath that may produce wrong results. No it doesn't. Like any function, it produces the correct results when given valid inputs, but if you give it bad input, you get GIGO. I suggest you go read the

Re: [PATCH, take 4][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-16 Thread Ralf Wildenhues
Hi Dave, sorry for making you go through another round. Except for the sed issues the following nits are all mechanical, and it would suffice if you re-checked only your new tests and only on one of the affected systems. I consider the patch ready after this round, but I will probably leave a

Re: [PATCH, take 4][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-16 Thread Dave Korn
Ralf Wildenhues wrote: Hi Dave, sorry for making you go through another round. :-/ That'll teach me to say unless there's anything else? +pathcar=s,^/\([^/]*\).*$,\1, +pathcdr=s,^/[^/]*,, +removedotparts=s,/\(\.\(/\|$\)\)\+,/,g +collapseslashes=s,/\+,/,g \+ is a GNU sed

Re: [PATCH, take 4][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-16 Thread Ralf Wildenhues
* Dave Korn wrote on Sun, Aug 16, 2009 at 06:26:11PM CEST: Ralf Wildenhues wrote: sorry for making you go through another round. :-/ That'll teach me to say unless there's anything else? Hehe. \+ is a GNU sed extension, \{1,\} is Posix (two instances). Nested \( \) are not

Re: [PATCH, take 4][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-16 Thread Roumen Petrov
Dave Korn wrote: So, here I hope is the final respin. Built and tested on i686-pc-cygwin and i686-pc-linux-gnu with no regressions and all new tests passing (see below sig separator for details). libtool/ChangeLog: * Makefile.am (TESTSUITE_AT): Add bindir.at. *

Re: [PATCH, take 4][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-16 Thread Dave Korn
Roumen Petrov wrote: I think that processing of '..' in a path is too naive. It will fail to produce correct results on filesystems with links. As I explained to Eric, this function implements 'abspath', not 'realpath', and given that we can't assume any of the directories even exist when

Re: [PATCH, take 4][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-16 Thread Dave Korn
Ralf Wildenhues wrote: * Dave Korn wrote on Sun, Aug 16, 2009 at 06:26:11PM CEST: +AT_CHECK([$LIBTOOL --mode=install $lt_INSTALL main$EXEEXT $curdir/bin/main$EXEEXT], [], [ignore], [ignore]) +AT_CHECK([$LIBTOOL --mode=execute $curdir/bin/main$EXEEXT], [], [stdout]) This one should work

Re: [PATCH, take 4][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-16 Thread Dave Korn
Dave Korn wrote: Guess I'll have to `ls *foo*0*` them and test -z the output, that should work. Nope, may have whitespace. Is checking the return status of ls portable? cheers, DaveK

Re: [PATCH, take 4][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-16 Thread Roumen Petrov
Dave Korn wrote: Roumen Petrov wrote: I think that processing of '..' in a path is too naive. It will fail to produce correct results on filesystems with links. As I explained to Eric, this function implements 'abspath', not 'realpath', and given that we can't assume any of the directories

Re: [PATCH, take 4][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-16 Thread Charles Wilson
Roumen Petrov wrote: Dave Korn wrote: Roumen Petrov wrote: I think that processing of '..' in a path is too naive. It will fail to produce correct results on filesystems with links. As I explained to Eric, this function implements 'abspath', not 'realpath', and given that we can't assume

Re: [PATCH, take 4][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-16 Thread Dave Korn
Roumen Petrov wrote: Dave Korn wrote: Roumen Petrov wrote: I think that processing of '..' in a path is too naive. It will fail to produce correct results on filesystems with links. this function implements 'abspath', not 'realpath', ^^^