Re: [SCM] GNU Libtool branch, master, updated. v2.4.5-5-gc60e054

2015-01-20 Thread Peter Rosin 
On 2015-01-20 18:24, Gary V. Vaughan wrote:
 -# Copyright (C) 2010-2015 Free Software Foundation, Inc.
 +# Copyright (C) 2010-2014 Free Software Foundation, Inc.

That's why I felt so young today!

Cheers,
Peter

___
https://lists.gnu.org/mailman/listinfo/libtool

Re: [SCM] GNU Libtool branch, master, updated. v2.4.5-5-gc60e054

2015-01-20 Thread Eric Blake 
On 01/20/2015 10:24 AM, Gary V. Vaughan wrote:

 * gl/build-aux/bootstrap.in, gl/build-aux/extract-trace,
 gl/build-aux/funclib.sh, gl/build-aux/options-parser: Sync with
 upstream.

 @@ -2267,11 +2267,12 @@ func_tool_version_number ()
  {
  $debug_cmd
  
 -_G_verout=`func_tool_version_output $@ |sed 1q`
 +_G_verout=`func_tool_version_output $@`
  _G_status=$?
  
  # A version number starts with a digit following a space on the first
  # line of output from `--version`.
 +_G_verout=`echo $_G_verout |sed 1q`

How probable is it that $_G_verout will ever be output captured from
some tool that includes \ in its output?  If so, you'd want to use
printf to make sure you don't run foul of a shell where \ is
interpolated by echo.

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
___
https://lists.gnu.org/mailman/listinfo/libtool

Re: [SCM] GNU Libtool branch, master, updated. v2.4.5-5-gc60e054

2015-01-20 Thread Gary V. Vaughan 
Hi Eric,

 On Jan 20, 2015, at 5:34 PM, Eric Blake ebl...@redhat.com wrote:
 
 On 01/20/2015 10:24 AM, Gary V. Vaughan wrote:
 
* gl/build-aux/bootstrap.in, gl/build-aux/extract-trace,
gl/build-aux/funclib.sh, gl/build-aux/options-parser: Sync with
upstream.
 
 @@ -2267,11 +2267,12 @@ func_tool_version_number ()
 {
 $debug_cmd
 
 -_G_verout=`func_tool_version_output $@ |sed 1q`
 +_G_verout=`func_tool_version_output $@`
 _G_status=$?
 
 # A version number starts with a digit following a space on the first
 # line of output from `--version`.
 +_G_verout=`echo $_G_verout |sed 1q`
 
 How probable is it that $_G_verout will ever be output captured from
 some tool that includes \ in its output?  If so, you'd want to use
 printf to make sure you don't run foul of a shell where \ is
 interpolated by echo.

Excepting deliberately malicious output, I would say the chances are
vanishingly small... but your suggestion is a good one all the same :-)

Applied upstream, and coming to a Libtool near you soon!

Cheers,
-- 
Gary V. Vaughan (gary AT gnu DOT org)

___
https://lists.gnu.org/mailman/listinfo/libtool

Re: [SCM] GNU Libtool branch, master, updated. v2.4.5-5-gc60e054

2015-01-20 Thread Gary V. Vaughan 
On Jan 20, 2015, at 6:34 PM, Peter Rosin p...@lysator.liu.se wrote:
 
 On 2015-01-20 18:24, Gary V. Vaughan wrote:
 -# Copyright (C) 2010-2015 Free Software Foundation, Inc.
 +# Copyright (C) 2010-2014 Free Software Foundation, Inc.
 
 That's why I felt so young today!

Seems libtool took another year of my life... ;-)

___
https://lists.gnu.org/mailman/listinfo/libtool