Re: [Libusbx-devel] [libusbx] Fix super-speed isoc packet size (#163)

2013-12-12 Thread Alan Stern
On Thu, 12 Dec 2013, Tim Roberts wrote: > Hans de Goede wrote: > > > > "the isoc endpoint is only created when changing to alt setting 1" > > > > Ah, that is what saves your bacon then, most devices have the isoc eps > > in altsetting 0 too, with a maxpacketsize of 0. > > > > No, they don't. Or

Re: [Libusbx-devel] [libusbx] Fix super-speed isoc packet size (#163)

2013-12-12 Thread Tim Roberts
Hans de Goede wrote: > > "the isoc endpoint is only created when changing to alt setting 1" > > Ah, that is what saves your bacon then, most devices have the isoc eps > in altsetting 0 too, with a maxpacketsize of 0. > No, they don't. Or at least they aren't supposed to. Alt setting 0 should not

Re: [Libusbx-devel] [libusbx] Fix super-speed isoc packet size (#163)

2013-12-12 Thread Hans de Goede
"the isoc endpoint is only created when changing to alt setting 1" Ah, that is what saves your bacon then, most devices have the isoc eps in altsetting 0 too, with a maxpacketsize of 0. Besides me no one else seems to be complaining, I guess most people don't use isoc with libusb. Anyways as s

Re: [Libusbx-devel] [libusbx] Fix super-speed isoc packet size (#163)

2013-12-12 Thread Joshua Blake
@jwrdegoede Yes, my device has two alt settings for the interface and the isoc endpoint is only created when changing to alt setting 1. The API design issue makes sense now, thanks for explaining further. On the other hand, that issue is not affecting me personally, and I do not have any other

Re: [Libusbx-devel] [libusbx] Fix super-speed isoc packet size (#163)

2013-12-10 Thread Hans de Goede
Josh, you're correct in that this is a long standing issue. Although I would not call it architectural, it is simply an API issue (the user should be able to specify the altsetting he wants the max-packet-size for). As for this blocking this patch, no the patch can go in as is, but I was hoping

Re: [Libusbx-devel] [libusbx] Fix super-speed isoc packet size (#163)

2013-12-10 Thread Joshua Blake
@jwrdegoede I looked at the reference issue and discussion. It seems like that is a long-standing architectural discussion that would have a much larger impact than just fixing the item that this pull request addresses. I'm not clear on whether you're saying this pull request is incorrect or sho

Re: [Libusbx-devel] [libusbx] Fix super-speed isoc packet size (#163)

2013-12-10 Thread mcuee
Ref: https://github.com/libusbx/libusbx/issues/4 --- Reply to this email directly or view it on GitHub: https://github.com/libusbx/libusbx/pull/163#issuecomment-30213816-- Sponsored by Intel(R) XDK Develop, test and displ

Re: [Libusbx-devel] [libusbx] Fix super-speed isoc packet size (#163)

2013-12-10 Thread Hans de Goede
Thanks for working on this. However in my experience the whole libusb_get_max_iso_packet_size API is rather useless as it takes the endpoint descriptor from the first altsetting of an interface rather then the current alt setting. We could fix things to make it use the current altsetting, but w

Re: [Libusbx-devel] [libusbx] Fix super-speed isoc packet size (#163)

2013-12-09 Thread Pete Batard
I think that makes sense. Unless there are any objections, I'll try to integrate this when I get a chance (can't let all of your efforts seem to go wasted after all ;)) /Pete --- Reply to this email directly or view it on GitHub: https://github.com/libusbx/libusbx/pull/163#issuecomment-30194212