Re: [Libva] [PATCH intel-driver v2 7/7] test: add some jpeg encode tests

2016-09-26 Thread Zhao Yakui
On 09/27/2016 04:11 AM, U. Artie Eoff wrote: Add JPEG encode tests that encode raw I420 and NV12 data at quality 100 and then decodes them to verify proper encoding. Currently, the 7680x4320 I420 test fails because ~40-60 Y-values (i.e. plane 0) in each line from the decoded bitstream are off

Re: [Libva] [PATCH intel-driver v2 6/7] test: add common test utils

2016-09-26 Thread Zhao Yakui
On 09/27/2016 04:11 AM, U. Artie Eoff wrote: Common utilities and functions that may be useful for multiple tests. This looks good to me. Add: Reviewed-by: Zhao Yakui Thanks Yakui Signed-off-by: U. Artie Eoff --- test/Makefile.am | 1

Re: [Libva] [PATCH intel-driver v2 5/7] test: add wrapper for SyncSurface

2016-09-26 Thread Zhao Yakui
On 09/27/2016 04:11 AM, U. Artie Eoff wrote: Add a wrapper that calls the driver i965_SyncSurface. This looks good to me. Thanks Yakui Signed-off-by: U. Artie Eoff --- test/i965_internal_decl.h | 3 +++ test/i965_test_fixture.cpp | 6 ++

Re: [Libva] [PATCH intel-driver v2 4/7] test: add streamable operators for VA structs and other

2016-09-26 Thread Zhao Yakui
On 09/27/2016 04:11 AM, U. Artie Eoff wrote: Add convenience streamable operators for VA and other common data structures so that tests can log them as needed. v2: put std::array stream operators into the std namespace otherwise gcc 5.x complains. This looks good to me. Add: Reviewed-by:

Re: [Libva] [PATCH intel-driver v2 2/7] test: wrap jpeg decode tests and data in namespace

2016-09-26 Thread Zhao Yakui
On 09/27/2016 04:11 AM, U. Artie Eoff wrote: Put the JPEG decode tests and test data into its own namespace so that it can be distinguished from encode. This looks good to me. Add: Reviewed-by: Zhao Yakui Signed-off-by: U. Artie Eoff ---

Re: [Libva] [PATCH intel-driver v2 1/7] test: split jpeg test data into header and cpp

2016-09-26 Thread Zhao Yakui
On 09/27/2016 04:11 AM, U. Artie Eoff wrote: Move static definitions of JPEG TestPatternData into the .cpp so that multiple files can include the i965_jpeg_test_data.h header file. Otherwise, there will be "multiple definition" compiler errors. Also, change generateSolid to be inline for the

[Libva] [PATCH intel-driver v2 6/7] test: add common test utils

2016-09-26 Thread U. Artie Eoff
Common utilities and functions that may be useful for multiple tests. Signed-off-by: U. Artie Eoff --- test/Makefile.am | 1 + test/test_utils.h | 49 + 2 files changed, 50 insertions(+) create mode 100644

[Libva] [PATCH intel-driver v2 4/7] test: add streamable operators for VA structs and other

2016-09-26 Thread U. Artie Eoff
Add convenience streamable operators for VA and other common data structures so that tests can log them as needed. v2: put std::array stream operators into the std namespace otherwise gcc 5.x complains. Signed-off-by: U. Artie Eoff --- test/i965_streamable.h | 361

[Libva] [PATCH intel-driver v2 7/7] test: add some jpeg encode tests

2016-09-26 Thread U. Artie Eoff
Add JPEG encode tests that encode raw I420 and NV12 data at quality 100 and then decodes them to verify proper encoding. Currently, the 7680x4320 I420 test fails because ~40-60 Y-values (i.e. plane 0) in each line from the decoded bitstream are off by more than 2 of the original raw I420 values.

[Libva] [PATCH intel-driver v2 2/7] test: wrap jpeg decode tests and data in namespace

2016-09-26 Thread U. Artie Eoff
Put the JPEG decode tests and test data into its own namespace so that it can be distinguished from encode. Signed-off-by: U. Artie Eoff --- test/i965_jpeg_decode_test.cpp | 8 ++--- test/i965_jpeg_test_data.cpp | 4 +++ test/i965_jpeg_test_data.h | 81

[Libva] [PATCH intel-driver v2 1/7] test: split jpeg test data into header and cpp

2016-09-26 Thread U. Artie Eoff
Move static definitions of JPEG TestPatternData into the .cpp so that multiple files can include the i965_jpeg_test_data.h header file. Otherwise, there will be "multiple definition" compiler errors. Also, change generateSolid to be inline for the same reason. Signed-off-by: U. Artie Eoff

[Libva] [PATCH intel-driver 4/7] test: add streamable operators for VA structs and other

2016-09-26 Thread U. Artie Eoff
Add convenience streamable operators for VA and other common data structures so that tests can log them as needed. Signed-off-by: U. Artie Eoff --- test/i965_streamable.h | 359 +++ test/i965_test_fixture.h | 1 + 2

[Libva] [PATCH intel-driver 5/7] test: add wrapper for SyncSurface

2016-09-26 Thread U. Artie Eoff
Add a wrapper that calls the driver i965_SyncSurface. Signed-off-by: U. Artie Eoff --- test/i965_internal_decl.h | 3 +++ test/i965_test_fixture.cpp | 6 ++ test/i965_test_fixture.h | 6 ++ 3 files changed, 15 insertions(+) diff --git

[Libva] [PATCH intel-driver 7/7] test: add some jpeg encode tests

2016-09-26 Thread U. Artie Eoff
Add JPEG encode tests that encode raw I420 and NV12 data at quality 100 and then decodes them to verify proper encoding. Currently, the 7680x4320 I420 test fails because ~40-60 Y-values (i.e. plane 0) in each line from the decoded bitstream are off by more than 2 of the original raw I420 values.

[Libva] [PATCH intel-driver 2/7] test: wrap jpeg decode tests and data in namespace

2016-09-26 Thread U. Artie Eoff
Put the JPEG decode tests and test data into its own namespace so that it can be distinguished from encode. Signed-off-by: U. Artie Eoff --- test/i965_jpeg_decode_test.cpp | 8 ++--- test/i965_jpeg_test_data.cpp | 4 +++ test/i965_jpeg_test_data.h | 81

[Libva] [PATCH intel-driver 3/7] test: add wrapper for CreateSurfaces2

2016-09-26 Thread U. Artie Eoff
Add support for calling i965_CreateSurfaces2 so that we can pass VASurfaceAttributes. This is needed to set a particular surface pixel format in some tests. We must call i965_CreateSurfaces2 via the vtable since it is a static function within the i965_drv_video.c file... thus hidden.