Re: [Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test Suite

2016-09-07 Thread Eoff, Ullysses A
A > <ullysses.a.e...@intel.com> > Cc: libva@lists.freedesktop.org > Subject: Re: [Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test > Suite > > > > On Sep 7, 2016, at 10:35 AM, Sean V Kelley <sea...@posteo.de> wrote: > > > > On Wed, 2016-09-07

Re: [Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test Suite

2016-09-07 Thread Sean V Kelley
On Thu, 2016-09-01 at 12:59 -0700, U. Artie Eoff wrote: > The following patchset integrates the Google Test Framework > into the source tree.  This test framework provides a rich > set of features like automatic test discovery, assertion macros, > test fixtures, structured console and/or xml test

Re: [Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test Suite

2016-09-07 Thread Sean V Kelley
ie > > > > > > > > -Original Message- > > > From: Xiang, Haihao > > > Sent: Friday, September 02, 2016 1:40 AM > > > To: Eoff, Ullysses A <ullysses.a.e...@intel.com>; li...@lists.fre > > > ed > > > esktop.org &g

Re: [Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test Suite

2016-09-06 Thread Eoff, Ullysses A
tel.com>; libva@lists.freedesktop.org > Subject: Re: [Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test > Suite > > > Thanks for the patches to integrate gtest framework into libva-intel- > driver. test_i965_drv_video works well for me, but I got segmentation

Re: [Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test Suite

2016-09-02 Thread Eoff, Ullysses A
ATCH RFC intel-driver 00/11] Automated (Unit) Test > Suite > > > Thanks for the patches to integrate gtest framework into libva-intel- > driver. test_i965_drv_video works well for me, but I got segmentation > fault when I ran 'make check-local', could you have a look at th

Re: [Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test Suite

2016-09-02 Thread Sean V Kelley
Hi Yakui, As I mentioned before to Haihao who asked the same question, the focus here is on driver unit testing. The intent is not to test Libva API. That is a separate area. Gtest is intended for the driver as unit tests and a first step in getting CI in place. VA-API conformance is a

Re: [Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test Suite

2016-09-02 Thread Xiang, Haihao
Thanks for the patches to integrate gtest framework into libva-intel- driver. test_i965_drv_video works well for me, but I got segmentation fault when I ran 'make check-local', could you have a look at this issue? libva info: Found init function __vaDriverInit_0_39 libva info: va_openDriver()

Re: [Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test Suite

2016-09-02 Thread Sean V Kelley
Hi Yakui, As I mentioned before to Haihao who asked the same question, the focus here is on driver unit testing. The intent is not to test Libva API. That is a separate area. Gtest is intended for the driver as unit tests and a first step in getting CI in place. VA-API conformance is a

Re: [Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test Suite

2016-09-01 Thread Zhao Yakui
On 09/02/2016 03:59 AM, U. Artie Eoff wrote: HI, Artie thanks for your patch set. It is great idea to add gtest test-suite, which is helpful to improve the code quality and avoid the regression. I have one main concern. Can we add it into the libva instead of driver? In such

[Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test Suite

2016-09-01 Thread U. Artie Eoff
The following patchset integrates the Google Test Framework into the source tree. This test framework provides a rich set of features like automatic test discovery, assertion macros, test fixtures, structured console and/or xml test results, and more. These kinds of features allow developers to