Please run the tests... I suspect this patch will cause some to fail. Those
tests will need updated too.
U. Artie
> -Original Message-
> From: Libva [mailto:libva-boun...@lists.freedesktop.org] On Behalf Of Daniel
> Charles
> Sent: Monday, October 17, 2016 5:45 PM
> To:
> -Original Message-
> From: Charles, Daniel [mailto:daniel.char...@intel.com]
> Sent: Tuesday, October 18, 2016 11:09 AM
> To: Eoff, Ullysses A
> Cc: libva@lists.freedesktop.org
> Subject: Re: [Libva] [PATCH][libva-intel-driver] i965_validate_config: return
>
> -Original Message-
> From: Charles, Daniel [mailto:daniel.char...@intel.com]
> Sent: Tuesday, October 18, 2016 10:20 AM
> To: Eoff, Ullysses A
> Cc: libva@lists.freedesktop.org
> Subject: Re: [Libva] [PATCH][libva-intel-driver] i965_validate_config: return
>
On Tue, Oct 18, 2016 at 8:25 AM, Eoff, Ullysses A
wrote:
> Please run the tests... I suspect this patch will cause some to fail. Those
> tests will need updated too.
>
Ran the test suite on ToT, no regression found with this patch.
--
Daniel.
> U. Artie
>
>>
On Tue, Oct 18, 2016 at 10:48 AM, Eoff, Ullysses A
wrote:
>> -Original Message-
>> From: Charles, Daniel [mailto:daniel.char...@intel.com]
>> Sent: Tuesday, October 18, 2016 10:20 AM
>> To: Eoff, Ullysses A
>> Cc:
Ah, I overlooked the data types on my first review. Indeed it's important to
take it into account when diff'ing. This is why they were being cast to "int"
previously to calculate the diff.
On my system /dev/urandom seems to work (i.e. not all zeros). But I agree,
let's drop it since it does
I've created a bugzilla for the issue...
https://bugs.freedesktop.org/show_bug.cgi?id=98311
Let's continue discussion there.
U. Artie
> -Original Message-
> From: Sean V Kelley [mailto:sean.v.kel...@intel.com]
> Sent: Monday, October 17, 2016 10:35 AM
> To: Xiang, Haihao