Re: [Libva] h264 decoding, Surface exporting to Beignet

On 05/12/2016 07:39 PM, Nikita Orlov wrote: Hello! Hi, Nikita I am decoding h264 via VAAPI, after I have decoded frame in VASurface, I export it to BEIGNET: 1)vaDeriveImage 2)vaAcquireBufferHandle 3)clCreateBufferFromLibvaIntel The problem, that after I call vaDeriveImage, it seems Surface

Re: [Libva] [Libva-intel-driver][PATCH] Avoid potential NULL pointer access

On 05/23/2016 12:20 PM, Xiang, Haihao wrote: The issue is reported by Klocwork Signed-off-by: Xiang, Haihao This looks good to me. Add: Reviewed-by: Zhao Yakui Thanks --- src/gen9_vdenc.c | 6 ++ src/i965_drv_video.c | 4 +++- 2 files changed, 9 insertions(+), 1 deletion

Re: [Libva] [PATCH V1][libva] fix check NULL issues reported by Klockwork

On 05/23/2016 01:46 PM, peng.chen wrote: Signed-off-by: peng.chen --- va/va_trace.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/va/va_trace.c b/va/va_trace.c index 994422e..398ca1a 100644 --- a/va/va_trace.c +++ b/va/va_trace.c @@ -501,7 +501,10 @@ sta

Re: [Libva] [PATCH V1][libva] fix check NULL issues reported by Klockwork

On 05/23/2016 03:02 PM, Chen, Peng C wrote: -Original Message- From: Zhao, Yakui Sent: Monday, May 23, 2016 2:51 PM To: Chen, Peng C Cc: libva@lists.freedesktop.org Subject: Re: [Libva] [PATCH V1][libva] fix check NULL issues reported by Klockwork On 05/23/2016 01:46 PM, peng.chen

[Libva] [LIBVA-INTEL-DRIVER][PATCH 00/12] Add the support of VP9 HW encoding on KBL

From: "Zhao, Yakui" This is the patch set that adds the support of VP9 HW encoding on KBL. Zhao Yakui (12): Refine vp9_probs.h so that the prob table can be used for encoding Add common helper functions for VP9 Hw encoding Add one field to keep the specific priv_state for enco

[Libva] [LIBVA-INTEL-DRIVER][PATCH 01/12] Refine vp9_probs.h so that the prob table can be used for encoding

Otherwise the prob definition will be defined twice if it is included in two files. Signed-off-by: Zhao Yakui Reviewed-by: Sean V Kelley --- src/Makefile.am | 1 + src/vp9_probs.c | 527 src/vp9_probs.h | 486

[Libva] [LIBVA-INTEL-DRIVER][PATCH 03/12] Add one field to keep the specific priv_state for encoding

It will be better that it is allocated/initialized in calling the XXX_vme_context_init callback function. Signed-off-by: Zhao Yakui Reviewed-by: Sean V Kelley --- src/i965_encoder.c | 5 + src/i965_encoder.h | 1 + 2 files changed, 6 insertions(+) diff --git a/src/i965_encoder.c b/src

[Libva] [LIBVA-INTEL-DRIVER][PATCH 05/12] Fix the 48-bit address issue for gpe_util functions on gen8+

Signed-off-by: Zhao Yakui Reviewed-by: Sean V Kelley --- src/i965_gpe_utils.c | 63 ++-- 1 file changed, 37 insertions(+), 26 deletions(-) diff --git a/src/i965_gpe_utils.c b/src/i965_gpe_utils.c index c2772ad..658af76 100644 --- a/src

[Libva] [LIBVA-INTEL-DRIVER][PATCH 02/12] Add common helper functions for VP9 Hw encoding

Some are to initialize/update the frame_context related with VP9. The second is to initialize the uncompressed_header, which can be used when the user doesn't pass the uncompressed_header. Signed-off-by: Zhao Yakui Reviewed-by: Sean V Kelley --- src/vp9_probs.c

[Libva] [LIBVA-INTEL-DRIVER][PATCH 04/12] Use the buffer allocated externally to configure dynamic state for gpe_context on Gen8+

Signed-off-by: Zhao Yakui Reviewed-by: Sean V Kelley --- src/i965_gpe_utils.c | 21 + src/i965_gpe_utils.h | 13 + 2 files changed, 34 insertions(+) diff --git a/src/i965_gpe_utils.c b/src/i965_gpe_utils.c index bcf5dcf..c2772ad 100644 --- a/src/i965_gpe_utils.c

[Libva] [LIBVA-INTEL-DRIVER][PATCH 06/12] Add the VAEncMacroblockMapBufferType buffer for encoding

Signed-off-by: Zhao Yakui Reviewed-by: Sean V Kelley --- src/i965_drv_video.c | 9 + src/i965_drv_video.h | 1 + 2 files changed, 10 insertions(+) diff --git a/src/i965_drv_video.c b/src/i965_drv_video.c index 2c70a29..932e5be 100644 --- a/src/i965_drv_video.c +++ b/src

[Libva] [LIBVA-INTEL-DRIVER][PATCH 10/12] Release the corresponding buffers for VP9 encoding

Signed-off-by: Zhao Yakui Reviewed-by: Sean V Kelley --- src/i965_drv_video.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/i965_drv_video.c b/src/i965_drv_video.c index 186443b..77fe9c7 100644 --- a/src/i965_drv_video.c +++ b/src/i965_drv_video.c @@ -2833,6 +2833,13

[Libva] [LIBVA-INTEL-DRIVER][PATCH 11/12] Add the support of CBR/VBR for Vp9 Encoding

Signed-off-by: Zhao Yakui Reviewed-by: Sean V Kelley --- src/gen9_vp9_encoder.c | 176 + src/gen9_vp9_encoder.h | 2 + 2 files changed, 165 insertions(+), 13 deletions(-) diff --git a/src/gen9_vp9_encoder.c b/src/gen9_vp9_encoder.c index

[Libva] [LIBVA-INTEL-DRIVER][PATCH 09/12] Export the Vp9 encoding profile/entrypoint for KBL

Signed-off-by: Zhao Yakui Reviewed-by: Sean V Kelley --- src/i965_device_info.c | 1 + src/i965_drv_video.c | 51 + src/i965_drv_video.h | 2 ++ src/i965_encoder.c | 87 ++ 4 files changed, 135 insertions

[Libva] [LIBVA-INTEL-DRIVER][PATCH 12/12] Export the VBR bit rate-control for VP9 encoding on KBL

Signed-off-by: Zhao Yakui Reviewed-by: Sean V Kelley --- src/i965_drv_video.c | 4 1 file changed, 4 insertions(+) diff --git a/src/i965_drv_video.c b/src/i965_drv_video.c index 77fe9c7..17941cb 100644 --- a/src/i965_drv_video.c +++ b/src/i965_drv_video.c @@ -959,6 +959,10

[Libva] [LIBVA-INTEL-DRIVER][PATCH 07/12] Add some utility functions for i965_gpe_resources

This is to add the wrapper function required by vp9 encoding. Signed-off-by: Zhao Yakui Reviewed-by: Sean V Kelley --- src/gen9_vdenc.c | 1 + src/i965_defines.h | 2 + src/i965_gpe_utils.c | 453 +++ src/i965_gpe_utils.h | 115

Re: [Libva] encode surfaces created from prime fd (backed by OpenGL 2D texture)

On 05/26/2016 10:44 AM, Kristine Ferrell wrote: Shengquan, Thanks for the sample code. I have some follow-up questions: 1. Can I use VA_RT_FORMAT_RGB32 as the pixel format for vaCreateSurfaces? It'll be simpler since normally the 2D texture is in ARGB format. [Yakui]: Yes. You can use the VA_

Re: [Libva] encode surfaces created from prime fd (backed by OpenGL 2D texture)

On 05/26/2016 02:09 PM, Kristine Ferrell wrote: On Thu, May 26, 2016 at 12:20 AM, Zhao Yakui wrote: On 05/26/2016 10:44 AM, Kristine Ferrell wrote: Shengquan, Thanks for the sample code. I have some follow-up questions: 1. Can I use VA_RT_FORMAT_RGB32 as the pixel format for

[Libva] [LIBVA-INTEL-DRIVER][PATCH 1/3] Encoding: Encoding reuses aux_batchbuffer instead of allocate new buffer

Signed-off-by: Zhao Yakui --- src/gen8_mfc.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/src/gen8_mfc.c b/src/gen8_mfc.c index c30bad6..60e6362 100644 --- a/src/gen8_mfc.c +++ b/src/gen8_mfc.c @@ -1244,23 +1244,12 @@ static void

[Libva] [LIBVA-INTEL-DRIVER][PATCH 3/3] Follow the HW spec to set the surface cache attribute for Gen9+

From: "Qu, PengFei" Currently it will use the unoptimized cache attribute for the surface on Gen9+. This is to follow the HW spec to optimize the cache attribute of the surface for gen9+. Signed-off-by: Qu, Pengfei Signed-off-by: Zhao Yakui --- src/gen8_post_processing.c | 10 +

[Libva] [LIBVA-INTEL-DRIVER][PATCH 2/3] Encoding: H264 uses the GPU to construct the PAK obj command on Gen8+

This is helpful to reduce the waiting time when preparing the command buffer of PAK object. Signed-off-by: Zhao Yakui --- src/gen8_mfc.c| 388 +++--- src/shaders/utils/Makefile.am | 30 ++- src/shaders/utils

Re: [Libva] [PATCH intel-driver] Remove extraneous OUT_BATCH in gen8_gpe_state_base_address

On 06/01/2016 07:38 AM, Scott D Phillips wrote: Thanks for catching the issue. This looks good to me. Thanks Yakui Line accidentally left behind in: a82f0be Fix the 48-bit address issue for gpe_util functions on Signed-off-by: Scott D Phillips --- src/i965_gpe_utils.c | 2 -- 1 fil

Re: [Libva] [PATCH] Fix to use source and output regions size instead of the input output surfaces original size.

On 06/20/2016 10:50 AM, Lim Siew Hoon wrote: From: "Ung, Teng En" Signed-off-by: Ung, Teng En This looks good to me. Add: Reviewed-by: Zhao Yakui Thanks Yakui --- src/gen75_vpp_vebox.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff -

[Libva] [PATCH] Downgrade the alignment requirement for linear surface on BDW+

When sharing the YUY2/UYVY buffer with other driver, the current alignment is too strict, which causes that it is not handled correctly by other driver.(The current alignment is considered based on I420/YV12) https://bugs.freedesktop.org/show_bug.cgi?id=96689 Signed-off-by: Zhao Yakui

Re: [Libva] [PATCH] Downgrade the alignment requirement for linear surface on BDW+

On 06/27/2016 12:09 PM, Zhao Yakui wrote: When sharing the YUY2/UYVY buffer with other driver, the current alignment is too strict, which causes that it is not handled correctly by other driver.(The current alignment is considered based on I420/YV12) https://bugs.freedesktop.org/show_bug.cgi

Re: [Libva] [ROI 2/2] Encoding: Add ROI example

On 06/28/2016 07:03 PM, Pengfei Qu wrote: From: Zhao Yakui Signed-off-by: Zhao Yakui Signed-off-by: pjl Signed-off-by: ceciliapeng Signed-off-by: Pengfei Qu It will be better to add the ROI option. In such case this can determine whether the ROI is used and so on. Thanks Yakui

Re: [Libva] [PATCH 3/3] add ip/pb qp diff configuration

What is the purpose of adding this field? It will be better that more descriptions can be added for this field so that the VA users can know its meaning. -Original Message- From: Libva [mailto:libva-boun...@lists.freedesktop.org] On Behalf Of Pengfei Qu Sent: Wednesday, June 29, 2016 5:0

Re: [Libva] [PATCH 01/14] Encoding: Abstract the calculation of mbmv cost for qp as one function and Add one function that initialize mbmv cost table for supported Qp range

On 07/01/2016 12:49 PM, Xiang, Haihao wrote: From: Zhao Yakui Signed-off-by: Zhao Yakui Signed-off-by: pjl Signed-off-by: Pengfei Qu --- src/gen6_mfc_common.c | 104 -- src/gen6_vme.h| 15 +++- 2 files changed, 98 insertions

Re: [Libva] [PATCH 01/14] Encoding: Abstract the calculation of mbmv cost for qp as one function and Add one function that initialize mbmv cost table for supported Qp range

On 07/01/2016 02:40 PM, Xiang, Haihao wrote: On Fri, 2016-07-01 at 14:11 +0800, Zhao Yakui wrote: On 07/01/2016 12:49 PM, Xiang, Haihao wrote: From: Zhao Yakui Signed-off-by: Zhao Yakui Signed-off-by: pjl Signed-off-by: Pengfei Qu --- src/gen6_mfc_common.c | 104

Re: [Libva] [PATCH 12/14] Adjust the maximum number of motion vectors for B frame on HSW+

On 06/30/2016 10:33 AM, Pengfei Qu wrote: From: Jia Meng This looks good to me. Thanks Yakui Signed-off-by: Jia Meng Signed-off-by: Pengfei Qu --- src/gen75_vme.c | 13 +++-- src/gen8_vme.c | 15 --- src/gen9_vme.c | 17 + 3 files changed, 24 in

Re: [Libva] [PATCH 13/14] scaling matrix of h264 encoder on gen8/gen9

On 06/30/2016 10:33 AM, Pengfei Qu wrote: From: Jia Meng qm is in raster scan order per va api, and fqm is in column wise raster scan order per hardware requirement. The title is inconsistent with what is done. Can we remove it for gen6/gen7/gen75 and only keep it for gen8/gen9? Thanks Ya

Re: [Libva] [PATCH 14/14] QP difference configuration for adjacent IP and PB frames

On 06/30/2016 10:33 AM, Pengfei Qu wrote: From: Jia Meng Signed-off-by: Jia Meng Signed-off-by: Pengfei Qu This looks good to me. Thanks Yakui --- src/gen6_mfc.h| 4 src/gen6_mfc_common.c | 41 + 2 files changed, 33 insertions(+),

Re: [Libva] [PATCH 10/13] VME shader keep for HEVC

On 07/12/2016 03:45 AM, Matt Turner wrote: On Thu, Jul 7, 2016 at 2:18 AM, Pengfei Qu wrote: +/* Compare three word data to get the min value */ +word_imin: + cmp.le.f0.0 (1) null:w INPUT_ARG0.0<0,1,0>:w INPUT_ARG0.4<0,1,0>:w {align1}; + (f0.0) mov (1) T

Re: [Libva] [PATCH 10/13] VME shader keep for HEVC

On 07/13/2016 12:27 PM, Matt Turner wrote: On Tue, Jul 12, 2016 at 6:29 PM, Zhao Yakui wrote: On 07/12/2016 03:45 AM, Matt Turner wrote: On Thu, Jul 7, 2016 at 2:18 AM, Pengfei Qu wrote: +/* Compare three word data to get the min value */ +word_imin: + cmp.le.f0.0 (1

[Libva] [LIBVA-INTEL-DRIVER][PATCH] Export the P010 surface attribute for HEVC/VP9 10-bits decoding

From: Zhao Yakui Signed-off-by: Zhao Yakui --- src/i965_drv_video.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/i965_drv_video.c b/src/i965_drv_video.c index ad48f22..87363f3 100644 --- a/src/i965_drv_video.c +++ b/src/i965_drv_video.c @@ -5798,6 +5798,15

Re: [Libva] [PATCH intel-driver] shaders/gen9: fix build when no intel-gen4asm available

On 07/21/2016 12:33 AM, U. Artie Eoff wrote: If intel-gen4asm version is< 1.9 or not installed then we shouldn't run the associated make rules. This fixes 'make dist' failure. This looks good to me. Add: Reviewed-by: Zhao Yakui Signed-off-by: U. Artie Eoff

Re: [Libva] [PATCH] Missing 'do' in "do ...while" in macro ALLOC_VDENC_BUFFER_RESOURCE

On 07/26/2016 04:54 PM, Lim Siew Hoon wrote: Signed-off-by: Lim Siew Hoon Good catch. This looks good to me. Add: Reviewed-by: Zhao Yakui Thanks Yakui --- src/gen9_vdenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gen9_vdenc.c b/src/gen9_vdenc.c index

[Libva] [Libva-Intel-Driver][PATCH 2/2] VPP: Check the returned status of hsw_veb_pre_format_convert before VEBOX VPP

Signed-off-by: Zhao Yakui --- src/gen75_vpp_vebox.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/src/gen75_vpp_vebox.c b/src/gen75_vpp_vebox.c index 2bc5cf9..9895814 100644 --- a/src/gen75_vpp_vebox.c +++ b/src/gen75_vpp_vebox.c @@ -1367,7 +1367,7

[Libva] [Libva-Intel-Driver][PATCH 1/2] VPP: Check the VPP pipeline_parameter to avoid NULL pointer

This is to fix the crash issue caused by the commit 51ad826fcc0d2512f7ef74e807e4b8526663fc28. Reported-by: Xu,Guangxin Signed-off-by: Zhao Yakui --- src/gen75_vpp_vebox.c | 27 +++ 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/src/gen75_vpp_vebox.c b

Re: [Libva] [Libva-Intel-Driver][PATCH 2/2] VPP: Check the returned status of hsw_veb_pre_format_convert before VEBOX VPP

On 08/10/2016 09:52 AM, Xiang, Haihao wrote: Signed-off-by: Zhao Yakui --- src/gen75_vpp_vebox.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/src/gen75_vpp_vebox.c b/src/gen75_vpp_vebox.c index 2bc5cf9..9895814 100644 --- a/src

[Libva] [Libva-Intel-Driver][PATCH V2 1/2] VPP: Check the VPP pipeline_parameter to avoid NULL pointer

This is to fix the crash issue caused by the commit 51ad826fcc0d2512f7ef74e807e4b8526663fc28. Reported-by: Xu,Guangxin Signed-off-by: Zhao Yakui --- src/gen75_vpp_vebox.c | 27 +++ 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/src/gen75_vpp_vebox.c b

[Libva] [Libva-Intel-Driver][PATCH V2 2/2] VPP: Check the returned status of hsw_veb_pre_format_convert before VEBOX VPP

V1->V2: Use the ASSERT_RET for the debug purpose Signed-off-by: Zhao Yakui --- src/gen75_vpp_vebox.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/src/gen75_vpp_vebox.c b/src/gen75_vpp_vebox.c index 2bc5cf9..91715fc 100644 --- a/

Re: [Libva] Driver stuck on picture encode

On 08/12/2016 11:18 PM, Lionel Landwerlin wrote: Hi, Playing around with the h264 encoder on Haswell, I've noticed that I can get the encoder stuck in gen75_mfc_avc_encode_picture() essentially by setting a bitrate above with can be generated by the encoder for a given picture. Will you please

Re: [Libva] [Libva-intel-driver][PATCH 1/2] Encode/VP9: turn gen9_vp9_get_coded_status() into a local function

Add: Reviewed-by: Zhao Yakui Thanks Yakui Signed-off-by: Xiang, Haihao --- src/gen9_vp9_encapi.h | 9 - src/gen9_vp9_encoder.c | 53 ++ src/i965_drv_video.c | 14 + 3 files changed, 24 insertions(+), 52 deletions(-) d

Re: [Libva] [Libva-intel-driver][PATCH 2/2] Encode/VP9: Don't use hardcoded offsets

: Reviewed-by: Zhao Yakui Thanks Yakui --- src/gen9_vp9_encoder.c | 26 -- src/gen9_vp9_encoder.h | 12 2 files changed, 16 insertions(+), 22 deletions(-) diff --git a/src/gen9_vp9_encoder.c b/src/gen9_vp9_encoder.c index edfbda6..76cd1d7 100644

Re: [Libva] [Libva-intel-driver][PATCH 1/2] Cleanup gen9_mfc.c

looks good to me. After the code is removed, it seems clearer. Add: Reviewed-by: Zhao Yakui Thanks. Yakui Signed-off-by: Xiang, Haihao --- src/gen9_mfc.c | 1764 +--- 1 file changed, 3 insertions(+), 1761 deletions(-) diff --g

Re: [Libva] [Libva-intel-driver][PATCH v2 2/2] Remove unused .g9a/.g9b files

On 08/23/2016 11:08 AM, Xiang, Haihao wrote: v2: remove unused .g9a files, and change the short commit log as well This looks good to me. Add: Reviewed-by: Zhao Yakui Thanks Yakui Signed-off-by: Xiang, Haihao --- src/shaders/utils/mfc_batchbuffer_avc_inter.g9a | 33 - src

Re: [Libva] [Libva-intel-driver][PATCH 2/2] Remove 2 unused .g9b files

On 08/23/2016 09:59 AM, Xiang, Haihao wrote: Signed-off-by: Xiang, Haihao --- src/shaders/utils/mfc_batchbuffer_avc_inter.g9b | 90 - src/shaders/utils/mfc_batchbuffer_avc_intra.g9b | 66 -- 2 files changed, 156 deletions(-) delete mode 100644 src/sha

Re: [Libva] I want to use VA-API to support new platform, I want know something about Intel implementation

On 08/24/2016 06:29 PM, Randy Li wrote: On 08/18/2016 10:31 AM, Xiang, Haihao wrote: Hi Randy, You can get lots of information / docs via internet. You may search for dri, libdrm, drm, gem, i915 etc. dri wiki https://dri.freedesktop.org/wiki/ drm: https://en.wikipedia.org/wiki/Direct_Rende

Re: [Libva] [PATCH 1/2] HEVC ENC: 10bit support

On 08/31/2016 05:13 PM, Pengfei Qu wrote: this patch enable HEVC 10bit encoding on KBL+. v1: add internal NV12 format surface in vme context structure. add VADriverContextP member in vem context structure. P010->NV12 is done in YUV check before encoding. v2: add P010->NV12 for ref/reconstructed

Re: [Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test Suite

On 09/02/2016 03:59 AM, U. Artie Eoff wrote: HI, Artie thanks for your patch set. It is great idea to add gtest test-suite, which is helpful to improve the code quality and avoid the regression. I have one main concern. Can we add it into the libva instead of driver? In such case

Re: [Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test Suite

Thanks for the explanation. Now I understand the intent. Thanks Yakui -Original Message- From: Sean V Kelley [mailto:svkel...@posteo.de] Sent: Friday, September 2, 2016 11:45 AM To: Zhao, Yakui ; Haitao Huang Cc: Eoff, Ullysses A ; libva@lists.freedesktop.org Subject: Re: [Libva

Re: [Libva] [HEVC10bit ENC V2 1/5] HEVC10bit ENC: add driver context member and internal NV12 surface in VME

On 09/02/2016 03:01 PM, Pengfei Qu wrote: Signed-off-by: Pengfei Qu --- src/gen6_vme.c | 17 + src/gen6_vme.h | 8 src/gen7_vme.c | 2 ++ src/gen8_vme.c | 12 +++- 4 files changed, 38 insertions(+), 1 deletion(-) diff --git a/src/gen6_vme.c b/src/gen6_vme

Re: [Libva] [HEVC10bit ENC V2 2/5] HEVC ENC: 10bit support

On 09/02/2016 03:01 PM, Pengfei Qu wrote: this patch enable HEVC 10bit encoding on KBL+. v1: remove P010->NV12 for ref/reconstructed frame and enc frame from this patch remove call i965_SyncSurface to work around the GPU hang when 10bit->8bit(P010->NV12)from this patch This comments looks a l

Re: [Libva] [HEVC10bit ENC V2 3/5] HEVC10bit:conver p010 to nv12 for ME surface

On 09/02/2016 03:01 PM, Pengfei Qu wrote: Signed-off-by: Pengfei Qu --- src/gen9_mfc_hevc.c | 127 1 file changed, 127 insertions(+) diff --git a/src/gen9_mfc_hevc.c b/src/gen9_mfc_hevc.c index 6021a7e..bc9225a 100644 --- a/src/gen9_mfc_hev

Re: [Libva] [PATCH V3: 1/4] HEVC10bit ENC: add private surface for p010 conversion to nv12

On 09/06/2016 08:09 AM, Pengfei Qu wrote: Signed-off-by: Pengfei Qu This looks good to me. Add: Reviewed-by: Zhao Yakui --- src/intel_media.h| 5 + src/intel_media_common.c | 10 ++ 2 files changed, 15 insertions(+) diff --git a/src/intel_media.h b/src

Re: [Libva] [PATCH V3: 2/4] HEVC10bit ENC:enable hevc 10bit on VME and PAK

On 09/06/2016 08:09 AM, Pengfei Qu wrote: 1.add p010->nv12 before VME 2.add CBR support This looks good to me. Add: Reviewed-by: Zhao Yakui Signed-off-by: Pengfei Qu --- src/gen6_mfc_common.c | 13 + src/gen9_mfc_hevc.c | 105 ++--

Re: [Libva] [PATCH V3: 3/4] HEVC10bit ENC:enable hevc 10bit encoding pipeline

On 09/06/2016 08:09 AM, Pengfei Qu wrote: Signed-off-by: Pengfei Qu This looks good to me. Add: Reviewed-by: Zhao Yakui --- src/i965_device_info.c | 1 + src/i965_drv_video.c | 20 +++- src/i965_drv_video.h | 1 + src/i965_encoder.c | 18

Re: [Libva] [PATCH V3: 4/4] HEVC10bit ENC: work around gpu hang when p010->nv12

On 09/06/2016 08:09 AM, Pengfei Qu wrote: Signed-off-by: Pengfei Qu This looks good to me. Add: Reviewed-by: Zhao Yakui --- src/gen9_vme.c | 1 + src/i965_drv_video.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/gen9_vme.c b/src/gen9_vme.c index 9e66275..264b27d

Re: [Libva] [PATCH V3: 2/4] HEVC10bit ENC:enable hevc 10bit on VME and PAK

On 09/06/2016 10:48 PM, Xiang, Haihao wrote: -Original Message- From: Libva [mailto:libva-boun...@lists.freedesktop.org] On Behalf Of Pengfei Qu Sent: Tuesday, September 6, 2016 8:09 AM To: libva@lists.freedesktop.org Subject: [Libva] [PATCH V3: 2/4] HEVC10bit ENC:enable hevc 10bit on

Re: [Libva] [Libva-intel-driver][PATCH] Code cleanup for vme/mfc initializing on SKL

On 09/06/2016 11:39 PM, Xiang, Haihao wrote: It keeps i965_encoder.c simple Thanks for the patch. But I don't think that this patch is necessary. The code looks more clear if it can select the different initialization callback function earlier based on the corresponding profile/entrypoint .

Re: [Libva] [Libva-intel-driver][PATCH 03/18] Add some new internal variables for a new sequence

On 09/06/2016 11:41 PM, Xiang, Haihao wrote: Currently these variables are used only for H.264 encoding Signed-off-by: Xiang, Haihao --- src/i965_encoder.c | 7 +++ src/i965_encoder.h | 4 2 files changed, 11 insertions(+) diff --git a/src/i965_encoder.c b/src/i965_encoder.c index

Re: [Libva] [Libva-intel-driver][PATCH 04/18] Check bitrate control related parameters in sequence and misc parameters

On 09/06/2016 11:41 PM, Xiang, Haihao wrote: Currently only used for H.264 encoding Signed-off-by: Xiang, Haihao --- src/i965_encoder.c | 184 +++-- src/i965_encoder.h | 12 2 files changed, 190 insertions(+), 6 deletions(-) diff --git a

Re: [Libva] [Libva-intel-driver][PATCH 07/18] Remove unused fields and code in H.264/VP8 BRC

On 09/06/2016 11:41 PM, Xiang, Haihao wrote: H.264 and VP8 share some data structures Signed-off-by: Xiang, Haihao --- src/gen6_mfc.h| 6 -- src/gen6_mfc_common.c | 29 +++-- src/gen8_mfc.c| 35 +++ 3 files changed

Re: [Libva] [Libva-intel-driver][PATCH 03/18] Add some new internal variables for a new sequence

On 09/07/2016 11:03 AM, Xiang, Haihao wrote: On 09/06/2016 11:41 PM, Xiang, Haihao wrote: Currently these variables are used only for H.264 encoding Signed-off-by: Xiang, Haihao --- src/i965_encoder.c | 7 +++ src/i965_encoder.h | 4 2 files changed, 11 insertions(+) diff --g

Re: [Libva] [Libva-intel-driver][PATCH 11/18] Check temporal layer structure

On 09/06/2016 11:45 PM, Xiang, Haihao wrote: Signed-off-by: Xiang, Haihao This looks good to me. Thanks. Yakui --- src/i965_encoder.c | 66 ++ src/i965_encoder.h | 9 2 files changed, 75 insertions(+) diff --git a/src/i965

Re: [Libva] [Libva-intel-driver][PATCH 12/18] Use arrays to store bitrate and framerate

On 09/06/2016 11:45 PM, Xiang, Haihao wrote: Currently only the first element is used This looks good to me. Thanks Signed-off-by: Xiang, Haihao --- src/gen6_mfc_common.c | 6 +++--- src/i965_encoder.c| 18 +- src/i965_encoder.h| 4 ++-- 3 files changed, 14 in

Re: [Libva] [Libva-intel-driver][PATCH 14/18] Change the type of the 2nd parameter of intel_mfc_update_hrd()

On 09/06/2016 11:46 PM, Xiang, Haihao wrote: In addition, change the two caller functions as well. This looks good to me. Thanks Yakui Signed-off-by: Xiang, Haihao --- src/gen6_mfc.c| 2 +- src/gen6_mfc.h| 4 ++-- src/gen6_mfc_common.c | 8 +--- src/gen75_mfc.c

Re: [Libva] [Libva-intel-driver][PATCH 15/18] Use arrays to store BRC related parameters per temporal layer

On 09/06/2016 11:46 PM, Xiang, Haihao wrote: Currently only the first element is used This looks good to me. Thanks Yakui Signed-off-by: Xiang, Haihao --- src/gen6_mfc.c| 8 +++ src/gen6_mfc.h| 6 ++--- src/gen6_mfc_common.c | 66 +

Re: [Libva] [Libva-intel-driver][PATCH 18/18] Add support for VAConfigAttribEncRateControlExt attribute

On 09/06/2016 11:46 PM, Xiang, Haihao wrote: Currently bit rate control per temporal layer is disabled This looks good to me. Add: Reviewed-by: Zhao Yakui Thanks Signed-off-by: Xiang, Haihao --- src/i965_drv_video.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a

Re: [Libva] [Libva-intel-driver][PATCH 17/18] Update CBR algo for H.264 per tempolar layer

On 09/06/2016 11:46 PM, Xiang, Haihao wrote: Signed-off-by: Xiang, Haihao This looks good to me. Add: Reviewed-by: Zhao Yakui Thanks --- src/gen6_mfc.c| 4 +-- src/gen6_mfc_common.c | 76 +-- src/gen6_vme.c| 2 +- src

Re: [Libva] [Libva-intel-driver][PATCH] Code cleanup for vme/mfc initializing on SKL

On 09/07/2016 11:01 AM, Xiang, Haihao wrote: i965_encoder.c is a general file, it would be better not to include more HW/implementation related code in this file. Actually it is more clear if you look into the new gen9_vme_context_init() and gen9_mfc_context_init(). Previous it selects differen

Re: [Libva] [Libva-intel-driver][PATCH 11/18] Check temporal layer structure

On 09/06/2016 11:45 PM, Xiang, Haihao wrote: Signed-off-by: Xiang, Haihao --- src/i965_encoder.c | 66 ++ src/i965_encoder.h | 9 2 files changed, 75 insertions(+) diff --git a/src/i965_encoder.c b/src/i965_encoder.c index 2ba5de7

Re: [Libva] [Libva-intel-driver][PATCH v2 01/18] intel_mfc_brc_prepare() only works for H.264 or H.264 MVC

On 09/09/2016 04:47 AM, Sean V Kelley wrote: On Thu, 2016-09-08 at 22:44 +0800, Xiang, Haihao wrote: v2: rebased Signed-off-by: Xiang, Haihao Haihao, It would be good to add a cover for the patch series going over the SVC/SVC-T support you are adding for CQP/CBR. [Yakui}: This is a good i

Re: [Libva] [PATCH intel-driver v2 1/7] test: split jpeg test data into header and cpp

ne for the same reason. This looks good to me. Add: Reviewed-by: Zhao Yakui Signed-off-by: U. Artie Eoff --- test/Makefile.am | 1 + test/i965_jpeg_test_data.cpp | 762 +++ test/i965_jpeg_test_data

Re: [Libva] [PATCH intel-driver v2 2/7] test: wrap jpeg decode tests and data in namespace

On 09/27/2016 04:11 AM, U. Artie Eoff wrote: Put the JPEG decode tests and test data into its own namespace so that it can be distinguished from encode. This looks good to me. Add: Reviewed-by: Zhao Yakui Signed-off-by: U. Artie Eoff --- test/i965_jpeg_decode_test.cpp | 8 ++--- test

Re: [Libva] [PATCH intel-driver v2 3/7] test: add wrapper for CreateSurfaces2

i965_drv_video.c file... thus hidden. This looks good to me. Add: Reviewed-by: Zhao Yakui Thanks. Yakui Signed-off-by: U. Artie Eoff --- test/i965_test_fixture.cpp | 20 test/i965_test_fixture.h | 10 +++--- 2 files changed, 23 insertions(+), 7 deletions

Re: [Libva] [PATCH intel-driver v2 4/7] test: add streamable operators for VA structs and other

: Zhao Yakui Thanks Signed-off-by: U. Artie Eoff --- test/i965_streamable.h | 361 +++ test/i965_test_fixture.h | 1 + 2 files changed, 362 insertions(+) create mode 100644 test/i965_streamable.h diff --git a/test/i965_streamable.h b/test

Re: [Libva] [PATCH intel-driver v2 5/7] test: add wrapper for SyncSurface

On 09/27/2016 04:11 AM, U. Artie Eoff wrote: Add a wrapper that calls the driver i965_SyncSurface. This looks good to me. Thanks Yakui Signed-off-by: U. Artie Eoff --- test/i965_internal_decl.h | 3 +++ test/i965_test_fixture.cpp | 6 ++ test/i965_test_fixture.h | 6 ++

Re: [Libva] [PATCH intel-driver v2 6/7] test: add common test utils

On 09/27/2016 04:11 AM, U. Artie Eoff wrote: Common utilities and functions that may be useful for multiple tests. This looks good to me. Add: Reviewed-by: Zhao Yakui Thanks Yakui Signed-off-by: U. Artie Eoff --- test/Makefile.am | 1 + test/test_utils.h | 49

Re: [Libva] [PATCH intel-driver v2 7/7] test: add some jpeg encode tests

by more than 2 of the original raw I420 values. It is not clear why only this resolution exhibits this problem. v2: don't create any input data in test fixture if jpeg encoding is not supported. This looks good to me. Add: Reviewed-by: Zhao Yakui Thanks Signed-off-by: U. Artie

Re: [Libva] [Libva-intel-driver][PATCH 1/2] Check whether there is a fully loaded HuC firmware

On 09/28/2016 08:42 AM, Xiang, Haihao wrote: Signed-off-by: Xiang, Haihao This looks good to me. Add: Reviewed-by: Zhao Yakui Thanks Yakui --- src/intel_driver.c | 12 src/intel_driver.h | 1 + 2 files changed, 13 insertions(+) diff --git a/src/intel_driver.c b/src

Re: [Libva] [Libva-intel-driver][PATCH] Set default framerate to 30fps if user doesn't set the corresponding sequence parameter

On 09/27/2016 10:49 PM, Xiang, Haihao wrote: User can update framerate using VAEncMiscParameterTypeFrameRate buffer later It looks good to me. Add: Reviewed-by: Zhao Yakui Thanks Yakui Signed-off-by: Xiang, Haihao --- src/i965_encoder.c | 7 ++- 1 file changed, 6 insertions

Re: [Libva] [Libva-intel-driver][PATCH 2/2] Add CBR and VBR bitrate control flags for low power encode if possible

On 09/28/2016 08:42 AM, Xiang, Haihao wrote: CBR and VBR for low power encode depend on the fully loaded HuC firmware. This looks good to me. Add: Reviewed-by: Zhao Yakui Thanks Yakui Signed-off-by: Xiang, Haihao --- src/i965_device_info.c | 11 +++ 1 file changed, 11

Re: [Libva] problem when tiling is disabled on decoded surfaces

On 10/08/2016 02:13 AM, Sean V Kelley wrote: On Fri, Oct 7, 2016 at 11:00 AM, Sean V Kelley wrote: On Thu, Oct 6, 2016 at 1:20 AM, Julien Isorce wrote: Hi, In intel vaapi driver I tried disabling tiling with: --- a/src/i965_drv_video.c +++ b/src/i965_drv_video.c @@ -1534,7 +1534,7 @@ i965

Re: [Libva] [Libva-intel-driver][PATCH] Use Media Read message if possible on Gen8+

test from 1 test case ran. (15365 ms total) [ PASSED ] 1 test. Signed-off-by: Xiang, Haihao This looks good to me. Add: Reviewed-by: Zhao Yakui Thanks Yakui --- src/gen8_post_processing.c | 56 +- src/shaders/post_processing/gen8/Makefile.a

Re: [Libva] [Libva-intel-driver][PATCH] Use Media Read message if possible on Gen8+

On 10/15/2016 03:58 AM, Eoff, Ullysses A wrote: -Original Message- From: Libva [mailto:libva-boun...@lists.freedesktop.org] On Behalf Of Sean V Kelley Sent: Friday, October 14, 2016 11:44 AM To: Zhao, Yakui; Xiang, Haihao Cc: libva@lists.freedesktop.org Subject: Re: [Libva] [Libva

[Libva] [PATCH 1/8] Fix the incorrect sampler_state offset for INTERFACE_DESCRIPTOR_DATA on BDW+

Signed-off-by: Zhao Yakui --- src/i965_gpe_utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/i965_gpe_utils.c b/src/i965_gpe_utils.c index 3ec164d..a29237b 100644 --- a/src/i965_gpe_utils.c +++ b/src/i965_gpe_utils.c @@ -1684,7 +1684,7

[Libva] [PATCH 2/8] Add the 10-bit flag for MEDIA_BLOCK_RW operation on 10bit surface

Signed-off-by: Zhao Yakui --- src/i965_gpe_utils.c | 16 src/i965_gpe_utils.h | 1 + 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/i965_gpe_utils.c b/src/i965_gpe_utils.c index a29237b..3cd41e8 100644 --- a/src/i965_gpe_utils.c +++ b/src/i965_gpe_utils.c

[Libva] [PATCH 3/8] Add one API to initialize MEDIA_OBJECT_WALKER parameter for video post-processing

Signed-off-by: Zhao Yakui --- src/i965_gpe_utils.c | 48 src/i965_gpe_utils.h | 14 ++ 2 files changed, 62 insertions(+) diff --git a/src/i965_gpe_utils.c b/src/i965_gpe_utils.c index 3cd41e8..30529e1 100644 --- a/src/i965_gpe_utils.c

[Libva] [PATCH 7/8] Execute the 10-bit scaling for P010 surface on Gen9+

Now the 10-bit scaling based on GPU shader is supported on Gen9+. In such case it will use the 10-bit scaling based on GPU shader instead of three-steps by using VEBOX(VEBOX->NV12->Scale NV12->VEBOX). Of course when the size is not changed, it still falls back to VEBOX. Signed-off-by: Z

[Libva] [PATCH 8/8] Align coordinate/width of DST rect for 10-bit VPP conversion

This is the HW requirement and it is handled internally. Signed-off-by: Zhao Yakui --- src/gen75_picture_process.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gen75_picture_process.c b/src/gen75_picture_process.c index 4f7f794..3c2e251 100644 --- a/src

[Libva] [PATCH 4/8] Initialize internal VPP context based on Render ring earlier

Signed-off-by: Zhao Yakui --- src/gen75_picture_process.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gen75_picture_process.c b/src/gen75_picture_process.c index 0b681f1..95bbcd6 100644 --- a/src/gen75_picture_process.c +++ b/src/gen75_picture_process.c @@ -148,6 +148,12

[Libva] [PATCH 6/8] VPP select the appropriate fourcc for deferred surface based on expected format

Otherwise it still selects NV12 for 10-bit surfaces, which is wrong. Signed-off-by: Zhao Yakui --- src/gen75_picture_process.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gen75_picture_process.c b/src/gen75_picture_process.c index 95bbcd6..069088a 100644 --- a/src

[Libva] [PATCH 5/8] Initialize one 10bit-scaling gpe_context for Gen9

Signed-off-by: Zhao Yakui --- src/gen75_vpp_vebox.c | 2 + src/gen75_vpp_vebox.h | 1 - src/gen8_post_processing.c | 5 + src/gen8_post_processing.h | 9 + src/gen9_post_processing.c

Re: [Libva] [Libva-intel-driver][PATH] Add the missing filename to the list

On 11/10/2016 11:16 AM, Xiang, Haihao wrote: Otherwise the package created by 'make dist' doesn't include the missing file This looks good to me. Add: Reviewed-by: Zhao Yakui Thanks Yakui Signed-off-by: Xiang, Haihao --- test/Makefile.am | 1 + 1 file changed, 1 ins

Re: [Libva] How to implement a EGL or DRM display in VA-API driver

On 11/11/2016 12:02 PM, Randy Li wrote: On 11/11/2016 11:45 AM, Xiang, Haihao wrote: On Wed, 2016-11-02 at 19:32 +0800, Randy Li wrote: On 10/29/2016 04:09 AM, Sean V Kelley wrote: On Fri, 2016-10-28 at 10:05 +0800, Randy Li wrote: On 10/27/2016 11:03 PM, Xiang, Haihao wrote: gstreamer,

Re: [Libva] [PATCH 2/8] Add the 10-bit flag for MEDIA_BLOCK_RW operation on 10bit surface

On 11/11/2016 01:02 PM, Xiang, Haihao wrote: On Wed, 2016-11-09 at 14:39 -0500, Zhao Yakui wrote: Signed-off-by: Zhao Yakui --- src/i965_gpe_utils.c | 16 src/i965_gpe_utils.h | 1 + 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/i965_gpe_utils.c b/src

Re: [Libva] How to implement a EGL or DRM display in VA-API driver

On 11/11/2016 12:27 PM, Randy Li wrote: On 11/11/2016 12:31 PM, Zhao Yakui wrote: On 11/11/2016 12:02 PM, Randy Li wrote: On 11/11/2016 11:45 AM, Xiang, Haihao wrote: On Wed, 2016-11-02 at 19:32 +0800, Randy Li wrote: On 10/29/2016 04:09 AM, Sean V Kelley wrote: On Fri, 2016-10-28 at

Re: [Libva] [PATCH 4/8] Initialize internal VPP context based on Render ring earlier

On 11/11/2016 01:40 PM, Xiang, Haihao wrote: On Wed, 2016-11-09 at 14:39 -0500, Zhao Yakui wrote: Signed-off-by: Zhao Yakui --- src/gen75_picture_process.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gen75_picture_process.c b/src/gen75_picture_process.c index 0b681f1

  1   2   3   4   5   6   >