Re: [Libva] [PATCH intel-driver 0/2] Speed up jpeg encode tests

2016-10-17 Thread Sean V Kelley
On Mon, Oct 17, 2016 at 7:04 AM, Scott D Phillips wrote: > On Sun, Oct 16, 2016 at 09:20:49PM -0700, Xiang, Haihao wrote: >> >> Hi Scott, >> >> Does your patches change the pass criteria? I don't see any failure >> after applying your patches, but

Re: [Libva] [PATCH intel-driver 0/2] Speed up jpeg encode tests

2016-10-17 Thread Scott D Phillips
On Sun, Oct 16, 2016 at 09:20:49PM -0700, Xiang, Haihao wrote: > > Hi Scott, > > Does your patches change the pass criteria? I don't see any failure > after applying your patches, but Common/JPEGEncodeInputTest.Full/95 > should be failed if no change to pass criteria. It should not alter the

Re: [Libva] [PATCH intel-driver 0/2] Speed up jpeg encode tests

2016-10-16 Thread Xiang, Haihao
Hi Scott, Does your patches change the pass criteria? I don't see any failure after applying your patches, but Common/JPEGEncodeInputTest.Full/95 should be failed if no change to pass criteria. Thanks Haihao > For me these two patches take the Big encode test from 44sec to > ~7sec. > > Scott

Re: [Libva] [PATCH intel-driver 0/2] Speed up jpeg encode tests

2016-10-14 Thread Eoff, Ullysses A
Very nice speed improvement! I was not aware of std::valarray. I have one minor comment in the first patch. Other than that, LGTM. We don't have to do it now, but perhaps we could use a std::valarray as the underlying type for ::JPEG::Encode::TestInput::bytes to avoid some of the extra copies

[Libva] [PATCH intel-driver 0/2] Speed up jpeg encode tests

2016-10-14 Thread Scott D Phillips
For me these two patches take the Big encode test from 44sec to ~7sec. Scott D Phillips (2): test: use valarray for raw image comparison test: read jpeg test data from /dev/urandom test/i965_jpeg_encode_test.cpp | 29 + test/i965_jpeg_test_data.cpp | 6 +++---