On Tue, 2016-10-11 at 12:21 -0700, U. Artie Eoff wrote: > The driver does not require surfaces to create a context. > That is, i965_CreateContext can accept an empty render_targets > list. Thus, make Surfaces an optional parameter to > I965TestFixture::createContext so that simple tests don't > have to bother with Surfaces if they are irrelevant to > the test case.
lgtm, applied.
Thanks,
Sean
>
> Signed-off-by: U. Artie Eoff <ullysses.a.e...@intel.com>
> ---
> test/i965_test_fixture.cpp | 5 +++--
> test/i965_test_fixture.h | 3 ++-
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/test/i965_test_fixture.cpp b/test/i965_test_fixture.cpp
> index 8fd914209467..74403f875a56 100644
> --- a/test/i965_test_fixture.cpp
> +++ b/test/i965_test_fixture.cpp
> @@ -83,12 +83,13 @@ void I965TestFixture::destroyConfig(VAConfigID
> id)
> }
>
> VAContextID I965TestFixture::createContext(
> - VAConfigID config, int w, int h, int flags, Surfaces& targets)
> + VAConfigID config, int w, int h, int flags, const Surfaces&
> targets)
> {
> VAContextID id = VA_INVALID_ID;
> EXPECT_STATUS(
> i965_CreateContext(
> - *this, config, w, h, flags, targets.data(),
> targets.size(), &id));
> + *this, config, w, h, flags,
> + const_cast<VASurfaceID*>(targets.data()),
> targets.size(), &id));
> EXPECT_ID(id);
>
> return id;
> diff --git a/test/i965_test_fixture.h b/test/i965_test_fixture.h
> index 9122d848e129..3fc11c34fa75 100644
> --- a/test/i965_test_fixture.h
> +++ b/test/i965_test_fixture.h
> @@ -88,7 +88,8 @@ public:
> * Convenience wrapper for i965_CreateContext. May generate a
> non-fatal
> * test assertion failure.
> */
> - VAContextID createContext(VAConfigID, int, int, int, Surfaces&);
> + VAContextID createContext(VAConfigID, int, int, int = 0,
> + const Surfaces& = Surfaces());
>
> /**
> * Convenience wrapper for i965_DestroyContext. May generate a
> non-fatal
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Libva mailing list Libva@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libva
