Re: [Libvir] [PATCH] Fix the function that remove the element of the hash table.

2008-02-06 Thread Hiroyuki Kaguchi
Though this patch has not been applied yet, are there any problems in this patch? If there is no problem, could you apply this patch ? (2008/01/29 23:45), Daniel P. Berrange wrote: On Tue, Jan 29, 2008 at 11:32:04AM +0900, Hiroyuki Kaguchi wrote: There are two logic error and a unnecessary

Re: [Libvir] [PATCH] Fix the function that remove the element of the hash table.

2008-02-06 Thread Jim Meyering
Hiroyuki Kaguchi [EMAIL PROTECTED] wrote: Though this patch has not been applied yet, are there any problems in this patch? If there is no problem, could you apply this patch ? (2008/01/29 23:45), Daniel P. Berrange wrote: On Tue, Jan 29, 2008 at 11:32:04AM +0900, Hiroyuki Kaguchi wrote:

[PATCH] for MinGW Re: [Libvir] Pthreads error in windows compilation

2008-02-06 Thread Atsushi SAKAI
Hi,  Today I recognized. It would be better to write #include pthread.h in hash.h than hash.c. And compilation works if configure.in changes in MINGW? Would you apply this patch? Anyway virsh.exe works fine, but cannot compile testutils.c. Thanks Atsushi SAKAI Richard W.M. Jones [EMAIL

Re: [Libvir] Re: [PATCH] add missing qemudReportError

2008-02-06 Thread Guido Guenther
I just noticed that the patch got mangled, sorry: On Tue, Feb 05, 2008 at 01:09:15PM +0100, Guido Guenther wrote: That said it might also be worthwhile to not let libvirtd segfault because of a missing call to qemudReportError - this is debatable though: diff --git a/src/qemu_conf.c

[Libvir] Re: libvirt on mingw

2008-02-06 Thread Richard W.M. Jones
Brecht Sanders wrote: Hello again, Note that I am using gcc (mingw) 3.4.5, and not 4 as you recommend. The attached patch got rid of the warnings though. Maybe there is a compiler switch to fix it in a cleaner way though. Anyway, with the attached patch it does compile. Basically it casts to

Re: [Libvir] Re: libvirt on mingw

2008-02-06 Thread Richard W.M. Jones
Richard W.M. Jones wrote: Brecht Sanders wrote: Hello again, Note that I am using gcc (mingw) 3.4.5, and not 4 as you recommend. The attached patch got rid of the warnings though. Maybe there is a compiler switch to fix it in a cleaner way though. Anyway, with the attached patch it does

Re: [Libvir] Re: [PATCH] add missing qemudReportError

2008-02-06 Thread Daniel Veillard
On Wed, Feb 06, 2008 at 03:23:50PM +0100, Guido Guenther wrote: I just noticed that the patch got mangled, sorry: On Tue, Feb 05, 2008 at 01:09:15PM +0100, Guido Guenther wrote: That said it might also be worthwhile to not let libvirtd segfault because of a missing call to qemudReportError -

[Libvir] Re: libvirt for Python on Windows

2008-02-06 Thread Richard W.M. Jones
Brecht Sanders wrote: Hi Richard, I have finally compiled a libvirt Python module. Attached are the files that need to go into python 2.4 homelib/site-packages, in case you want to try this. How did you build _libvirtmod though? Rich. -- Emerging Technologies, Red Hat -

Re: [Libvir] don't use virBufferAdd with string literals

2008-02-06 Thread Daniel Veillard
On Tue, Feb 05, 2008 at 04:02:32PM +, Daniel P. Berrange wrote: On Mon, Feb 04, 2008 at 08:27:41PM +0100, Jim Meyering wrote: I noticed a little glitch here: src/xml.c: virBufferAdd(buf, (usbdevice tablet), 13); src/xml.c: virBufferAdd(buf, (usbdevice tablet), 18);

Re: [Libvir] [PATCH] change a Disk/Nic of inactive domain

2008-02-06 Thread Daniel Veillard
On Tue, Feb 05, 2008 at 04:00:14PM -0800, Ryan Scott wrote: Resurrecting a two-week old thread... Was a version of this patch ever committed? I don't see it, but I may have missed it. I used an earlier version of the patch to fix a problem we've noticed, but I would like to see the

Re: [Libvir] [PATCH] change a Disk/Nic of inactive domain

2008-02-06 Thread Richard W.M. Jones
Daniel Veillard wrote: On Tue, Feb 05, 2008 at 04:00:14PM -0800, Ryan Scott wrote: Resurrecting a two-week old thread... Was a version of this patch ever committed? I don't see it, but I may have missed it. I used an earlier version of the patch to fix a problem we've noticed, but I would

Re: [PATCH] for MinGW Re: [Libvir] Pthreads error in windows compilation

2008-02-06 Thread Daniel P. Berrange
On Wed, Feb 06, 2008 at 06:26:04PM +, Richard W.M. Jones wrote: Atsushi SAKAI wrote: Hi, ???Today I recognized. It would be better to write #include pthread.h in hash.h than hash.c. And compilation works if configure.in changes in MINGW? Would you apply this patch? I think actually

[Libvir] Re: libvirt for Python on Windows

2008-02-06 Thread Brecht Sanders
Aha, the big question. So far I only have loose notes, but basically it comes down to the instructions below. I used SWIG (http://www.swig.org/) to build the DLL of the Python module. My setup had Python 2.4 installed in C:\Prog\Python24. Of course the required C dependancies where also

[Libvir] python/libvir.c returning wrong value on error?

2008-02-06 Thread Cole Robinson
Hi all, Looking at python/libvir.c, all the custom functions return VIR_PY_NONE on error. This unfortunately doesn't map well to some of the generated python bindings which expect an error val of -1. So if these commands fail, no exception will be thrown at the python level. (Ex.

Re: [Libvir] python/libvir.c returning wrong value on error?

2008-02-06 Thread Cole Robinson
Daniel P. Berrange wrote: On Wed, Feb 06, 2008 at 03:18:13PM -0500, Cole Robinson wrote: Hi all, Looking at python/libvir.c, all the custom functions return VIR_PY_NONE on error. This unfortunately doesn't map well to some of the generated python bindings which expect an error val of -1. So

[Libvir] [patch 0/3] Fix some gcc 4.3.0 warnings

2008-02-06 Thread Mark McLoughlin
Hi, With gcc-4.3.0 (from Fedora rawhide), some new warnings are thrown up. The following three patches fixes them. The first two are straightforward, I think, but perhaps people might prefer to remove -Winline from our warning flags rather than apply the last patch. Cheers, Mark.

[Libvir] [patch 0/2] Fix two misc patches

2008-02-06 Thread Mark McLoughlin
Hi, Ignore this mail and look at the two following ... I can't figure out how to make quilt mail send one of these intro mails, even when sending a single patch :-) Cheers, Mark. -- -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[Libvir] [patch 1/2] Create directory for saving iptables rules

2008-02-06 Thread Mark McLoughlin
The patch which reworked the iptables rules saving accidently dropped the call to virFileMakePath() resulting in: Failed to saves iptables rules to /var/lib/libvirt/iptables/filter/INPUT.chain : No such file or directory Re-instate the virFileMakePath() call. Signed-off-by: Mark McLoughlin

[Libvir] [patch 2/2] Dont crash if theres no /sys/hypervisor/capabilities

2008-02-06 Thread Mark McLoughlin
xenHypervisorMakeCapabilitiesXML() can be called with either of it's FILE* paramaters NULL; don't crash when the capabilities pointer is NULL. Signed-off-by: Mark McLoughlin [EMAIL PROTECTED] Index: libvirt/src/xen_internal.c === ---

[Libvir] [Patch] Compilation cleanup

2008-02-06 Thread Atsushi SAKAI
Hi, This patch fixes following message in compilation. === xm_internal.h:64: warning: 'xenXMDomainAttachDevice' declared 'static' but never defined xm_internal.h:65: warning: 'xenXMDomainDetachDevice' declared 'static' but never defined === Signed-off-by: Atsushi SAKAI