Re: [libvirt] [PATCH] Fix enabling storage driver

2008-06-10 Thread Richard W.M. Jones
On Mon, Jun 09, 2008 at 03:14:14PM -0400, Cole Robinson wrote: As of a couple weeks ago, the storage driver is only registered if the WITH_LIBVIRTD macro is defined. The configure option --with-libvirtd actually wasn't defining this macro. The attached patch fixes this. Odd ... but yes +1.

Re: [libvirt] [PATCH] virDomainMemoryPeek - peek into guest memory

2008-06-10 Thread Richard W.M. Jones
On Mon, Jun 09, 2008 at 01:47:09PM +0100, Richard W.M. Jones wrote: Here's a patch which should address all concerns raised, although I left the VIR_MEMORY_VIRTUAL flag because I still think it's important to have it. Please note to whomever is maintaining libvirt in Fedora that there is

Re: [libvirt] [PATCH] virDomainMemoryPeek - peek into guest memory

2008-06-10 Thread Daniel P. Berrange
On Tue, Jun 10, 2008 at 09:39:44AM +0100, Richard W.M. Jones wrote: On Mon, Jun 09, 2008 at 01:47:09PM +0100, Richard W.M. Jones wrote: Here's a patch which should address all concerns raised, although I left the VIR_MEMORY_VIRTUAL flag because I still think it's important to have it.

Re: [libvirt] [PATCH] virDomainMemoryPeek - peek into guest memory

2008-06-10 Thread Daniel Veillard
On Tue, Jun 10, 2008 at 09:39:44AM +0100, Richard W.M. Jones wrote: On Mon, Jun 09, 2008 at 01:47:09PM +0100, Richard W.M. Jones wrote: Here's a patch which should address all concerns raised, although I left the VIR_MEMORY_VIRTUAL flag because I still think it's important to have it.

[libvirt] Release?

2008-06-10 Thread Richard W.M. Jones
I've just had a chat with Daniel about whether it's time for a new release of libvirt. My own primary focus is getting the virDomain*Peek APIs into a released version so I can use them from Fedora. libvirt 0.4.2 was released on 8th Apr 2008. I just scanned the changelog and there's a pretty

Re: [libvirt] Release?

2008-06-10 Thread Daniel Veillard
On Tue, Jun 10, 2008 at 12:40:50PM +0100, Richard W.M. Jones wrote: I've just had a chat with Daniel about whether it's time for a new release of libvirt. My own primary focus is getting the virDomain*Peek APIs into a released version so I can use them from Fedora. libvirt 0.4.2 was

Re: [libvirt] Release?

2008-06-10 Thread Stefan de Konink
Daniel Veillard schreef: On Tue, Jun 10, 2008 at 12:40:50PM +0100, Richard W.M. Jones wrote: I've just had a chat with Daniel about whether it's time for a new release of libvirt. My own primary focus is getting the virDomain*Peek APIs into a released version so I can use them from Fedora.

Re: [libvirt] Release?

2008-06-10 Thread Atsushi SAKAI
Hi, Rich Would you commit this patch? https://www.redhat.com/archives/libvir-list/2008-June/msg00031.html Other patches are minor issue, it may skip it. Thanks Atsushi SAKAI Richard W.M. Jones [EMAIL PROTECTED] wrote: I've just had a chat with Daniel about whether it's time for a new

Re: [libvirt] Release?

2008-06-10 Thread Richard W.M. Jones
On Tue, Jun 10, 2008 at 09:13:06PM +0900, Atsushi SAKAI wrote: Would you commit this patch? https://www.redhat.com/archives/libvir-list/2008-June/msg00031.html I'm not sure that I understand the use of this patch. Is this so that we can specify devices in /etc/xen files like 'phy:' or 'file:'

Re: [libvirt] Release?

2008-06-10 Thread Atsushi SAKAI
Hi, Rich Yes. When the user forget to add phy or file in VM image path, The error handled on libvirt previously without error message now. This patch change the VM image path error handling from libvirt to Xend. For this purpose, libvirt just pass VM image path without check. Xend reports error

Re: [libvirt] Release?

2008-06-10 Thread Richard W.M. Jones
On Tue, Jun 10, 2008 at 09:36:50PM +0900, Atsushi SAKAI wrote: When the user forget to add phy or file in VM image path, The error handled on libvirt previously without error message now. This patch change the VM image path error handling from libvirt to Xend. For this purpose, libvirt just

Re: [libvirt] Release?

2008-06-10 Thread Daniel P. Berrange
On Tue, Jun 10, 2008 at 02:12:29PM +0200, Stefan de Konink wrote: Daniel Veillard schreef: On Tue, Jun 10, 2008 at 12:40:50PM +0100, Richard W.M. Jones wrote: I've just had a chat with Daniel about whether it's time for a new release of libvirt. My own primary focus is getting the

Re: [libvirt] Release?

2008-06-10 Thread Daniel P. Berrange
On Tue, Jun 10, 2008 at 01:17:48PM +0100, Richard W.M. Jones wrote: On Tue, Jun 10, 2008 at 09:13:06PM +0900, Atsushi SAKAI wrote: Would you commit this patch? https://www.redhat.com/archives/libvir-list/2008-June/msg00031.html I'm not sure that I understand the use of this patch. Yes,

Re: [libvirt] Release?

2008-06-10 Thread Daniel P. Berrange
On Tue, Jun 10, 2008 at 02:14:34PM +0100, Richard W.M. Jones wrote: On Tue, Jun 10, 2008 at 09:36:50PM +0900, Atsushi SAKAI wrote: When the user forget to add phy or file in VM image path, The error handled on libvirt previously without error message now. This patch change the VM image

Re: [libvirt] Release?

2008-06-10 Thread Stefan de Konink
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Daniel P. Berrange schreef: No, this is not developed enough. It works fine with Xen, so 'not developed' might not be the right word. The only thing that you mentioned, reverse mapping the configuration, is not a trivial problem. But this doesn't

Re: [libvirt] Release?

2008-06-10 Thread Richard W.M. Jones
On Tue, Jun 10, 2008 at 02:56:56PM +0100, Daniel P. Berrange wrote: On Tue, Jun 10, 2008 at 01:17:48PM +0100, Richard W.M. Jones wrote: On Tue, Jun 10, 2008 at 09:13:06PM +0900, Atsushi SAKAI wrote: Would you commit this patch?

Re: [libvirt] Release?

2008-06-10 Thread Cole Robinson
Daniel Veillard wrote: On Tue, Jun 10, 2008 at 12:40:50PM +0100, Richard W.M. Jones wrote: So is it time for a release? Yes, I guess it makes sense :-) I will try to push a new release before the end of the week. Do we have patches pending which should be incorporated before ? I yes

Re: [libvirt] [PATCH] Fix UUIDString for python bindings

2008-06-10 Thread Daniel Veillard
On Thu, Jun 05, 2008 at 02:08:41PM -0400, Cole Robinson wrote: The attached patch fixes a few issues in the python bindings. First, UUIDString has, to my understanding, never worked. It expected to be passed a buffer to fill with the uuid, which through my tests isn't realistically doable

Re: [libvirt] [PATCH] Fix enabling storage driver

2008-06-10 Thread Daniel Veillard
On Tue, Jun 10, 2008 at 09:38:59AM +0100, Richard W.M. Jones wrote: On Mon, Jun 09, 2008 at 03:14:14PM -0400, Cole Robinson wrote: As of a couple weeks ago, the storage driver is only registered if the WITH_LIBVIRTD macro is defined. The configure option --with-libvirtd actually wasn't

Re: [libvirt] Release?

2008-06-10 Thread Daniel Veillard
On Tue, Jun 10, 2008 at 10:45:56AM -0400, Cole Robinson wrote: Daniel Veillard wrote: On Tue, Jun 10, 2008 at 12:40:50PM +0100, Richard W.M. Jones wrote: So is it time for a release? Yes, I guess it makes sense :-) I will try to push a new release before the end of the week. Do

Re: [libvirt] Release?

2008-06-10 Thread Cole Robinson
Daniel Veillard wrote: On Tue, Jun 10, 2008 at 10:45:56AM -0400, Cole Robinson wrote: Daniel Veillard wrote: On Tue, Jun 10, 2008 at 12:40:50PM +0100, Richard W.M. Jones wrote: So is it time for a release? Yes, I guess it makes sense :-) I will try to push a new release before the end of

[libvirt] [PATCH] Fix storage pool autostart python binding

2008-06-10 Thread Cole Robinson
The attached patch fixes a few issues with the storage api python bindings. The pool GetAutostart is now generated as intended. Also the libvirtError class now accepts the pool or vol object passed to it when a command fails. Thanks, Cole diff --git a/python/libvir.py b/python/libvir.py index