Re: [libvirt] Using Xen config files

2008-06-26 Thread Daniel Veillard
On Thu, Jun 26, 2008 at 12:06:04AM -0400, Thomas Moyer wrote: Is it possible to directly utilize the Xen config files when using the python bindings for libvirt? If not, is there any automated method of converting the Xen config to a libvirt XML config? If the config files are installed

[libvirt] [PATCH] fix_syntax_check

2008-06-26 Thread Atsushi SAKAI
Hi, Daniel I accidentally met the following error. Just changes tabs to spaces. xm_internal.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Thanks Atsushi SAKAI fix_syntax_check.patch Description: Binary data -- Libvir-list mailing list Libvir-list@redhat.com

Re: [libvirt] PATCH: Generic internal API for network XML parser/formatter

2008-06-26 Thread Daniel Veillard
On Tue, Jun 24, 2008 at 04:17:18PM +0100, Daniel P. Berrange wrote: We currently have two drivers which handle the networking XML containing duplicated parsers and formatters for the XML, and very similar structs. This patch introduces a new general purpose internal API for parsing and

Re: [libvirt] [PATCH 1 of 4] [LXC] Detect support for NETNS in lxc driver initialization

2008-06-26 Thread Daniel Veillard
On Tue, Jun 24, 2008 at 08:51:33AM -0700, Dan Smith wrote: Allow check for containers support to be done without CLONE_NEWNET, and then determine support on the fly by checking for iproute2 support and a successful clone(CLONE_NEWNET). This lets us set a flag for later, as well as not

Re: [libvirt] [PATCH 2 of 4] [LXC] Add functions to manage veth device pairs

2008-06-26 Thread Daniel Veillard
On Tue, Jun 24, 2008 at 08:51:34AM -0700, Dan Smith wrote: This gives us the ability to create a veth pair so that we can move one into the network namespace of an LXC container. Cool, thanks ! +1 Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard

Re: [libvirt] [PATCH 3 of 4] [LXC] Add XML parsing of container network interfaces

2008-06-26 Thread Daniel Veillard
On Tue, Jun 24, 2008 at 08:51:35AM -0700, Dan Smith wrote: Changes: - Throw an error after parsing if nets were specified and NETNS support is not present Fine by me [...] +error_out: +xmlFree(macaddr); +macaddr = NULL; +xmlFree(network); +network = NULL; +

Re: [libvirt] [PATCH 4 of 4] [LXC] Add setup/cleanup of container network interfaces

2008-06-26 Thread Daniel Veillard
On Tue, Jun 24, 2008 at 08:51:36AM -0700, Dan Smith wrote: Changes: - Remove extraneous i variables from various functions - Only bring up lo if we have other interfaces (and thus NETNS) - Fail setup of interfaces if NETNS support is not present - Only add CLONE_NEWNET to start flags if

Re: [libvirt] PATCH: Generic internal API for domain XML parser/formatter

2008-06-26 Thread Daniel Veillard
On Tue, Jun 24, 2008 at 04:34:11PM +0100, Daniel P. Berrange wrote: We currently have five drivers which handle the domain XML containing duplicated parsers and formatters for the XML with varying degrees of buginess, and often very similar structs. This patch introduces a new general purpose

Re: [libvirt] PATCH: 1/2: port Test driver to network APIs

2008-06-26 Thread Daniel Veillard
On Tue, Jun 24, 2008 at 04:59:18PM +0100, Daniel P. Berrange wrote: This patch ports the Test driver to use the network XML apis. Basically the 'struct _testNet' is removed, and replaced by usage of the generic virNetworkObjPtr and virNetworkDefPtr objects. The XML parser and formatters are

Re: [libvirt] PATCH: Generic internal API for network XML parser/formatter

2008-06-26 Thread Daniel P. Berrange
On Thu, Jun 26, 2008 at 08:36:46AM -0400, Daniel Veillard wrote: [...] +static virNetworkDefPtr +virNetworkDefParseXML(virConnectPtr conn, + xmlDocPtr xml) +{ +xmlNodePtr root = NULL; +xmlXPathContextPtr ctxt = NULL; +virNetworkDefPtr def; +

Re: [libvirt] PATCH: Generic internal API for domain XML parser/formatter

2008-06-26 Thread Daniel P. Berrange
On Thu, Jun 26, 2008 at 09:19:15AM -0400, Daniel Veillard wrote: On Tue, Jun 24, 2008 at 04:34:11PM +0100, Daniel P. Berrange wrote: We currently have five drivers which handle the domain XML containing duplicated parsers and formatters for the XML with varying degrees of buginess, and

Re: [libvirt] PATCH: 2/2: port Test driver to new domain APIs

2008-06-26 Thread Daniel Veillard
On Tue, Jun 24, 2008 at 05:03:16PM +0100, Daniel P. Berrange wrote: This patch ports the Test driver over to the domain XML apis. Basically the 'struct _testDom' is removed, and replaced by usage of the generic virDomainObjPtr and virDomainDefPtr objects. The XML parser and formatters are

Re: [libvirt] PATCH: 2/2: port Test driver to new domain APIs

2008-06-26 Thread Daniel P. Berrange
On Thu, Jun 26, 2008 at 09:57:08AM -0400, Daniel Veillard wrote: On Tue, Jun 24, 2008 at 05:03:16PM +0100, Daniel P. Berrange wrote: One thing i'm wondering is if we couldn't do single instance XML definitions for tests including the domains, network, etc... just reusing the new routines

Re: [libvirt] PATCH: Generic internal API for domain XML parser/formatter

2008-06-26 Thread Cole Robinson
Daniel P. Berrange wrote: Given an XML document describing a network, parses the doc and generates a virDomainDefPtr to represent it in memory. This is a little more advanced than the network parser because the various hypervisor drivers have slightly varying capabilities. So we pass a

Re: [libvirt] PATCH: Generic internal API for network XML parser/formatter

2008-06-26 Thread Daniel Veillard
On Thu, Jun 26, 2008 at 02:48:58PM +0100, Daniel P. Berrange wrote: On Thu, Jun 26, 2008 at 08:36:46AM -0400, Daniel Veillard wrote: [...] +static virNetworkDefPtr +virNetworkDefParseXML(virConnectPtr conn, + xmlDocPtr xml) +{ +xmlNodePtr root = NULL;

Re: [libvirt] PATCH: Generic internal API for domain XML parser/formatter

2008-06-26 Thread Daniel Veillard
On Thu, Jun 26, 2008 at 02:53:44PM +0100, Daniel P. Berrange wrote: On Thu, Jun 26, 2008 at 09:19:15AM -0400, Daniel Veillard wrote: On Tue, Jun 24, 2008 at 04:34:11PM +0100, Daniel P. Berrange wrote: We currently have five drivers which handle the domain XML containing duplicated parsers

Re: [libvirt] PATCH: 2/2: port Test driver to new domain APIs

2008-06-26 Thread Daniel Veillard
On Thu, Jun 26, 2008 at 02:59:37PM +0100, Daniel P. Berrange wrote: On Thu, Jun 26, 2008 at 09:57:08AM -0400, Daniel Veillard wrote: On Tue, Jun 24, 2008 at 05:03:16PM +0100, Daniel P. Berrange wrote: One thing i'm wondering is if we couldn't do single instance XML definitions for

Re: [libvirt] [PATCH] Change virsh list behavior

2008-06-26 Thread Daniel Veillard
On Wed, Jun 25, 2008 at 03:42:59PM -0700, Ryan Scott wrote: At the popular request of pretty much everyone in Sun who uses virsh... Change virsh list to list all domains, and add an --active flag to list only the active domains. But that breaks the behaviour for everybody and sounds a

Re: [libvirt] [PATCH] Change virsh list behavior

2008-06-26 Thread Daniel P. Berrange
On Thu, Jun 26, 2008 at 11:51:01AM -0400, Daniel Veillard wrote: On Wed, Jun 25, 2008 at 03:42:59PM -0700, Ryan Scott wrote: At the popular request of pretty much everyone in Sun who uses virsh... Change virsh list to list all domains, and add an --active flag to list only the active

[libvirt] [PATCH] fix compilation for MinGW (with LXC)

2008-06-26 Thread Atsushi SAKAI
Hello, Dan Smith May I commit this patch for MinGW compilation? veth.c is not necessary for MinGW. Thanks Atsushi SAKAI fix_compilation_on_mingw_with_lxc.patch Description: Binary data -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list