Re: [libvirt] some unsorted questions

2008-07-17 Thread Daniel Veillard
On Thu, Jul 17, 2008 at 01:29:45AM +0200, Stefan de Konink wrote: Now personally I think it is smart to check if a domain is already defined, or in use. If this is not the case libvirtd and the client get this message: libvir: Xen Daemon error : GET operation failed: That doesn't seem

Re: [libvirt] some unsorted questions

2008-07-17 Thread Daniel P. Berrange
On Thu, Jul 17, 2008 at 01:29:45AM +0200, Stefan de Konink wrote: Secondly; I am a bit distracted by the domids concept. These ids are not available before a domain is launched. I think it would be interesting to allow signed values. In this way the 'defined' not active domains would get a

Re: [libvirt] [PATCH] repeat lookup by name in LookupByID

2008-07-17 Thread Evgeniy Sokolov
Daniel Veillard пишет: On Wed, Jul 16, 2008 at 08:10:21PM +0100, Daniel P. Berrange wrote: Yes, the documentation is wrong - all inactive VMs have an ID of -1, and thus lookup-by-ID is nonsensical for inactive VMs. If any application did make use of this change which falls back to

Re: [libvirt] [PATCH] repeat lookup by name in LookupByID

2008-07-17 Thread Daniel P. Berrange
On Thu, Jul 17, 2008 at 01:20:59PM +0400, Evgeniy Sokolov wrote: Daniel Veillard ?: On Wed, Jul 16, 2008 at 08:10:21PM +0100, Daniel P. Berrange wrote: Yes, the documentation is wrong - all inactive VMs have an ID of -1, and thus lookup-by-ID is nonsensical for inactive VMs. If any

Re: [libvirt] some unsorted questions

2008-07-17 Thread Daniel P. Berrange
On Thu, Jul 17, 2008 at 01:29:45AM +0200, Stefan de Konink wrote: If this gets implemented I would suggest a call that fetches all domains from a running system and not only the defined or only the active ones. This is a good idea regardless. The current APIs require an application todo

[libvirt] [PATCH] remove unnecessary V = NULL; stmts after VIR_FREE(V)

2008-07-17 Thread Jim Meyering
Doing a review (in progress), I spotted one of these, so went in search of others. They're harmless, so this is more a heads up than anything else. I am happy to defer application until the patch queue has been reduced. From d97af7667699529c216835d806d1f0c6f698a70d Mon Sep 17 00:00:00 2001 From:

[libvirt] Re: [PATCH] remove unnecessary V = NULL; stmts after VIR_FREE(V)

2008-07-17 Thread Daniel P. Berrange
On Thu, Jul 17, 2008 at 12:11:13PM +0200, Jim Meyering wrote: Doing a review (in progress), I spotted one of these, so went in search of others. They're harmless, so this is more a heads up than anything else. I am happy to defer application until the patch queue has been reduced. From

[libvirt] [PATCH] cpu usage in OpenVZ

2008-07-17 Thread Evgeniy Sokolov
OpenVZ calculate statistics and allow to get them . Added function for getting cpu usage of container. Index: src/openvz_driver.c === RCS file: /data/cvs/libvirt/src/openvz_driver.c,v retrieving revision 1.31 diff -u -p -r1.31

Re: [libvirt] [PATCH] cpu usage in OpenVZ

2008-07-17 Thread Daniel P. Berrange
On Thu, Jul 17, 2008 at 03:04:46PM +0400, Evgeniy Sokolov wrote: OpenVZ calculate statistics and allow to get them . Added function for getting cpu usage of container. Modular some minor comments, ACK for this patch. +if (!openvzIsActiveVM(vm)) { +info-cpuTime = 0; +} else

Re: [libvirt] [PATCH] repeat lookup by name in LookupByID

2008-07-17 Thread Daniel Veillard
On Thu, Jul 17, 2008 at 10:30:19AM +0100, Daniel P. Berrange wrote: On Thu, Jul 17, 2008 at 01:20:59PM +0400, Evgeniy Sokolov wrote: Daniel Veillard ?: On Wed, Jul 16, 2008 at 08:10:21PM +0100, Daniel P. Berrange wrote: Yes, the documentation is wrong - all inactive VMs have an ID of

Re: [libvirt] [PATCH] Fix pool-create for netfs format 'auto'

2008-07-17 Thread Daniel P. Berrange
On Wed, Jul 16, 2008 at 01:30:33PM -0400, Cole Robinson wrote: Trying to pool-create a netfs pool with the format type 'auto' (as in, to autodetect the format) runs the command mount -t auto munged-source-path '-t auto' seems to do its job for regular file systems, but actually fails with

Re: [libvirt] some unsorted questions

2008-07-17 Thread Stefan de Konink
Daniel P. Berrange schreef: In the case of the Xen drivers, this requires O(n) calls to XenD which are rather expensive. XenD does actually have ability to return data about all domains in a single request. So if we had an API for fetching all domains at once it'd only require O(1) expensive

Re: [libvirt] some unsorted questions

2008-07-17 Thread Cole Robinson
Daniel P. Berrange wrote: On Thu, Jul 17, 2008 at 01:29:45AM +0200, Stefan de Konink wrote: If this gets implemented I would suggest a call that fetches all domains from a running system and not only the defined or only the active ones. This is a good idea regardless. The current APIs

Re: [libvirt] some unsorted questions

2008-07-17 Thread Daniel P. Berrange
On Thu, Jul 17, 2008 at 10:22:05AM -0400, Cole Robinson wrote: Daniel P. Berrange wrote: On Thu, Jul 17, 2008 at 01:29:45AM +0200, Stefan de Konink wrote: If this gets implemented I would suggest a call that fetches all domains from a running system and not only the defined or only the

Re: [libvirt] [PATCH] Fix pool-create for netfs format 'auto'

2008-07-17 Thread Chris Lalancette
Daniel P. Berrange wrote: ACK. I actually thought we'd fixed this already, since Chris came across it a while back.. I thought so too, but then I think I remember that I didn't actually change the code, just configured around it. In any case, this seems to be a good change to me too, so ACK.

[libvirt] RFC? finding potential storage pool resources

2008-07-17 Thread David Lively
Hi - I'm looking into using (which I think means extending) libvirt to enumerate potential storage pool resources, in particular: * existing physical disk device names (for creating disk pools) * existing logical volume group names (for creating logical pools) Note that

Re: [libvirt] RFC? finding potential storage pool resources

2008-07-17 Thread Daniel P. Berrange
On Thu, Jul 17, 2008 at 05:28:01PM -0400, David Lively wrote: Hi - I'm looking into using (which I think means extending) libvirt to enumerate potential storage pool resources, in particular: * existing physical disk device names (for creating disk pools) * existing logical volume

Re: [libvirt] [PATCH]: Add MIGRATE_LIVE definition to ruby-libvirt bindings

2008-07-17 Thread David Lutterkort
On Mon, 2008-07-07 at 17:28 +0200, Chris Lalancette wrote: Attached is a trivial patch to add the MIGRATE_LIVE flag into the ruby-libvirt bindings. Signed-off-by: Chris Lalancette [EMAIL PROTECTED] ACK .. Committed. (1) Do you need a new ruby-libvirt release for this ? (2) How far back has