Re: [libvirt] [PATCH]: qemu_driver: convert uuid to string in error messages

2008-07-25 Thread Guido Günther
On Fri, Jul 25, 2008 at 11:46:48AM -0400, Daniel Veillard wrote: > On Fri, Jul 25, 2008 at 09:56:27AM -0400, Guido Günther wrote: > > On Fri, Jul 25, 2008 at 05:02:43AM -0400, Daniel Veillard wrote: > > > On Fri, Jul 25, 2008 at 09:29:43AM +0100, Daniel P. Berrange wrote: > > > > On Thu, Jul 24, 20

[libvirt] [PATCH/RFC]: hostdev passthrough support

2008-07-25 Thread Guido Günther
Hi, attached is some basic support for host device passthrough. It enables you to passthrough usb devices in qemu/kvm via: I didn't implement unplug yet since this needs some modifications to qemu/kvm to be able to identify the correct device to unplug. Does this look reasonable? -- Guido

[libvirt] virsh

2008-07-25 Thread drew einhorn
Hi, I have virsh running in a remote ssh session in a dom0 xen VM, it is presenting a virtual console for a domU vm running a RHEL5 installer The RHEL5 is going astray setting up the network using DHCP, I want to do Ctrl-Alt-Fn to view the installer log files, and access a shell prompt. But the

Re: [libvirt] [PATCH] OpenVZ xml refactoring

2008-07-25 Thread Daniel P. Berrange
On Fri, Jul 25, 2008 at 04:44:09PM +0400, Evgeniy Sokolov wrote: > Patch switch OpenVZ XML format to generic. > main changes: > - I used generic virDomainNetDef to define network in container. > And wrote function to apply virDomainNetDef for container. > Method virDomainNetDefParseXML is publi

Re: [libvirt] [PATCH]: Utterly trivial comment cleanups in src/domain_conf.c

2008-07-25 Thread Daniel P. Berrange
On Fri, Jul 25, 2008 at 06:16:12PM +0200, Chris Lalancette wrote: > The subject pretty much says it all, except for the minor fact of using > "domain.xml" in the xmlReadDoc(). This cleanup really just makes the code > easier to read. > > Signed-off-by: Chris Lalancette <[EMAIL PROTECTED]> Thanks

Re: [libvirt] [PATCH]: Utterly trivial comment cleanups in src/domain_conf.c

2008-07-25 Thread Daniel Veillard
On Fri, Jul 25, 2008 at 06:16:12PM +0200, Chris Lalancette wrote: > The subject pretty much says it all, except for the minor fact of using > "domain.xml" in the xmlReadDoc(). This cleanup really just makes the code > easier to read. > > Signed-off-by: Chris Lalancette <[EMAIL PROTECTED]> Look

Re: [libvirt] [PATCH] OpenVZ xml refactoring

2008-07-25 Thread Daniel Veillard
On Fri, Jul 25, 2008 at 04:44:09PM +0400, Evgeniy Sokolov wrote: > Patch switch OpenVZ XML format to generic. > main changes: > - I used generic virDomainNetDef to define network in container. > And wrote function to apply virDomainNetDef for container. > Method virDomainNetDefParseXML is publi

[libvirt] [PATCH]: Utterly trivial comment cleanups in src/domain_conf.c

2008-07-25 Thread Chris Lalancette
The subject pretty much says it all, except for the minor fact of using "domain.xml" in the xmlReadDoc(). This cleanup really just makes the code easier to read. Signed-off-by: Chris Lalancette <[EMAIL PROTECTED]> Index: src/domain_conf.c ==

Re: [libvirt] [PATCH]: qemu_driver: convert uuid to string in error messages

2008-07-25 Thread Daniel Veillard
On Fri, Jul 25, 2008 at 09:56:27AM -0400, Guido Günther wrote: > On Fri, Jul 25, 2008 at 05:02:43AM -0400, Daniel Veillard wrote: > > On Fri, Jul 25, 2008 at 09:29:43AM +0100, Daniel P. Berrange wrote: > > > On Thu, Jul 24, 2008 at 03:52:32PM -0400, Guido G?nther wrote: > > > > Hi, > > > > qemu_dri

Re: [libvirt] [PATCH]: qemu_driver: convert uuid to string in error messages

2008-07-25 Thread Guido Günther
On Fri, Jul 25, 2008 at 05:02:43AM -0400, Daniel Veillard wrote: > On Fri, Jul 25, 2008 at 09:29:43AM +0100, Daniel P. Berrange wrote: > > On Thu, Jul 24, 2008 at 03:52:32PM -0400, Guido G?nther wrote: > > > Hi, > > > qemu_driver misses some conversions to a char* before printing the uuid. > > > Po

[libvirt] [PATCH] OpenVZ xml refactoring

2008-07-25 Thread Evgeniy Sokolov
Patch switch OpenVZ XML format to generic. main changes: - I used generic virDomainNetDef to define network in container. And wrote function to apply virDomainNetDef for container. Method virDomainNetDefParseXML is public now. - tag "container" is changed to "devices" - changed format of tag "

Re: [libvirt] PATCH: 12/14: Convert XM driver XML formatter to generic API

2008-07-25 Thread Daniel P. Berrange
On Thu, Jul 24, 2008 at 11:53:48AM -0400, Daniel Veillard wrote: > > > -hvm > > +hvm > > Hum the previous patch was changing things the way around ... > > > > > -/usr/lib/xen/bin/qemu-dm > > > > and removing the extra emulator Yes were indeed both bugs - I'm fixing th

Re: [libvirt] PATCH: 11/14: Change XM driver in-memory objects

2008-07-25 Thread Daniel P. Berrange
On Thu, Jul 24, 2008 at 10:44:18AM -0400, Daniel Veillard wrote: > On Tue, Jul 08, 2008 at 05:40:17PM +0100, Daniel P. Berrange wrote: > > This is a refactoring of the XM driver. Previously we would store > > the virConfPtr objects as our master 'in memory' representation > > of inactive domains. T

Re: [libvirt] Problems when using libvirt-cim provider

2008-07-25 Thread Atsushi SAKAI
Hi, You should discussed on following list. https://www.redhat.com/mailman/listinfo/libvirt-cim/ Thanks Atsushi SAKAI "SHAN, CHUN -HCHBJ" <[EMAIL PROTECTED]> wrote: > Hi,all: > > I am trying to use libvirt API and libvirt-cim now. After installed them > successfully, I can see the "Vi

Re: [libvirt] Problems when using libvirt-cim provider

2008-07-25 Thread Daniel Veillard
On Fri, Jul 25, 2008 at 05:04:36PM +0800, SHAN, CHUN -HCHBJ wrote: > Hi,all: > > I am trying to use libvirt API and libvirt-cim now. After installed them > successfully, I can see the "Virt_*" providers using "cimprovider -l > -s"commond. My cimom is pegasus. > > Then I used wb

[libvirt] Problems when using libvirt-cim provider

2008-07-25 Thread SHAN, CHUN -HCHBJ
Hi,all: I am trying to use libvirt API and libvirt-cim now. After installed them successfully, I can see the "Virt_*" providers using "cimprovider -l -s"commond. My cimom is pegasus. Then I used wbemcli as cim client. But when I used "wbemcli ei" to enumerate instances of a sp

Re: [libvirt] PATCH Remove unused openvz code

2008-07-25 Thread Daniel Veillard
On Thu, Jul 24, 2008 at 11:48:42AM +0100, Daniel P. Berrange wrote: > > The openvz driver currrently generates a compile warning due to this > unused function. If no one objects I'll shortly remove it. Sure fine ! > I intend to turn on openvz and LXC driver compilation for the nightly > builds

Re: [libvirt] Couple qemu driver bugs after xml refactoring

2008-07-25 Thread Daniel Veillard
On Thu, Jul 24, 2008 at 09:39:36AM +0100, Daniel P. Berrange wrote: > On Tue, Jul 22, 2008 at 05:23:00PM +0100, Daniel P. Berrange wrote: > > On Tue, Jul 22, 2008 at 04:53:19PM +0100, Daniel P. Berrange wrote: > > > There was a good reason for removing the 127.0.0.1 from the XML parsing > > > stage

Re: [libvirt] Double free in test driver error handling (0.4.4)

2008-07-25 Thread Daniel Veillard
On Thu, Jul 24, 2008 at 09:41:10AM +0100, Daniel P. Berrange wrote: > On Mon, Jul 21, 2008 at 07:03:29PM +0200, T?th Istv?n wrote: > > While debugging the libvirt-java error handling problem, Ive found that > > if I call the test driver with a bad uri, the application instantly > > bombs with a >

Re: [libvirt] [PATCH]: qemu_driver: convert uuid to string in error messages

2008-07-25 Thread Daniel Veillard
On Fri, Jul 25, 2008 at 09:29:43AM +0100, Daniel P. Berrange wrote: > On Thu, Jul 24, 2008 at 03:52:32PM -0400, Guido G?nther wrote: > > Hi, > > qemu_driver misses some conversions to a char* before printing the uuid. > > Possible fix attached. > > ACK, surprised that the printf() format checks do

Re: [libvirt] [PATCH]: libvirt.h: very xen centric

2008-07-25 Thread Daniel Veillard
On Thu, Jul 24, 2008 at 03:50:32PM -0400, Guido Günther wrote: > Hi, > while reading through that I noticed libvirt.h is quiet xen centric. > Purely cosmetic patch attached, > -- Guido Good catch, remains from the very early days, blame me :-) Note that libvirt.h is generated so the patch reall

Re: [libvirt] [PATCH] qemudOpenMonitor: fix open(2) error check

2008-07-25 Thread Daniel Veillard
On Thu, Jul 24, 2008 at 03:48:47PM -0400, Guido Günther wrote: > Hi, > open returns -1 on failure. Pointed out by Guido Trotter on: > > http://bugs.debian.org/492250 > > Patch against current CVS attached. Hum, good catch, I checked for other occurences of this mistake but everywhere else we u

Re: [libvirt] [PATCH] qemudOpenMonitor: fix open(2) error check

2008-07-25 Thread Daniel P. Berrange
On Thu, Jul 24, 2008 at 03:48:47PM -0400, Guido G?nther wrote: > Hi, > open returns -1 on failure. Pointed out by Guido Trotter on: Opps, very embarrassing bug :-) ACK Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-

Re: [libvirt] [PATCH]: libvirt.h: very xen centric

2008-07-25 Thread Daniel P. Berrange
On Thu, Jul 24, 2008 at 03:50:32PM -0400, Guido G?nther wrote: > Hi, > while reading through that I noticed libvirt.h is quiet xen centric. > Purely cosmetic patch attached, ACK Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- ht

Re: [libvirt] [PATCH]: qemu_driver: convert uuid to string in error messages

2008-07-25 Thread Daniel P. Berrange
On Thu, Jul 24, 2008 at 03:52:32PM -0400, Guido G?nther wrote: > Hi, > qemu_driver misses some conversions to a char* before printing the uuid. > Possible fix attached. ACK, surprised that the printf() format checks don't complain about passing an unsigned char to a %s format in GCC. This is actu