Re: [libvirt] [PATCH] openvz: swap source bridge=... with target dev=...

2008-10-02 Thread Anton Protopopov
Hi. I rewrite functions taken from vzctl in the new patch, so this: Here is the patch, that implements the following behaviour * interface name inside container is automatically generated and equals ethN, where N is the number of that interface within current domain * mac address of

Re: [libvirt] [PATCH 1 of 2] Add internal cgroup manipulation functions

2008-10-02 Thread Daniel P. Berrange
On Wed, Oct 01, 2008 at 11:10:33PM +0100, Daniel P. Berrange wrote: On Wed, Oct 01, 2008 at 02:11:24PM -0700, Dan Smith wrote: DB Rather than rely on this virt type string - virt type is not DB adding enough uniqueness - can still have a (virttype, name) clash DB between 2 libvirt drivers.

Re: [libvirt] libvirt-qpid

2008-10-02 Thread Daniel Veillard
On Wed, Sep 24, 2008 at 10:55:36AM -0700, Ian Main wrote: Howdy folks! Okay i started playing with this a bit, so a few hints and feedback The source code repo: http://git.et.redhat.com/?p=libvirt-qpid.git;a=summary So I'd like to hear any feedback you guys might have. This file in

Re: [libvirt] libvirt-qpid

2008-10-02 Thread Daniel P. Berrange
On Thu, Oct 02, 2008 at 03:06:01PM +0200, Daniel Veillard wrote: On Wed, Sep 24, 2008 at 10:55:36AM -0700, Ian Main wrote: Howdy folks! If you wish to try it out, I've made rpms for fedora 9 x86_64 and i386. They are in the ovirt repo, which you can add to yum using: rpm -ivh

Re: [libvirt] libvirt-qpid

2008-10-02 Thread Ian Main
On Wed, 1 Oct 2008 11:36:24 +0100 Daniel P. Berrange [EMAIL PROTECTED] wrote: On Wed, Oct 01, 2008 at 11:10:41AM +0100, Daniel P. Berrange wrote: On Wed, Sep 24, 2008 at 10:55:36AM -0700, Ian Main wrote: - Make it less chatty, but log stuff Configurable use of syslog() would be a good

Re: [libvirt] libvirt-qpid

2008-10-02 Thread Daniel Veillard
On Thu, Oct 02, 2008 at 03:40:06PM +0100, Daniel P. Berrange wrote: On Thu, Oct 02, 2008 at 03:06:01PM +0200, Daniel Veillard wrote: You also need 'yum install qpidd' I suspect this indicates a missing dependancy maybe in the libvirt-qpid package but I'm not 100% sure Yeah, i believe

Re: [libvirt] libvirt-qpid

2008-10-02 Thread Daniel P. Berrange
On Wed, Oct 01, 2008 at 02:55:57PM -0700, Ian Main wrote: On Wed, 1 Oct 2008 11:36:24 +0100 Daniel P. Berrange [EMAIL PROTECTED] wrote: On Wed, Oct 01, 2008 at 11:10:41AM +0100, Daniel P. Berrange wrote: On Wed, Sep 24, 2008 at 10:55:36AM -0700, Ian Main wrote: - Make it less chatty,

Re: [libvirt] libvirt-qpid

2008-10-02 Thread Ian Main
On Wed, 1 Oct 2008 11:10:41 +0100 Daniel P. Berrange [EMAIL PROTECTED] wrote: On Wed, Sep 24, 2008 at 10:55:36AM -0700, Ian Main wrote: So I've been working on a qpid interface to libvirt. Here's the description I've come up with: libvirt-qpid provides an interface with libvirt

Re: [libvirt] libvirt-qpid

2008-10-02 Thread Ian Main
On Thu, 2 Oct 2008 16:50:08 +0200 Daniel Veillard [EMAIL PROTECTED] wrote: On Thu, Oct 02, 2008 at 03:40:06PM +0100, Daniel P. Berrange wrote: On Thu, Oct 02, 2008 at 03:06:01PM +0200, Daniel Veillard wrote: You also need 'yum install qpidd' I suspect this indicates a missing

Re: [libvirt] libvirt-qpid

2008-10-02 Thread Daniel Veillard
On Thu, Oct 02, 2008 at 08:16:02AM -0700, Ian Main wrote: On Thu, 2 Oct 2008 16:50:08 +0200 Daniel Veillard [EMAIL PROTECTED] wrote: On Thu, Oct 02, 2008 at 03:40:06PM +0100, Daniel P. Berrange wrote: On Thu, Oct 02, 2008 at 03:06:01PM +0200, Daniel Veillard wrote: You also need

[libvirt] PATCH: Support SDL configuration for QEMU driver

2008-10-02 Thread Daniel P. Berrange
QEMU has two modes of providing a graphical display, VNC and SDL. Now most of our tools just use VNC, but occasionally people want to use SDL for some crazy reason. We already support this in Xen driver, but the QEMU impl has been rather lacking. At the moment if you ask for a SDL display it'll

Re: [libvirt] PATCH: Support SDL configuration for QEMU driver

2008-10-02 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: ... Now previously since we just use 'execv' the QEMU process would just inherit all libvirtd's environment variables. When we now use execve() no variables are inherited - we have to explicitly set all the ones we need. I'm not sure what we should

Re: [libvirt] [PATCH] Fix 1 char device for qemu VM

2008-10-02 Thread Cole Robinson
Daniel Veillard wrote: On Mon, Sep 29, 2008 at 12:48:30PM -0400, Cole Robinson wrote: Cole Robinson wrote: Trying to start a qemu guest with more than 1 character device (serial or parallel, doesn't count for console) always times out. There was an error in the code that would strip the pty

[libvirt] [PATCH] Centralize use of DEBUG macros

2008-10-02 Thread Cole Robinson
Currently the DEBUG and DEBUG0 macros are duplicated in every file that uses them. This patch moves the macros to internal.h, removes the needless duplication, and now every file gets them for free. Seems to work as expected in my testing. Thanks, Cole commit

[libvirt] [PATCH] Clean up some uses qemudDebug

2008-10-02 Thread Cole Robinson
The patch cleans up some uses of qemudDebug, moving them over to use the DEBUG macros. There are still lots of uses of qemudDebug in qemud/*, but I don't know if they can/should be moved over to use DEBUG. Thanks, Cole commit 99c6268b660f00eb906d936248df83348befa5ab Author: Cole Robinson [EMAIL

[libvirt] [PATCH] Unify *ReportError logic

2008-10-02 Thread Cole Robinson
Currently, most src/* files have their own ReportError function. Some support printf style arguments, others only allow reporting a single string message. The code for all of them does virtually the same thing, possibly passing a different constant off to another function. The attached patch adds

Re: [libvirt] [PATCH] Unify *ReportError logic

2008-10-02 Thread Daniel P. Berrange
On Thu, Oct 02, 2008 at 03:41:21PM -0400, Cole Robinson wrote: Currently, most src/* files have their own ReportError function. Some support printf style arguments, others only allow reporting a single string message. The code for all of them does virtually the same thing, possibly passing a

[libvirt] [PATCH] qemu: fix block stats for virtio and scsi

2008-10-02 Thread Guido Günther
Hi, qemudDomainBlockStats needs to map between qemu and libvirt device naming as well. Possible patch attached. Cheers, -- Guido From 57b8c8e66abfcc57c2f05d8b8364de6ecc05dcf9 Mon Sep 17 00:00:00 2001 From: Guido Guenther [EMAIL PROTECTED] Date: Thu, 2 Oct 2008 21:12:20 +0200 Subject: [PATCH]

Re: [libvirt] [PATCH] qemu: fix block stats for virtio and scsi

2008-10-02 Thread Daniel P. Berrange
On Thu, Oct 02, 2008 at 09:56:51PM +0200, Guido G?nther wrote: Hi, qemudDomainBlockStats needs to map between qemu and libvirt device naming as well. Possible patch attached. Cheers, -- Guido From 57b8c8e66abfcc57c2f05d8b8364de6ecc05dcf9 Mon Sep 17 00:00:00 2001 From: Guido Guenther

Re: [libvirt] [PATCH] Unify *ReportError logic

2008-10-02 Thread Cole Robinson
Daniel P. Berrange wrote: On Thu, Oct 02, 2008 at 03:41:21PM -0400, Cole Robinson wrote: Currently, most src/* files have their own ReportError function. Some support printf style arguments, others only allow reporting a single string message. The code for all of them does virtually the same

Re: [libvirt] [PATCH] qemu: fix block stats for virtio and scsi

2008-10-02 Thread Guido Günther
On Thu, Oct 02, 2008 at 09:06:25PM +0100, Daniel P. Berrange wrote: I think this needs to use the virDiskNameToIndex() method to extract the index instead. Corrected pach attached. I don't know how devices are called when using xenner so I left that out. -- Guido From

[libvirt] [PATCH] Fix possible segfault if starting qemu vm with an inactive virtual network

2008-10-02 Thread Cole Robinson
The attached patch fixes a possible segfault if trying to start a domain which tries to use an inactive virtual network. We should explicitly catch that error and report it, but that's a separate patch. Thanks, Cole commit eca87f821890c7d54f2ba57288acad1b234ec13e Author: Cole Robinson [EMAIL