Re: [libvirt] Re: [PATCH 01/12] Domain Events - Public API

2008-10-22 Thread Daniel Veillard
On Tue, Oct 21, 2008 at 03:11:08PM -0400, Ben Guthro wrote: [PATCH 01/12] Domain Events - Public API This patch does the following: -implements the Event register/deregister code -Adds some callback lists, and queue functions used by drivers -Move EventImpl definitions into the

[libvirt] Re: [RFC] sVirt v0.10 - initial prototype

2008-10-22 Thread James Morris
On Tue, 21 Oct 2008, Daniel P. Berrange wrote: I should note that the domain XML format is representative of the config for a particular deployment of a virtual machine onto a host. It is not a generic interchange format for 'appliances'. If you were distributing an appliance, then the

[libvirt] Re: [RFC] sVirt v0.10 - initial prototype

2008-10-22 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 01:50:20PM -0400, Daniel J Walsh wrote: Daniel P. Berrange wrote: On Tue, Oct 21, 2008 at 09:57:15AM -0400, Daniel J Walsh wrote: James Morris wrote: I think the 'policytype' bit of the label may thus better live in the host capabilities XML document, so you can

[libvirt] Re: [RFC] sVirt v0.10 - initial prototype

2008-10-22 Thread James Morris
On Tue, 21 Oct 2008, Daniel J Walsh wrote: Why do we care about the policy type? Policy type is a fairly meaningless object. If you are trying to figure out if the host machine is valid to run a virtual machine you should just check whether the type is valid on the machine, That way if I

[libvirt] Re: [RFC] sVirt v0.10 - initial prototype

2008-10-22 Thread James Morris
On Tue, 21 Oct 2008, Daniel P. Berrange wrote: As I mentioned in my reply to Dan Walsh's comments, I thing that the policy type its state (disabled, permissive, enforcing) is really a property of the host, rather than the VM, and so should live in the host capabilities XML document. I think

[libvirt] Re: [RFC] sVirt v0.10 - initial prototype

2008-10-22 Thread Daniel P. Berrange
On Wed, Oct 22, 2008 at 08:50:19PM +1100, James Morris wrote: On Tue, 21 Oct 2008, Daniel P. Berrange wrote: I should note that the domain XML format is representative of the config for a particular deployment of a virtual machine onto a host. It is not a generic interchange format

[libvirt] Re: [RFC] sVirt v0.10 - initial prototype

2008-10-22 Thread James Morris
On Wed, 22 Oct 2008, Daniel P. Berrange wrote: I think to start with we probably just assume a single security labelling model per hypervisor connection. If a single host happened to have multiple models, I believe each model would likely be scoped to a specific hypervisor on the host. I

Re: [libvirt] [PATCH 00/12] Domain Events - Round 3

2008-10-22 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 03:40:45PM -0400, Ben Guthro wrote: Apologies about the duplicate 00, 01, and 02 emails. My email seems to be acting up, and I didn't see those patches come through...so I resent those 3 Then they arrived in pairs. That's usually the fault of the mailman server

Re: [libvirt] errors building rpm

2008-10-22 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 04:39:36PM -0400, Ben Guthro wrote: I keep getting the following error when trying to build via a 'sudo make rpm' on the tip of the tree + /usr/lib/rpm/find-lang.sh /var/tmp/libvirt-0.4.6-1.fc9-root libvirt No translations found for libvirt in

Re: [libvirt] Re: [PATCH 01/12] Domain Events - Public API

2008-10-22 Thread Ben Guthro
Daniel Veillard wrote on 10/22/2008 05:14 AM: thanks for the changes! I think the prototypes are good to go, maybe a couple tiny changes but I can make them myself based on the 'make rebuild' output in the doc directory functions in src/libvirt.c still need arguments checkings however, but

Re: [libvirt] errors building rpm

2008-10-22 Thread Cole Robinson
Daniel P. Berrange wrote: On Tue, Oct 21, 2008 at 04:39:36PM -0400, Ben Guthro wrote: I keep getting the following error when trying to build via a 'sudo make rpm' on the tip of the tree + /usr/lib/rpm/find-lang.sh /var/tmp/libvirt-0.4.6-1.fc9-root libvirt No translations found for libvirt

Re: [libvirt] errors building rpm

2008-10-22 Thread Ben Guthro
This looks like it fixed the problem for me, as well Thanks! +1 Cole Robinson wrote on 10/22/2008 09:31 AM: Daniel P. Berrange wrote: On Tue, Oct 21, 2008 at 04:39:36PM -0400, Ben Guthro wrote: I keep getting the following error when trying to build via a 'sudo make rpm' on the tip of the

Re: [libvirt] errors building rpm

2008-10-22 Thread Daniel Veillard
On Wed, Oct 22, 2008 at 09:31:58AM -0400, Cole Robinson wrote: Daniel P. Berrange wrote: On Tue, Oct 21, 2008 at 04:39:36PM -0400, Ben Guthro wrote: I keep getting the following error when trying to build via a 'sudo make rpm' on the tip of the tree + /usr/lib/rpm/find-lang.sh

Re: [libvirt] errors building rpm

2008-10-22 Thread Jim Meyering
Cole Robinson [EMAIL PROTECTED] wrote: Daniel P. Berrange wrote: On Tue, Oct 21, 2008 at 04:39:36PM -0400, Ben Guthro wrote: I keep getting the following error when trying to build via a 'sudo make rpm' on the tip of the tree + /usr/lib/rpm/find-lang.sh /var/tmp/libvirt-0.4.6-1.fc9-root

Re: [libvirt] errors building rpm

2008-10-22 Thread Cole Robinson
Jim Meyering wrote: Cole Robinson [EMAIL PROTECTED] wrote: Daniel P. Berrange wrote: On Tue, Oct 21, 2008 at 04:39:36PM -0400, Ben Guthro wrote: I keep getting the following error when trying to build via a 'sudo make rpm' on the tip of the tree + /usr/lib/rpm/find-lang.sh

[libvirt] [PATCH]: Add default pool types

2008-10-22 Thread Chris Lalancette
As suggested by danpb, to fix up the regression caused by last week's VIR_ENUM cleanup patch, add a .defaultFormat member to .poolOptions. In storage_conf.c, if virXPathString(/pool/source/format/@type) returns NULL, then set the pool type to .defaultFormat; otherwise, lookup the type via

Re: [libvirt] [PATCH]: Add default pool types

2008-10-22 Thread Cole Robinson
Chris Lalancette wrote: As suggested by danpb, to fix up the regression caused by last week's VIR_ENUM cleanup patch, add a .defaultFormat member to .poolOptions. In storage_conf.c, if virXPathString(/pool/source/format/@type) returns NULL, then set the pool type to .defaultFormat;

Re: [libvirt] Re: [PATCH 01/12] Domain Events - Public API

2008-10-22 Thread Daniel Veillard
On Wed, Oct 22, 2008 at 09:17:28AM -0400, Ben Guthro wrote: Daniel Veillard wrote on 10/22/2008 05:14 AM: thanks for the changes! I think the prototypes are good to go, maybe a couple tiny changes but I can make them myself based on the 'make rebuild' output in the doc directory

[libvirt] [PATCH] Add storage API support to test driver

2008-10-22 Thread Cole Robinson
The attached patch implements the storage driver routines for the test driver. Most of the code is identical to storage_driver.c with all the references to backends removed. One caveat of this is that storage pools are hardcoded to a specific size when they are defined: I figure someone could

Re: [libvirt] Re: [PATCH 6/6] host (node) device enumeration - python bindings

2008-10-22 Thread David Lively
Ok, here are proper python bindings to the node device enumeration functions and objects. diff --git a/python/generator.py b/python/generator.py index c706b19..0186e6e 100755 --- a/python/generator.py +++ b/python/generator.py @@ -258,6 +258,11 @@ py_types = { 'const virConnectPtr': ('O',

Re: [libvirt] image locking?

2008-10-22 Thread Guido Günther
On Tue, Oct 21, 2008 at 12:16:01PM -0700, Itamar Heim wrote: While this might work for SBC (although most enterprises have the datacenter on remote sites as well, so not always that easy). I don't think the solution is viable for CBC though (I am not sure CBC would use iSCSI, probably NFS is

Re: [libvirt] image locking?

2008-10-22 Thread Daniel P. Berrange
On Wed, Oct 22, 2008 at 10:21:38PM +0200, Guido G?nther wrote: On Tue, Oct 21, 2008 at 12:16:01PM -0700, Itamar Heim wrote: While this might work for SBC (although most enterprises have the datacenter on remote sites as well, so not always that easy). I don't think the solution is viable