Re: [libvirt] [PATCH] Allow changing ejectable device in domains using default qemu emulator

2008-10-23 Thread Cole Robinson
Stuart Jansen wrote: > When a qemu domain is launched but an emulator is not explicitly > defined, the default emulator is used. Attempts to attach ejectable > devices to a domains using the default emulator fail with the error: > "Error Connecting CDROM: internal error\nCannot determine QEMU argv

[libvirt] Re: [PATCH 0/6] host ("node") device enumeration, take two

2008-10-23 Thread David Lively
On Thu, 2008-10-23 at 13:53 +0100, Daniel P. Berrange wrote: > On Tue, Oct 21, 2008 at 01:45:47PM -0400, David Lively wrote: > > * using newfangled array-based lists for NodeDeviceObj's > > The individual capabilities within a device are still using a linked list, > though that's not a critical

[libvirt] [PATCH] Allow changing ejectable device in domains using default qemu emulator

2008-10-23 Thread Stuart Jansen
When a qemu domain is launched but an emulator is not explicitly defined, the default emulator is used. Attempts to attach ejectable devices to a domains using the default emulator fail with the error: "Error Connecting CDROM: internal error\nCannot determine QEMU argv syntax (null)". The followin

Re: [libvirt] hourly cvs snapshot broken

2008-10-23 Thread Daniel Veillard
On Wed, Oct 22, 2008 at 05:11:54PM -0600, Stuart Jansen wrote: > Now sure where to report this. Looks like that hourly CVS snapshot > haven't been working for more than a month. > > If hourly snapshots are no longer being created, the Web site should > probably be update. > > http://libvirt.org/d

Re: [libvirt] [PATCH/RFC] qemu/kvm: allow to hot remove scsi/virtio disks

2008-10-23 Thread Guido Günther
Hi Daniel, On Tue, Oct 21, 2008 at 03:25:25PM +0200, Daniel Veillard wrote: [..snip..] > Those are just stylistic issues, I can apply the patch with those > changed if you wish if you don't have time for a new patch, Thanks for your comments. Updated version attached. I basically removed the u

[libvirt] hourly cvs snapshot broken

2008-10-23 Thread Stuart Jansen
Now sure where to report this. Looks like that hourly CVS snapshot haven't been working for more than a month. If hourly snapshots are no longer being created, the Web site should probably be update. http://libvirt.org/downloads.html -- Libvir-list mailing list Libvir-list@redhat.com https://ww

Re: [libvirt] [PATCH 00/12] Domain Events : DONE !

2008-10-23 Thread Daniel P. Berrange
On Thu, Oct 23, 2008 at 09:40:36AM -0400, Ben Guthro wrote: > > Again congratulations ! I think this also means the next release > > will be a 0.5.0 since this is a major API addition. I still looking > > at the other pending patches though, it would be better to have them > > in the next relea

Re: [libvirt] [PATCH 00/12] Domain Events : DONE !

2008-10-23 Thread Ben Guthro
Also - Additional work is needed in the hypervisor drivers other than qemu to properly emit domain events. My initial patch submission included some code designed to add, and monitor xenstore watches. It would be nice to get this integrated, as well. Ben Guthro wrote on 10/23/2008 09:40 AM:

Re: [libvirt] [PATCH 00/12] Domain Events : DONE !

2008-10-23 Thread Ben Guthro
> Again congratulations ! I think this also means the next release > will be a 0.5.0 since this is a major API addition. I still looking > at the other pending patches though, it would be better to have them > in the next release ... oh and I want your java bindings and we need > Python too (a

Re: [libvirt] [PATCH] fix mingw compilation warning

2008-10-23 Thread Daniel Veillard
On Thu, Oct 23, 2008 at 01:59:21PM +0200, Jim Meyering wrote: > Building for mingw, I got this warning: > > libvirt.c:242: warning: control reaches end of non-void function > > Here's the fix: > > fix mingw compilation warning > * src/libvirt.c (winsock_init) [HAVE_WINSOCK2_H]: Alway

Re: [libvirt] [PATCH 00/12] Domain Events : DONE !

2008-10-23 Thread Daniel Veillard
On Tue, Oct 21, 2008 at 03:10:15PM -0400, Ben Guthro wrote: > The following patch series implements the Events API discussed here > previously in this thread: Okay, I commited the set of patches to CVS, congratulations (also added you to the AUTHORS list as a result) ! I made the changes that

[libvirt] Re: [PATCH 0/6] host ("node") device enumeration, take two

2008-10-23 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 01:45:47PM -0400, David Lively wrote: > Ok, here's my substantially-reworked node device enumeration patch, this > time done with a proper understanding of the public-obj/Obj/Def > model :-) as last discussed here: > https://www.redhat.com/archives/libvir-list/2008-September

[libvirt] Re: [RFC] sVirt v0.10 - initial prototype

2008-10-23 Thread Paul Moore
On Wednesday 22 October 2008 5:23:45 am James Morris wrote: > On Tue, 21 Oct 2008, Daniel J Walsh wrote: > > Why do we care about the policy type? Policy type is a fairly > > meaningless object. If you are trying to figure out if the host > > machine is valid to run a virtual machine you should j

Re: [libvirt] [PATCH] fix mingw compilation warning

2008-10-23 Thread Daniel P. Berrange
On Thu, Oct 23, 2008 at 01:59:21PM +0200, Jim Meyering wrote: > Building for mingw, I got this warning: > > libvirt.c:242: warning: control reaches end of non-void function > > Here's the fix: > > fix mingw compilation warning > * src/libvirt.c (winsock_init) [HAVE_WINSOCK2_H]: Alway

[libvirt] [PATCH] fix mingw compilation warning

2008-10-23 Thread Jim Meyering
Building for mingw, I got this warning: libvirt.c:242: warning: control reaches end of non-void function Here's the fix: fix mingw compilation warning * src/libvirt.c (winsock_init) [HAVE_WINSOCK2_H]: Always return a value. diff --git a/src/libvirt.c b/src/libvirt.c index ca2675a..0

Re: [libvirt] [PATCH]: Export during logical pool discovery

2008-10-23 Thread Chris Lalancette
Chris Lalancette wrote: > Attached is an updated patch for adding tags to logical > findPoolSources. Given danpb's last feedback, I completely removed the XML > parsing and did it all with structures. The result should (hopefully) be a > lot > easier on the eyes, and is a little more generic.

Re: [libvirt] [PATCH]: Add default pool types

2008-10-23 Thread Chris Lalancette
Chris Lalancette wrote: > As suggested by danpb, to fix up the regression caused by last week's VIR_ENUM > cleanup patch, add a ".defaultFormat" member to .poolOptions. In > storage_conf.c, if virXPathString(/pool/source/format/@type) returns NULL, > then > set the pool type to .defaultFormat; ot

Re: [libvirt] Re: [PATCH 11/12] Domain Events - test harness

2008-10-23 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 03:20:19PM -0400, Ben Guthro wrote: > [PATCH 11/12] Domain Events - test harness > Test app, and infrastructure changes for an example dir ACK. > diff --git a/examples/domain-events/events-c/Makefile.am > b/examples/domain-events/events-c/Makefile.am > new file mode 10064

Re: [libvirt] Re: [PATCH 10/12] Domain Events - test driver

2008-10-23 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 03:19:56PM -0400, Ben Guthro wrote: > [PATCH 10/12] Domain Events - test driver > Minor changes to test driver structure to prevent compile errors ACK Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http:

Re: [libvirt] Re: [PATCH 09/12] Domain Events - openvz driver

2008-10-23 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 03:17:18PM -0400, Ben Guthro wrote: > [PATCH 09/12] Domain Events - openvz driver > Minor changes to openvz driver structure to prevent compile errors ACK Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- h

Re: [libvirt] Re: [PATCH 08/12] Domain Events - lxc driver

2008-10-23 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 03:16:50PM -0400, Ben Guthro wrote: > [PATCH 08/12] Domain Events - lxc driver > Minor changes to LXC driver structure to prevent compile errors ACK Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://

Re: [libvirt] Re: [PATCH 07/12] Domain Events - remote driver

2008-10-23 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 03:16:20PM -0400, Ben Guthro wrote: > [PATCH 07/12] Domain Events - remote driver > Deliver local callbacks in response to remote events > > remote_internal.c | 276 > +- > 1 file changed, 271 insertions(+), 5 deletions

Re: [libvirt] Re: [PATCH 06/12] Domain Events - qemu driver

2008-10-23 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 03:15:47PM -0400, Ben Guthro wrote: > [PATCH 06/12] Domain Events - qemu driver > Register for, and dispatch domain event callbacks > > qemu_conf.h |3 + > qemu_driver.c | 101 > +- > 2 files changed, 97 inser

Re: [libvirt] Re: [PATCH 05/12] Domain Events - Driver API

2008-10-23 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 03:15:19PM -0400, Ben Guthro wrote: > [PATCH 05/12] Domain Events - Driver API > Additions to the driver API ACK Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt

Re: [libvirt] Re: [PATCH 04/12] Domain Events - rpc changes

2008-10-23 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 03:14:49PM -0400, Ben Guthro wrote: > [PATCH 04/12] Domain Events - rpc changes > Changes to the RPC protocol > > remote_dispatch_localvars.h |3 +++ > remote_dispatch_proc_switch.h | 18 ++ > remote_dispatch_prototypes.h |3 +++ > remote_proto

Re: [libvirt] Re: [PATCH 03/12] Domain Events - daemon changes

2008-10-23 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 03:12:52PM -0400, Ben Guthro wrote: > [PATCH 03/12] Domain Events - daemon changes > This code changes the daemaon to: > use the pulic def of virEventRegisterImpl > Add functionality to dispatch events to connected remote drivers > > event.c | 21 + > event.

Re: [libvirt] Re: [PATCH 02/12] Domain Events - Internal API

2008-10-23 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 03:11:36PM -0400, Ben Guthro wrote: > [PATCH 02/12] Domain Events - Internal API > This patch >-Removes EventImpl from being a private function >-Introduces the virDomainEventCallbackListPtr, and virDomainEventQueuePtr > objects > diff --git a/src/event.c b/src/eve

Re: [libvirt] Re: [PATCH 01/12] Domain Events - Public API

2008-10-23 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 03:11:08PM -0400, Ben Guthro wrote: > [PATCH 01/12] Domain Events - Public API > > This patch does the following: >-implements the Event register/deregister code >-Adds some callback lists, and queue functions used by drivers >-Move EventImpl definitions into th

Re: [libvirt] [PATCH 1/2] adapt to API change in gnulib

2008-10-23 Thread Daniel P. Berrange
On Thu, Oct 23, 2008 at 12:12:45PM +0200, Jim Meyering wrote: > This is actually two changes sets. > The first part is an update from gnulib (including the fix for API change), > the second adjusts .cvsignore files (sorting at same time) > so that "git status" is clean after you run "make sync-vcs-

[libvirt] [PATCH 1/2] adapt to API change in gnulib

2008-10-23 Thread Jim Meyering
This is actually two changes sets. The first part is an update from gnulib (including the fix for API change), the second adjusts .cvsignore files (sorting at same time) so that "git status" is clean after you run "make sync-vcs-ignore-files" to generate all .gitignore files. For reference, the co

Re: [libvirt] [PATCH]: Add default pool types

2008-10-23 Thread Daniel P. Berrange
On Wed, Oct 22, 2008 at 04:06:47PM +0200, Chris Lalancette wrote: > As suggested by danpb, to fix up the regression caused by last week's VIR_ENUM > cleanup patch, add a ".defaultFormat" member to .poolOptions. In > storage_conf.c, if virXPathString(/pool/source/format/@type) returns NULL, > then

[libvirt] [PATCH]: Implement ruby-libvirt storage pool discovery binding

2008-10-23 Thread Chris Lalancette
Attached is a pretty simple patch to implement the virConnectFindStoragePoolSources() binding for ruby-libvirt.This capability went into libvirt-0.4.5, so any version of libvirt that has storage API support should have support for this call. There's not much more to say; it works in my testing, an

[libvirt] [PATCH]: Update ruby-libvirt migrate binding to use rb_scan_args

2008-10-23 Thread Chris Lalancette
It's really not a good idea to hand parse variable number of args to a ruby binding, like I implemented for the "migrate" method. Convert this to use rb_scan_args, which is the proper way to do it, and matches all of the other variable argument implementations in the binding. Signed-off-by: Chris

Re: [libvirt] [PATCH]: Export during logical pool discovery

2008-10-23 Thread Daniel P. Berrange
On Thu, Oct 23, 2008 at 09:05:24AM +0200, Chris Lalancette wrote: > Attached is an updated patch for adding tags to logical > findPoolSources. Given danpb's last feedback, I completely removed the XML > parsing and did it all with structures. The result should (hopefully) be a > lot > easier on

Re: [libvirt] Problem in running libvirt-cim test suite

2008-10-23 Thread Daniel P. Berrange
On Thu, Oct 23, 2008 at 11:39:31AM +0530, srinivas k wrote: > Hi, > > I trying to install libvirt-cim in my ubuntu-xen-3.2.1 machine. I am able to > install all dependencies and libvirt-cim , but when I run cimtest which has > given in libvirt.org, I am getting following error message >* Star

[libvirt] [PATCH]: Export during logical pool discovery

2008-10-23 Thread Chris Lalancette
Attached is an updated patch for adding tags to logical findPoolSources. Given danpb's last feedback, I completely removed the XML parsing and did it all with structures. The result should (hopefully) be a lot easier on the eyes, and is a little more generic. Signed-off-by: Chris Lalancette <[E