Re: [libvirt] [PATCH] Parse ipaddr for bridge network types

2009-01-22 Thread Jim Meyering
john.le...@sun.com wrote: Parse ipaddr for bridge network types As well as supporting round-tripping of the IP address, this fixes a leak if ipaddr was specified in the Xen domain config. diff --git a/src/domain_conf.c b/src/domain_conf.c At first glance it looks fine. I do appreciate the

Re: [libvirt] [PATCH] Remove non-existent symbol from linker script

2009-01-22 Thread Daniel P. Berrange
On Wed, Jan 21, 2009 at 01:42:24PM -0800, john.le...@sun.com wrote: # HG changeset patch # User john.le...@sun.com # Date 1232574142 28800 # Node ID 0a35ce4ac7e0cf83df188dea0fc37818b4c39d48 # Parent fc06d88e4140cebc9d0b7795019c0c2741c3f8a9 Remove non-existent symbol from linker script

Re: [libvirt] [PATCH] Add a rule for generating .hgignore

2009-01-22 Thread Daniel P. Berrange
On Wed, Jan 21, 2009 at 02:17:46PM -0800, john.le...@sun.com wrote: # HG changeset patch # User john.le...@sun.com # Date 1232576262 28800 # Node ID c58822f94b2b5e87a363128a4bd36ec2846054fe # Parent c109dd0801246b82aed8d5f9b1fa4196432868d0 Add a rule for generating .hgignore

Re: [libvirt] [PATCH] Add a rule for generating .hgignore

2009-01-22 Thread Daniel P. Berrange
On Thu, Jan 22, 2009 at 08:31:46AM +0100, Jim Meyering wrote: john.le...@sun.com wrote: Add a rule for generating .hgignore diff --git a/Makefile.maint b/Makefile.maint --- a/Makefile.maint +++ b/Makefile.maint @@ -717,3 +717,5 @@ sync-vcs-ignore-files: mv $(c2g)-t $(c2g)

Re: [libvirt] PATCH: 19/25: Remove use of non-threadsafe POSIX apis

2009-01-22 Thread Daniel P. Berrange
On Fri, Jan 16, 2009 at 12:25:02PM +, Daniel P. Berrange wrote: On Fri, Jan 16, 2009 at 12:21:59PM +, Richard W.M. Jones wrote: On Tue, Jan 13, 2009 at 05:46:37PM +, Daniel P. Berrange wrote: +char buf[1024]; sysconf (_SC_GETPW_R_SIZE_MAX)? Looking at glibc's

Re: [libvirt] [PATCH] Solaris least privilege support

2009-01-22 Thread Daniel P. Berrange
On Tue, Jan 20, 2009 at 11:13:38AM -0800, john.le...@sun.com wrote: # HG changeset patch # User john.le...@sun.com # Date 1232478815 28800 # Node ID 9c7ef175f3a797ecc3ffa6b1fed5a27d1814838c # Parent ce76623e857f5bb2cf3af8414335f891fd7902b7 Solaris least privilege support On Solaris dom0,

Re: [libvirt] [PATCH] Support script setting for bridge-type interfaces

2009-01-22 Thread Daniel P. Berrange
On Wed, Jan 21, 2009 at 10:35:22AM -0800, john.le...@sun.com wrote: # HG changeset patch # User john.le...@sun.com # Date 1232562793 28800 # Node ID e0b0295722ecf4645983e3a9a090e0aaabc40da7 # Parent ce10bb67bbcee1a49b900e260a65ccfb1b69588b Support script setting for bridge-type interfaces

Re: [libvirt] PATCH: 19/25: Remove use of non-threadsafe POSIX apis

2009-01-22 Thread Richard W.M. Jones
On Thu, Jan 22, 2009 at 10:48:59AM +, Daniel P. Berrange wrote: On Fri, Jan 16, 2009 at 12:25:02PM +, Daniel P. Berrange wrote: On Fri, Jan 16, 2009 at 12:21:59PM +, Richard W.M. Jones wrote: On Tue, Jan 13, 2009 at 05:46:37PM +, Daniel P. Berrange wrote: +char

Re: [libvirt] RE: Re: kvm-81: save / restore does not work - missing incoming stdio feature

2009-01-22 Thread Richard W.M. Jones
On Thu, Jan 22, 2009 at 12:10:51PM +, Daniel P. Berrange wrote: On Mon, Jan 19, 2009 at 01:01:15PM +, Daniel P. Berrange wrote: On Mon, Jan 19, 2009 at 01:53:48PM +0100, Daniel Schwager wrote: Hi Daniel, Charles Duffy (thanks Charles !) told me how to fix libvirt for using

Re: [libvirt] setting up dnsmasq options for PXE boot

2009-01-22 Thread Richard W.M. Jones
On Tue, Jan 20, 2009 at 02:05:26PM +0300, Dmitry Guryanov wrote: But for working PXE boot it should have also something like --dhcp-boot=pxelinux.0,itchy,192.168.107.1 This isn't supported by libvirt at the moment, but it would great to have a patch which enabled this. PXE-booting using

Re: [libvirt] PATCH: 19/25: Remove use of non-threadsafe POSIX apis

2009-01-22 Thread Daniel P. Berrange
On Thu, Jan 22, 2009 at 10:48:59AM +, Daniel P. Berrange wrote: On Fri, Jan 16, 2009 at 12:25:02PM +, Daniel P. Berrange wrote: On Fri, Jan 16, 2009 at 12:21:59PM +, Richard W.M. Jones wrote: On Tue, Jan 13, 2009 at 05:46:37PM +, Daniel P. Berrange wrote: +char

Re: [libvirt] setting up dnsmasq options for PXE boot

2009-01-22 Thread Daniel P. Berrange
On Thu, Jan 22, 2009 at 03:12:39PM +, Richard W.M. Jones wrote: On Tue, Jan 20, 2009 at 02:05:26PM +0300, Dmitry Guryanov wrote: But for working PXE boot it should have also something like --dhcp-boot=pxelinux.0,itchy,192.168.107.1 This isn't supported by libvirt at the moment, but it

Re: [libvirt] PATCH: Add RNG schemas for capabilities, storage and node device XML

2009-01-22 Thread Richard W.M. Jones
On Wed, Jan 21, 2009 at 04:31:36PM +, Daniel P. Berrange wrote: We currently only have RNG schemas for the domain XML and network XML. This patch adds more RNG schemas covering the host capabilities XML, the storage pool and storage volume XML and node device XML In addition it sets up

Re: [libvirt] PATCH: 19/25: Remove use of non-threadsafe POSIX apis

2009-01-22 Thread Daniel P. Berrange
On Thu, Jan 22, 2009 at 04:21:25PM +0100, Jim Meyering wrote: Daniel P. Berrange berra...@redhat.com wrote: On Fri, Jan 16, 2009 at 12:25:02PM +, Daniel P. Berrange wrote: On Fri, Jan 16, 2009 at 12:21:59PM +, Richard W.M. Jones wrote: On Tue, Jan 13, 2009 at 05:46:37PM +,

Re: [libvirt] PATCH: 19/25: Remove use of non-threadsafe POSIX apis

2009-01-22 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: One problem in virGetUserDirectory. It always returns NULL. Yep, already fixed that. And did you mean to include the TCP socket changes in this set? Yes, its require to remove the use of non-threadsafe gethostname() call In that case, ACK.

Re: [libvirt] PATCH: Support setting QEMU disk driver type

2009-01-22 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: The domain XML has long supported ability to set the disk driver type but we only used it in Xen so far. This patch adds support for QEMU usage. In this usage the driver name is always going to be 'qemu' since all backends are in QEMU, no

Re: [libvirt] PATCH: Add RNG schemas for capabilities, storage and node device XML

2009-01-22 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: We currently only have RNG schemas for the domain XML and network XML. This patch adds more RNG schemas covering the host capabilities XML, the storage pool and storage volume XML and node device XML In addition it sets up the makefile to install

[libvirt] Probs connecting QEMU hypervisor with URL ?

2009-01-22 Thread Daniel Schwager
Hi, i tried to use virt-viewer to connect to a remote machine running libvirt kvm-qemu at FC9 - but it failed. So, I run virsh without the URL directly on FC9, it works (e.g. virsh list). If I use a connection URL, it failed. Did I miss something ? regards Danny [r...@xxx03 ~]#

Re: [libvirt] [PATCH] Remove non-existent symbol from linker script

2009-01-22 Thread John Levon
On Thu, Jan 22, 2009 at 10:08:54AM +, Daniel P. Berrange wrote: virNetworkRemoveInactive; -virNetworkSaveConfigXML; Actually this is a typo - it should be virNetworkSaveXML I thought that when I read your patch, but virNetworkSaveXML isn't used outside of network_conf.c, so I think

Re: [libvirt] PATCH: Support storage copy on write volumes

2009-01-22 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: This is a follow up on Miloslav's proposal to add copy on write support to the storage APIs, changing the XML to that described here: http://www.redhat.com/archives/libvir-list/2009-January/msg00231.html In addition to the original QCOW/VMDK

Re: [libvirt] [PATCH] Add a rule for generating .hgignore

2009-01-22 Thread John Levon
On Thu, Jan 22, 2009 at 08:31:46AM +0100, Jim Meyering wrote: There are a couple of problems when doing it that way: OK, try this version. regards, john Add a rule for generating .hgignore Also regenerate, and fix a missing entry. Signed-off-by: John Levon john.le...@sun.com diff --git

Re: [libvirt] [PATCH] Add a rule for generating .hgignore

2009-01-22 Thread Daniel P. Berrange
On Thu, Jan 22, 2009 at 06:19:32PM +, John Levon wrote: On Thu, Jan 22, 2009 at 08:31:46AM +0100, Jim Meyering wrote: There are a couple of problems when doing it that way: OK, try this version. regards, john Add a rule for generating .hgignore Also regenerate, and fix a

Re: [libvirt] [PATCH] Remove non-existent symbol from linker script

2009-01-22 Thread Daniel P. Berrange
On Thu, Jan 22, 2009 at 05:22:03PM +, John Levon wrote: On Thu, Jan 22, 2009 at 10:08:54AM +, Daniel P. Berrange wrote: virNetworkRemoveInactive; -virNetworkSaveConfigXML; Actually this is a typo - it should be virNetworkSaveXML I thought that when I read your patch, but

[libvirt] [PATCH] xm_internal.c: fix locking bug: s/Unlock/Lock/

2009-01-22 Thread Jim Meyering
Merge error? I'll commit this in an hour or so. From e660e3353b468cb219208a1aba9f8eca456467dd Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Thu, 22 Jan 2009 20:08:55 +0100 Subject: [PATCH] xm_internal.c: fix locking bug: s/Unlock/Lock/ * src/xm_internal.c

Re: [libvirt] [PATCH] xm_internal.c: fix locking bug: s/Unlock/Lock/

2009-01-22 Thread Jim Meyering
Jim Meyering j...@meyering.net wrote: Merge error? I'll commit this in an hour or so. With a corrected title: s/Lock/Unlock/ ... -xenUnifiedLock(priv); +xenUnifiedUnlock(priv); -- Libvir-list mailing list Libvir-list@redhat.com

Re: [libvirt] [PATCH] xm_internal.c: fix locking bug: s/Unlock/Lock/

2009-01-22 Thread Daniel P. Berrange
On Thu, Jan 22, 2009 at 08:09:51PM +0100, Jim Meyering wrote: Merge error? I'll commit this in an hour or so. Go for it - how did you notice it ? Just luck ? This is why I want to get my previous CIL locking test program integrated into the 'make check' somehow - or at least a separate 'make

Re: [libvirt] [PATCH] xm_internal.c: fix locking bug: s/Unlock/Lock/

2009-01-22 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: On Thu, Jan 22, 2009 at 08:09:51PM +0100, Jim Meyering wrote: Merge error? I'll commit this in an hour or so. Go for it - how did you notice it ? Just luck ? Ha! I wish. I noticed it while resolving conflicts induced as I've merged your initial

[libvirt] RE: Probs connecting QEMU hypervisor with URL ?

2009-01-22 Thread Daniel Schwager
One more - i tried do debug this problem with the debug-enviroment variable - it seems like libvirt can't connect the qemu hypervisor ... Hmm, in xen-enviroment, there's a xend daemon running - but in qemu-enviroment ? There's no separate daemon qemud or similar running ... so, again's which

Re: [libvirt] [PATCH] Parse ipaddr for bridge network types

2009-01-22 Thread Jim Meyering
John Levon john.le...@sun.com wrote: On Thu, Jan 22, 2009 at 08:59:53AM +0100, Jim Meyering wrote: At first glance it looks fine. I do appreciate the accompanying tests. However, ... Please rebase and repost. I believe it's dependent on the bridge script patch. Do you want me to commit

Re: [libvirt] RFC: configuring host interfaces with libvirt

2009-01-22 Thread Jim Fehlig
Adding Marius (SuSE sysconfig maintainer) in case I'm misspeaking :-) David Lutterkort wrote: On Tue, 2009-01-20 at 11:35 -0700, Jim Fehlig wrote: David Lutterkort wrote: For certain applications, we want libvirt to be able to configure host network interfaces in a variety of ways;

[libvirt] [PATCH] Fix recursive lock in xenstore driver

2009-01-22 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1232675291 28800 # Node ID 903a29e99c80a35ce7f4754a3bcc3ab34bf32d8a # Parent b83af161640c69b1de279547b270b8acb101152e Fix recursive lock in xenstore driver The watch handlers take the driver lock, so must use an internalized version of

[libvirt] [PATCH] Quieten virsh schedinfo for shutoff domain

2009-01-22 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1232675291 28800 # Node ID 3ef027308b88b47b2f3ca721bf88f2e606d8e3bc # Parent 903a29e99c80a35ce7f4754a3bcc3ab34bf32d8a Quieten virsh schedinfo for shutoff domain Quietly return failure for a shutoff domain in the sched params driver routines.

[libvirt] [PATCH] xend driver: handle new-format sched-credit options

2009-01-22 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1232675291 28800 # Node ID ad7f82da983cc0ba07f7f4e94a2f23a4edc3be57 # Parent 3ef027308b88b47b2f3ca721bf88f2e606d8e3bc xend driver: handle new-format sched-credit options Signed-off-by: John Levon john.le...@sun.com diff --git

[libvirt] OpenNebula driver, libvirt-0.5.1

2009-01-22 Thread Abel Míguez Rodríguez
Dear all, We have ready the OpenNebula driver implementation for libvirt 0.5.1, making use of all the features we were requested to. Attached are the driver sources and the patches intended to be applied to libvirt-0.5.1, obtained from git revision 0e490f: ---Changelog revision 0e490f:Mon Jan 19