[libvirt] [PATCH] gnulib/tests: allow test-getaddrinfo to pass when offline

2009-01-26 Thread Mark McLoughlin
Sometimes - yes, even in the latter part of the first decade of the twenty first century - one doesn't have access to the Internet while one is hacking. Signed-off-by: Mark McLoughlin mar...@redhat.com --- gnulib/tests/test-getaddrinfo.c |5 + 1 files changed, 5 insertions(+), 0

[libvirt] [Patch][RFC] Fine grained access control in libvirt by rbac (0/3)

2009-01-26 Thread Syunsuke HAYASHI
The series of patches introduces a fine grained access control to libvirt. They enable libvirt to enforce users what operations to invoke in role-based way. Our team found that Konrad and Daniel have similar interest to ours. Comments and suggestions are very welcome. Patches: - Embedding

[libvirt] [Patch][RFC] Example policy files (3/3)

2009-01-26 Thread Syunsuke HAYASHI
The policy checker employs two files. Role_definition.xml defines what and how VMs a role is allowed to operate. User_definition.xml defines what roles are available to a user. Operations are currently represented by numbers. They are defined in src/xr_internal.h in libvirt part, though it is

[libvirt] [PATCH] kvm/virtio: Set IFF_VNET_HDR when setting up tap fds

2009-01-26 Thread Mark McLoughlin
IFF_VNET_HDR is a tun/tap flag that allows you to send and receive large (i.e. GSO) packets and packets with partial checksums. Setting the flag means that every packet is proceeded by the same header which virtio uses to communicate GSO/csum metadata. By enabling this flag on the tap fds we

Re: [libvirt] [PATCH] xm_internal.c: fix locking bug: s/Unlock/Lock/

2009-01-26 Thread Richard W.M. Jones
On Thu, Jan 22, 2009 at 07:13:47PM +, Daniel P. Berrange wrote: On Thu, Jan 22, 2009 at 08:09:51PM +0100, Jim Meyering wrote: Merge error? I'll commit this in an hour or so. Go for it - how did you notice it ? Just luck ? This is why I want to get my previous CIL locking test

Re: [libvirt] [PATCH] Quieten virsh schedinfo for shutoff domain

2009-01-26 Thread Richard W.M. Jones
On Thu, Jan 22, 2009 at 05:49:12PM -0800, john.le...@sun.com wrote: +/* + * If it's not running, we can't help. + */ +if (domain-id 0) +return NULL; NACK. Unfortunately you shouldn't return from a function without setting an error (and you have to set an error

Re: [libvirt] [PATCH] Fix virsh sched-credit for xend

2009-01-26 Thread Richard W.M. Jones
On Fri, Jan 23, 2009 at 10:34:14AM +, Daniel P. Berrange wrote: On Thu, Jan 22, 2009 at 05:49:00PM -0800, john.le...@sun.com wrote: # HG changeset patch # User john.le...@sun.com # Date 1232675291 28800 # Node ID 415bfd87e0ecd7751ed6df372e82da0e3991d617 # Parent

Re: [libvirt] [PATCH] qemud: don't dereference NULL on failed virGetUserDirectory

2009-01-26 Thread Richard W.M. Jones
On Fri, Jan 23, 2009 at 02:23:14PM +0100, Jim Meyering wrote: Jim Meyering j...@meyering.net wrote: I spotted this while merging my unix_sock_dir changes: ... char *userdir = virGetUserDirectory(NULL, uid); +if (userdir == NULL) { +/* give no diagnostic here;

Re: [libvirt] [PATCH] trivial libvirt example code

2009-01-26 Thread Richard W.M. Jones
On Fri, Jan 23, 2009 at 02:51:02PM -0500, Dave Allan wrote: The examples directory doesn't have a trivial example of how to connect to a hypervisor, make a few calls, and disconnect, so I put one together. I would appreciate any suggestions on anything that I've done wrong as well as

Re: [libvirt] libvirt-0.5.1: problems connecting qemu:///system

2009-01-26 Thread Richard W.M. Jones
On Sun, Jan 25, 2009 at 02:21:07PM +0100, Nikola Ciprich wrote: When I run libvirtd -f /etc/libvirt/libvirtd.conf -v -l and try to connect, I get: Can you set LIBVIRT_DEBUG=1 at both the client and server ends. Rich. -- Richard Jones, Emerging Technologies, Red Hat

Re: [libvirt] [PATCH] gnulib/tests: allow test-getaddrinfo to pass when offline

2009-01-26 Thread Richard W.M. Jones
On Mon, Jan 26, 2009 at 08:30:27AM +, Mark McLoughlin wrote: Sometimes - yes, even in the latter part of the first decade of the twenty first century - one doesn't have access to the Internet while one is hacking. Signed-off-by: Mark McLoughlin mar...@redhat.com ---

Re: [libvirt] PATCH: Support VNC password for QEMU guests

2009-01-26 Thread Daniel P. Berrange
On Sun, Jan 25, 2009 at 09:22:53PM +0100, Radek Hladik wrote: Daniel P. Berrange napsal(a): This patch adds support for using the monitor interface to set the VNC password (qemu) change vnc password Password: A minor tricky thing is that we can't just send the command and

Re: [libvirt] [PATCH] gnulib/tests: allow test-getaddrinfo to pass when offline

2009-01-26 Thread Daniel P. Berrange
On Mon, Jan 26, 2009 at 08:30:27AM +, Mark McLoughlin wrote: Sometimes - yes, even in the latter part of the first decade of the twenty first century - one doesn't have access to the Internet while one is hacking. Signed-off-by: Mark McLoughlin mar...@redhat.com ---

Re: [libvirt] [PATCH] Quieten virsh schedinfo for shutoff domain

2009-01-26 Thread John Levon
On Mon, Jan 26, 2009 at 10:54:23AM +, Richard W.M. Jones wrote: On Thu, Jan 22, 2009 at 05:49:12PM -0800, john.le...@sun.com wrote: +/* + * If it's not running, we can't help. + */ +if (domain-id 0) +return NULL; NACK. Unfortunately you shouldn't return

Re: [libvirt] [PATCH] Fix virsh sched-credit for xend

2009-01-26 Thread John Levon
On Mon, Jan 26, 2009 at 10:55:37AM +, Richard W.M. Jones wrote: Does XenD actaully persist the schedinfo changes for inactive domains ? Historically we've only considered the sched tunables API to be relevant to active guests, and none of the drivers make any attempt to persist the

Re: [libvirt] [PATCH] Fix virsh sched-credit for xend

2009-01-26 Thread Daniel P. Berrange
On Mon, Jan 26, 2009 at 10:55:37AM +, Richard W.M. Jones wrote: On Fri, Jan 23, 2009 at 10:34:14AM +, Daniel P. Berrange wrote: On Thu, Jan 22, 2009 at 05:49:00PM -0800, john.le...@sun.com wrote: # HG changeset patch # User john.le...@sun.com # Date 1232675291 28800 # Node

Re: [libvirt] [PATCH] xm_internal.c: fix locking bug: s/Unlock/Lock/

2009-01-26 Thread Daniel P. Berrange
On Mon, Jan 26, 2009 at 10:50:32AM +, Richard W.M. Jones wrote: On Thu, Jan 22, 2009 at 07:13:47PM +, Daniel P. Berrange wrote: On Thu, Jan 22, 2009 at 08:09:51PM +0100, Jim Meyering wrote: Merge error? I'll commit this in an hour or so. Go for it - how did you notice it ?

Re: [libvirt] [PATCH] kvm/virtio: Set IFF_VNET_HDR when setting up tap fds

2009-01-26 Thread Richard W.M. Jones
On Mon, Jan 26, 2009 at 10:39:25AM +, Mark McLoughlin wrote: IFF_VNET_HDR is a tun/tap flag that allows you to send and receive large (i.e. GSO) packets and packets with partial checksums. Setting the flag means that every packet is proceeded by the same header which virtio uses to

Re: [libvirt] [PATCH] Fix virsh sched-credit for xend

2009-01-26 Thread John Levon
On Mon, Jan 26, 2009 at 11:29:01AM +, Daniel P. Berrange wrote: It isn't that simple. Tunables are not represented as part of the XML, Good point, that would need to be fixed. I'd missed this. So if we want to be able to set tunables on inactive domains, the

Re: [libvirt] [PATCH] Fix virsh sched-credit for xend

2009-01-26 Thread Richard W.M. Jones
On Mon, Jan 26, 2009 at 11:48:42AM +, John Levon wrote: On Mon, Jan 26, 2009 at 11:29:01AM +, Daniel P. Berrange wrote: It isn't that simple. Tunables are not represented as part of the XML, Good point, that would need to be fixed. I'd missed this. So if we want to be able to

Re: [libvirt] PATCH: Support VNC password for QEMU guests

2009-01-26 Thread Daniel P. Berrange
On Mon, Jan 26, 2009 at 11:15:01AM +, Daniel P. Berrange wrote: On Sun, Jan 25, 2009 at 09:22:53PM +0100, Radek Hladik wrote: Daniel P. Berrange napsal(a): This patch adds support for using the monitor interface to set the VNC password (qemu) change vnc password Password:

Re: [libvirt] [PATCH] kvm/virtio: Set IFF_VNET_HDR when setting up tap fds

2009-01-26 Thread Mark McLoughlin
Hi Rich, On Mon, 2009-01-26 at 11:39 +, Richard W.M. Jones wrote: On Mon, Jan 26, 2009 at 10:39:25AM +, Mark McLoughlin wrote: IFF_VNET_HDR is a tun/tap flag that allows you to send and receive large (i.e. GSO) packets and packets with partial checksums. Setting the flag means that

Re: [libvirt] PATCH: Support VNC password for QEMU guests

2009-01-26 Thread Radek Hladik
Daniel P. Berrange napsal(a): On Mon, Jan 26, 2009 at 11:15:01AM +, Daniel P. Berrange wrote: On Sun, Jan 25, 2009 at 09:22:53PM +0100, Radek Hladik wrote: Daniel P. Berrange napsal(a): This patch adds support for using the monitor interface to set the VNC password (qemu)

Re: [libvirt] [PATCH] Fix virsh sched-credit for xend

2009-01-26 Thread John Levon
On Mon, Jan 26, 2009 at 12:28:47PM +, Richard W.M. Jones wrote: No, surely we should fix the XML to represent it, and then it /would/ work. Must be better than another identical API. Historically there has been a bit of a debate about this. It's not clear if the XML is meant to

[libvirt] [PATCH] Fix stderr spewage from docs/examples install

2009-01-26 Thread john . levon
# HG changeset patch # User John Levon john.le...@sun.com # Date 1232970961 28800 # Node ID 839f1721d6d9c2cfdbc9327814a4c4a9564ff814 # Parent 26d337992a98a00d98f83247eb113ca3d729d8ef Fix stderr spewage from docs/examples install *.res don't exist, so shouldn't be in the generated Makefile.am

[libvirt] [PATCH] fix errors in virReportSystemErrorFull

2009-01-26 Thread Jim Meyering
While looking at removing most of the remaining uses of strerror, I spotted problems in virReportSystemErrorFull. 1) it would leak combined 2) that allocated, written-into buffer wasn't even used So, since we'd rather avoid having to allocate at all in the error-reporting path (esp for OOM

[libvirt] [PATCH] * src/virterror.c (virErrorMsg): Correct indentation.

2009-01-26 Thread Jim Meyering
Just correct bogus indentation. From dca64d37d946f73275fc5e8300e8cd29f34afd06 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Mon, 26 Jan 2009 14:44:22 +0100 Subject: [PATCH] * src/virterror.c (virErrorMsg): Correct indentation. --- src/virterror.c | 84

[libvirt] [PATCH] mark a few diagnostics for translation

2009-01-26 Thread Jim Meyering
Avoid compile-time warnings: From 4597152e0c4a1e4a5ee85156496a8625b5cc4f42 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Mon, 26 Jan 2009 14:54:21 +0100 Subject: [PATCH 2/3] mark a few diagnostics for translation * src/proxy_internal.c (xenProxyCommand): Mark a

Re: [libvirt] [PATCH] fix errors in virReportSystemErrorFull

2009-01-26 Thread Daniel P. Berrange
On Mon, Jan 26, 2009 at 03:02:48PM +0100, Jim Meyering wrote: So, since we'd rather avoid having to allocate at all in the error-reporting path (esp for OOM errors), I've made it automatic. That doesn't really matter/help the OOM reporting scenario, because the convention for

Re: [libvirt] [PATCH] * src/virterror.c (virErrorMsg): Correct indentation.

2009-01-26 Thread Daniel P. Berrange
On Mon, Jan 26, 2009 at 03:03:59PM +0100, Jim Meyering wrote: Just correct bogus indentation. From dca64d37d946f73275fc5e8300e8cd29f34afd06 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Mon, 26 Jan 2009 14:44:22 +0100 Subject: [PATCH] * src/virterror.c (virErrorMsg):

Re: [libvirt] [PATCH] mark a few diagnostics for translation

2009-01-26 Thread Daniel P. Berrange
On Mon, Jan 26, 2009 at 03:05:05PM +0100, Jim Meyering wrote: Avoid compile-time warnings: From 4597152e0c4a1e4a5ee85156496a8625b5cc4f42 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Mon, 26 Jan 2009 14:54:21 +0100 Subject: [PATCH 2/3] mark a few diagnostics for

[libvirt] Re: [Patch][RFC] Fine grained access control in libvirt by rbac (0/3)

2009-01-26 Thread Konrad Eriksson1
Yes, we're looking into adding similar form of access control in libvirt. The approach we're looking at is to inject AC as a module that intercepts calls from the libvirt core (libvirt.c) to the drivers. Reason: * AC module can be loaded/unloaded on the fly without need to recompile (can

Re: [libvirt] PATCH: Support VNC password for QEMU guests

2009-01-26 Thread Daniel P. Berrange
On Tue, Jan 20, 2009 at 11:08:56PM +, Daniel P. Berrange wrote: This patch adds support for using the monitor interface to set the VNC password (qemu) change vnc password Password: A minor tricky thing is that we can't just send the command and password all in one go, we

[libvirt] Re: [Patch][RFC] Fine grained access control in libvirt by rbac (0/3)

2009-01-26 Thread Daniel P. Berrange
On Mon, Jan 26, 2009 at 04:19:14PM +0100, Konrad Eriksson1 wrote: Yes, we're looking into adding similar form of access control in libvirt. The approach we're looking at is to inject AC as a module that intercepts calls from the libvirt core (libvirt.c) to the drivers. Reason: * AC module

Re: [libvirt] [PATCH] Fix virsh sched-credit for xend

2009-01-26 Thread Richard W.M. Jones
On Mon, Jan 26, 2009 at 01:21:46PM +, John Levon wrote: On Mon, Jan 26, 2009 at 12:28:47PM +, Richard W.M. Jones wrote: No, surely we should fix the XML to represent it, and then it /would/ work. Must be better than another identical API. Historically there has been a bit of

[libvirt] PATCH: Fix remote driver RPC recv handling

2009-01-26 Thread Daniel P. Berrange
I noticed a odd error message randomly appearing from virsh after all commands had been run # virsh dominfo VirtTest Id: - Name: VirtTest UUID: 82038f2a-1344-aaf7-1a85-2a7250be2076 OS Type:hvm State: shut off CPU(s): 3 Max

Re: [libvirt] [PATCH] mark a few diagnostics for translation

2009-01-26 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: On Mon, Jan 26, 2009 at 03:05:05PM +0100, Jim Meyering wrote: Avoid compile-time warnings: From 4597152e0c4a1e4a5ee85156496a8625b5cc4f42 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Mon, 26 Jan 2009 14:54:21 +0100

[libvirt] [ANNOUNCE] New release virt-manager 0.6.1

2009-01-26 Thread Cole Robinson
I'm happy to announce a new virt-manager release, version 0.6.1. The release can be downloaded from: http://virt-manager.org/download.html The direct download link is: http://virt-manager.org/download/sources/virt-manager/virt-manager-0.6.1.tar.gz This release includes: - VM disk and

[libvirt] [ANNOUNCE] New release virtinst 0.400.1

2009-01-26 Thread Cole Robinson
I'm happy to announce a new virtinst release, version 0.4.1. The release can be downloaded from: http://virt-manager.org/download.html The direct download link is: http://virt-manager.org/download/sources/virtinst/virtinst-0.400.1.tar.gz This release includes: - Add virt-image - vmx support

[libvirt] about libvirt-qpid on libvirt.org

2009-01-26 Thread Atsushi SAKAI
Hi, I have a question about libvirt-qpid. The libvirt-qpid is working for QPID broker? If so, it should be added in livirt is section of following pages. http://libvirt.org/ How do you think? (If agreed, I add it.) Thanks Atsushi SAKAI -- Libvir-list mailing list Libvir-list@redhat.com

Re: [libvirt] [PATCH] trivial libvirt example code

2009-01-26 Thread Dave Allan
Richard W.M. Jones wrote: On Fri, Jan 23, 2009 at 02:51:02PM -0500, Dave Allan wrote: The examples directory doesn't have a trivial example of how to connect to a hypervisor, make a few calls, and disconnect, so I put one together. I would appreciate any suggestions on anything that I've