Re: [libvirt] [PATCH 4/9] iptables.c: Use virStrerror, not strerror.

2009-02-04 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: On Mon, Feb 02, 2009 at 06:08:17PM +0100, Jim Meyering wrote: From: Jim Meyering meyer...@redhat.com * src/iptables.c: Include virterror_internal.h. Use virStrerror, not strerror. * src/virterror.c (virStrerror): Remove static. *

Re: [libvirt] PATCH: Prevent libvirtd 100% CPU usage when --timeout is used

2009-02-04 Thread Daniel P. Berrange
On Wed, Feb 04, 2009 at 02:46:58PM +, Daniel P. Berrange wrote: A couple of bugs conspired to make libvirtd use 100% CPU usage when the --timeout option is used. This is the default for qemu:///session instance which are auto-spawned, so quite annoying! eg libvirt --timeout=30 -

Re: [libvirt] PATCH: Prevent libvirtd 100% CPU usage when --timeout is used

2009-02-04 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: On Wed, Feb 04, 2009 at 02:46:58PM +, Daniel P. Berrange wrote: A couple of bugs conspired to make libvirtd use 100% CPU usage when the --timeout option is used. This is the default for qemu:///session instance which are auto-spawned, so quite

[libvirt] PATCH: Prevent libvirtd 100% CPU usage when --timeout is used

2009-02-04 Thread Daniel P. Berrange
A couple of bugs conspired to make libvirtd use 100% CPU usage when the --timeout option is used. This is the default for qemu:///session instance which are auto-spawned, so quite annoying! eg libvirt --timeout=30 - The qemudRunLoop() method was registering a timeout on every iteration of

[libvirt] [PATCH] Report error for some xend operations on shutdown domain

2009-02-04 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1233765613 28800 # Node ID 706a43692cceeba796e36c070e2b46f85d8cb4f0 # Parent bda41ea0cbbdea409447686c30b7afb10b9cae85 Report error for some xend operations on shutdown domain Signed-off-by: John Levon john.le...@sun.com diff --git

[libvirt] [PATCH] remove useless code

2009-02-04 Thread Jim Meyering
Barely worth posting for review, but who knows... From a7cae36a3d966e80d82859d63c60a303b63d6720 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Wed, 4 Feb 2009 17:44:24 +0100 Subject: [PATCH] remove useless code * src/bridge.c (brAddTap): Remove redundant errno=ENOMEM

[libvirt] [PATCH] lxc_container: Don't dereference NULL upon failure (x2)

2009-02-04 Thread Jim Meyering
Spotted these while skimming through all VIR_FREE uses. From af9e606d97e8321683ba765ba0a4af4c065d3b4b Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Wed, 4 Feb 2009 18:44:34 +0100 Subject: [PATCH] lxc_container: Don't dereference NULL upon failure * src/lxc_container.c

[libvirt] Re: [PATCH] Add showError function to display error data generated by libvirt.

2009-02-04 Thread Dave Allan
David Allan wrote: --- examples/hellolibvirt/hellolibvirt.c | 46 ++ 1 files changed, 46 insertions(+), 0 deletions(-) diff --git a/examples/hellolibvirt/hellolibvirt.c b/examples/hellolibvirt/hellolibvirt.c index cc1af0f..234637e 100644 ---

Re: [libvirt] [PATCH] remove useless code

2009-02-04 Thread Jim Meyering
Jim Meyering j...@meyering.net wrote: From a7cae36a3d966e80d82859d63c60a303b63d6720 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Wed, 4 Feb 2009 17:44:24 +0100 Subject: [PATCH] remove useless code * src/bridge.c (brAddTap): Remove redundant errno=ENOMEM assignment

[libvirt] [PATCH] Allow off-line removal of devices via xend

2009-02-04 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1233765613 28800 # Node ID bda41ea0cbbdea409447686c30b7afb10b9cae85 # Parent e6b17082b9b9440ce14ad76bd2f4c003ae2404db Allow off-line removal of devices via xend We must avoid xenstore if the domain isn't running. For disks, this works in all

[libvirt] [PATCH] Improve error reporting in virsh

2009-02-04 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1233791330 28800 # Node ID 6588879d8cc9a3af1147a5edd624aee5155493ae # Parent da162569b5f7e132c4ccbfc56fc3670fb5ecee10 Improve error reporting in virsh Rather than verbosely printing every error, save the last error and report that only if the

Re: [libvirt] [PATCH] Allow off-line removal of devices via xend

2009-02-04 Thread John Levon
On Wed, Feb 04, 2009 at 03:42:10PM -0800, john.le...@sun.com wrote: Allow off-line removal of devices via xend This patch is bogus, please ignore for now thanks john -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Add distro to domain XML

2009-02-04 Thread John Levon
On Fri, Jan 30, 2009 at 10:50:38AM -0800, john.le...@sun.com wrote: Add distro to domain XML Support recording the distro type and variant of a domain. Comments? We obviously don't want to fork the XML, but consider being able to record this for debugging purposes very important. regards

Re: [libvirt] [PATCH] Solaris PV is localtime. Allow this setting through the conversions

2009-02-04 Thread John Levon
On Thu, Jan 29, 2009 at 11:33:10AM +, Daniel P. Berrange wrote: Hmm, current XenD may not mind having 'localtime' here, but I'm worried older XenD may not be so forgiving. Will have to check older source. Any success? Existing code unconditionally sets localtime=0 and localtime=1, but

[libvirt] [PATCH] Robustify sexpr parser for NICs

2009-02-04 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1233806614 28800 # Node ID 0b9d8336e5e089b19ac8381fdc77eadc72ef9eb7 # Parent 379763c63798c9f0c426facb9b9b61e34e6477e2 Robustify sexpr parser for NICs xend can occassionally get itself confused. Avoid crashing libvirt in this case.

[libvirt] [PATCH] Use virMacAddrCompare() in xs_internal.c

2009-02-04 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1233800565 28800 # Node ID 379763c63798c9f0c426facb9b9b61e34e6477e2 # Parent e6b17082b9b9440ce14ad76bd2f4c003ae2404db Use virMacAddrCompare() in xs_internal.c This solves a failure to look up a net device. Signed-off-by: John Levon

[libvirt] [PATCH] Allow off-line removal of devices via xend

2009-02-04 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1233806617 28800 # Node ID 507c2058c5f3c37894c573c4559eab58c5b52d7d # Parent 0b9d8336e5e089b19ac8381fdc77eadc72ef9eb7 Allow off-line removal of devices via xend We must avoid xenstore if the domain isn't running. For disks, this works in all

Re: [libvirt] [PATCH] Robustify sexpr parser for NICs

2009-02-04 Thread Jim Meyering
john.le...@sun.com wrote: Robustify sexpr parser for NICs xend can occassionally get itself confused. Avoid crashing libvirt in this case. diff --git a/src/xend_internal.c b/src/xend_internal.c --- a/src/xend_internal.c +++ b/src/xend_internal.c @@ -1759,7 +1759,8 @@

Re: [libvirt] [PATCH] Add distro to domain XML

2009-02-04 Thread Jim Meyering
John Levon le...@movementarian.org wrote: On Fri, Jan 30, 2009 at 10:50:38AM -0800, john.le...@sun.com wrote: Add distro to domain XML Support recording the distro type and variant of a domain. Comments? We obviously don't want to fork the XML, but consider being able to record this for

Re: [libvirt] [PATCH] Use virMacAddrCompare() in xs_internal.c

2009-02-04 Thread Jim Meyering
john.le...@sun.com wrote: Use virMacAddrCompare() in xs_internal.c This solves a failure to look up a net device. Please take the time to describe the failure scenario in enough detail that someone (maybe me) can reproduce it. IMHO, a bug-fix patch like this is best accompanied by a test case