On Fri, Jan 30, 2009 at 10:50:38AM -0800, john.le...@sun.com wrote:
# HG changeset patch
# User john.le...@sun.com
# Date 1233340700 28800
# Node ID c1cc701bfb5b7417c2c8cd3571022dcd161c518f
# Parent cb53cd19242ca7c4a8d20a54495108d7f6639e57
Add distro to domain XML
Support recording the
On Wed, Feb 04, 2009 at 06:44:52PM +0100, Jim Meyering wrote:
Barely worth posting for review, but who knows...
From a7cae36a3d966e80d82859d63c60a303b63d6720 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Wed, 4 Feb 2009 17:44:24 +0100
Subject: [PATCH] remove useless
On Wed, Feb 04, 2009 at 06:49:23PM +0100, Jim Meyering wrote:
Spotted these while skimming through all VIR_FREE uses.
From af9e606d97e8321683ba765ba0a4af4c065d3b4b Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Wed, 4 Feb 2009 18:44:34 +0100
Subject: [PATCH]
On Wed, Feb 04, 2009 at 08:12:49PM -0800, john.le...@sun.com wrote:
# HG changeset patch
# User john.le...@sun.com
# Date 1233806614 28800
# Node ID 0b9d8336e5e089b19ac8381fdc77eadc72ef9eb7
# Parent 379763c63798c9f0c426facb9b9b61e34e6477e2
Robustify sexpr parser for NICs
xend can
On Wed, Feb 04, 2009 at 03:56:26PM -0800, john.le...@sun.com wrote:
# HG changeset patch
# User john.le...@sun.com
# Date 1233791330 28800
# Node ID 6588879d8cc9a3af1147a5edd624aee5155493ae
# Parent da162569b5f7e132c4ccbfc56fc3670fb5ecee10
Improve error reporting in virsh
Rather than
Daniel P. Berrange berra...@redhat.com wrote:
...
These two are not safe to remove. Look at the whole code block in
question:
if (diskVal-list == NULL)
VIR_FREE(diskVal);
else if (virConfSetValue(conf, disk, diskVal) 0) {
diskVal = NULL;
goto no_memory;
On Wed, Feb 04, 2009 at 08:41:59PM -0800, john.le...@sun.com wrote:
# HG changeset patch
# User john.le...@sun.com
# Date 1233800565 28800
# Node ID 379763c63798c9f0c426facb9b9b61e34e6477e2
# Parent e6b17082b9b9440ce14ad76bd2f4c003ae2404db
Use virMacAddrCompare() in xs_internal.c
This
On Wed, Feb 04, 2009 at 01:07:49PM +0100, Jim Meyering wrote:
Daniel P. Berrange berra...@redhat.com wrote:
On Mon, Feb 02, 2009 at 06:08:17PM +0100, Jim Meyering wrote:
From: Jim Meyering meyer...@redhat.com
* src/iptables.c: Include virterror_internal.h.
Use virStrerror, not strerror.
On Fri, Jan 30, 2009 at 02:10:57PM -0500, John Levon wrote:
It doesn't work quite right with a running domain. The 'new' will
correctly set the config, but the temporary config doesn't include the
new setting. So tests of the form set autostart; is it set? will fail.
I'm not sure I
Daniel P. Berrange berra...@redhat.com wrote:
On Wed, Feb 04, 2009 at 01:07:49PM +0100, Jim Meyering wrote:
...
Here's an incremental diff that also includes additional changes, e.g.,
- enable the syntax-check for strerror
- change more out of error reports to
On Thu, Feb 05, 2009 at 02:30:02PM +0100, Jim Meyering wrote:
Daniel P. Berrange berra...@redhat.com wrote:
On Wed, Feb 04, 2009 at 01:07:49PM +0100, Jim Meyering wrote:
...
Here's an incremental diff that also includes additional changes, e.g.,
[snip more
On Sat, Jan 31, 2009 at 02:32:09PM +0100, Guido Günther wrote:
we currently don't report errors to save qemu's domain status file back
to the caller. That was o.k. as long as the code was there for testing
but now that the XML is being picked up on daemon restart we must
handle these.
Any
On Thu, Feb 05, 2009 at 01:55:39PM +0100, Jim Meyering wrote:
Daniel P. Berrange berra...@redhat.com wrote:
...
These two are not safe to remove. Look at the whole code block in
question:
if (diskVal-list == NULL)
VIR_FREE(diskVal);
else if (virConfSetValue(conf,
On Thu, Feb 05, 2009 at 02:49:50PM +0100, Jim Meyering wrote:
Daniel P. Berrange berra...@redhat.com wrote:
On Thu, Feb 05, 2009 at 02:30:02PM +0100, Jim Meyering wrote:
Daniel P. Berrange berra...@redhat.com wrote:
On Wed, Feb 04, 2009 at 01:07:49PM +0100, Jim Meyering wrote:
...
Daniel P. Berrange berra...@redhat.com wrote:
On Thu, Feb 05, 2009 at 01:55:39PM +0100, Jim Meyering wrote:
Daniel P. Berrange berra...@redhat.com wrote:
...
These two are not safe to remove. Look at the whole code block in
question:
if (diskVal-list == NULL)
On Thu, Feb 05, 2009 at 05:01:55PM +0100, Jim Meyering wrote:
Daniel P. Berrange berra...@redhat.com wrote:
On Thu, Feb 05, 2009 at 01:55:39PM +0100, Jim Meyering wrote:
Daniel P. Berrange berra...@redhat.com wrote:
...
These two are not safe to remove. Look at the whole code block in
Daniel P. Berrange berra...@redhat.com wrote:
ACK, this makes more sense now
I've committed these 10 and the remove useless code ones.
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, Feb 05, 2009 at 06:56:58AM +0100, Jim Meyering wrote:
xend can occassionally get itself confused. Avoid crashing libvirt in
this case.
The example I had looked like this:
(device (vif (backend 0)))
I'm not sure it's appropriate for a test case since it's strictly a bug.
On Thu, Feb 05, 2009 at 08:00:04AM +0100, Jim Meyering wrote:
Use virMacAddrCompare() in xs_internal.c
This solves a failure to look up a net device.
Please take the time to describe the failure scenario
in enough detail that someone (maybe me) can reproduce it.
OK. The problem was one
On Thu, Feb 05, 2009 at 11:53:37AM +, Daniel P. Berrange wrote:
Support recording the distro type and variant of a domain.
I don't really consider distro type variant as represented by
virt-install to be very satisfactory. It was intended to represent
the capabilities of the OS being
On Thu, Feb 05, 2009 at 04:57:06PM +, John Levon wrote:
On Thu, Feb 05, 2009 at 11:53:37AM +, Daniel P. Berrange wrote:
None of this exists in upstream XenD. As a general rule unless it is in
upstream XenD, then we shouldn't include it in libvirt. That said, I
Oh come on. Hacks
On Thu, Feb 05, 2009 at 12:34:32PM +, Daniel P. Berrange wrote:
+static void
+virshReportError(vshControl *ctl)
+{
+if (last_error == NULL)
+return;
+
+if (last_error-code == VIR_ERR_OK) {
+vshError(ctl, TRUE, %s, _(unknown error));
+return;
On Thu, Feb 05, 2009 at 11:56:59AM +, Daniel P. Berrange wrote:
It doesn't work quite right with a running domain. The 'new' will
correctly set the config, but the temporary config doesn't include the
new setting. So tests of the form set autostart; is it set? will fail.
I'm not sure
On Thu, Feb 05, 2009 at 05:00:41PM +, Daniel P. Berrange wrote:
Oh come on. Hacks for RHEL5 are OK, but anyone else has changes in their
system and it's not? Whatever happened to libvirt not being lowest
common denominator?
The changes put in RHEL5 are *backports* of existing
A number of bugs conspired together to cause some nasty problems when
a QEMU vm failed to start
- vm-monitor was not initialized to -1, so when a VM failed to start
the vm-monitor was just '0', and thus we closed FD 0 (libvirtd's stdin)
- The next client to connect got FD 0 as its socket
On Thu, Feb 05, 2009 at 05:00:41PM +, Daniel P. Berrange wrote:
there were RHEL-5 Xen features which were not already upstream in a newer
Xen version, we wouldn't include them in libvirt (they wouldn't be in
RHEL-5 Xen anyway, because we don't add stuff there unless it is already
in
On Thu, Feb 05, 2009 at 05:05:53PM +, John Levon wrote:
On Thu, Feb 05, 2009 at 12:34:32PM +, Daniel P. Berrange wrote:
+static void
+virshReportError(vshControl *ctl)
+{
+if (last_error == NULL)
+return;
+
+if (last_error-code == VIR_ERR_OK) {
+
On Sat, Jan 31, 2009 at 02:32:09PM +0100, Guido G?nther wrote:
Hi,
we currently don't report errors to save qemu's domain status file back
to the caller. That was o.k. as long as the code was there for testing
but now that the XML is being picked up on daemon restart we must
handle these.
Guido Günther a...@sigxcpu.org wrote:
we currently don't report errors to save qemu's domain status file back
to the caller. That was o.k. as long as the code was there for testing
but now that the XML is being picked up on daemon restart we must
handle these.
The attached patch does that,
FYI, this was caught by bleeding-edge gcc (built from git just this morning).
There are a few other problems, too.
From a3149ae688f4f7eac3ee001f8f4d5997d3f23eeb Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 5 Feb 2009 18:57:07 +0100
Subject: [PATCH] don't print
On Thu, Feb 05, 2009 at 12:09:16PM -0500, John Levon wrote:
On Thu, Feb 05, 2009 at 11:56:59AM +, Daniel P. Berrange wrote:
It doesn't work quite right with a running domain. The 'new' will
correctly set the config, but the temporary config doesn't include the
new setting. So tests
On Thu, Feb 05, 2009 at 05:34:20PM +, Daniel P. Berrange wrote:
Ok, how about a slightly different virSaveLastError() call, avoiding
the need to do the pair of call virGetLastEror() + virCloneError()
Sounds reasonable to me.
Also, it is neccessary to free the error message/object
On Thu, Feb 05, 2009 at 06:03:48PM +, Daniel P. Berrange wrote:
Python API, you can see it returning False when it shouldn't.
You should be able to see it with 'virsh dominfo'
Yes, sorry. You do indeed see the wrong answer there.
The problem is that we're doing a new and xend is
# HG changeset patch
# User john.le...@sun.com
# Date 1233859424 28800
# Node ID dd8a1923aae38d9e36cb98a934af64450ecd85a2
# Parent 8086732c0e4250d26a4cfed2411e86b209712eb5
Introduce virCopyLastError()
Allow applications to store a copy of the last error reported.
Signed-off-by: John Levon
# HG changeset patch
# User john.le...@sun.com
# Date 1233859425 28800
# Node ID c594c1c54b88947082a01b6aaa81ad7756bbd951
# Parent a23da778e0ddf954d8bf0a185b508fc236feb4be
Improve error reporting in virsh
Rather than verbosely printing every error, save the last error and
report that only if the
On Thu, Feb 05, 2009 at 11:28:48AM -0800, john.le...@sun.com wrote:
Improve error reporting in virsh
Rather than verbosely printing every error, save the last error and
report that only if the entire command fails.
This version fixes up the memory leak issue Dan spotted. It's dependent
upon
On Thu, Feb 05, 2009 at 11:27:19AM -0800, john.le...@sun.com wrote:
# HG changeset patch
# User john.le...@sun.com
# Date 1233859424 28800
# Node ID dd8a1923aae38d9e36cb98a934af64450ecd85a2
# Parent 8086732c0e4250d26a4cfed2411e86b209712eb5
Introduce virCopyLastError()
Allow applications
On Thu, Feb 05, 2009 at 08:16:57PM +, Daniel P. Berrange wrote:
On Thu, Feb 05, 2009 at 11:27:19AM -0800, john.le...@sun.com wrote:
# HG changeset patch
# User john.le...@sun.com
# Date 1233859424 28800
# Node ID dd8a1923aae38d9e36cb98a934af64450ecd85a2
# Parent
On Thu, Feb 05, 2009 at 11:28:48AM -0800, john.le...@sun.com wrote:
# HG changeset patch
# User john.le...@sun.com
# Date 1233859425 28800
# Node ID c594c1c54b88947082a01b6aaa81ad7756bbd951
# Parent a23da778e0ddf954d8bf0a185b508fc236feb4be
Improve error reporting in virsh
Rather than
On Thu, Feb 05, 2009 at 08:20:28PM +, Daniel P. Berrange wrote:
This actually still leaks the char * strings associated with the
error - we probably need to now add a virErrorFree() function to
go along with the new virSaveError function.
Yep, working on two new patches. Sorry about that.
On Thu, Feb 05, 2009 at 06:09:10PM +, John Levon wrote:
On Thu, Feb 05, 2009 at 05:34:20PM +, Daniel P. Berrange wrote:
Just have the virXendError macro call virReportErrorHelper directly,
as it already does - there is no need to wrap it in the conditional
check
On Thu, Feb 05, 2009 at 08:37:29PM +, Daniel P. Berrange wrote:
On Thu, Feb 05, 2009 at 06:09:10PM +, John Levon wrote:
In contrast, only set an error if one isn't set already is simple,
immediately understandable, and covers almost all the common cases.
I'm not totally against
On Thu, Feb 05, 2009 at 08:39:55PM +, Daniel P. Berrange wrote:
First, we'd need to make some changes to the libvirtd because it calls
into a number of APIs, both public entry points some of the internal
helpers directly, but does not reset the error in betweeen these calls.
Of
Running virsh with the remote driver (as it always is on Solaris), it
leaks pretty heavily:
thewhip:~ # yes start fewfewf | virsh /dev/null 21
[1] 6388
# prstat -c -p 6388
PID USERNAME SIZE RSS STATE PRI NICE TIME CPU PROCESS/NLWP
6388 root 10M 6788K sleep 590
# HG changeset patch
# User john.le...@sun.com
# Date 1233870901 28800
# Node ID 2c12bdf95e5e5f7d00b606df679364463555d76e
# Parent 059167552cb467c107870c3b739438ca107116a8
Introduce virSaveLastError(), virFreeError()
Allow applications to store a copy of the last error reported.
Signed-off-by:
# HG changeset patch
# User john.le...@sun.com
# Date 1233870902 28800
# Node ID fe7d1aae6184476568fcd3da379207375d8a05a6
# Parent 9fecb1254ee1dad6efeedc50239852104a6f40e2
Improve error reporting in virsh
Rather than verbosely printing every error, save the last error and
report that only if the
John Levon wrote:
Running virsh with the remote driver (as it always is on Solaris), it
leaks pretty heavily:
thewhip:~ # yes start fewfewf | virsh /dev/null 21
[1] 6388
# prstat -c -p 6388
PID USERNAME SIZE RSS STATE PRI NICE TIME CPU PROCESS/NLWP
6388 root
On Mon, 2009-02-02 at 10:59 +0100, Marius Tomaschewski wrote:
For now, I want to stay out of setting up static routes, but I think
that has to come sooner or later.
It is OK to limit routes to the default route for now, but IMO
it is better to use separate xml nodes, e.g.:
static
On Thu, Feb 05, 2009 at 07:23:36PM -0500, Jim Paris wrote:
Yeah, it seems there is no limit on the size of the readline history,
so it just grows forever. Try this?
Yep, that's a relief, thanks.
regards
john
--
Libvir-list mailing list
Libvir-list@redhat.com
49 matches
Mail list logo
