Re: [libvirt] Question about the specification of virsh vcpupinand virsh vcpuinfo in libvirt-0.6.1.

2009-04-20 Thread Takahashi Tomohiro
Hi, Would you give me a comment on this patch? If not, please apply it. Thanks, Tomohiro Takahashi. Takahashi Tomohiro wrote: Hi Daniel-san, Thank you for your reply. virsh doesn't place any restrictions on whether those commands can be run on inactive guests. It should just try the API

[libvirt] [PATCH] src/bridge.c compile error

2009-04-20 Thread Anton Protopopov
Hi. The absense of SIOCBRADDBR causes compile error: bridge.c:143: error: conflicting types for 'brAddBridge' bridge.h:50: error: previous declaration of 'brAddBridge' was here See attached patch for fix. By the way, what functionality do one loose if his system isn't supporting

Re: [libvirt] Xen network interface behavior with 0.6.2

2009-04-20 Thread Daniel P. Berrange
On Fri, Apr 17, 2009 at 01:29:12PM -0700, Kaitlin Rupert wrote: Hi, I'm using libvirt 0.6.2 to create a Xen guest with a network type interface (see XML below). When the guest is defined, the interface is converted to an ethernet type interface. If the guest is started, the interface

Re: [libvirt] [PATCH] src/bridge.c compile error

2009-04-20 Thread Daniel Veillard
On Mon, Apr 20, 2009 at 11:28:21AM +0400, Anton Protopopov wrote: Hi. The absense of SIOCBRADDBR causes compile error: bridge.c:143: error: conflicting types for 'brAddBridge' bridge.h:50: error: previous declaration of 'brAddBridge' was here See attached patch for fix. Makes

Re: [libvirt] KVM migration with uri = NULL

2009-04-20 Thread Daniel P. Berrange
On Sun, Apr 19, 2009 at 09:16:53AM +0200, Chris Lalancette wrote: Zvi Dubitzky wrote: What is the meaning of using virDomainMigrate () with NULL uri. Looking at the code of qemudDomainMigratePrepare2 ()/ qemu_driver.c, I understand that it tries to perform a migration to another VM

Re: [libvirt] PATCH: Allow LXC to use private /dev/pts instance

2009-04-20 Thread Daniel P. Berrange
On Fri, Apr 17, 2009 at 09:39:19AM -0500, Serge E. Hallyn wrote: Quoting Daniel P. Berrange (berra...@redhat.com): Calling unshare(CLONE_NEWNS) will not prevent the host OS from seeing the new /dev/pts if / was MS_SHARED. That isn't taken care of anywhere else for this process's

Re: [libvirt] [PATCH 1/1] lxc: only do CLONE_NEWUSER when kernel supports it

2009-04-20 Thread Daniel P. Berrange
On Fri, Apr 17, 2009 at 04:50:10PM -0500, Serge E. Hallyn wrote: From 2513f8a7e0654e84570fe0ef2204dabe276b9e4e Mon Sep 17 00:00:00 2001 From: root r...@jaunty.(none) Date: Fri, 17 Apr 2009 16:41:01 -0500 Subject: [PATCH 1/1] lxc: only do CLONE_NEWUSER when kernel supports it The ubuntu

[libvirt] [PATCH] Fix typo in manpage

2009-04-20 Thread Mark McLoughlin
Hey, Just committed this simple patch. Cheers, Mark. Subject: [PATCH] Fix typo in manpage It's service libvirtd start, not service start libvirtd. Reported-by: Robert P. J. Day rpj...@crashcourse.ca Signed-off-by: Mark McLoughlin mar...@redhat.com --- docs/virsh.pod |2 +- virsh.1

Re: [libvirt] [PATCH 1/1] lxc: only do CLONE_NEWUSER when kernel supports it

2009-04-20 Thread Daniel Veillard
On Mon, Apr 20, 2009 at 11:29:13AM +0100, Daniel P. Berrange wrote: On Fri, Apr 17, 2009 at 04:50:10PM -0500, Serge E. Hallyn wrote: From 2513f8a7e0654e84570fe0ef2204dabe276b9e4e Mon Sep 17 00:00:00 2001 From: root r...@jaunty.(none) Date: Fri, 17 Apr 2009 16:41:01 -0500 Subject: [PATCH

[libvirt] PATCH: Remove PID file before starting QEMU, and after shutdown

2009-04-20 Thread Daniel P. Berrange
We spawn QEMU with a -pidfile option to write its PID out to a file. This file is never removed though, so next time the guest starts there is small race condition where we might be unlucky enough to read the old PID out of the file, instead of the new QEMU PID. This patch adds a call to remove

Re: [libvirt] PATCH: Improve error reporting for operations on inactive domains

2009-04-20 Thread Daniel P. Berrange
On Fri, Apr 17, 2009 at 04:33:59PM +0200, Daniel Veillard wrote: On Fri, Apr 17, 2009 at 12:39:42PM +0100, Daniel P. Berrange wrote: If you try todo an operation on an inactive QEMU guest which is not applicable, eg ask to pause an inactive guest, then you currently get a useless message

Re: [libvirt] PATCH: Fix remote driver create/destroy methods to update ID field

2009-04-20 Thread Daniel P. Berrange
On Fri, Apr 17, 2009 at 01:30:43PM +0200, Daniel Veillard wrote: On Fri, Apr 17, 2009 at 12:12:14PM +0100, Daniel P. Berrange wrote: If you have an existing virDomainPtr object, and start it using the virDomainCreate(virDomainPtr dom) method, then internal cached 'id' field in the

Re: [libvirt] PATCH: Change virDomainAssignDef to lookup on UUID

2009-04-20 Thread Daniel P. Berrange
On Fri, Apr 17, 2009 at 01:20:29PM +0200, Daniel Veillard wrote: On Fri, Apr 17, 2009 at 12:07:49PM +0100, Daniel P. Berrange wrote: The virDomainAssignDef method currently uses the 'name' field to lookup domains. The UUID is the best internal identifier, so this changes over to use that

Re: [libvirt] PATCH: Use virDomainDefPtr to build QEMU args instead of virDomainObjPtr

2009-04-20 Thread Daniel P. Berrange
On Fri, Apr 17, 2009 at 01:11:37PM +0200, Daniel Veillard wrote: On Fri, Apr 17, 2009 at 11:41:41AM +0100, Daniel P. Berrange wrote: This is a fairly simple NFC patch which changes the QEMU driver to use the virDomainDefPtr object when building command line arguments instead of the

Re: [libvirt] PATCH: Add a tool virt-xml-validate

2009-04-20 Thread Daniel P. Berrange
On Fri, Apr 17, 2009 at 11:37:57AM +0100, Daniel P. Berrange wrote: On Thu, Apr 16, 2009 at 05:29:52PM +0200, Daniel Veillard wrote: On Thu, Apr 16, 2009 at 01:57:06PM +0100, Daniel P. Berrange wrote: On Thu, Apr 16, 2009 at 02:42:08PM +0200, Daniel Veillard wrote: Well its not part

Re: [libvirt] [PATCH 2/4] VirtualBox support

2009-04-20 Thread Daniel P. Berrange
On Fri, Apr 17, 2009 at 06:11:29PM +0200, Daniel Veillard wrote: On Fri, Apr 17, 2009 at 05:46:21PM +0200, Daniel Veillard wrote: On Fri, Apr 17, 2009 at 11:17:58AM +0200, Pritesh Kothari wrote: Hi All, Patch 2/4: contains new files needed for VirtualBox support. Resending

Re: [libvirt] PATCH: Allow LXC to use private /dev/pts instance

2009-04-20 Thread Serge E. Hallyn
Quoting Daniel P. Berrange (berra...@redhat.com): This patch attached now just makes it MS_SLAVE. There's no need for the extra SHARED flag, since the only process libvirt_lxc spawns is the 'init' process inside the container and that immediately makes its own root private. Thanks, this

[libvirt] F10: how to save snapshot back to image?

2009-04-20 Thread Gerry Reno
In Fedora 10 I've managed to get libvirt to call the emulator with custom arguments so I can invoke -snapshot. I just replaced the emulator in /usr/bin with my own script which adds the argument and then calls the original emulator. This works fine. And the snapshot works fine. I can make

Re: [libvirt] PATCH: Remove PID file before starting QEMU, and after shutdown

2009-04-20 Thread Daniel Veillard
On Mon, Apr 20, 2009 at 01:52:30PM +0100, Daniel P. Berrange wrote: We spawn QEMU with a -pidfile option to write its PID out to a file. This file is never removed though, so next time the guest starts there is small race condition where we might be unlucky enough to read the old PID out of

Re: [libvirt] Xen network interface behavior with 0.6.2

2009-04-20 Thread Kaitlin Rupert
Daniel P. Berrange wrote: On Fri, Apr 17, 2009 at 01:29:12PM -0700, Kaitlin Rupert wrote: Hi, I'm using libvirt 0.6.2 to create a Xen guest with a network type interface (see XML below). When the guest is defined, the interface is converted to an ethernet type interface. If the guest is

Re: [libvirt] Xen network interface behavior with 0.6.2

2009-04-20 Thread Daniel P. Berrange
On Mon, Apr 20, 2009 at 12:06:16PM -0700, Kaitlin Rupert wrote: Daniel P. Berrange wrote: On Fri, Apr 17, 2009 at 01:29:12PM -0700, Kaitlin Rupert wrote: Hi, I'm using libvirt 0.6.2 to create a Xen guest with a network type interface (see XML below). When the guest is defined, the

Re: [libvirt] Xen network interface behavior with 0.6.2

2009-04-20 Thread Kaitlin Rupert
Daniel P. Berrange wrote: On Mon, Apr 20, 2009 at 12:06:16PM -0700, Kaitlin Rupert wrote: Daniel P. Berrange wrote: On Fri, Apr 17, 2009 at 01:29:12PM -0700, Kaitlin Rupert wrote: Hi, I'm using libvirt 0.6.2 to create a Xen guest with a network type interface (see XML below). When the

Re: [libvirt] F10: how to save snapshot back to image?

2009-04-20 Thread Gerry Reno
Gerry Reno wrote: In Fedora 10 I've managed to get libvirt to call the emulator with custom arguments so I can invoke -snapshot. I just replaced the emulator in /usr/bin with my own script which adds the argument and then calls the original emulator. This works fine. And the snapshot works

Re: [libvirt] F10: how to save snapshot back to image?

2009-04-20 Thread Daniel Veillard
On Mon, Apr 20, 2009 at 04:24:28PM -0400, Gerry Reno wrote: Right now, I cannot gain access to the monitor in libvirt. Therefore I cannot issue something like savevm, loadvm, or commit hda or any of these commands necessary for working with snapshots. I also am unable to send Ctrl key