[libvirt] [PATCH] Fix a compilation problem with LXC drop capabilities

2009-05-29 Thread Daniel Veillard
The lxcContainerDropCapabilities() function requires PR_CAPBSET_DROP to be defined in order to compile, but it may not be defined in older kernels. So I made the compilation of the core of the function conditional, raise an error but still return 0 to not make the container initialization fail.

Re: [libvirt] [PATCH] fix storage volume inconsistencies in schema and document

2009-05-29 Thread Daniel Veillard
On Sat, May 23, 2009 at 09:06:44PM +0900, Ryota Ozaki wrote: Signed-off-by: Ryota Ozaki ozaki.ry...@gmail.com From 23b096394eb15183a12c3277ac7a61e1eb73deb2 Mon Sep 17 00:00:00 2001 From: Ryota Ozaki ozaki.ry...@gmail.com Date: Sat, 23 May 2009 20:52:51 +0900 Subject: [PATCH] fix storage

[libvirt] PATCH: Fix double-free in daemon after client connection drop

2009-05-29 Thread Daniel P. Berrange
If a client drops a connection unexpectedly there is a possiblity of a double free in the daemon if using SASL or TLS. This is because there is possibility for poll() on the socket, returns POLLIN and POLLHUP/ERR at the same time. Both the POLLIN and POLLHUP handling code will attempt to use

Re: [libvirt] [PATCH] Fix a compilation problem with LXC drop capabilities

2009-05-29 Thread Ryota Ozaki
On Fri, May 29, 2009 at 9:20 PM, Daniel Veillard veill...@redhat.com wrote:  The lxcContainerDropCapabilities() function requires PR_CAPBSET_DROP to be defined in order to compile, but it may not be defined in older kernels. So I made the compilation of the core of the function conditional,

Re: [libvirt] PPC Qemu Machine Type Patch

2009-05-29 Thread Daniel Veillard
On Thu, May 28, 2009 at 07:26:15PM +0100, Daniel P. Berrange wrote: On Thu, May 28, 2009 at 01:16:30PM -0400, Thomas J. Baker wrote: Here's a patch I was asked to post here that attempts to fix libvirt incorrectly specifying g3bw as the machine type when it calls qemu-system-ppc. The

Re: [libvirt] [PATCH] network driver: Fix regression defining colliding networks at daemon startup.

2009-05-29 Thread Daniel Veillard
On Thu, May 28, 2009 at 07:24:59PM +0100, Daniel P. Berrange wrote: On Thu, May 28, 2009 at 01:16:25PM -0400, Cole Robinson wrote: If two virtual networks have the same hardcoded bridge device (which prevents them from being active simultaneously) we still want to define them at daemon

[libvirt] PATCH: Fix thread safety with HAL driver restart

2009-05-29 Thread Daniel P. Berrange
The restart method of the HAL implementation of node device is not currently threadsafe, because it destroys and creates the entire driver, including its mutexes. This patch changes it to simply throw away all existing devices, and re-load them from dbus. Daniel diff -r 625ffe1918a4

[libvirt] PATCH: Include OS driver name in device information

2009-05-29 Thread Daniel P. Berrange
This patch extends the node device XML from $ virsh nodedev-dumpxml pci_8086_27d6 device namepci_8086_27d6/name parentcomputer/parent capability type='pci' domain0/domain bus0/bus slot28/slot function3/function product id='0x27d6'82801G (ICH7 Family) PCI Express Port

Re: [libvirt] PATCH: Fix mingw32 build

2009-05-29 Thread Daniel Veillard
On Thu, May 28, 2009 at 05:37:14PM +0100, Daniel P. Berrange wrote: On Win32/mingw32 the name 'interface' is #defined to the COM_interface struct. Needless to say, libvirt thus fails to build in spectacular ways. This patch does s/interface/iface/ on all variables. It also fixes bugs in the

Re: [libvirt] PATCH: Fix thread safety with HAL driver restart

2009-05-29 Thread Daniel Veillard
On Fri, May 29, 2009 at 02:36:40PM +0100, Daniel P. Berrange wrote: The restart method of the HAL implementation of node device is not currently threadsafe, because it destroys and creates the entire driver, including its mutexes. This patch changes it to simply throw away all existing

Re: [libvirt] PATCH: Include OS driver name in device information

2009-05-29 Thread Daniel Veillard
On Fri, May 29, 2009 at 02:39:09PM +0100, Daniel P. Berrange wrote: This patch extends the node device XML from $ virsh nodedev-dumpxml pci_8086_27d6 device namepci_8086_27d6/name parentcomputer/parent capability type='pci' domain0/domain bus0/bus slot28/slot

Re: [libvirt] libvirt needs to dynamically support kvm-img and/or qemu-img

2009-05-29 Thread Doug Goldstein
On Thu, May 28, 2009 at 2:47 PM, Doug Goldstein car...@gentoo.org wrote: On Thu, May 28, 2009 at 9:48 AM, Daniel P. Berrange berra...@redhat.com wrote: On Thu, May 28, 2009 at 09:04:55AM -0500, Doug Goldstein wrote: snip I don't much like this function with the mix of fixe length buffers,

Re: [libvirt] [PATCH] network driver: Fix regression defining colliding networks at daemon startup.

2009-05-29 Thread Cole Robinson
On 05/29/2009 09:35 AM, Daniel Veillard wrote: On Thu, May 28, 2009 at 07:24:59PM +0100, Daniel P. Berrange wrote: On Thu, May 28, 2009 at 01:16:25PM -0400, Cole Robinson wrote: If two virtual networks have the same hardcoded bridge device (which prevents them from being active simultaneously)

Re: [libvirt] [PATCH] qemu_driver: Fix another domain startup error reporting race.

2009-05-29 Thread Cole Robinson
On 05/28/2009 02:24 PM, Daniel P. Berrange wrote: On Thu, May 28, 2009 at 01:16:23PM -0400, Cole Robinson wrote: Parse the command line output a bit earlier so we have a better chance of reporting the full error output on failure. I hit this when QEMU would try to boot an invalid kernel

Re: [libvirt] PATCH: Fix mingw32 build

2009-05-29 Thread Laine Stump
On 05/28/2009 12:37 PM, Daniel P. Berrange wrote: On Win32/mingw32 the name 'interface' is #defined to the COM_interface struct. Needless to say, libvirt thus fails to build in spectacular ways. ACK!!! (That's the Bill the Cat Yuck! kind, not the open source Looks good, okay. kind ;-)

Re: [libvirt] PATCH: Fix mingw32 build

2009-05-29 Thread Daniel P. Berrange
On Fri, May 29, 2009 at 12:04:11PM -0400, Laine Stump wrote: On 05/28/2009 12:37 PM, Daniel P. Berrange wrote: On Win32/mingw32 the name 'interface' is #defined to the COM_interface struct. Needless to say, libvirt thus fails to build in spectacular ways. ACK!!! (That's the Bill the

[libvirt] Release of libvirt-0.6.4

2009-05-29 Thread Daniel Veillard
The monthly release is out ! There is a number of new things in that release, but as happens in time-based releases some are not fully complete, for example the OpenNebula driver was added but it still need a bit of work on the detection code and a bit of cleanup to avoid a GPL/AFS licencing

Re: [libvirt] [PATCH] Fix a compilation problem with LXC drop capabilities

2009-05-29 Thread Serge E. Hallyn
Quoting Ryota Ozaki (ozaki.ry...@gmail.com): On Fri, May 29, 2009 at 9:20 PM, Daniel Veillard veill...@redhat.com wrote:  The lxcContainerDropCapabilities() function requires PR_CAPBSET_DROP to be defined in order to compile, but it may not be defined in older kernels. So I made the