Re: [libvirt] [PATCH] Fix a compilation problem with LXC drop capabilities

2009-06-02 Thread Daniel P. Berrange
On Tue, Jun 02, 2009 at 11:15:58AM +0900, Ryota Ozaki wrote: On Mon, Jun 1, 2009 at 6:24 PM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, May 29, 2009 at 04:42:54PM -0500, Serge E. Hallyn wrote: Quoting Ryota Ozaki (ozaki.ry...@gmail.com): On Fri, May 29, 2009 at 9:20 PM, Daniel

[libvirt] PATCH: Fix libvirt log initialization to not override environment

2009-06-02 Thread Daniel P. Berrange
Witht he libvirtd daemon, if you start it up with LIBVIRT_LOG_OUTPUTS or LIBVIRT_LOG_FILTERS set, then it'll initially use these settings for logging, but then when it reads the config file it'll reset all logging and ignore your environment variables. This is rather confusing ! This quick fix

[libvirt] PATCH: Misc user mode linux startup bugs

2009-06-02 Thread Daniel P. Berrange
There's a number of annoying bugs in the user mode linux driver startup code. This patch fixes lots of them. We failed to check umlMonitorCommand for error, leading to a NULL de-reference due to another bug in that function. This patch also checks if 'res' is NULL before de-referenceing it, just

[libvirt] PATCH: Support networking in User Mode Linux driver

2009-06-02 Thread Daniel P. Berrange
This patch adds support for bridge, virtual network, multicast and user-mode networking in the User Mode Linux driver. You can't pass an open TAP device file descriptor to UML, so we also extend the bridge.c file to supporting creation deletion of persistent TAP devices. Daniel diff --git

[libvirt] PATCH: Centralize some duplicated NUMA code

2009-06-02 Thread Daniel P. Berrange
The QEMU and UML drivers currently duplicate a non-trivial chunk of NUMA code. This patch moves it all into src/nodeinfo.c which already has some other common NUMA code for capabilities initialization. In doing so it changes the functions to have a common 'node' naming scheme, to avoid clash

[libvirt] PATCH: Implement capabilities NUMA APIs in LXC driver

2009-06-02 Thread Daniel P. Berrange
The LXC driver is missing a implementation of the capabilities API, even though it has its capabilities object available in its internally struct. This patch exposes the capabilities, and also hooks up the shared NUMA APIs. Daniel diff -r 0d3150636e3e src/lxc_driver.c --- a/src/lxc_driver.c

[libvirt] PATCH: Convert VBox driver to preferred style

2009-06-02 Thread Daniel P. Berrange
The driver function table in the VBox driver is currently using named struct member initializers. We previously removed all these from other drivers, so we have a clearer indication of missing APIs in each driver. This patch updates VBox to follow the preferred style Daniel diff -r f639344b66bc

[libvirt] PATCH: Wire up NUMA APIs in VirtualBox driver

2009-06-02 Thread Daniel P. Berrange
This patch simply wires up the shared NUMA API implementations in the virtualbox driver Daniel diff -r 8b34df5f9ddf src/vbox/vbox_tmpl.c --- a/src/vbox/vbox_tmpl.c Thu May 28 11:55:49 2009 +0100 +++ b/src/vbox/vbox_tmpl.c Thu May 28 11:56:10 2009 +0100 @@ -4955,8 +4955,8 @@ virDriver

[libvirt] PATCH: Remove all getuid==0 checks from code

2009-06-02 Thread Daniel P. Berrange
This patch is preparing the way for future work on allowing the libvirtd daemon to run as a less-privileged user ID. The idea is that we will switch from 'root' to 'libvirtd', but use Linux capabilties to keep the handful of higher privileges we need for our work. Thus any code which does a check

Re: [libvirt] [PATCH 1/1] Add backend support for nodedev-create and destroy

2009-06-02 Thread Daniel P. Berrange
On Mon, Jun 01, 2009 at 11:31:40AM -0400, David Allan wrote: --- src/Makefile.am |4 +- src/node_device.c | 411 +++ src/node_device.h | 13 ++ src/node_device_conf.c | 139 +--

Re: [libvirt] PATCH: Convert VBox driver to preferred style

2009-06-02 Thread Pritesh Kothari
On Tuesday 02 June 2009 12:09:24 Daniel P. Berrange wrote: The driver function table in the VBox driver is currently using named struct member initializers. We previously removed all these from other drivers, so we have a clearer indication of missing APIs in each driver. This patch updates

Re: [libvirt] PATCH: Wire up NUMA APIs in VirtualBox driver

2009-06-02 Thread Pritesh Kothari
On Tuesday 02 June 2009 12:10:05 Daniel P. Berrange wrote: This patch simply wires up the shared NUMA API implementations in the virtualbox driver Daniel diff -r 8b34df5f9ddf src/vbox/vbox_tmpl.c --- a/src/vbox/vbox_tmpl.cThu May 28 11:55:49 2009 +0100 +++ b/src/vbox/vbox_tmpl.cThu

Re: [libvirt] PATCH: Centralize some duplicated NUMA code

2009-06-02 Thread Pritesh Kothari
On Tuesday 02 June 2009 12:05:54 Daniel P. Berrange wrote: .version = vboxGetVersion, .getHostname = vboxGetHostname, .getMaxVcpus = vboxGetMaxVcpus, -.nodeGetInfo = vboxNodeGetInfo, +

Re: [libvirt] PATCH: Remove all getuid==0 checks from code

2009-06-02 Thread Serge E. Hallyn
Quoting Daniel P. Berrange (berra...@redhat.com): This patch is preparing the way for future work on allowing the libvirtd daemon to run as a less-privileged user ID. The idea is that we will switch from 'root' to 'libvirtd', but use Linux capabilties to keep the handful of higher privileges

Re: [libvirt] PATCH: Remove all getuid==0 checks from code

2009-06-02 Thread Daniel P. Berrange
On Tue, Jun 02, 2009 at 08:29:47AM -0500, Serge E. Hallyn wrote: Quoting Daniel P. Berrange (berra...@redhat.com): This patch is preparing the way for future work on allowing the libvirtd daemon to run as a less-privileged user ID. The idea is that we will switch from 'root' to 'libvirtd',

Re: [libvirt] PATCH: Fix redetection of transient QEMU VMs on daemon restarts

2009-06-02 Thread Daniel Veillard
On Wed, May 27, 2009 at 04:58:44PM +0100, Daniel P. Berrange wrote: When the libvirtd daemon starts up, it reads all config files from /etc/libvirt/qemu. For each config file loaded, it then probes for a pidfile / live status XML config in /var/run/libvirt/qemu. In retrospect there is an

Re: [libvirt] [PATCH 1/1] Add backend support for nodedev-create and destroy

2009-06-02 Thread Daniel Veillard
On Tue, Jun 02, 2009 at 11:29:46AM +0100, Daniel P. Berrange wrote: On Mon, Jun 01, 2009 at 11:31:40AM -0400, David Allan wrote: --- src/Makefile.am |4 +- src/node_device.c | 411 +++ src/node_device.h |

Re: [libvirt] PATCH: Misc user mode linux startup bugs

2009-06-02 Thread Daniel Veillard
On Tue, Jun 02, 2009 at 10:50:56AM +0100, Daniel P. Berrange wrote: There's a number of annoying bugs in the user mode linux driver startup code. This patch fixes lots of them. We failed to check umlMonitorCommand for error, leading to a NULL de-reference due to another bug in that function.

Re: [libvirt] PATCH: Fix libvirt log initialization to not override environment

2009-06-02 Thread Daniel Veillard
On Tue, Jun 02, 2009 at 10:31:20AM +0100, Daniel P. Berrange wrote: Witht he libvirtd daemon, if you start it up with LIBVIRT_LOG_OUTPUTS or LIBVIRT_LOG_FILTERS set, then it'll initially use these settings for logging, but then when it reads the config file it'll reset all logging and ignore

Re: [libvirt] PATCH: Support networking in User Mode Linux driver

2009-06-02 Thread Daniel Veillard
On Tue, Jun 02, 2009 at 10:52:59AM +0100, Daniel P. Berrange wrote: This patch adds support for bridge, virtual network, multicast and user-mode networking in the User Mode Linux driver. You can't pass an open TAP device file descriptor to UML, so we also extend the bridge.c file to supporting

Re: [libvirt] PATCH: Implement capabilities NUMA APIs in LXC driver

2009-06-02 Thread Daniel Veillard
On Tue, Jun 02, 2009 at 11:07:35AM +0100, Daniel P. Berrange wrote: The LXC driver is missing a implementation of the capabilities API, even though it has its capabilities object available in its internally struct. This patch exposes the capabilities, and also hooks up the shared NUMA APIs.

Re: [libvirt] PATCH: Convert VBox driver to preferred style

2009-06-02 Thread Daniel Veillard
On Tue, Jun 02, 2009 at 11:09:24AM +0100, Daniel P. Berrange wrote: The driver function table in the VBox driver is currently using named struct member initializers. We previously removed all these from other drivers, so we have a clearer indication of missing APIs in each driver. This patch

Re: [libvirt] PATCH: Wire up NUMA APIs in VirtualBox driver

2009-06-02 Thread Daniel Veillard
On Tue, Jun 02, 2009 at 11:10:05AM +0100, Daniel P. Berrange wrote: This patch simply wires up the shared NUMA API implementations in the virtualbox driver ACK, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind RPM search

[libvirt] Upgrade and PCI Passthrough

2009-06-02 Thread Aaron Clausen
I upgraded my Debian host to KVM 72 and libvirt 0.6.3-4 in the hopes of gaining use of PCI passthrough. I suspect that the upgrade may have gone a bit awry, because when I attempt to enable passthrough, I get the following error: /usr/bin/kvm: invalid option -- '-pcidevice' Is the version of

Re: [libvirt] Upgrade and PCI Passthrough

2009-06-02 Thread Chris Wright
* Aaron Clausen (mightymartia...@gmail.com) wrote: I upgraded my Debian host to KVM 72 and libvirt 0.6.3-4 in the hopes of gaining use of PCI passthrough. I suspect that the upgrade may have gone a bit awry, because when I attempt to enable passthrough, I get the following error:

[libvirt] Anyway to configure multiple boot devices?

2009-06-02 Thread Matty
I am running a number of KVM guests on a physical machine, and want to configure the hosts to boot from the network if the internal disk isn't bootable. After reading through a number of documents, I came across the following bug report: https://bugzilla.redhat.com/show_bug.cgi?id=472236